From nobody Mon Feb 9 23:38:01 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9161A19E804 for ; Mon, 30 Dec 2024 19:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585810; cv=none; b=cz4bZNXWFdYUzlYsiMybcjN/VsYJnNL0vXnBUDhdkpanbyF2+eQVgEbBajDABz91YtepJ2AW+DCHFI+pMW7XQaFAE5d/B7StkrljPm957hKGcLvdoO0PCs21FcVxNXH8u+Og6C05GTgst19jPAAwhkEeAa0H+DBTLMwC/j5/TmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585810; c=relaxed/simple; bh=K6pjky9Ek+SsXugaEvIVw+NDXMsgVeIBpUzxf1GYqic=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K+JQr/Ddz7txe25MdAcoAQYm8+OcuOydfKAun8UJgfps1o+RQLm9Txyxk9m4ifmlEgdvp9qgKamxRfZUWFD9hgT6vU/bgnRq8YFYs28Z81I46Mvxv1Ynqjbu/whLmeynOTGGycMM1ZOPIOu0LPXViK2O1Qv6jBXl40gzcOfyIa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ajtTACvA; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ajtTACvA" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21644db9f3cso12671315ad.2 for ; Mon, 30 Dec 2024 11:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585808; x=1736190608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M468sUTraHS5kC5PSlnNFUa8bcgzq60Ww60qpx627NE=; b=ajtTACvAkkj+yFEAKgD1ysRLYmKNevjRVLuXAZ4oJjRqjSvGRv1gK+N3RhncIb8k61 WmQSj2HxbxXmCYWTbwvKE2/iA+ueYWWj695o8GOLRGJc2kL3AtNGpo3mfbvyXuX4ks1R 6SvM0AtEQd4J0VsuG+u/kPaIJKd+RJ1XMI2Wm00wtcSh/7NWIBrUXjBCEgczMf5pcjsZ Siipm7d4QCk47KLsgJqLkul6qBY5OptREJ0KNf+x5sxn2OlGU4bVYiW2CqC1Tu5NjfWo mPi0ceCjHp10CQ9tdCMS73hyz9mBz6LKY6X2n9S9yh3uYOJ5ZaTL5fFPFmNWKuMYMaIJ EfvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585808; x=1736190608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M468sUTraHS5kC5PSlnNFUa8bcgzq60Ww60qpx627NE=; b=W42oR/5mYwe8uRFvp/pVEDYwODyI9GMydd9Jogn6DOdawdZEesiDOw3A06xzrILLAy kCwxpAaBTGIFv88164TJaz/KXCtbiyX0DrnJ144rkEzxj3LKy/+wRTFXU7vxysSjXda/ Bd0jbrjerB+J9t8lAy7ho63riDw1s0VzkyqMaOxbFynDFBoLWfA36w516bYzl9j5y8Ds jk8mDTCzQR93TpLS6RIpyrU7NAW3eBYpy/Plm6Q5HuiecYSbAxx+LtW5Jk5ZVp/qSZrn LhsUfjhRAgyyJUGDNN/PjZR+okhuy7Kd0t2Idg69mOxOtOkSuRq3719oyQZjvCLLkJd7 HO+w== X-Forwarded-Encrypted: i=1; AJvYcCWh9SpcPEjbHrFVe9VqpYzcqeCVECuXqQEbdwh2optXL9vLtquNlT6/rb+nCHkpwPsZCs8oXQ7pXXFEAZY=@vger.kernel.org X-Gm-Message-State: AOJu0YxtSVrUtLATCd5BwL+G/InUnqVLlUNF4dpnooBTViOByA430lLm 7pSvcm1DuqpQvN/o9OJ2Q6v+j9lwMhES1hMUkcsGDU3S2ryTTqTqWG4gog== X-Gm-Gg: ASbGncuLltwzMcElU2gPDSBlzTv77XlVNvMRmWPPa7Ko5HUX+71Xg0+uqi2h/ds8D8k 1lh/bzS7ulRe1pNIjYGJKAYma8AkLnVLg7deR2ds/dJHsIvVZ7BWkuW/8cc4NNOZvcRroSnjFD6 /Ir1gQMIG5Qgn6J0cIcSyf6UMktKuF1QWBkAU10qv+16USu8wtZJRWjCBiXfKC3wmfPupNnr/8t FIROV9KNNrqcaoFM2vQWFJQl1weTCt8oJfT4rpk+IPykQb9P6buZbI= X-Google-Smtp-Source: AGHT+IHt3vajaSu5hkKlS/aNe/nV1zyzO8BEmVLGz/v3Of8aTqXbYAMdXCmK7VNgLgBDFHoMns4PCQ== X-Received: by 2002:a17:902:d4c9:b0:215:8d29:af0b with SMTP id d9443c01a7336-219e6f2706fmr192690715ad.14.1735585807835; Mon, 30 Dec 2024 11:10:07 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:10:07 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 10/15] staging: gpib: hp_82341: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:30 +0530 Message-Id: <20241230185633.175690-11-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Return the error value if the first gpib_register_driver() fails and if the second gpib_register_driver() fails unregister the first gpib_register_driver() and return the error value. Add pr_err() statements indicating the fail and the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/hp_82341/hp_82341.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index 8ad1c885a9fb..4953dac1e177 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -807,8 +807,21 @@ MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table); =20 static int __init hp_82341_init_module(void) { - gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE); - gpib_register_driver(&hp_82341_interface, THIS_MODULE); + int ret; + + ret =3D gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE); + if (ret) { + pr_err("hp_82341: gpib_register_driver failed: error =3D %d\n", ret); + return ret; + } + + ret =3D gpib_register_driver(&hp_82341_interface, THIS_MODULE); + if (ret) { + pr_err("hp_82341: gpib_register_driver failed: error =3D %d\n", ret); + gpib_unregister_driver(&hp_82341_unaccel_interface); + return ret; + } + return 0; } =20 --=20 2.34.1