From nobody Sun May 10 06:29:32 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADFE1A42A5 for ; Mon, 30 Dec 2024 13:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565434; cv=none; b=bRdkZO8ZckHCPzjyk9TS75g4LxBacRZUAvQxeVMi+o2L+0YM0jL3G9HtdNukctYlrwKblEjrg5b5/r2DGvofcgjlY7FhQTs7kkVlh6zZmCHh3XMkOiIAdqJa3C/lJsx70FwR+szSIoD4UhH8P2mgF2H3RgiU4ogjrf1EIdYSoxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565434; c=relaxed/simple; bh=95yOJU1VQIxVEl1re8QM5fh7nv37jOqHWqJP6VF+aZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iMIrVtSaOnX7PYms+FA+eKFwhYZfjggsmyqgyog0P0ZxjT/uwJIDDdgyOXGD/pxaej4ov9AXlN1NMDB/lsx0Y7ElrYSGIJn4AWVwcsOw5LbpH3gjcSsyooOousTl6zTgq9QlygGXdJV/UoU6vZ6ybUdbtby+/TG3BYUYeWhUMzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RQmLUI/h; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RQmLUI/h" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4361f664af5so104149945e9.1 for ; Mon, 30 Dec 2024 05:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735565431; x=1736170231; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H+7xtqqtkp033OeyM7tyDLWsNcEaw2gaAkIZmZbhgBg=; b=RQmLUI/hv8UxLTUPl8LUTisIc0WB09ke4UtGnplYcLFXgaoM6WBnISi3iiFsD30p3J EaPbW2a0z4Z1D8eT9xnnE7uU2iF93+beGLsIjcRTKTSBE/gUG7Ox6woNsUDdvZcqAits p4jNtD472FJPjXUasjfXIiezwYaCwyPrLMl4Y2pRbIRlm11ot1gTSkn+DouM88zqdcPj oz+I3tysop2hBjZCIxeyaWHZi97l7Hc6IGyHFRyAjybwudQiUjq8c6AGiH90PRs86eN2 PikHm+rPJuXCXonB3BgmpFCkzHeQOUn5sG2FmyNq4TaBT63s65H6oY2e0EP2vQLisJJv OEVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735565431; x=1736170231; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+7xtqqtkp033OeyM7tyDLWsNcEaw2gaAkIZmZbhgBg=; b=PtWlqVzBX2ghnsA9mczFgZbb5Xw6YBqJYorBevZO31M/ZmzeCNzQXxzaKTfmG0eGE7 iUsGdAnU890rXc8EmhkkFl6JSJsOhH+z2E7mOatEfwK3phNNf+XWr6dc6KQlUmG5cO1f VGBh6/5o0wYg894GhD8DP48V4htJhvHaKh0e0izCBQ68JZLYkvm6Kgrco/2JIzp5jWhj L0bg3z6PagCp+qufhCo1VkRO/hsJH+P39brse8rC2QqILRABAeKqWjz5gvrwF9iDpcmP MChwlKtbJFAP41kiJ2FWACKZQmhj+yxCHxXOdDz/VD5woAterVMtrDKJbYG2PdyYlDnO vyTw== X-Forwarded-Encrypted: i=1; AJvYcCWme/+ByL5SNZT5DdyWNXmlrTYgvr3tAePT7NxroLTA8PHOVZlw8LyzK0iNMivKQc0S6hAB5f2HE8IcepQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyZb+RKDVY5NcPbJkTqMyt4CB2Aes4ekqxWoIgJuCQS8vmkJvuU S9Z/SSHa7bXdJjR7SdQ5yrehM8ifz+d8x0XsSBmtLaG9DXdNIPdk41rSZGZMkXA= X-Gm-Gg: ASbGncvyaKFrOvjBszmWYpiYGvxlxvAOr/fGTvhty4jFQdN9QuADKvaxua1JI/ggVDM 1GaVmpWe5zSeT0ViJIdN0cEKQpSPSoTdvMYGn3RObi/7DFkO3WFGKOv5kuVAnFw5XCETFacXJh7 JKyhGBaA1l3kzhbg6cqhi8uMALAIjQ7InAE5IZvtB2bwt7y1KqY6YhXGk9NsuB5WPFsYU+PHVkj 4lwlql92+rdc3NYsT2BY0hxFHiZHz1fmU9FH2u/EKo4AC55WWrZy3bhti8d1AmtvQ== X-Google-Smtp-Source: AGHT+IFmCgtOdjnwvghX/v1AS76frg41vQn9vshRFjLcdgo6QJdoBCPQr0LD+fyMTYsbsDCIjUPY5Q== X-Received: by 2002:a05:6000:144b:b0:385:e37a:2a56 with SMTP id ffacd0b85a97d-38a223fd302mr28676119f8f.52.1735565431271; Mon, 30 Dec 2024 05:30:31 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828d39sm31079082f8f.9.2024.12.30.05.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 05:30:30 -0800 (PST) From: Bryan O'Donoghue Date: Mon, 30 Dec 2024 13:30:18 +0000 Subject: [PATCH v9 1/4] clk: qcom: gdsc: Release pm subdomains in reverse add order Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-1-f15fb405efa5@linaro.org> References: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> In-Reply-To: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Vladimir Zapolskiy , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , stable@vger.kernel.org X-Mailer: b4 0.15-dev-1b0d6 gdsc_unregister() should release subdomains in the reverse order to the order in which those subdomains were added. Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support= ") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/gdsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index fa5fe4c2a2ee7786c2e8858f3e41301f639e5d59..bc1b1e37bf4222017c172b77603= f8dedba961ed5 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -571,7 +571,7 @@ void gdsc_unregister(struct gdsc_desc *desc) size_t num =3D desc->num; =20 /* Remove subdomains */ - for (i =3D 0; i < num; i++) { + for (i =3D num - 1; i >=3D 0; i--) { if (!scs[i]) continue; if (scs[i]->parent) --=20 2.45.2 From nobody Sun May 10 06:29:32 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE4C1A8413 for ; Mon, 30 Dec 2024 13:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565437; cv=none; b=Jyc/SETIlozRVIULFga+6hLzKn/iiHjSTaLOVmxkc7L++28s/CjVyyxt0T/PNIU6JBm3QBe3g/Tz7YDl1Bua7hHs+nyIfjscLGsuuEvav5wMldoGHfk9CUyY86TjN7/RSCQqK6yE6mFcSdmohoTImSsl4SeKQLOUbt+NIqCMfxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565437; c=relaxed/simple; bh=sNd2EYZIg7l4zPuE7KNVjgjjMpcll492t3gb4SPn5/g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sqkKdygYIPCHzZw9aSJn+ioIBxphpbbgotCwxh3oEqm3YtVHzem8p7UuWce/UcCMhJHh+JsjifkQlzYS4PkK3GdVw4Uk9rLwz0+CQNcjA0NSIv1dt9voGrUXazPMAv2POoBJLFEk2a//3+5HJi1wbB75QPHAss0LmAIz6XbSuU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EWrGG5ID; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EWrGG5ID" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-385e3621518so4333118f8f.1 for ; Mon, 30 Dec 2024 05:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735565433; x=1736170233; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OmmcpflYSTdG9DnEC1Lz8/bGJpmwX76Rv9811OTTa/Q=; b=EWrGG5IDJZuxm92tfhj3Ag40e0RwXi5VHjBXSRtRoXMq3Ou0bU1YPg8yyt1UvhIpIK JA/7YT8MK04czmdMiGvx+hjAi0ZgzD2/2APWhHgv6hlSyGiOam5CaPmiHv+pL0VF2U/p 27BbnU9yrYKPhKT66LeP16PpbzOuSwZNApxxQ1UvGUmHhoNuwhEpS3qh56qV+Isv445K SQfAETCNW2SOK0sB1FStt8ySnF7A8iZLeoRA5X02aur45hD3l+uLloJh/fXOiXdqnEsu nlGm0XvYZGiiAqW+KZJIBrsT+7SLzol64TbhmakGXxwV000Gb4trX+JaUOHWtJDGLwq2 F7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735565433; x=1736170233; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OmmcpflYSTdG9DnEC1Lz8/bGJpmwX76Rv9811OTTa/Q=; b=DnzS3dTQMhmtCj6c+QQy6W8cmdT/Zwk8dWp2SzjtsuyyFIwUk3EccO9Ca5uLyPI+/Q xhPR5aIA7yPOMEWaW/LSQ5oxRShe5KN53rJCi3d6pkV8cl0EpnmYu3ImUWVDPC3XVtM4 L3pMU945iD9vCpcRtprhvqRpp3rcFjHQugAVgWMb/K6k/D4YdpBmB1t77kDtZmBepClB iKqoim0K1/2M8Ye+aGyfzMUrV2wwVK21zN0Hq3GBJ8smX6mj+plrM9LpJuZbpjFKPOP+ zlqEPyx9QJODO9YT2R/g2JbhpKDmuZDXk0LX9ij/du0cfkZ5cWQon8S5xRT9xnU10P16 rgJA== X-Forwarded-Encrypted: i=1; AJvYcCWjvWFaYYrEuYAEEJxodhLUlQSEs1pcKqDKoKGEP4CAmKZgDuPGvw3st+Bpc7XlMgFEECUPz8aOExMR+2g=@vger.kernel.org X-Gm-Message-State: AOJu0YwKMrTKb1SwicjmPpM7Ow9IZtfRdHC7j/ZmM+4/iAMxgkSzLpx/ CP0K/v0j2QzPtld6vQ7Z0ho4uskPTjC6KBiiv+wQTDmxxvHpXU2lxjAJ7LYb2uE= X-Gm-Gg: ASbGncuAsscYORBG4YHfCV65skoUvmpxPwRbLiOxk3Ts8VzxFXkBkOLyGk7vlpVDHCf /fPOAcpBhfgkoXFS7/MHniMwMo8MzFeW6LY8XrgosE0P4V+hLEtxVKeJObBOpwqiPPWduyRROYf r3GvP2uu7Pr/1Mdj1aM5+rP+Gi6B3sLbNojVcNdnI8aBV+xEdpBmZBooE0k8M00iPEJVcgtUjog UGIPsMMtpWb9os4QR04PZW2/xVsyploiJgitMKlN6A04+qI23KkjZ6I9McjURIuzg== X-Google-Smtp-Source: AGHT+IGtqzbMxbz8z4IpV9vofNDhZDNQzchKvO50pMuWuhuqRDt6Nomht67se1WDndXJNBW+wBsc7g== X-Received: by 2002:a5d:6484:0:b0:388:cacf:24c1 with SMTP id ffacd0b85a97d-38a223ff10bmr30771407f8f.58.1735565432677; Mon, 30 Dec 2024 05:30:32 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828d39sm31079082f8f.9.2024.12.30.05.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 05:30:32 -0800 (PST) From: Bryan O'Donoghue Date: Mon, 30 Dec 2024 13:30:19 +0000 Subject: [PATCH v9 2/4] clk: qcom: gdsc: Capture pm_genpd_add_subdomain result code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-2-f15fb405efa5@linaro.org> References: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> In-Reply-To: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Vladimir Zapolskiy , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , stable@vger.kernel.org X-Mailer: b4 0.15-dev-1b0d6 Adding a new clause to this if/else I noticed the existing usage of pm_genpd_add_subdomain() wasn't capturing and returning the result code. pm_genpd_add_subdomain() returns an int and can fail. Capture that result code and throw it up the call stack if something goes wrong. Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support= ") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/gdsc.c | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index bc1b1e37bf4222017c172b77603f8dedba961ed5..fdedf6dfe7b90c074b200353fc0= c2b897863c79f 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -506,6 +506,23 @@ static int gdsc_init(struct gdsc *sc) return ret; } =20 +static void gdsc_pm_subdomain_remove(struct gdsc_desc *desc, size_t num) +{ + struct device *dev =3D desc->dev; + struct gdsc **scs =3D desc->scs; + int i; + + /* Remove subdomains */ + for (i =3D num - 1; i >=3D 0; i--) { + if (!scs[i]) + continue; + if (scs[i]->parent) + pm_genpd_remove_subdomain(scs[i]->parent, &scs[i]->pd); + else if (!IS_ERR_OR_NULL(dev->pm_domain)) + pm_genpd_remove_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); + } +} + int gdsc_register(struct gdsc_desc *desc, struct reset_controller_dev *rcdev, struct regmap *regmap) { @@ -555,30 +572,27 @@ int gdsc_register(struct gdsc_desc *desc, if (!scs[i]) continue; if (scs[i]->parent) - pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); + ret =3D pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) - pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); + ret =3D pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd= ); + if (ret) + goto err_pm_subdomain_remove; } =20 return of_genpd_add_provider_onecell(dev->of_node, data); + +err_pm_subdomain_remove: + gdsc_pm_subdomain_remove(desc, i); + + return ret; } =20 void gdsc_unregister(struct gdsc_desc *desc) { - int i; struct device *dev =3D desc->dev; - struct gdsc **scs =3D desc->scs; size_t num =3D desc->num; =20 - /* Remove subdomains */ - for (i =3D num - 1; i >=3D 0; i--) { - if (!scs[i]) - continue; - if (scs[i]->parent) - pm_genpd_remove_subdomain(scs[i]->parent, &scs[i]->pd); - else if (!IS_ERR_OR_NULL(dev->pm_domain)) - pm_genpd_remove_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); - } + gdsc_pm_subdomain_remove(desc, num); of_genpd_del_provider(dev->of_node); } =20 --=20 2.45.2 From nobody Sun May 10 06:29:32 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BAFB1A9B3D for ; Mon, 30 Dec 2024 13:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565438; cv=none; b=djcxPNXS6j4GdywrOlleJ6ocsfUUb5qGtOv0GTM/K2MtK7ENivTLrM9JIUpFHjFbI5vf/1iB8nDetz3LvBaTAhiPR/zNQ1Z9sHKXyu2RNjvfm6T8XlOcUa83HGxbQnkHQwFKrCCI1fvhooW4s9OPsFU1sVtJpPinPuAOeTAi4k0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565438; c=relaxed/simple; bh=BCcVhjXqM/11poMT/N4HvI5IzpguMzkE/XgunRZ0xcw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NG1p1XJ/Am7PSE4ULmk5wFqQO1UWKtgz/1xNIUZ0wWWjAMjaxH7D9G2GufFmZZefuJLbrFwpwP1oa2E3rYCPS6dThvy7ye7JbQLtQMluuoJWxV8ihd8RZ0z1I6BMK06Q4stQZLaA7QhAC6dLIZkZ9NF9z+UV71h3Ti/nS1Q19jo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=htZgMWK5; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="htZgMWK5" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-385d7b4da2bso7850396f8f.1 for ; Mon, 30 Dec 2024 05:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735565434; x=1736170234; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H3Aq0nsQUak92jzQ+dzMHRTGJEDpjujxd82cAU7SdLo=; b=htZgMWK5gUHVGEef04/Tj62ee9ttGemK6/p3/yP1a5aqUUD5OxF9uuxttwMxseQ1K4 Dwk1GLErE24L4RPXnxe1/9sqWw9TxOeHHC41qIOf5mQwQPCuyDrxkfLWzp0aOmFgVBmA coQ3dse1y8DqdKn9b/UiArIQK+DUtIsy4dYykcRmElxhsNQeU1ug0PeqNvtF2F5KZ2yw A8cGbQrVUhAMU9fRTYxDq94PqeIgcwqK0VUFx9HrQQ5gCO0Nm00OgaEVRVYVcOPf2jHF BjxIaC3zc2Tff/KAtD4unETRYzs5WzUoGWQYxRJyprINadNgjf8sCmDmSXVw5aji8O9x gqiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735565434; x=1736170234; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3Aq0nsQUak92jzQ+dzMHRTGJEDpjujxd82cAU7SdLo=; b=pZUgL6iojLRB6rL+LBgGOLFNO0y8gkj34gTwBhgxBK+TX3oWJ+oIBm20RcPxP8ifix lOP+pHk6X4Xm193vF8+1bB+EXaM3TXILaccAybQ8/Jh5WBm4wApBSbGG4I+L96aNZs6L 4Rn847ieqeZwI27GefmvObmL+M3q4F4Y5KtOd9JJdUY7aNbe4PtZl2GeB7GHlAICSinz m93rdT9NaIhXBDYYVi3qpaEb4p59t5DtNdCvhiG5bfKMc37C9vLkp6AWH+akgFIq8J5o Z/lfh2Qw/DEIcXDviHyBCa+SXhCdXklgumxVVxVSmC4XNhtvrvy7/S5EsM0MLJwpnPD+ jYlQ== X-Forwarded-Encrypted: i=1; AJvYcCUk5uWJ6AJ6aWW1PooDHYgZV41aXb7rSB1OEgBJOoN0YvwWF1XI9H7ZGatmiIyA4AnouAwhLOsAZ3zTyq8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4eRjs1wyKg0EZE9S0rc3Ye9Kvn+a4/0UcIB2BlpsCswY6tywv aXkQ8zQPzDnPyCEUJRoltglrXcQJiCTiyKoygD+nCsZF8aKxuSKPVCwd1mZ5UoI= X-Gm-Gg: ASbGncvQSW6oRA4z6hf3Nfi57tPDAY7Bl0Ub+E5HSM1nGjvjqFqirbXtNl1FDZ+SEQI I8JltbVoqZDLFSWCF71aKjUTw2/16b66PcOoT5VPBmBUYEyWLSCtnYLBh7dd0LytexNDDTLnq/v Ue8SMFKvEvbxfKQeCPhZ2Uy22NvA/lulYqnpD7SHLxpLxEaTpMy6Q7xcXpkhKQ+JN4vyZ5yLHo6 xNgTY7nx3892ODcO0CCaTik9YFqXtWZUO65kk2Uli+FsS5AP79gEvVM4ul6HjErTQ== X-Google-Smtp-Source: AGHT+IFgdTgzzdlfAxH5jUsIbbaTEC0aRjVWyDVXKTAU9Yg1613Ll11GJA25Ci0KmwfQueuGgmBVPA== X-Received: by 2002:a05:6000:18a9:b0:386:3835:9fff with SMTP id ffacd0b85a97d-38a22406d43mr32551764f8f.59.1735565433967; Mon, 30 Dec 2024 05:30:33 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828d39sm31079082f8f.9.2024.12.30.05.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 05:30:33 -0800 (PST) From: Bryan O'Donoghue Date: Mon, 30 Dec 2024 13:30:20 +0000 Subject: [PATCH v9 3/4] clk: qcom: common: Add support for power-domain attachment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-3-f15fb405efa5@linaro.org> References: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> In-Reply-To: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Vladimir Zapolskiy , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-1b0d6 Right now we support one power-domain per clock controller. These single power-domains are switched on by the driver platform logic. However when we have multiple power-domains attached to a clock-controller that list of power-domains must be handled outside of driver platform logic. Use devm_pm_domain_attach_list() to automatically hook the list of given power-domains in the dtsi for the clock-controller driver. Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 33cc1f73c69d1f875a193aea0552902268dc8716..b79e6a73b53a4113ca324d102d7= be5504a9fe85e 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -22,6 +22,7 @@ struct qcom_cc { struct qcom_reset_controller reset; struct clk_regmap **rclks; size_t num_rclks; + struct dev_pm_domain_list *pd_list; }; =20 const @@ -299,6 +300,10 @@ int qcom_cc_really_probe(struct device *dev, if (!cc) return -ENOMEM; =20 + ret =3D devm_pm_domain_attach_list(dev, NULL, &cc->pd_list); + if (ret < 0 && ret !=3D -EEXIST) + return ret; + reset =3D &cc->reset; reset->rcdev.of_node =3D dev->of_node; reset->rcdev.ops =3D &qcom_reset_ops; --=20 2.45.2 From nobody Sun May 10 06:29:32 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABEB1AA1D8 for ; Mon, 30 Dec 2024 13:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565438; cv=none; b=c03lmIoQm1pGWUowyObbsbc/UKsKZQlC+sunTyGKW13RyLjcgpBGb2JYPap23y2/6KXCJBQiURh7FBdrkMIj5wYwGxYHkSgAwLAfUYRIkL1HdiT3v9ICTNUGMxML+ZzBKnwP9Ac6Ba9W6eG0xeOGlLw9fl77igQCHCNXnfyauP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735565438; c=relaxed/simple; bh=M6v/yVywOYSdREs9Ma/IF2kj9M/pArXzsHHXPNQpe4Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=koKbi6C2WwKeCvvPS6gOl2gsrEoyqvk+QD9p99k1MYqBibgpTW2Z3YWst1O7ctuTKLaO+iAmOuZJ/IGhIH2VXpw1GDfDt9udoRl4hfRpyypCgTzaLS0SFul5MqxQ9zkpJWt4xYZyMolo4yyna4Mk0goSkVstlsWCY8j9FUM+UjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bKX0z5kl; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bKX0z5kl" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-436637e8c8dso92713865e9.1 for ; Mon, 30 Dec 2024 05:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735565435; x=1736170235; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E+HbyAf9hSfisDxRlm9nH3ur/YZXFptsBxBxxyxB/bQ=; b=bKX0z5klEKaOPYxXCKT3cMuXOD55FbhVOboOftSxN9Mlo5yAVYNZzYeJSSKoOJLO1B WEFE/N5+15NigIg33j9pJLCxarx9C2uKBN/C4xnTggSZBsJENAxY9Iwf1wU0FnpN19or IskZAeEmavd1MBMP3kaReGv12UU7gJSrtjW4a/mArmOLjYUtUzmkEaFnqrlSplfDkDDW 3opsoyoLLNwOCtQVBBAsZbgV6lPs6aZNLEQ+XfylwgXzP5lh2Ptz4Y4YX/u7b4x02Tst 1Pk9MRenGiu9ZlYmcSZtqOB9MLihl+bvLeRGf/QOPKhCnXMSipwL7iVvMKd3Ma3X5CqD yfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735565435; x=1736170235; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+HbyAf9hSfisDxRlm9nH3ur/YZXFptsBxBxxyxB/bQ=; b=sLA6vuhf9WR76cCN2Hxg2azw+U7iCS1UiNP+eCrdvPnZ0MaY9ZrB4WxRm+xGyiQO+u HABhqcoYRCsI8raZtt9z/bnk/YvGpQgrLVnVdmRG9AntpDAFwpJRoyhjqjhhL3StdeMg ovHzoVl2WO19caE+nppR3JQit2nS+p+T5uSNm4LP45hQUgGrWsyqIXXqj1B4upvP7mxu zMYuYA6S9sr1QrFN18vgPxq2zpJ2aQQZLXnjgh2GOsxjSS3Nx0LAe+Bxl4juuOaL/ch2 1R86QVublksdvu/OrzZXanXiLx82s5gJa+x0QGloIld843EFczauSQn6i5L5f1oSFH+m hjow== X-Forwarded-Encrypted: i=1; AJvYcCXtPOCk4AMseTfIWj8XFWa4UpUayFiY/ggCd+anyJSD1tGRG2OfA6G+p8hQS3dLzMxG1d+CxyspCdltqMg=@vger.kernel.org X-Gm-Message-State: AOJu0YwW//wO9dhpHHtu6lXB6xwyPtgxOUQsBpX1DDloYvPqxkTvph8V m3FyDoV8757KdgG7Roon23slTIW00PWfYb5xqQBLNSGKzOuv//kNZKmV2+t5hDE= X-Gm-Gg: ASbGncsK52l6jAI8vwzgQ0lGCvfSgMdgMX4UfAPwwUetygb5rrBCRKMo7p3zPmn2XVm k7R2lQtk8gg90R1lR23J9AL9ski++8+VPOzr6mEGcms+oLCrVRmq5j3j4orJJapoaZi7jsp1hTt jlxXo0EbLRApH0tg5HwWagv1xqvtN5H2iQ1goeEdc9korxrYHOWzr9izeZD0yeTbe5/as2+YOuZ T3qzftuHuRnuS0KCyp+Izrmob15HvkDODkOw1YqLcJ3k70IdUkeVY+GNnulhSuctw== X-Google-Smtp-Source: AGHT+IGbde6w1I6UgtuC3oTih3PE68/zI/nzQhw97B5ixtSC72o42J5rCWbDoKaWj3o4sX4ZnXRUSA== X-Received: by 2002:adf:ab0c:0:b0:386:37f5:99f6 with SMTP id ffacd0b85a97d-38a223ff225mr25512139f8f.53.1735565435022; Mon, 30 Dec 2024 05:30:35 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828d39sm31079082f8f.9.2024.12.30.05.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 05:30:34 -0800 (PST) From: Bryan O'Donoghue Date: Mon, 30 Dec 2024 13:30:21 +0000 Subject: [PATCH v9 4/4] clk: qcom: Support attaching GDSCs to multiple parents Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-4-f15fb405efa5@linaro.org> References: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> In-Reply-To: <20241230-b4-linux-next-24-11-18-clock-multiple-power-domains-v9-0-f15fb405efa5@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov , Vladimir Zapolskiy , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-1b0d6 When a clock-controller has multiple power-domains we need to attach the GDSCs provided by the clock-controller to each of the list of power-domains as power subdomains of each of the power-domains respectively. GDSCs come in three forms: 1. A GDSC which has no parent GDSC in the controller and no child GDSCs. 2. A GDSC which has no parent GDSC in the controller and has child GDSCs. 3. A child GDSC which derives power from the parent GDSC @ #2. Cases 1 and 2 are "top-level" GDSCs which depend on the power-domains - the power-rails attached to the clock-controller to power-on. When dtsi::power-domains =3D <> points to a single power-domain, Linux' platform probe code takes care of hooking up the referenced power-domains to the clock-controller. When dtsi::power-domains =3D <> points to more than one power-domain we must take responsibility to attach the list of power-domains to our clock-controller. An added complexity is that currently gdsc_enable() and gdsc_disable() do not register the top-level GDSCs as power subdomains of the controller's power-domains. This patch makes the subdomain association between whatever list of top-level GDSCs a clock-controller provides and the power-domain list of that clock-controller. What we don't do here is take responsibility to adjust the voltages on those power-rails when ramping clock frequencies - PLL rates - inside of the clock-controller. That voltage adjustment should be performed by operating-point/performance setpoint code in the driver requesting the new frequency. There are some questions that it is worth discussing in the commit log: 1. Should there be a hierarchy of power-domains in the clock-controller ? In other words if a list of dtsi::power-domains =3D should a specific hierarchy be applied by the gdsc code somehow ? The short answer is no, you must properly represent power-domain dependencies in your dtsi. Do this: pd_a { compat =3D "qcom, power-domain-a"; power-domains =3D <&pd_c>; }; pd_b { compat =3D "qcom, power-domain-b"; }; pd_c { compat =3D "qcom, power-domain-c"; }; clock-controller { compat =3D"qcom, some-clock-controller"; power-domains =3D <&pd_a, &pd_b>; } Not this: pd_a { compat =3D "qcom, power-domain-a"; }; pd_b { compat =3D "qcom, power-domain-b"; }; pd_c { compat =3D "qcom, power-domain-c"; }; clock-controller { compat =3D"qcom, some-clock-controller"; power-domains =3D <&pd_c, &pd_a, &pd_b>; } 2. Should each GDSC inside a clock-controller be attached to each power-domain listed in dtsi::power-domains =3D <> ? In other words should child GDSCs attach to the power-domain list. The answer to this is no. GDSCs which are children of a GDSC within a clock-controller need only attach to the parent GDSC. With a single power-domain or a list of power-domains either way only the parent/top-level GDSC needs to be a subdomain of the input dtsi::power-domains =3D <>. 3. Should top-level GDSCs inside the clock-controller attach to each power-domain in the clock-controller. Yes a GDSC that has no parent GDSC inside of the clock-controller has an inferred dependency on the power-domains powering the clock-controller. 4. Performance states Right now the best information we have is that performance states should be applied to a power-domain list equally. Future implementations may have more detail to differentiate the option to vote for different voltages on different power-domains when setting clock frequencies. Either way setting the performance state of the power-domains for the clock-controller should be represented by operating-point code in the hardware driver which depends on the clocks not in the gdsc_enable()/gdsc_disable() path. Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/common.c | 1 + drivers/clk/qcom/gdsc.c | 35 +++++++++++++++++++++++++++++++++++ drivers/clk/qcom/gdsc.h | 1 + 3 files changed, 37 insertions(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index b79e6a73b53a4113ca324d102d7be5504a9fe85e..9e3380fd718198c9fe63d736161= 5a91c3ecb3d60 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -323,6 +323,7 @@ int qcom_cc_really_probe(struct device *dev, scd->dev =3D dev; scd->scs =3D desc->gdscs; scd->num =3D desc->num_gdscs; + scd->pd_list =3D cc->pd_list; ret =3D gdsc_register(scd, &reset->rcdev, regmap); if (ret) return ret; diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index fdedf6dfe7b90c074b200353fc0c2b897863c79f..7687661491f1fd5a3076c839c4f= 70f430783fc51 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -506,6 +506,36 @@ static int gdsc_init(struct gdsc *sc) return ret; } =20 +static int gdsc_add_subdomain_list(struct dev_pm_domain_list *pd_list, + struct generic_pm_domain *subdomain) +{ + int i, ret; + + for (i =3D 0; i < pd_list->num_pds; i++) { + struct device *dev =3D pd_list->pd_devs[i]; + struct generic_pm_domain *genpd =3D pd_to_genpd(dev->pm_domain); + + ret =3D pm_genpd_add_subdomain(genpd, subdomain); + if (ret) + return ret; + } + + return 0; +} + +static void gdsc_remove_subdomain_list(struct dev_pm_domain_list *pd_list, + struct generic_pm_domain *subdomain) +{ + int i; + + for (i =3D 0; i < pd_list->num_pds; i++) { + struct device *dev =3D pd_list->pd_devs[i]; + struct generic_pm_domain *genpd =3D pd_to_genpd(dev->pm_domain); + + pm_genpd_remove_subdomain(genpd, subdomain); + } +} + static void gdsc_pm_subdomain_remove(struct gdsc_desc *desc, size_t num) { struct device *dev =3D desc->dev; @@ -520,6 +550,8 @@ static void gdsc_pm_subdomain_remove(struct gdsc_desc *= desc, size_t num) pm_genpd_remove_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) pm_genpd_remove_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); + else if (desc->pd_list) + gdsc_remove_subdomain_list(desc->pd_list, &scs[i]->pd); } } =20 @@ -575,6 +607,9 @@ int gdsc_register(struct gdsc_desc *desc, ret =3D pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) ret =3D pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd= ); + else if (desc->pd_list) + ret =3D gdsc_add_subdomain_list(desc->pd_list, &scs[i]->pd); + if (ret) goto err_pm_subdomain_remove; } diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index 1e2779b823d1c8ca077c9b4cd0a0dbdf5f9457ef..dd843e86c05b2f30e6d9e978681= 580016333839d 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -80,6 +80,7 @@ struct gdsc_desc { struct device *dev; struct gdsc **scs; size_t num; + struct dev_pm_domain_list *pd_list; }; =20 #ifdef CONFIG_QCOM_GDSC --=20 2.45.2