From nobody Sun May 10 06:49:23 2026 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B716B2594BC for ; Sun, 29 Dec 2024 04:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735444825; cv=fail; b=YM5Zlacdv5f85KU2ZhrxCoWgWlpj1oGvLdq2dOSsEFO7N8ZYUM38ft4dud+1XhT2PelK4Qo8Fo37QAIiABrv3qJjUECo4bURBcrTquVli+GLqYefdetVwn7Sqg0mtDYC3n/aIhXfrPz7RXfUiNtOqST53S29rrxHg5llIXrL3c8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735444825; c=relaxed/simple; bh=W6jq9R9OYUNeBqNHveYJbaHT6cw5Od0bskisrCQyuwM=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Fj0TZP4BwFiT1qDAHjyv3JfWoNd2qq/NspKhF3UXMkqrtCBuEDaX60dwpYBoNo8xFD1/0sZ+BNmtPe+RScsu6n2Aw8Fm2oyJNWZLdHTm0c3DdpgYT4lj5P5dOIVEXd7Rio7O8rE2BS8iF+sDNvPVFBelyZHbqdNKIqgqs7i0DRg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IVGVNVmH; arc=fail smtp.client-ip=40.107.244.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IVGVNVmH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r/PT7SV26CxMSQwO2IhNdEQnwwPxp8T0AHh4OhYjAuwTiqmcVW8UJ/eTXJEKkzXZVC3olV6h4mT60qrHCds+WLT5tuRRQn9pSMP1PKNy8lE2GKmG6+H4MPJbiDcDQnawPBGb/gJbJekR++h9HZlYaQDeC61ByOVIGgdQpGSfN+TNRk8vkNYqqXudz5M96WMfafjYv71SFy01+W8X1OiBIGdxbmLCMEZg2e2dXyNypqytaujM2yEU6szarGN4p8FcoTIHn9WJYf4BsKzqbVIREoyQufSUTaKZRumLHwBB0UAeLY2yDwvgcFAA3YlUO4B3VskXcmNHjvGmCuvkjc8sSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aG5MKxugYM8pahis7ZjdcGl1DbSgHAGganRVV8iYMAg=; b=utilPg2CtWDar16yxNwzyxwr8lrMKVWObzcXydp+r9AQrBGzT6iKE6ksbg94XQT+GmPly1J1aEtQWHeYvVSkg+QYQYTwdue1rKc/k8/ZaVAJHa9/k/jI/s+W1jM+RrLpZMYslWnEwy8whwDE7afgH+uQzIU8EgM8aBd6xt9C2rOrFQ9InXsj6YlqmMfipV8BOG0iUETeD5D33L6aHobCMZ80uyJigj22O+zSifNFmVch6cCQDN4VHWv3b5dZnDgn2l67Pk49MJZ/dTSKoiaOaLuXREBsa0j7y9mps2YD/lxzqKl7qtyf2UbyBCU6T/XRZhDDmNPOEAkSH6tYTEGKMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=cmpxchg.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aG5MKxugYM8pahis7ZjdcGl1DbSgHAGganRVV8iYMAg=; b=IVGVNVmHExyKUrhsJD62rWl2DaRkPP7eDuJ1pY6KcAU86fOBKza0uZD/pex0jNqc/wMunjRtNzx8t2w3q8blv6eWEFQ7zlgTZNV7UPw2HPwMceYRhQGnGKaJm54kU4tHeVje/WF721kBE0U7p5kjhcwH78gVMRXywvt0MRY1s0o= Received: from SN4PR0501CA0097.namprd05.prod.outlook.com (2603:10b6:803:42::14) by DM4PR12MB5939.namprd12.prod.outlook.com (2603:10b6:8:6a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.18; Sun, 29 Dec 2024 04:00:15 +0000 Received: from SA2PEPF0000150B.namprd04.prod.outlook.com (2603:10b6:803:42:cafe::46) by SN4PR0501CA0097.outlook.office365.com (2603:10b6:803:42::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8314.8 via Frontend Transport; Sun, 29 Dec 2024 04:00:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150B.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Sun, 29 Dec 2024 04:00:14 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sat, 28 Dec 2024 22:00:10 -0600 From: K Prateek Nayak To: Johannes Weiner , Suren Baghdasaryan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak Subject: [PATCH] psi: Prepend "0x" to format specifiers when printing PSI flags Date: Sun, 29 Dec 2024 03:59:40 +0000 Message-ID: <20241229035940.3210-1-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150B:EE_|DM4PR12MB5939:EE_ X-MS-Office365-Filtering-Correlation-Id: 38ec5b8b-acae-4dae-5a91-08dd27bd4cdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7PMyo3uvK1Td6rCdOaZkSxNBZ0zoHgcvTFFqgl4w/VMU8zijrvdlCgxVTlvg?= =?us-ascii?Q?XwfHXmN6yAnGI4bVX7I7ChUVMp6L85/Ci1oz/YDGKHGriw3AYNAAh8sh8mTX?= =?us-ascii?Q?/cJFRPAUnvNh/VsBQcoPkhWxhPylWAq2Vt686Xm5f0KuxZV0nwEfzw4HpnlS?= =?us-ascii?Q?Exn6IDtQdx5yYp2ymupx9ZFi4l9dfUXuCptVDf89AF48JAh5FsLLS2mJw4Dn?= =?us-ascii?Q?0qNH/e83YMC97QGuIIAfkWl7Uj/8kOp+XaTX2olvVL+gWWwwK2BhpWR2et2n?= =?us-ascii?Q?L3GEQSLNi1YTEVtfl/Tbwpojjp7zd8lpv1s2O1XBSE6XadpySQ09m+3q03P3?= =?us-ascii?Q?qE4XmQPij+j45/k7GraxgXt9ChB9TAfEFU+4CxV7f0RurN6dN3LMALDP0DYy?= =?us-ascii?Q?wcFhYQIXru/vcK4nLJ0OWzkkWrndWaXyfciL9UCFRiL6JR/34jRW6lm38Dzl?= =?us-ascii?Q?fSwNa9Mlkjo6N4LkyI0gb/XqRqJk+/HRStmIEuqrj92k5vyjReFTy2GKdtms?= =?us-ascii?Q?TQT1zcmp6D/oq1W54bFf+Y6r51CH994vAllh3W/JAXvVF8StYtoXrDgH+cte?= =?us-ascii?Q?KpOKh1ZdrTiMhG8kNFnliX8Z14sm+bwM6Cxkfqty3uEzCxey3BX3gKZFp7uL?= =?us-ascii?Q?BJifExx9tmKQFI34k/k2ayxssoDX42BFlnorUYrEzjCvbVzr6FzwE2VcRcS0?= =?us-ascii?Q?TgVszUTm4kC21nkkDUqTmwnmVY5/w8HIK0s2JpH64zpANkBN1vgMqjIdIhKG?= =?us-ascii?Q?un9QU0luAEObYStvXGvtk2MpYeqJd9E9oDBNKUX9kBjUqAru5XuaSySUM1rH?= =?us-ascii?Q?BziJ9ff+LPLwh0fZx6rgzBRoIkKp0KB4bj/tBu5XddQekgnpvjxxTsTvGN2z?= =?us-ascii?Q?nWIxwDkuQ/gTWpqN201SD3DlgV4pkeWHDzi679sltXlFRdk1+3oG9bTIHrqD?= =?us-ascii?Q?BojYj/X/3x/s+Tj3kfwJsg5Gaut/4GiULs+lGsgZo1Dnw5gy5RvPlUJ8E+Fw?= =?us-ascii?Q?vLe2CyMEM1wvvFPLE1ex8TM6a4vPlSZ87cfQh7xurFrqISDAEMokRpo5L2aa?= =?us-ascii?Q?g5cHrGyOPn6WAgLS/VRhf0TP3s8I2Kx3VKNniZ2zi0kwiB1WCdAw9LvUu/Nr?= =?us-ascii?Q?9MjS4weUewc1kUh0egqZoL8kxH0QMD1i6gwDlb9PzWrPYkVpmXM65XNKQdnm?= =?us-ascii?Q?dViAhLTYVtHMcygZdglMeDuDOEqE5FiqjQP/2CMJ6fgIN1aFsEq4pkXoHXxp?= =?us-ascii?Q?82SU2K8gxg2Sb9BJkCm8IWnETdrmobzcgOKzD9yCDaidMM3gbGME7Nsan+lK?= =?us-ascii?Q?ISpf6XrgVHFnUCISfmw4WBtqfpyVDzTiKxMD/1cePg6DMdZTJXoa5p39qgaT?= =?us-ascii?Q?H09nwQH6udtx9wmbPLnGGcorq1bkelgzbUrgrEA1UbMM0A5V7j+TKvbqcmZj?= =?us-ascii?Q?qW5ijE2UxKcny9rFUCEazL02i8GR9KpNbhEj3oLvCQUC6YXlYNhznSfTms6m?= =?us-ascii?Q?A9pwdhWSA1uLZgM=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2024 04:00:14.7508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38ec5b8b-acae-4dae-5a91-08dd27bd4cdc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5939 Content-Type: text/plain; charset="utf-8" It is not immediately clear that the PSI flags, the set, and the clear bits printed in PSI warnings are hexadecimal values. Prepend "0x" to format specifiers to make it clear. Since "kernel/sched" uses "0x%x" as opposed to "%#x" when printing hexadecimal values, the same was followed to keep consistency. Signed-off-by: K Prateek Nayak --- kernel/sched/psi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 84dad1511d1e..ceac814d2837 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -818,7 +818,7 @@ static void psi_group_change(struct psi_group *group, i= nt cpu, if (groupc->tasks[t]) { groupc->tasks[t]--; } else if (!psi_bug) { - printk_deferred(KERN_ERR "psi: task underflow! cpu=3D%d t=3D%d tasks=3D= [%u %u %u %u] clear=3D%x set=3D%x\n", + printk_deferred(KERN_ERR "psi: task underflow! cpu=3D%d t=3D%d tasks=3D= [%u %u %u %u] clear=3D0x%x set=3D0x%x\n", cpu, t, groupc->tasks[0], groupc->tasks[1], groupc->tasks[2], groupc->tasks[3], clear, set); @@ -887,7 +887,7 @@ static void psi_flags_change(struct task_struct *task, = int clear, int set) if (((task->psi_flags & set) || (task->psi_flags & clear) !=3D clear) && !psi_bug) { - printk_deferred(KERN_ERR "psi: inconsistent task state! task=3D%d:%s cpu= =3D%d psi_flags=3D%x clear=3D%x set=3D%x\n", + printk_deferred(KERN_ERR "psi: inconsistent task state! task=3D%d:%s cpu= =3D%d psi_flags=3D0x%x clear=3D0x%x set=3D0x%x\n", task->pid, task->comm, task_cpu(task), task->psi_flags, clear, set); psi_bug =3D 1; base-commit: 7c8cd569ff66755f17b0c0c03a9d8df1b6f3e9ed --=20 2.34.1