From nobody Sun May 10 07:13:41 2026 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2088.outbound.protection.outlook.com [40.107.236.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7015941C6C for ; Sat, 28 Dec 2024 10:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735380280; cv=fail; b=QoHK7qdhTnuaLofb47Wh4iYJJayUWJaeHSRzlch2HZWfl4/HbxCmSkTHwrQ145+0ZmBE8pKcSGgUedIIp4yRtc5jZ+sBCTvvQS591sLB/AppkYYSc8lYyJj6h/Oir1xVqHdJYupVC0lxkm3NkplMtq1+2xU/EUkQbzjseKtwmxY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735380280; c=relaxed/simple; bh=u9I87J+mwOd9vhMJkBIKaPT7OEJInyQNVYo0FwUaAXY=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=TiCcswSUCaATsg1a8qf03NhSfHSlciFOLLLRdfKrq/J/VMFpvb3b/ZjJygCvABUr3mhthWYRLYcDGUJk7iL+Da4ptEFiBg1UVadGl4quzg02tXO95ZaV/WxlUWAaAvlSx5QswyDZaWCmA0o2SHuev1VPKFKfkE57774vn2+xIdI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TDNIVTzD; arc=fail smtp.client-ip=40.107.236.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TDNIVTzD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LTnEeTq4eHZZOXr9fmc6Ac3eQXvPgbpOS7aRfaikM6V4YUWBYMeV/8xHlQ7p2Y7ebqY45Re+nxLCltRNOV7nQd+GEkDqsxRoQurty5KzVzR/DoiDCLv1NhgUNO/8TLnUokSxolM7mCiHKFqXwOkPsAiIDaUeqPFvMnHk29M9CG4vvu2iAQzAKBuQ/FV97oune+QEIUnR77FX2dtIxQGpKGsncdRcPRY2569Xe9UN2vEHANXZiDrgtK3FLubjbHFmVmuDdliM1L6IAiJl5DRy3pxK0z9KRJaiZ93QaxrU3cNQG+gWBYp7ZYJJtM1kumkdVZYCgm5IdMHKUSBN320Wpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5V6rU82VZA4DyHLxyPOM4zFJZoRv+zofjId5+dgyyQ0=; b=ngUbj3ZrZOhp3E6QhGp+F7IT5HNvGdikL2iMj/M66Ybxb6Uvl3XzvlnDptuntPQ1K8L5IKMpU84YcdFtVCDoDGQIMF7ectY3i9DwKikc22aBSawMLq+8e3lBdustiK+ToVRmUCMytjFeX6P9IBSlTrfoo+Qn9l3YZcM+ojE5EDawYeN4Y1/i3UchQRyEVYF/6HN6anXi0fWlvqgNDHsGgmUCP7nbZ6WIgGRRslEUjVkeoZhkmJrsLApR+xoSr6pR13RZ5X+oftCbbylhXclsD1xvAgIyaayKzdiTG1jIlKl5lFL5vxtKwmkqVNVsonqaRuLWwQiWc3WXJp7c4WuWGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5V6rU82VZA4DyHLxyPOM4zFJZoRv+zofjId5+dgyyQ0=; b=TDNIVTzDEOLAh+v6+Hdmf3bDM7Qb/tAppsqhTkyBIJ/YSwHK4B8yeRqvVpnK+z/WqdrIhF/b13WCQibsEh7bZoaSSQhE0ndpSgnsh13wCABXtBdSvbMj0PG0pQiWgT2zA117FHrZYUsKuqpKLk8ya9qtYnoMOJSGsymFVveoGrJdJ1MOwziLW+LoIGaCnTBlAHZA6Jh1Zc6m3gpT7GdtIlZGvBcOIngjWC3bKlfU1gJsoO+Z7rMpEl8pS8USLdvWsiDDM19TK3rvZY9jb9SOYCpDh40lIaeAIQ4UgtyH6ciyRi1wMtVmi16yKvKrPsTII0ASIo18jo6rDyesUzLQqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM4PR12MB6424.namprd12.prod.outlook.com (2603:10b6:8:be::16) by BY5PR12MB4146.namprd12.prod.outlook.com (2603:10b6:a03:20d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.18; Sat, 28 Dec 2024 10:04:31 +0000 Received: from DM4PR12MB6424.namprd12.prod.outlook.com ([fe80::8133:5fd9:ff45:d793]) by DM4PR12MB6424.namprd12.prod.outlook.com ([fe80::8133:5fd9:ff45:d793%4]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 10:04:31 +0000 From: Andrea Righi To: Tejun Heo , David Vernet , Changwoo Min Cc: Yury Norov , linux-kernel@vger.kernel.org Subject: [PATCH sched_ext/for-6.14] sched_ext: idle: clarify comments Date: Sat, 28 Dec 2024 11:04:11 +0100 Message-ID: <20241228100411.755767-1-arighi@nvidia.com> X-Mailer: git-send-email 2.47.1 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0203.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::9) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6424:EE_|BY5PR12MB4146:EE_ X-MS-Office365-Filtering-Correlation-Id: cacfea99-13db-4502-ba12-08dd2726fe68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KqMfyzpzrLqasmJtp8ODz8E4CSV6w9n3eler4yn5iDN956SWP1pxto336obb?= =?us-ascii?Q?dua8WBWncS/SPZBRK7ryckKyANaT8r0uDGY+eoMTXRiKea2M7XIIt/BaCj5j?= =?us-ascii?Q?1yP70zwzDwYFmS+rC5qJMmEzHeiDsUCWmFHLNbHgeZzKVVFHJU0uEN6Yg8OB?= =?us-ascii?Q?Og17urjYie/6VkRgn9wP1q6Npl/TbcpXjz07iJ8ZP1EjZ+n1dFYlScRKOyJe?= =?us-ascii?Q?5XODPFezslLPFysiFWCN8Y43ck8ZzA+ia6e0yaPJzxB5O+izY/iDxXMoPO+u?= =?us-ascii?Q?zquQGREnRdwJw34QcWTRgRdK+m5KYtfXzY1+T4NAGLz9w9MDpB4KmhJEjB9q?= =?us-ascii?Q?ykOFb9JuKeXFZfcjFvlIRnfBpn1fDNAVGNkl1N6A4b9uTxf1+5Am3J8/kIDG?= =?us-ascii?Q?rSVfjQWOT1HpNv+jao1Z91ZgkAsu2LZCq0wmXVi4eNtWRCMThb7vza30pyvN?= =?us-ascii?Q?DjhUZ8xXx7uSScDJxF9PCN6aP4Iu1E4V52fcuNgjU+fxRAS/fdEGqH+w8THx?= =?us-ascii?Q?SEe7Czrmg7WTqn3JWog+cDAETvZD5g6zZTE4CInio3XubMDfbSwpDfmIaoXq?= =?us-ascii?Q?FegOusgSjICQJsuqm4zb2ZNMVi9SKwiQzz35SqUSfSya8dDxtk6X/yLVYFX2?= =?us-ascii?Q?LDpEVbWADN3DZVIC01uUoe2IWjbv3Sd7G7tbABR7lKoK3d8P2oLRuyz6rjo3?= =?us-ascii?Q?X9PKdbRm1n7XpF0PZsJ9RGRxNDAc6eDvxeMGDPYFZRgcTtgNl8Rd71FNFowi?= =?us-ascii?Q?Ka2wstNj1SxP4Zncq8JcrHJxGvZzHATWa1dBZTUfZ87j4WnaVi8Fb9dtm/Dl?= =?us-ascii?Q?XUMoBEcPYWcWU6MROPquW/WvxFqwXsKnMk7dSI2JyPE0G/uUA30GludyNl5R?= =?us-ascii?Q?1UAZAALICn5gxqWYlm1K6iUxe4hCxRp905fyTfdicXVj82OuLMRZlmxVexVb?= =?us-ascii?Q?9xl3Q8vgLT/75c6gGEQSWIdFKbShPNSWvsddPG6Kuzs1TTxO5Ho7PaTNgrEx?= =?us-ascii?Q?gWd+8369HfF6pA1iW02eLa5XhR2W5QochPIXkVoB9llhDw52+f8LGk30Ib4F?= =?us-ascii?Q?Rr650SEjFTQVGzkG/SDXLGpV5LJu1OuIwR/BxbNXSIDQiUdO4mwacdToco5L?= =?us-ascii?Q?x8UdBfkceXb3a/PItHInLz/pQ7dr9rmA7Ciw82Fonre5h8cyNBu+U7JuRTpP?= =?us-ascii?Q?W9oeldRC+AJuR3bqp26tLu79jpCFZf1yvRzG8qu0mD0HezTUOWP1k9kwoWOo?= =?us-ascii?Q?Mh99OzGvi91Qj7fhcn+slFCnKU+JHKepBbo4uJ3owfKI+5WSIm0+XyrfCE90?= =?us-ascii?Q?bYnN6xgfTwVEEcno/94NI3VSl9aodqcXJBRPCVRguvd0HvD68W7Th/IhUv21?= =?us-ascii?Q?1EoiVWj2IdqdnhS7xIl3Jv1SAP61?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6424.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S481avjNUpbYMCErMR3qVqBdrjgVkJaEEaamzw4sSZSB5wL/WbPJTCAjRvR3?= =?us-ascii?Q?B6y3vJ7dKcp4BwIwV6SkCCdWlAQLXR8J7Pb9Pv+tompgXRxfLYDrwUguouCB?= =?us-ascii?Q?TLHPPWx66TIIiRGlFnrxtMlHIZe+Z4iOneTQ8spsHWqIy47BVHApSKDSryhT?= =?us-ascii?Q?0QKlh0pqLzFyOlLy2NefNlwLvP5M/kmyCHq0eWcwJxeE40aynZ6dIc+nIDlQ?= =?us-ascii?Q?X6NXcYDLULnI5Gp4JYeKJjNz7zJvR7bJFUqFJHWNs8IqiT9x0T5iVexZAcAx?= =?us-ascii?Q?oRf2KjBAnJfmcLz3BrhADnnmS+5+PMJyvGZph9eaCkoYX2NlTMgBoT1YzITt?= =?us-ascii?Q?DikSsnXqWmDIz9u02LVye5chzsdSljrC4Dl+UvfK401naA9v87KYFzFMQMFE?= =?us-ascii?Q?d7RyL+rXRyZV61yuuQz3GCpe460sGNhW2UaXFPTuiU7dG3h7Mz4nfpathQlk?= =?us-ascii?Q?c0hjYyue7wNTmQ5HoWcGDxO6EkILNkREuC19Z0/6LGnwAQXaD4f/rBc01ebA?= =?us-ascii?Q?9sgb/akbA1hVcLXqj1+9xoNi217QU3Fk2SBdWM+M7HnM1fArEeVsOq/QHgTf?= =?us-ascii?Q?TiZMwBjr+2WvTwh2ZePR3nbqXpnYwyFtnYEiyozHUVX6ZGJAdF/KvC+20KaS?= =?us-ascii?Q?MiqONPKjm6YrnN7zwMgJ+gbpjwb96vKgPiEoyvCVLnPjtwPLaGAuHo8/0vRB?= =?us-ascii?Q?RNaEAJH6VKalAcGB/V/A36Nsu0RBNyrAWYqEJnurGMJNP79FgJup5HZMGP0F?= =?us-ascii?Q?KyfOzoRFgoNWh3EAbdgW5XbLlN7oB/6HQYCOACo4p8YawpSKa6iihyWNeA7v?= =?us-ascii?Q?w8otikbpk5sJwmA8xnsdIcKt3pl37QqRhkAeImcwHEBc0xmV+KiL3z3+OUzA?= =?us-ascii?Q?rVcdLiWMXNH1KNYOF9v9qlCyXvR5oGu7oIOn5I6vpnZIrwcX0qQatU16g5hF?= =?us-ascii?Q?8DyhTcFsP0PliBooMYFTiN2mVA/qv+PA+tzUQBQQ0pEWUfWqI15gWkb/t1Um?= =?us-ascii?Q?Uh0gHc30gAH+Ihh1JdNwjvLcVYPbvDmMN0fkzPd1rKcPteZxAZB3I0Ox6cQ1?= =?us-ascii?Q?oy9WyA3VZyqtrXxbYimFaG2+mQy4G6zfuNg5HYiVjVSbL6s2izJga/KZ8NTP?= =?us-ascii?Q?QWOM4eGspPo+nr7l/78gRGRPTF8hmpEAgRPSY8lCtoUgz8uR6hwpbf4SXRvb?= =?us-ascii?Q?Gos+K/vCG2dEZFmHGPfcsPnfw67xo3O+mqBPbGiuPXhRmGfqPpT31MZi8tgl?= =?us-ascii?Q?KIS72X7XGtAqHePZBC9iz7BqSOi1EHQ3exm96gGyyDQanH518YIlTX25vWpc?= =?us-ascii?Q?vYTM1sV0jqToTHEA6KSzjVexPJSRZyGpqWAsSDkw9Bit+MAEwdno0lFERGtm?= =?us-ascii?Q?adKvUQawdg6eCIDgWjIFpzzQkqkZ2d7jmG/1MzpEcb3sw86ObmZfbf4ZyIbz?= =?us-ascii?Q?8W2nFtnGacIoNfI0Padi71GRMuvxyU33MYoIrn7V+xlCaFDKCl3e7bfRFtex?= =?us-ascii?Q?KorCKEcHpLMArEzIQpSxS78OfKPo7qYilZkOJGRMs2aZczhuXLB8Q4U1JmE5?= =?us-ascii?Q?oxn+PUPM4tEA2NJXIhBEHwIehIRSLprb43phhkoK?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cacfea99-13db-4502-ba12-08dd2726fe68 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 10:04:31.0858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8P/gjpyMtQppmgy9S0EZUfO4sLSm0LFgXo7FTjSiHC1/qn89Vb53Ea/Ey4sA4629d//RSEcQIi8jqhdN8N7pag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4146 Content-Type: text/plain; charset="utf-8" Add a comments to clarify about the usage of cpumask_intersects(). Moreover, update scx_select_cpu_dfl() description clarifying that the final step of the idle selection logic involves searching for any idle CPU in the system that the task can use. Reviewed-by: Yury Norov Signed-off-by: Andrea Righi --- kernel/sched/ext.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index eec4716de225..2d701203a3db 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -3180,6 +3180,10 @@ static bool test_and_clear_cpu_idle(int cpu) * scx_pick_idle_cpu() can get caught in an infinite loop as * @cpu is never cleared from idle_masks.smt. Ensure that @cpu * is eventually cleared. + * + * NOTE: Use cpumask_intersects() and cpumask_test_cpu() to + * reduce memory writes, which may help alleviate cache + * coherence pressure. */ if (cpumask_intersects(smt, idle_masks.smt)) cpumask_andnot(idle_masks.smt, idle_masks.smt, smt); @@ -3408,6 +3412,8 @@ static void update_selcpu_topology(void) * 4. Pick a CPU within the same NUMA node, if enabled: * - choose a CPU from the same NUMA node to reduce memory access latenc= y. * + * 5. Pick any idle CPU usable by the task. + * * Step 3 and 4 are performed only if the system has, respectively, multip= le * LLC domains / multiple NUMA nodes (see scx_selcpu_topo_llc and * scx_selcpu_topo_numa). --=20 2.47.1