From nobody Sun May 10 07:13:40 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D5BC147 for ; Sat, 28 Dec 2024 07:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735371777; cv=none; b=N1NXgjYYNBuhTSglRMuREqLH3Ou4y0HsokpfhddBshRRp3rFxU50UT5Yz6eQkunjyulsvRLIeHPootMOQP2+mfT6AdTWF+iHuKNLDZ+uVRCEBpe/4PVFTh1yJxOC4gcIYMTR4JPWU7JxZxSsTiGHEz+RwpIJAzKZ+XzrGBWAzJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735371777; c=relaxed/simple; bh=+jL23i2S7GjzIlkoLAqHLixhVHgbi68gHACTaiGm6I0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pffv78bq5vRsN9nqPj/RBK3TqjUf1CaWDobkU094Z20Imkimvz4qLbvVlQDOV+nFJ/SBLy2mCulXnMLahIs8qN+IT2QTVuyGvgVdIzDzWUb4BoLTgCA0pBKuwaCttnil57Y3+NUfRIaX2gpWoI3SkeEgKhbXcz4bRz3WdpYP/Bk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YcccEe67; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcccEe67" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2166360285dso98073315ad.1 for ; Fri, 27 Dec 2024 23:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735371775; x=1735976575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3rsV2nfU5EaAlPng9btOD8t6qLIbEB4yucGpMpfAy+Y=; b=YcccEe67hyQGhwTzLfe1haWaP6rpo15D1KQZ96EXS58kJe6+Xhu6B37W8huOqH7/Ww 9G9K6aM4LFMwUOEyRJ8bidLpFKBh+x4U2Ti/cIZ7jyFUWNhf9bGmhWc/PnFlQjrE9yGM FgZPcaD0hXPA1Dai87bb0tpZ300dY+245inxRYTi8pz/Cm6fUufj+aNdT+zt2kenkel6 KqVbvFiZeGaMj19xdYZzVUVGAHEXD7ByZq1WaqShjaB/yTcjgiMe1NTYonzsTYy6eqwO gP/TgbduvogqYGkA8IABj0FwwLm5VMiKiFnXd0360nPAMlJd/srMpJkuurZgU/EBLERD ksMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735371775; x=1735976575; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3rsV2nfU5EaAlPng9btOD8t6qLIbEB4yucGpMpfAy+Y=; b=xKWKMH6/bbuysfWK0BYscOoNWSXoXuMIlsmnMSC4A0L02Av5IXkKMg2I3WGo0uxIN0 tAJfF5kh7jUOvzp/GlVtS5fS65IoNrEVaD2L8mFCBQhAvWSkeaF02m6hNiXSwGSUpj8K WUsxJtOxRvJUA1DSOKIWq1kHixnrvG7ZQf7m3kRs3wPemMIXIXCwui3l8FX1fdkls1Hc rHXhZrJYv8vvZT66XFsxC8fYecY0PyBkH1JM7qvO+KraBK/kJwCMyFxPH1L2yBMd3wVw enukwxdOXUD8BbQHdSBAI1rbDRarhT7GM2y8kHXC1J8ASDrHEqbSrQtVcF1iSTFN363y Mq4A== X-Gm-Message-State: AOJu0YzKNUR15BqBaI7LfBMW074MMzyKTsOnPfzKghrvHxTo9KjelNlq HyZPY/1RlXqTQi3aT3lNmgsb4MUv/0H0sPQfpD0vrRLERmh3f1CF X-Gm-Gg: ASbGnctwS99PWtrKoMZxtXv5TTzMcvZimTD8YJBwMF/uVkJyrtqAAchu6hftfKd7wqC tbkiPTjg+RExGYKnsAZAUe7lR9X14oxGvnnBRB3tnBdHjtmSicDxITpq45zTL7W1E6o5O11oRXx JmrVAcwD9yGIsU5J+wqNvQVu8sCEquvwkTJCCM3VY+bYcFXGRzJiEDaQZynSdo03lMxcRE/7/Dy Po0XayLTKacOPqGAcrN0RIP4lOR5XQuxHlIqFKQQdpU8GDQoOCq X-Google-Smtp-Source: AGHT+IG65w5n7OLLnzrv+HQkfBNq6HGr6M1Z3BgH6SiEnhbLL160w/Alk9SVIbdR55iGRxu2Luf1CA== X-Received: by 2002:a17:903:2345:b0:215:9a73:6c45 with SMTP id d9443c01a7336-219e6e9dee3mr402505075ad.22.1735371775010; Fri, 27 Dec 2024 23:42:55 -0800 (PST) Received: from localhost.localdomain ([45.115.0.249]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-219dca02f8asm145568745ad.279.2024.12.27.23.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 23:42:54 -0800 (PST) From: Tanya Agarwal X-Google-Original-From: Tanya Agarwal X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tanya Agarwal Add missing error handling for add_repeat_template() return value. Note that this error case is already properly handled later in other add_repeat_template() function calls. CID 1309755: (#1 of 1): Unused value (UNUSED_VALUE) returned_value: Assigning value from add_repeat_template(p, repeat_count) to ret here, but that stored value is overwritten before it can be used. Coverity Link: https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=3D= 1309755 Signed-off-by: Tanya Agarwal --- lib/842/842_compress.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c index c02baa4168e1..055356508d97 100644 --- a/lib/842/842_compress.c +++ b/lib/842/842_compress.c @@ -532,6 +532,8 @@ int sw842_compress(const u8 *in, unsigned int ilen, } if (repeat_count) { ret =3D add_repeat_template(p, repeat_count); + if (ret) + return ret; repeat_count =3D 0; if (next =3D=3D last) /* reached max repeat bits */ goto repeat; --=20 2.39.5