From nobody Sun May 10 07:14:29 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FD41805E; Sat, 28 Dec 2024 01:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348526; cv=fail; b=c7OzZU3kEXwDIrc3OfD8r7JnTicgYp5GrJ9thQ5wIUBc6jI6teeyRug6RsqxzaHywo2ciWm8ba1hyyp6/VhTE1FVjoObU48YTe5wzFYr1LKomClA0dEcbrq/9lVe4Pt5Rdyd0MgTpS/p+Nki2sdOMJ3GzTVJ6ad5Tpw2OO4x/wI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348526; c=relaxed/simple; bh=rr4+NY79vHDTao21SuIwtmUb1wnSE8ucvghNGRhzc8o=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kRsMxra/1QUDI6nb1C6Sm9ZaxWIpM8moXldQL8LyDbXJkNkUdddP+9g48zBYC1uPOKzYz2SLEiYsAPtvpHDTc1LO+GJXCpKWMF9WcGbmceznXotFMwqGvvoo9dyb+8oCV9B06hXm7a5W3XTHrHdij3T03Ss8GdSL4PIYnue/cgA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=G//0vpng; arc=fail smtp.client-ip=40.107.20.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="G//0vpng" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gVpIBXKGDph7VANcYk4QJZCn4EzewIx7bvYcluc4SZR5svnbJ0byeNPfVc8L9XkqXmlMcYWuzf0/8wARB3oW2cZHpkwL3MYL6g3TsGloe+qFcV1PHpIG3CLqV3n5CRd5xIif53z3VyIR7DcnssS23ma8FwDifqIJVaa8xlV3JUXi0vk0p4ea7GrcXLoV+362g6FJAcjsfezHTEmwNZ2s4emGJ7M4sVEzGffZ+TB4yizfbAKPRtyLBRVC2jt++4yER9QeXh16X0x+L/it5fUF9Du8oofLo6BpzUBNezkEnw2vBxmzkP48/juiOvrr9mQ9LwshaRweIv4Z/CUon/A7HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXYTp5BoecHg34e+obK9OingrwQWYhGlKmIRTdHjAGw=; b=A81C6fyc7AIg6W2VB5Vw2VbkwxT/TP+PuzuiH18mOJEeR4aHmcMpv9E18WxYob1Yfv+n3UUO+CUqoCLR2xtEVhAnX74Pqkbl7943MofP2Nsavh2wPcuMA80frFnCMhqEdeudC4P1u3ivSNyreD3uz3Xqvh/Dz3BVZxPfK+6+3TYjBS36UygZRwRo261CwcyJiChWgSaxLcKbUZngsRoEJaBHJbeJgc23U9QGEKMbZZtep7b/MR0xRfdPa5ttvbjt+C5kIa+adSXMcRbkAdsqQUv4Ph0/AKfXAttDK/DpWwfV5hbbAaT6Tmkv7DupfUgzr2K46WbhoYWp9blklWLkwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXYTp5BoecHg34e+obK9OingrwQWYhGlKmIRTdHjAGw=; b=G//0vpngaurqRXrrBO8WtE6q50Gf80d3sz9sYm49MRZdJnU6xl8jFew+90FA3J/eKinN9+jsoZZlXXeHOY8aSG7RVYUdsWt4khMMnFk3aPi1uuoZjOHP6aK2xk6/NYW+x/MK/My23b9gDy2DEhys8LJHWofjNotD+kzjXqJp1ffMUi6htbEgpYFbTHVDOwuKscyJaj+EYRuMuJkOmV3cGbgKjsaFU/7VigC9cwdFgSfu0jb3PIOblh/01023p/CMQzr5afYJ16oOd5rTku+GGbvzJWBY7h/royKHBJBwcH6s3EhI947lqokEQaJV/v8iqrWlsmQu4mdrTRBECS4MTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:18 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:18 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:37 +0800 Subject: [PATCH 01/12] PM: sleep: wakeirq: Introduce device-managed variant of dev_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-1-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=2367; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1uWzLxz0ETkHUyA0IoSi0XaXoYut2vJxQmLJwOorGBk=; b=qSMQnYyGM9tDfzHYkMUGmXNyaUzaGa3+ti6BAH9c9FzUsXHbRHcqUk+iAcM38J1RjL8RaqoVX 5f/l7EkwTGjALGnbsV+r7vQCvfEhAsFjc2BLLoZCeIs1xuYV04uru6q X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 78ae5531-0393-418c-85f7-08dd26dd1779 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aXcySDIvNUx4RXZRVGRoZ0ZwQk5RdlIxa2thSFoyU1VvWGdTT211QjAySEJL?= =?utf-8?B?eEl3cTJhTmpmbVBiRHRnSERWSEZWemQvK284WWhEVDJ1UXRFRUlDbFJQZW5i?= =?utf-8?B?MXRvOTIrU3NkdWpPMk1SNnUxT3BBd1BsRlFTUjBFRUg3eHNhczJaWnVqQlkr?= =?utf-8?B?ZWhZanJGQVVHSElWaXJNOWZ3U3A5NnBrOUJ6L1J5ZEQvNEQ2V0FjQTUvalZS?= =?utf-8?B?RDcxbzQ5dHArQVM0d3Naa1Q0cjJtNlhTeC8xNGxJbmx6QzhIc1NydVFsMVZK?= =?utf-8?B?ZCtGYi9zcXAxZFNlbTAycVhWZ0UreGZSTDBxOGdiRGEwOGtqc2NOV3hodGsx?= =?utf-8?B?SDF2U2haaDd2S1VUT29yRFhqdUVOL3h6ZVEwTnJmcm5mVzJnWFZ4MVpIVTNl?= =?utf-8?B?S1AwUGs5TEhUUGdPcVpveWtHcGNTaFc0SXNSYnZNRXAzcFN3UUIvWGJNRXhH?= =?utf-8?B?Y1VoWmt4djdtZTR0NVExbjBEUnduVUowYi9jdEpqcE1jSHA0QkpvUDYwbDkr?= =?utf-8?B?K0RyMUEzMXRid3MwbVIycENxbG5yWmdWY3NwQVpYR3FCR0dBbm50YXNoZ3Jh?= =?utf-8?B?aDBjWUF1STQ1cCtOemp2M2tud1VLTWMzVWM1YW56WjdKN3VLYmVPSHNwbDBr?= =?utf-8?B?U0M0RThZYzhXTytDeGhwMDluZ1Y1cHFrdlE1R1FEc0lxK1FHQ1lhNTBxSkpj?= =?utf-8?B?ZlFPRHdjQ1RRUXNnMXNNenk3TlFoUE9nU1Q3bm9vRmxYREh5K09uNFVVYUVh?= =?utf-8?B?Z0cwb3RtL24rUHNpY0lmV0trVklPNTJtdnhCVGh6UzFVNll0aEdzc3QyQXl5?= =?utf-8?B?SGlDNTlvaFJweTFCa1k3YkgrcG9FRFE4T0ViZ1ZSN2czZEIxVkNvd2JtUE5x?= =?utf-8?B?Q2dKNDRhVG1JaG9OODNqU0R0Myt4ZDFzcDBxVW8rak1XVGg1OUJSRm5ZZnJ4?= =?utf-8?B?Y0FWenc0TDJnOWwySFFPMEZ1WnhVMTBmZk0vSDZOVHdmaTRjVzN4YUNGWE1m?= =?utf-8?B?UldzMVR3N2hlZ3FZQy9VZ28yMmwxRnJldTByTHpKZ0JYSGVpY2xZSlVNY2NS?= =?utf-8?B?cGdDb3FXN0VuZGtISG1ncm5BL2xRRlRBQUNBdDNWSmtHbmZTWjZDVjdLcFhy?= =?utf-8?B?WjBkV25UbWVTUi9CalNaMUFRUnlwcGxtN245cG9JMGpkYk1RbWFIOWdvUVU3?= =?utf-8?B?QUI1bFV3akUxakNyWi9lMTJwNEN0MjdxMUExSksrUTFweThHQndHbXJaMHJI?= =?utf-8?B?YllOOTA0YkY5a0trZmRBQkQvWkt2N0c5TFhTWWd4MzExbjVpWWNuWmlrWFdY?= =?utf-8?B?TzZYVDA1blpaSVUxRTJVeGY0T1NOTDgvb0lLKzFqN0NpQlkvZHlNSWVEMmV1?= =?utf-8?B?SlFTUVdJQkI0K3J5K1ZGd2ZOQTVLQUNSMnUxWWVwUWhzM0diWHQwOTNhVkFS?= =?utf-8?B?cFZnVENheHRTM2pRc2NvS1d1UjVPOC8yYTdZcEtVRFUxNXFaUnc1akphSFY0?= =?utf-8?B?M0ZGZEFqeG5pR1FKcWJsRlJBUzJKM0NGMnlsck8zRkc5MktIS1V0M0wzSTFt?= =?utf-8?B?YnY2WWUyNElnc3ZUK1J6akxKMmxqUVE3bUZHSkt0d3Zxd2ViRjVncG9oOHE1?= =?utf-8?B?eERadXBpeko4eGdDTVhmU0JVL1QxU1ljR2ZUOFVtN2RnUVErUW0xWEdUd3lP?= =?utf-8?B?ck16eHE3YWdnbTJwS0IxS3BOWXRkZlNWRUlST2ZsdUVRNnhOQU9MbUFHY1Jy?= =?utf-8?B?a3ZZRTRvenhDa21NYU0wTW1ueDZuYVdKQWw2dU5ybHo2ajlzYVVSa29wS1JI?= =?utf-8?B?MzFtUGFieGl0cGM3dTNXZEFFSXNONURpWUtXSUJEREhpdHlsMGJUcXhsK2hr?= =?utf-8?B?TUxjaHE1R1ZIeVQrYnNWczhHT0lKWmZZNG9VQnErSy9tRmVEajJGa2taNlRH?= =?utf-8?B?WWx2clZvMGJGLzBVUUdZZXRRRjhBVzBSNUxoLzlTemR5enNTL1BlZitaYUdt?= =?utf-8?B?UTd5RGhvOWJ3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlpkNkl2T2YrcjkrREFvUUF2cVplQXlGQWo2aXkwUUljaEVQWllVU0xTaUI0?= =?utf-8?B?WnlNalQrcjZxejQwRWw0eFFZdXFKMTczUEV5ZHBpV0xGQkthQjdGMjV2UmhM?= =?utf-8?B?ZGlEeGpOUlNQWm1kajIzNTllV25UMld5YS9iR04xRXNuZTlobUhINE1WWUhX?= =?utf-8?B?TVh5bExEK3N5WUErSmw4N2c2Nzgwb1l2U3J4VVVTV1lKd3ozOWRDaGplQXBj?= =?utf-8?B?WHV5OUNMa1cyWnlRejR3K0NUR2VibVpFUVpOTnQrdmtXLzdmYjAxem5sc1NN?= =?utf-8?B?b2VKTWVUdXZTclo0WUdRQ1VYdnV5WTRadGYvdS9NVERiRDJYRm1YTCtIVWxF?= =?utf-8?B?Nmd2QkQ1UnA0dnlQbWVFRW9vZlZ2TFRyclZ0WVVnZnBmTEkwY3dCS3FnVWo5?= =?utf-8?B?NXRoQVJtVlBXYk8yUWpjeXJ5Ui9mYzdBUy9LaEZWUklUWFNNdEZtblZDUXg4?= =?utf-8?B?djBxbGZGUmZlYXFQZE5sWVNLeTJjbSsrdHlyL2xwdi9Qb1c5bzd4Tk5TZXFu?= =?utf-8?B?SGQ1NDBPY014MUN5OWkzSk5vQXNKNTByRnEvRUpJd1ZkRGtNZ0RNSEtxWGN0?= =?utf-8?B?ZFptU0hwY2MyY0JwbWtnby9zSkNORjdYNDZrMjBWbnVkdmswaE5ZOTJ4Yllw?= =?utf-8?B?L1YvS0pwQ1lnK0RRK1NIQUxlQlZzZ3E2d29vb2FlQWV1M21GWlBFa00vRzVG?= =?utf-8?B?L2hqQ3VPYUJxUmt1RHc2bnI0a01icFJiUUJSejJpNlFVL2w2R1ptQ294OXMr?= =?utf-8?B?NzU3ZmhJK3pnZGpMd1QyRUNNWVhYT2YyNzhUdnQ1ckx1Rks2cEhiaFpVQThN?= =?utf-8?B?S0owWU5UWDFndGxGS2JwWC82dTZvV0xLMVpuSThvSzFidk56d0M2d1Q1Qkwv?= =?utf-8?B?K0VBdFBmVHlOWE1uQXNFZ29lSDBDWGFsSE9sa2ZLREZVTzdEaUZKYWlDZ1FB?= =?utf-8?B?S1BjaEZOeXVJbXV0SkR2blBWZWtLSU5CQUlkTGJYbzNDVnlGMjVCTHQ5c254?= =?utf-8?B?M0lGRk9RbW5COXFoeCsrMjM5ZTJzMThxZ2hJWHR1RlNGRG1vZHhJVVo2dlpl?= =?utf-8?B?Wk9IYjNBVjdxMzBkVXV5VHJuSm1PejVldnR2UXZmTnViVXd2alVqYU9GRHFW?= =?utf-8?B?cE92Y3ZkNUo4ZnFCRG5DWFFNL3A3dzBwSE9KQWdldkpGRXJoNFJGSGNrRk1o?= =?utf-8?B?MTFlYXZDSlh1ZHZUeVFqc3ljRmRLSVpBbzJ1L1Q2eWxtNVZnbWlOV0t6azZW?= =?utf-8?B?UkVjNVFDeUFvMFNTQk5GR2ZWa09QRk8vM0wzMURhVWEzSTFtbk9hOGVCZHVU?= =?utf-8?B?WWRJdlZpRjlWVmJEeDd5cGJlbnBhb0lkamlscHpmN283NW5vM0xrS3VpeUNR?= =?utf-8?B?ZWNhb2xMSGluZWVkOU5ndGlld09TTjg0WWNFUE1rS2FKWTRVWDFzYUdJUTVV?= =?utf-8?B?aFJ5TW84SnkwTlNpZ0RMNUZzTTdwTXFsMGVjMDFIaGQzelk3RmFkRnY0ckx5?= =?utf-8?B?NFlmM0c5QUMrQUs5QmxYc3A2d29hbzZtUFBoR1RTTWhCdkxBUTRwUGo4SXNL?= =?utf-8?B?RElXSUZ1VEdvMDlRL1V1bmE1SFVNMXdRRGdoMDVqWkVzeFFRSUo3U00rZFoz?= =?utf-8?B?MGdGNGxmakJxWC9TRnlPSWlHWlB1Z2VEUjdnZGorZkc2a3ZsN3puaS9VUFNE?= =?utf-8?B?YlVPa25xZ2MzQnR3TmQ0dVRrdVEvc2NTN3d6Tm1sN01MWkgzNWdxVE5MK3li?= =?utf-8?B?eFh4My9NVVZ6UyszNWI3dVEwdkNkRzY3bThsVHFXYzNxNytPLytZZXY5aW5G?= =?utf-8?B?Z0hqaWtEZXJQcERvWlJGZGZkUC93U0JJNGpaaGEwOWhtdlVINzVmQU1URlRW?= =?utf-8?B?b2dYMTMwQzQwT3NKcjV2S0tEbkJuSHVsZDFWaDRiQlJYNVBiNkNTbGJEZTB2?= =?utf-8?B?UUx2VXpmWXd5SUplUHdMdUZKWnJXWExJenljb3RiSVJpdms4bVM1alNIc01x?= =?utf-8?B?ZG02YnNsNXBPOTdBeUxLL0hJUVdHL3N3SURCK0hrWDhmTXVSc01vdi9DeTdS?= =?utf-8?B?TERwTENGdUNtcjZXazVVdkkzQlNTb3NnMU5qRThtbWtaSGNacHhza3JKNkRR?= =?utf-8?Q?0WJEJX5VcbcyPjr/Ag/0jS+Tw?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ae5531-0393-418c-85f7-08dd26dd1779 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:18.3158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uZpt2V3s6fjoSeNpK+N8ZCTOW9FTqpcYRuuV2IeIZSIS04XS3WUHC1McTJ1X3lhfLJFZTG8YJNo6dPCNO5MxPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Add device-managed variant of dev_pm_set_wake_irq which automatically clear the wake irq on device destruction to simplify error handling and resource management in drivers. Signed-off-by: Peng Fan --- drivers/base/power/wakeirq.c | 25 +++++++++++++++++++++++++ include/linux/pm_wakeirq.h | 6 ++++++ 2 files changed, 31 insertions(+) diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c index 5a5a9e978e85f3fc9d89cb7d43527dc1dd42a9b1..cdc445189f68479c54f85e84be0= 9ae4f488df1b5 100644 --- a/drivers/base/power/wakeirq.c +++ b/drivers/base/power/wakeirq.c @@ -103,6 +103,31 @@ void dev_pm_clear_wake_irq(struct device *dev) } EXPORT_SYMBOL_GPL(dev_pm_clear_wake_irq); =20 +static void devm_pm_clear_wake_irq(void *dev) +{ + dev_pm_clear_wake_irq(dev); +} + +/** + * devm_pm_set_wake_irq - device-managed variant of dev_pm_set_wake_irq + * @dev: Device entry + * @irq: Device IO interrupt + * + * + * Attach a device IO interrupt as a wake IRQ, same with dev_pm_set_wake_i= rq, + * but the device will be auto clear wake capability on driver detach. + */ +int devm_pm_set_wake_irq(struct device *dev, int irq) +{ + int ret; + + ret =3D dev_pm_set_wake_irq(dev, irq); + if (ret) + return ret; + + return devm_add_action_or_reset(dev, devm_pm_clear_wake_irq, dev); +} + /** * handle_threaded_wake_irq - Handler for dedicated wake-up interrupts * @irq: Device specific dedicated wake-up interrupt diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h index d9642c6cf85211af603ce39e280a5b4de6617ee5..25b63ed51b765c2c6919f259668= a12675330835e 100644 --- a/include/linux/pm_wakeirq.h +++ b/include/linux/pm_wakeirq.h @@ -10,6 +10,7 @@ extern int dev_pm_set_wake_irq(struct device *dev, int ir= q); extern int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq); extern int dev_pm_set_dedicated_wake_irq_reverse(struct device *dev, int i= rq); extern void dev_pm_clear_wake_irq(struct device *dev); +extern int devm_pm_set_wake_irq(struct device *dev, int irq); =20 #else /* !CONFIG_PM */ =20 @@ -32,5 +33,10 @@ static inline void dev_pm_clear_wake_irq(struct device *= dev) { } =20 +static inline int devm_pm_set_wake_irq(struct device *dev, int irq) +{ + return 0; +} + #endif /* CONFIG_PM */ #endif /* _LINUX_PM_WAKEIRQ_H */ --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F210C41760; Sat, 28 Dec 2024 01:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348532; cv=fail; b=OddnEZ/r9INrw6Ypnm4b10kkut7upzFvE5mKjwyY4g162QDZ9HTA/14T8hHVapbZH4yKPMBd8LHGFXhu5zXi70pw5VkNbNdkA3NPjO5HXOCjrLTxkqU1I7kyEWcmgxI8M9y6je/yjgceqTeHh+IU90qtFO+tImBO+kdOETN4KDU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348532; c=relaxed/simple; bh=f0XWM6xBggK2QfOcHzd3+B2023F378UQ/qXOqelOuSw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=i9BTANH45oNos44PDe51aF7CucAeR3vUiYIY3CiMCFyZNXIieXYVzLiLxK3WOilN5oMH/HLuu2C5xIR28LPz/7VQWtydbb3AezsuRFCzysm733nwL43q/hZwIIz6YG7RduoI9wV9e8nbA7tZmPUu5EPh/JxgEMqkHgcXhmP21CU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KGSpnsMn; arc=fail smtp.client-ip=40.107.20.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KGSpnsMn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AqDXq0jdL/wwgfH3YPvYabWCXmYalSsxlGH4OzWpUbk1frs0Ek3ybPi4AKE24Fvs2PLOv6lEZyoCbTOcCItF3MHLg6Ii/VGZx79zL7NM+Eqe6VjsETuoX49dQ0hvP9xt1EUmuVdoD6VsWX8iJps40kHhhHaye0XO1Cy6aDff556eSYVNvYt6DJcVBlZJONHOJ32R3SD4qERjQ/A4rjdqz660TZfZVDogEWqom6q+paMhWXtYao7vJHD23U02U2Mcd2kRngFP2OVJS4e2KUzZ8umInEtok17P8bcw8BiFdTk0SqVWbrkt/HcJ+CT8xl0FYV03YYlJLyrrMo9sMv5gaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=vSs+X/kBp3fWnVmsTLg7S9+o9wn749zyjP57Y4E7XDh+CslRXhQHVhSZLoTFlZu0sW9luqttbB+ROLGriUKwcq3IkFbwaf6IcaPIr4D135zHw2D3rMNGRyCE+A3zkZjJxeZPm55DtQxovdbXT9jPhVN6/fbXzNMixLwLBBmYWGjZLcSF481stRB+en3wQeuiN5wh5FXfETgWAMBxWAEdnqgs/jxoVVJczUIocmYPd2nQw8CrBAVHYedvM+wM0r0ZnpEmQIPfYl2B7L+UkAOi2rTN32/KrNRN1bSs0XHUrP0re5XfIuGFTo+4GsHIRHiOADYrYYJVJb7oJu4Z2oRqnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=KGSpnsMnAzbmgAwnWh1MAH1hEuH+LCsNs7l2E9znPIarEFdJ5i1A3sSRFEclWX4hZUQsFAPuLD0+BqdU4hII/5+FU9+POI7iI4RSLsQ4055z7DnaPXIUyYh7Qk+X8f2ov2BJQalv5N5sNscUd1VNU+nryJFSxKZ+urvypz6V50BpgsybtORaghuFWOVCe9ugAf8gJTWsAR6HL3ufcrG0iILabXXaFJk6sRwW1TBEN0fx3IhVbYGtyK49gYF0i9aDkhLpl0G/wR7wE1eEhJT5ng20B9AB+FAoGBAqcbQA8sHLagUvNQfsYbRc1W580++DUL7pP4FfCfKs/EykeTEwqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:23 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:23 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:38 +0800 Subject: [PATCH 02/12] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-2-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1402; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lLk6bV9Q4qc+HUdwJdc/NyACnoatpwVUWdW9RwekWXs=; b=5OdW9htTwL8MFAvAyBNZ/2f0h1+VWymLzScDuYIdMdyOM5rQUUci7IzEeTZuelTVx/ZYACjxB CAm5iCzf4BsBX1SdaFUQCpoOFQWyqSIZjUtSq/FsN5iH1g7wLMYaf38 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: af5dd577-acd6-441c-2c9d-08dd26dd1ab4 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QzVTYW5uTUJXTEdTK1MzZE9xVHZZRllrbGd6Z1M2Q2tBUzVpN3RYa1M4MmJp?= =?utf-8?B?YzM0d0h5aU9qdEZIbkhIeXdaeElCNGJRM1NycWRCcDd1ZXIzeHp1K3RYc1hm?= =?utf-8?B?SFI3alJtbUtxRDdsSkJzT2cvUjZ1V3hwYmloNkFLQXVoRWQvTHY0ODY4b0pR?= =?utf-8?B?Z2x4RC9kVVRadm11Zmp4NHZMbzNHTU5oSzcvOFBIeXlQd2xQQnhNQVUvNllL?= =?utf-8?B?M1pwWmFNU2N3R0ZITXBzOUo2dndEWFdIWHJMNU5OUW5OaDExc3FjZGlUaDd4?= =?utf-8?B?bnIwTUhDM3EwOXRqUk1FYTdURmFRd2tNM0xJaW5ma21DMUk5YWtCMmRSNWlp?= =?utf-8?B?UG5ubWFyR09rSTVSNXFRcUxPSElRL3dYb1ZoVkxWaktHU0xwNm54K1FjSkpF?= =?utf-8?B?ZzNBSTlQcE1KN2tsdXZpZThEM25BNkFyOXFPTDJvQ3FaQnlhM3VjTnE4NmZK?= =?utf-8?B?Z3FjSVJNWkJ2OThZdWdaQ3RWcFdxSWl3a3A4ZVIwUkUzbnc5cjFnUDRXMEhZ?= =?utf-8?B?WWMrSVA5cWo4NWl6UmhLY1lMRnlRUC9PNnlzSDk0TGtVV0NpOWljOTI2L2NC?= =?utf-8?B?UVBWQmk4NFhqRHNhZXpwWFE1ZXUyNHhyZHBya1dpTDg4SktlaWNKNmhVVlo4?= =?utf-8?B?REpkRnR3RFoyTHFjU3R4RklBcGhuTzNiMTBFR3c3N2RCOThzM2ZTUlRwUEJn?= =?utf-8?B?bDZLNjFUSzJmTW1RSExoVHJycUc3cVpwR3NJMENWWHdxbTVPM1YyM2ZGVnBQ?= =?utf-8?B?YlV5STJOQnVXNS9NcHZORlJjZ1JVSG5iL2FHL01KWFJ4WkFGVnd4VVdYYUdK?= =?utf-8?B?Tzc0RmFUQmtVQWhRbkh4NjBtVmRWSFBLeGExejA3UDhLbVB6OG15QmM2RGJV?= =?utf-8?B?V0tFYXU1YlBNdWVRY3B0QzlCSHhrZmVrVWFKdkQwUHo1aXdwTmhKN0RWVjNy?= =?utf-8?B?OXlGcFFZVjlyK3lHOU1pRUxUZHBKWGpzVldTT0w5aW9oQStKM1EydnpWSUl0?= =?utf-8?B?czNmRE9tQ3FIWmkzbEM3bGJRbWc1U3oralZwVWFzcnhLa3NrY2pKeU9RVEpz?= =?utf-8?B?cm12dUc2Y1RUTS90VlJZclpIemVLa1U4TEk2WU9lTmgvNFpFVDhPTldBUEVP?= =?utf-8?B?b21YdXRtSS8rY05tdDJDcG5OYWg0MGJpcFo3clhxb0g0N3l0c01ZVEoyV0hD?= =?utf-8?B?UUdNZk5BSDZ3NVRYWWhHak9zekcyaElyL05uL2R2d2pKWTd4cytoM1pydW5w?= =?utf-8?B?ajgwTldOTzlBa2pDTktDaktHR3hiSU83L0VJajBwNWc2UzRwUWM0T1lXakRS?= =?utf-8?B?UkgxZ2dOZzYzYTlQRkZOdngyM2xSelNFTWw0RW94M3RzUXRJNlBVNk5Qcnhw?= =?utf-8?B?NW9vQ051aDdKd1F5TlBQbW9pMGZJUlhyaExqR2lKTmU0U0trMXZSbmVOdEJh?= =?utf-8?B?V1R6d0E2N3NNWXBTanRpUjdIUWRhWWNRRktjdS9SZEh4elZOcDZnMHlONXFh?= =?utf-8?B?MzI5UWk1d2pUMThqdHBpYkRLckJVdExTUmp2clc4aEFGblI1UFFDaElWOEpE?= =?utf-8?B?ZENEcVJTMGtiVG5HSXN0eHZ2aDIrbFltNVRJMERoRktkUnQ4VnUzRGExOWVM?= =?utf-8?B?eXV2OGhiYU5EY2VFY1EyQ0VvU3VvUXNMMW85RHFiK1pmNUpaZ21EQXFwaXQ1?= =?utf-8?B?RmlkMTBtMjE5Rk9JQW95bjlIeXRQeWsrQ1A3R2tqc2YwZktRSHBlWlo5L3hW?= =?utf-8?B?OEJTcVIxRDZZS2YrWmkxcHluNGhuUk1tV2x0VGtFNitReWc4d0ZwdDVKK05Q?= =?utf-8?B?eWxjZlFTb2JrMkw0aWFRWnc5Z3RIOEpvS3hxRlplVFg1Y3gremlXcWtvM3dU?= =?utf-8?B?MEdzck5zdlRaa3lCNE9TdDhKNE16c0pRbnVPN0FQdzdwbGxzT2JzNXlJb2c1?= =?utf-8?Q?BmcjofHyy1lwyOZweBg77OR43r477HFx?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnZoWkdYc1diQjg0VkJkQUIrVndEb0hRR2M2Z1BweHdFdlJiZEVNUUtRK29o?= =?utf-8?B?bEFhVnpMc0oyWjJzbThDUzd5czdBZlZlSUJsTEQwSGs4QWZMMTBRUkZ2NStx?= =?utf-8?B?dGRHc2tReS9oZDhDUUVYWVJjNVhHUlE2QmRGaGUxL2NCMDlPSVFGeTFzUjVm?= =?utf-8?B?dDdnWFBRby9FWFJnOFhzbkJiaDdkeXJnS1BOS0pkblBjVDMxeGJ6bWZEL1VC?= =?utf-8?B?NWI5Y2czZDRXRmNSbkpoWUcvV0pzRWwwZHo5SVF2VHlVR0Z6NDdWdnkzaU5T?= =?utf-8?B?cHk2Wmd5emRHQ1kyN2hENytLMC9tcXJNVGVJV3NUeVk5UzNwY2hnZXV0aVBC?= =?utf-8?B?dTh4L2hkTzU3RHRxcXUvR2NOS2thL3REUEk1RVpObTJxbmJwY2xBandBc2xs?= =?utf-8?B?bGlMajFYYUswT0ZlN0Jxc3gyaTJpQnJkeWlFbmdTRkNYSm1PTlVsZEJTU203?= =?utf-8?B?RWRNSzVJaFh0WTJBcitibFVGTHVqcUs2elowTGk2OVZ2VFR4cGhvREZOamlh?= =?utf-8?B?NzFxbHA4RnV6VUVsMFRzR296a0xhZkZPVXlwNkVLc3c4NUJJelM0Y0N1WFpE?= =?utf-8?B?RTQweThrczdPN3YzSWkvNi94NSswNVJKMVFYQk80VEMveUxjZUovMlVBcEFL?= =?utf-8?B?Yk04bFpTejBRa1pmUnE2TjBmV2RmUklXclFtY2d2Mi9Yemc2YTUyZ2duZW5h?= =?utf-8?B?VG91OGpmTFdGWEpHYy9hNXBqdDZaZ2tOU1p2SmFsMldIV1JmejkxdCtERFZI?= =?utf-8?B?SEc0a0Q5d2psUHJEUVFkTU1FT05nRjFxMzFCSklJdXA3VXRYdjFlRjRwL1N6?= =?utf-8?B?eUZrekdhS0tXeVI1eEpETk05elJ0aTJ3T2pZM3dmeWJ3VTcwYWR3aHphMUpU?= =?utf-8?B?UGI2cExIMnBpTEh1TVNVRWFQSTJkL3htekdsZHU2ZGZNZUc2SktjNGhka0hW?= =?utf-8?B?cTNLUFdldVZXbDA3QkF3Zm1iVGRBTzRpaGFmNHNjaldwQ2NVc2N3bytOUWVV?= =?utf-8?B?bVJVQUJJb0x4d3c1bWJpenlnc3hyRXg0ajJLR3psbDZLOXBNNFRCam1YSnhZ?= =?utf-8?B?b3hjWjBxTUN6NXN6RHplQkpSOFFxVnp6dzkrbm9FQ1NWSjlweHNVOUIrajhN?= =?utf-8?B?NHQ1N0I2OElIVmlPZW1QQXFuYUF2WjJkbkpKQy9mWHI4SVBRUldQc0w5TVha?= =?utf-8?B?RnVId05kcTNJUnVIOE1YT1F4OGtSekVjY2h5TWNvMXpPUW5iT09VanFNSVNk?= =?utf-8?B?VmtVY1A1OEhzRlg1RDJNb3dMNTBXSWNqWmlZMCs4TndFa1lEUkhHYjVDMWk3?= =?utf-8?B?eE50MGQxS3B4NElLb0hYK09XZTVkdWYyd0FEdW1MUmYrbkdXUUFVOXBuYS94?= =?utf-8?B?cnVoZ29WTU05MjUxV0Q4MmNpWlZLSHRsRHdORlFIZTVPa1FpanloODdOWVpp?= =?utf-8?B?MjdDUGlTVDJocmx2MHVSNjBYMzhJR1RkTXgwZmdDYzY1RFJCQUVkbjBEZjlj?= =?utf-8?B?MC9TMEpjNjBpYTZmMERYRitrQWd1VmNoUW42OGFXK24yMVFCWjlPeExpV1I2?= =?utf-8?B?aGF5QjUyVlVQcmJmT0xFRGoyai9ER0lUM0crd1lrUi9DbDl1ZWxkK3hYRG1M?= =?utf-8?B?R3FQTWxBUU5zbURrU29qb2t4OHBLMnJ4RnVXWmVlbFFkeCtWUVVKd1IvOG1L?= =?utf-8?B?L3E4a0pVbDBCdjc3bjg5OVQvcGdVK0wrbjh3WG5QN0hmMUxVTlFvSm9hZjRq?= =?utf-8?B?aGhkTVJ5amd0WlYrMlNXL1JUdGdldmgrZDVZOUNQZk9tcFAwLy8zMWwwYlJu?= =?utf-8?B?aXFGSmN1UEpFcUtWSnlJV1kzWkU3NjBob3hOdW9GeGlYV3BsM2E1aG5QdkF3?= =?utf-8?B?Z1cxQ1F4UUF1VWliRzl3VHVLMEs5RWdBWFVYUEtwcnprQWVMQmZ2L3VpVkYv?= =?utf-8?B?RVJNT0d6N3k1L3VvVm4vK1FnbXdpWnY3MkpnY1RacFlXNzMveFp0SUFWbm5R?= =?utf-8?B?WDlRODRxREh1TzBJbTZKNTN5Rnk3RTBOSms0QythZXo2ZUt0NE0yV3cyNVFh?= =?utf-8?B?TU5WenEzcVFTRzFiZDI2TlFLYTRNd3pKMjRXL2dDMnlEWjhhT3pUQmlPVXJu?= =?utf-8?Q?7PVMTdZ2qR8voBsC/wCWNDMWK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: af5dd577-acd6-441c-2c9d-08dd26dd1ab4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:23.5158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LM0zqJEORufJ8hy1wQpfzRbClrJ4fHBq4b49P5JnEm5v1slV/x3WUf8D/eWqw7T3KCpy11bpsluupP/mcawKxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/ep93xx_keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboar= d/ep93xx_keypad.c index 817c23438f6e5176431e1f736bb511f9919b67de..6e3cbe3ca72dbd43485c23f6042= b4fba007ff5e6 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -260,18 +260,13 @@ static int ep93xx_keypad_probe(struct platform_device= *pdev) platform_set_drvdata(pdev, keypad); =20 device_init_wakeup(&pdev->dev, 1); - err =3D dev_pm_set_wake_irq(&pdev->dev, keypad->irq); + err =3D devm_pm_set_wake_irq(&pdev->dev, keypad->irq); if (err) dev_warn(&pdev->dev, "failed to set up wakeup irq: %d\n", err); =20 return 0; } =20 -static void ep93xx_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id ep93xx_keypad_of_ids[] =3D { { .compatible =3D "cirrus,ep9307-keypad" }, { /* sentinel */ } @@ -285,7 +280,6 @@ static struct platform_driver ep93xx_keypad_driver =3D { .of_match_table =3D ep93xx_keypad_of_ids, }, .probe =3D ep93xx_keypad_probe, - .remove =3D ep93xx_keypad_remove, }; module_platform_driver(ep93xx_keypad_driver); =20 --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6104550285; Sat, 28 Dec 2024 01:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348537; cv=fail; b=sUUurJ+OKJZx6girds2Y7jRSwXqIft+Pzxt61IHEbbvZBjWuy7F7vZ2L/s99Dmlb7Hq3O+znLaDElcbsQD8nEATmjoTVMThOR4cFgYfk7c99lbUNnNC0a3yvpqpJX2HbVn/fsNWuPCKGv3B9Q5bs9TI0nGTvnFcp6bOQAD6x7uM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348537; c=relaxed/simple; bh=DNmSM/zlaiHe7y+SpoUtP9k7yyKM9LouOCBuhZSkcWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=k8hepYkFhRBYKOdNsdMnel3+Mv5aPedhITq0FW3X+4aM/GpMBjHKYJ525S/EBDtMP9Gf5IltTTlvxRcF8o4XzY3id9RPiw+qYcNDNOTXYeIZjXLqhKrgroqyaKkqyO3gLE9eepfH3OTequEh/07woI0rSWU8ZSRSSxQ4xqvu1us= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=XBLE3//a; arc=fail smtp.client-ip=40.107.20.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="XBLE3//a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lWEDXFj1zRBZbCj4jTywAYgUog+kXOLJm/GyPFk4BSTFhuJ6sPkUZCGU3ydCnqnB6iTW7n1Z4/9NXpZfwQ3tHnVoaFj4aFhUkRmzyuOySq2eJV9vZCKrxTL36b8qJamFachTUDVUMhD4oNCGnYbpN5WRLwXNH+fTM+JZdpxP9IMpb7IhvS+W2GTn9fOEKZFAvB8GUZ1Y327P7wmHIzviAiQPir2qUPwokDZm40TRvp1Cbi5L1rqjUXJwOfEIeG+/kLKkeMl3laLpRPPxtVQRuZhE3SIVJuDWOsN62KJKHB2K4R/7QyczSoUXVl/UMkLVsUksW2tQP9nF6zvRO/TqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=nMK61q1f3iv8IS8mVpJPXCLtlAMGuij5lngqJRXQktiudXn2LWPhNY6LhhpAfKb9LQmeo5gFoglFha9iQm9p8VnQ8t71mbHsNsh2EjLcQleHnAO2JIjR84eFB4rF6ei04jAHb57tPbjZHciTrBxetf5ioLSfC26O+d6cFt0qiiMuJVYi1HeCLjvtMjwiirnzrzbwXjV5eL0H/sp3N6nlGy/K1vlYuXdF4GgfBiqbaiWUSegs7MysJa1EuErwTMer3dJk24sVOC6TeYWactjcKZLhGpuo2P9CgIEkGhg5dzhD942c9u9rXAnD86EsVuldNQQ/WmvLGgx8WJqI9QJc7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=XBLE3//aEAKVbhEC+/BM1AxatOEnWwzsJqOyaIsZkYVospAzKoJsgqlZLWgRXL7KUD5PK/hIpFEOS6PEpveF2Rnyp2ax7gLzjHRNSIxSbY6LPsSJr8Ptm/uSSoIW+PQJ8rrcL2vp9CFLrt9yx0Sq6x+Q0vm/632nvRTeOwpWQOWGts6HjqExsCX7M/DbaCktVYgX+A03ied7ASJlyXGZvAHT3JmeqpT+c4A1mEoUEXmQUEAkDttlKj0VFXmTrlzy80R11Lf66lb44eMhz+QIm9hB3DUket3x0SUxHle97tYthqdDToK+kHU51yWEOkbdshFZ4wMOYmD6cXEXq7IIQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:28 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:28 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:39 +0800 Subject: [PATCH 03/12] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-3-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=ITPynXFen6NGI8Tv+l+31DPkuKOjZW+qKhVpYyrqEi1xXbuJiSLrF2YI2N0Bz1lh8BwJ5w4al wmUn6KOWVzGAMLjoeV1RPp2jYZsny3AhGb+XF2EJuPOEk3vDtyGfzq9 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a463dc9-5b0f-4a17-510f-08dd26dd1dcd X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NXgxL2l5aWY5OVlxeVVDM2pOemNRcXZzczNQdmlqYmtkZktvbGY4dk1BWUV2?= =?utf-8?B?U0hqWkVWT244Mko0Z3MyOTc4elVpa0kvMmdvQVY3Y04ydGdwZHRVWjRFaWhj?= =?utf-8?B?eDRiY2VRc3RROGlJVzlXZHd6QU5qcVduaVRHdHlnUG8xcXkxd1BucTlYeHFp?= =?utf-8?B?Yk9oaDJwb0hQS0plcGFPbWIyQlduamUyVlpJakk3TG5UeUtlYWlWR1pCRFNw?= =?utf-8?B?VTZzNUN3UUdyY2gxVkk2aVo2VmE1RjRNT2phVkMxNDdKZXlLczZCY0NKMGlE?= =?utf-8?B?aWE4Uk9zZGRaaFdJRzVWa3BscTFzVzVmOXZjdmJrZFRLQjMvMWx1Q09qa3Ru?= =?utf-8?B?aXRyUWV5WkFkaWdOSGpTbmxobUw5MW9aNk1pckprQVpvQmdWSklOV2ZuV2N3?= =?utf-8?B?dXRHQXluQml0dnQ1Z25XRWc2VFErcXEzVllHYnYvM2YrUHU0ZVo3c1JuWGhY?= =?utf-8?B?eWY1MFBjMFNsOWFHUHk4Q3VUSWdPSEhYdHdCVW1HRWJOWDZjY2xueWw0Y0hO?= =?utf-8?B?WmVHaS83MmVnZ0tPWE1VSWJ6NWZSVzl6OENQVzg2d05ub1dCZWUrUmRRYVNR?= =?utf-8?B?NHFaRUR6eHFQQ1lwRlZCQWVzN0c0ZUU2SWJ0VDZiT0pEVWg1cXNZTEV0RVZU?= =?utf-8?B?aEZhRE95SVIzeUVyaCtyeVh2K20rcSs5OW5rcFZrbHNMUlNtdWUxNCtJZUZu?= =?utf-8?B?YmtKeFhLK0NSUWN2aC9Kb1hGMDZPUm5jL1dyMHk0QnZuTE1YeFlFWFM1THRu?= =?utf-8?B?Zjd1cEEzSVVPYyt2Y0gwT3FZS0lhb3E1RmMrWjgrUU5kbE1KZzJ3eDE1N0FC?= =?utf-8?B?aGpKb004amszOEZoZXdYWU9jRFAzK3JhUkd1allVWi9kcExuV0ZiSmRmcytZ?= =?utf-8?B?c2FHRkkwMklBcFlDYXloRnVUOWhOYUloRHlWQ3Nna2hLc2IycjJOYzU0dTla?= =?utf-8?B?WTM4TEY5Wi9SOFBHZUQvZXVHSU80RmdoNlJmTFN0UjBHUDk5TDBzcW0zUjZU?= =?utf-8?B?eGkwZmtEOFllSHliTTB0amllWEdtWjVkc29pd2xMUUNoZzNkcHNjNTBoSmUw?= =?utf-8?B?b0lDTkFpY3VxL3RyaXluNjZhQ0J0MlpuQ1VuWjlMY2RiSUdFWXZCdnA0WW51?= =?utf-8?B?RmR2WVlydUlnSlVtYkdsSVh2MTZNSjc2LysxaXV6SjE5M1JJOGtTYjIydVNO?= =?utf-8?B?RE1jY3FnRUZiU3RpNlF6MU83cVNvYU8vS0VrOURsQTdMUkFodU5TemRpcEtn?= =?utf-8?B?RFFUTTBrTGhqY3dwRDdqcWJaQjd6V0Z0d29nQ0szVFIrcTNMVEV4VEdjRHRw?= =?utf-8?B?NjdRcUtYbjlQeEJZYUE4N1B2K0hKMWxWOGVYZHJRTmpLT0pXWVZxeVBqbDBP?= =?utf-8?B?ZmFUYVhiMUt6Zyt1bHFPcEZDbmJEKzU3SXEyOHBuSXREL29zV2E5R1RpcDVC?= =?utf-8?B?K0szYjBvd0x6VUtJODI2MjhSYWxDZE84Ty9uZFlrRTdTSFVYNytvc3NodkJE?= =?utf-8?B?dnRVNjVsZU11azB2cjVtZ3ZBbmduam81d0p1YXJ4RkFydDJBUnNTOXNSbHVH?= =?utf-8?B?ZWR6SVNlaDlsZWVJem02TE1zeXF0ejFiZWdUTlZkRkNwa0ZHSzV2N0xPZXp5?= =?utf-8?B?MmlaOG0xNjlKZ3lPVllhVlFCSmNIdHhxbUJwb29LeGNFTUk2UjhORjNZbkh1?= =?utf-8?B?MWFBUEJCNHZYQW9EeG44QVlLMnJnUE9uN0Q3aFZEaTlKcnAwQjQzMjB6UU5Z?= =?utf-8?B?S2lFVGhLUlZad1A1YU4vU0FFN3ZCNzhYVUZZUEJBZEV4UjJKcW41MHN5V1ly?= =?utf-8?B?QWMzbk5SSDFMd0Y5ZnFndGFRa3RVN1Z3ZXJzdWw3cFhrWllpM1RoS0hacFdh?= =?utf-8?B?QUZIUHNsYWE3RjZHd2FubGZTeFk4aUZFN1VzNDNtRTF5K2ltL3ZFVTF5Mmxt?= =?utf-8?Q?M8dXsFsgnSd3o8cXjpMWymVwdZaCaoxz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWUydEhvZ2E0RzVqZm5VWENSbEpKc0laYnc2K2cvakdQMEk5MGRDTk05cGtE?= =?utf-8?B?K1RqQlliL3ZwcWFVbEFjejZRVEdPb2VJWGZiL0FhL29JTDdzRzNyVEhDa21u?= =?utf-8?B?OU9SaGh5b3d1Qmg5cmZLYkhqVGhvR3NZRVdtZWtWNUZwbVo1RFl4dmNyaDd5?= =?utf-8?B?eWplbzdTd1lwR3cvblUzUTViSEVUT1dFaWlZWnEzYXRWeTQ4TFJpRnZiVDdT?= =?utf-8?B?bEt6MUEzVmtFaXB5UVp0emExc29HSStrdTdMRkJteUIrbE9rWmFuUDdlWFhV?= =?utf-8?B?aEJlaEhsY0t4UjdmaDR0OWtnTlUzNVgycUYrNVBPand4V0NYMHpyZzFFZjRE?= =?utf-8?B?ZW5LemlPQXJjUnJwV2YwODBDL2FKYTBsZjZkREJBZ3pqQ3pRczh1Q0Nid0ha?= =?utf-8?B?M3hHc2Uyejg3UGdxUVJHbThvbk03WC9aRXBDd2h5WTE2MUhCV2FDaTFuV0lN?= =?utf-8?B?WE1hOGdEQU9aVWZjdGNmOU1kcXB3aXVmdHhWZFFGWS91d0pWMFJ0dlVLYVhM?= =?utf-8?B?ZDlQb2FMcC84WmJiVGpKYVdJd2QrcGVRbjhiUzMyNVptVFBDcEIzbjMwU0Fz?= =?utf-8?B?d0dQSU5BMUhZTEV4SG1yNDZrMjF4STZEcjBsWisvWGFmUnlEdXg4LzFZOFA1?= =?utf-8?B?ZFZhUExXN1BpSUhPdXRCRlJXTnJxWFJwMVViRkZtdWY1QmlQdUhteHBVbVBM?= =?utf-8?B?Q1NYczMzQ2lOVWM2TjVlNlRTaGlEcGVtemNQMU9LcjlvNUFVd0FPd3JySlVY?= =?utf-8?B?bnJRNFd3RzZYM2locXlKRFlleFNGdExwWHRDVWpVMXprVFkvV2FlR05uY0oy?= =?utf-8?B?RFVVeEljNWR5WHBtaEw2VHdZN2NlN0pUOTNDa2w2MjRUeEtXMzVPMzFpTkRs?= =?utf-8?B?eXZKT3FOV3FaWXdiajJ4VlBPdURmV2tuVkU4bmZGV1JqWXhPMUtTUjd5MU1z?= =?utf-8?B?eFFCSmtPTjJLbW8waTNsSHFQeEtMWVo0cGxzblpqa0lESGhkRnRjRXh5NHc4?= =?utf-8?B?WFREYjVuanMyMjEzM2VLVm9neTNTcjdtMDNqMnJtRWVhdGkxeTZqQmU1a2oz?= =?utf-8?B?N084ZFpCSUdGSTVXZDVlY0VPeFVhbjlFTUkzd1p0SGZ3Y1dGTG1SVk4vSitv?= =?utf-8?B?WlFBZWJ0U1ZuV294cVpWWGxybldCNmJLbkhzTVpiUDBPNExDaU1jZ3Y1YStv?= =?utf-8?B?cGgvRXE5SEVTWE1Bc1pwd3pvZVZ6NTBJTWtUTy83eWRldWtWbjk4ODRNTWI5?= =?utf-8?B?WVkyRldWcUtYY1B0MzNTSjhZZkN4eUYvTG5WRXp0U1NFNks3SU16VWJqditW?= =?utf-8?B?dGdnVkV2dWdlb0gxY0VldVNLeDFGNG1sVXJOQXRMR095d25zSWt6NFZHOWRl?= =?utf-8?B?MThIcDNYbHZNd2JtNkgxYndXVGhNb3hOeEQvK3ZucWxLWWp1WHl4SmRYK1RF?= =?utf-8?B?b0pKL0VQdnBzM0xCV2lEbVcxNHpIbnoxcW1aL1FUZldJY2orZkVDMUIvdVVZ?= =?utf-8?B?NEwrVkxsV0d6Tllod3J6TnBicVAzYWdIYU5nd1pXK1IxdTZITXFwWllFeGlw?= =?utf-8?B?eTNId2NVQjlHWGxLc1JLSlBvVlBSdnpwY1hyME9DNzlwaWpHMjVzYmxLQnY5?= =?utf-8?B?M1B1OUFFNzRQdkFzcW9EblhkUVJ0cURYb1RmK2gwcWhOelhSaWw2cFRSWnFk?= =?utf-8?B?enpieFVIc1B1Q1BsVUZtbUwvZGs3S09pWS9sUFNaU1lFOU9paDc1SlVNVTZw?= =?utf-8?B?amowNkQxamQ2SjZmV2hoSThWOER0dGorU2lobDhOS0Y2aDBHdGJwOXkvVmNj?= =?utf-8?B?MnVmdHBjN3B3aG11Wk5mUE41QzhJVGdKUW52WkpHd3Q1dGoxTloyRmdoRjV1?= =?utf-8?B?UDRPL3FWcjlPV2pNcTQ1R2ZzN2xDeEd0Q3JPSWJGbE9WUnZKMUZqNk5VOEZw?= =?utf-8?B?ZnVDSEpaWFpSUFRSUllPZERDQVB3S1BhS3FIK2ZWOVR3WUNLTk42UlBRY2tM?= =?utf-8?B?d1lEaW1pS3BLZXNNeVZVa2ZxUGhROE96NHdPUjJXMHh3Zjkzd1RBeXkxR09q?= =?utf-8?B?MWJWMVluRnNkVmhUWUdISks3eDdSeXBHMDlObmU2aXVRbnZjT1Q1bHVGUGhW?= =?utf-8?Q?oLwomqfQPpvVd/kLZQ6XstfZ3?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a463dc9-5b0f-4a17-510f-08dd26dd1dcd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:28.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LYtznAeGYIu8MZpOGd3NkS0oHP9D5N8RErVMSD/mWqkv2HpiJzDvALxM8prkBUt+znJIsOotmJXLljeiwbrM3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard= /omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73= 778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device = *pdev) } =20 device_init_wakeup(dev, true); - error =3D dev_pm_set_wake_irq(dev, keypad_data->irq); + error =3D devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); =20 return 0; } =20 -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] =3D { { .compatible =3D "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); =20 static struct platform_driver omap4_keypad_driver =3D { .probe =3D omap4_keypad_probe, - .remove =3D omap4_keypad_remove, .driver =3D { .name =3D "omap4-keypad", .of_match_table =3D omap_keypad_dt_match, --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789F27082D; Sat, 28 Dec 2024 01:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348542; cv=fail; b=qPv9bYtx14q9G0t3PsCmegW5I3kqmaQVR37hvLoeQqgKLX7Lfbe5hU3b9PZjdWYS4DMLM12ui2UXljiE3we6JjrqUyfAirS5G2rlVYwALQPVD4a9Q+zLA5oAeHzAkSSOcm2dUPk7DQABSxbgJu+kZShMVwotAAFI7aouwXmer+s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348542; c=relaxed/simple; bh=zQeVfeCxLWPp1ta82McHGDfqjkgW42mBMCjsal6VJxQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WxofqxsYZgof3EFCj4UJVGHy+mSRhgPyQDcBLPNql0jESCe4Fc9Uhu4A3YyQUuQhcWo1mOaui92n7mgezFgkDXLJMmoZA5XlSeLAuhi0rklpzvoSNQ4PjUBwrMFjTFoeGZJtmxcYVypmHMkDtz3tLeKbXZVoLyfmY0wgETjkjVY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bdVTbLzx; arc=fail smtp.client-ip=40.107.22.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bdVTbLzx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=De03qc/7+W09q88nvZWjpdJ+r44syFhmY0TGXrDE9q8cLOOQ+MC2FTi/26TBOTg1z71q/Njjd2+YilGj2hVqA2yBruyaElB3FzznpfGnaJFCyehc9x0U5kkafytI4nMKaOdBBe3iuf2o0DBS0O0e3DDuSIKrL6PC1POWXdwPlz8yvMOasg1ES5hAuxZY1ER4iKQAzwGhflNJnP3qo7ZlZhxJAqBfT69E8uDmBUQ7OkMCx5BA9Z6i+akGtRpBr+BEb75qnSg967vVYBGvDiak7OnV4huxskJ12YkZCfTiAsLDTFP/cQ+mOU/JxPEn7N1laO3U59HZAE3rCv1cMPKHkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=FW5NwhB6l0ulZlgR8HG4Y0y6fxynFZ5VS3ZIxGwpH74L90gXYmN/Z0R9zJjABrQOvPeDSCsaFgG1jgM0xzSySFtFHhYpyWlbjktQtwERCr/aEMcWiWoau2YF7puLTfamwHlk8K6PQBxTy1bwYfJFbAlw6Si1pKdPNhoBnkPk7LGmEADNJj//fMsMdrJEw8PdAje9VqE/UsM4UDVDtunaYEHfrXyo3Y0DDRLfrMiUVHosTRWTJerLjfkfF5BX8nxpJZVbI5jC49AJdAYwtLRoEpFiFhtC5OneUhmhHyZG6/K2IZ8q9pjZ/hgpdcZarohsaWgvza8fS5IvFEvBrPtcoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=bdVTbLzxiZp2lRvyYH6Bc24luyGUH+RGc4fBdXYmTBIVFgOTXEViTJ4s/2MYXyVZF9izqgQge22bRocgyzocpeFBKin+IBVVMZ8zsQMn9CwojzYW8I5ieqpNQfHmOhcVeZnglGDVVllkty5SzZK23UEsnCZO0Ck0TX5BkNowSsfyT71QeIeZsVALm3I3fkUT2GEQOfb4dVCtObhysKjGVxBY+xu9NnrgHTyo+CczxQRzDddYsePxupFSjSK9gvqzEVngWyndAeDV7L1nk8wtoEpQnSEX3YtJJjXv4viJbdwfupfOJMULC6mPH45PnVWPKFCFkJwrj3sli68tjXp8fQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:34 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:33 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:40 +0800 Subject: [PATCH 04/12] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-4-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=g2vZhAdAlG59tJHA7zmPtBw4oLxwHW1tSbJmlo9rLyg=; b=n1Rdvh+byloMgU9fVOo/u/dO2fgSbylAiFhuEeGCWpv+c5cbO6HQBC8GN4OZ2AYv6PpvAFCpi 5ptQtE7Ox15CwPoCaVywbzaXII03UcP1k2p2mA5iZLfYxQWU34rIpK0 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: a8ff64c7-de9a-4bfb-c06e-08dd26dd20e6 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QUFLZ09Uc285ZlhQZXp0UkN5TVAvQWFnUTUyQS92aVhZakhoOU1RL1BJVFdw?= =?utf-8?B?Um1sRW03ZHQwN2pLVmVEVm9jQUtRQ1ZwQUU0amxJTWlQaXJjM2MwbTJnNHQ4?= =?utf-8?B?bzBsOWlRTTVLTlhUWkxiSFo3WUlMZyt5c0hobW9OQ3lHTTNaNVVTT0ZpUzAy?= =?utf-8?B?cHdGQUhZSGptbGl1akJPT0JrTTZReDZveXFNM0VhbWFKK2xuWSt1bmdXNDI5?= =?utf-8?B?SnFvemxCMGtuOC82dlRwMXZ4eCtpZEgrRlZHYk9VK3lYcEJObC9iWjcwRnZk?= =?utf-8?B?aE5MOGlCd01oMTVza3VWOXVSeUZYTStZUkpSY0VXYi93czF4Z01xQWMzRXlL?= =?utf-8?B?Q1BjcmdvalowRVcvUWZ6ZWovdC81R1k0N3ZDbnh2MzR3K21lMXQ0Tk9tUGI4?= =?utf-8?B?aVMwMGlGT2l6bFpQNmYxdFd2TmJUb285UnlWTGhWN3ZlcjlUQ3daRlZaWXM4?= =?utf-8?B?TkhoWE54aDN6akc3Ky9TSU56YUhXbms2WHdHSkR1NW9hRXZlMFh3YU56emF2?= =?utf-8?B?cEdRMjNvaWNtY1hYWEVhejN3STFFemtVVVNtVnEwSzRsdWxydnZJMVBENm9x?= =?utf-8?B?NTVLZGxrZDhEMFpjT1BSQm5sSkhQaTNadXptY2Vpb0J3THkrb3RKWVJ4S1hu?= =?utf-8?B?N1hjVlMxbmZmbVBvN0RaRUFmNGJKR1FndkNLeGsxNXV3NEMxdXRmU2xaemVL?= =?utf-8?B?Z0RCL3Q4dzdNajduMytLMDF5cm1VRFVRcXpXeGhwYjIrcENDNm9rVUgrZEdm?= =?utf-8?B?V3J4bm9OdlozN0JLK0d0cXlUMnJLSmFocCs0T2JnSml3SlBmbk03MXowelNa?= =?utf-8?B?MHBJUTF3bkNyeW9aL25RMkpUczVONVdGNUcyMXN3NmFsUUNBVGFhNnozWUpm?= =?utf-8?B?QVdhOTREK3hNbWx2YVc1bVQvS21iMkJWYzE3WjVTUTNnbFZGZTAyd1hiczVx?= =?utf-8?B?bzNTSGlIcXdTemN2bDJRNitNeHpEK0dWVVVNOWltWjBCNjBTaTJEYklvdWdj?= =?utf-8?B?bVBIYldUS0JES0tKcWtPL1U0MlFRelhLZ0RXWXloNFkxbDFiRXRQUExLeUNl?= =?utf-8?B?RmpLa0ROYnlFUFJ5cjE2N3dTNDFKOUJGckRXVnp2RDVQaEZZVmtIUHZ0M1lM?= =?utf-8?B?WmpWQ01NWFZtK2pqUE9YUnNZa2JVczQvL0NPMzg3R1ZOVjl5TzRNbE9jYWtO?= =?utf-8?B?NW1kMTNUVythYi9PUitxUXVBRTF3Q2Jyd0trUHhLWlJUdkJIS0tsR2ptUWlo?= =?utf-8?B?ejdjNTNPL1E2R0RMbGF4SEF0VHBUVFpWZEExcHluYkhEdDN4TE1PT1JvcXFD?= =?utf-8?B?a0JmN2RUZytlSHBsZ3BUMVI5QTEvZ0lqTEo0RHViZkp4SCtRS2lXenNQemdm?= =?utf-8?B?Sk1hZUoxZjZndFNsOUd6eUJxb3k3NzhQTFFUdkpVYndNU2xMTEMxd2dIYkxk?= =?utf-8?B?S2pReTZFQmZ3cEdGVjg0cVN3R0pwME9WUnNwZmg4V2xLYzBaeVl0V3VWOEhw?= =?utf-8?B?eG9XSVZxYnljY3c3N1ZGRzlqd1ljM2M4aUgyMTZzL2ZueHYzZlNYYmtVbnc4?= =?utf-8?B?Z0M5N294V1VVbU45MzhnUDNXbU1mb2pNcU8zWjJHcEhCLzNHNkFDL2gwRytZ?= =?utf-8?B?TUhqcjFBN1orMlc3aVpMOE91dStnWE1kbUlrVU5MdEwwQmpVNmZqbU56UkRP?= =?utf-8?B?KzU0S2lRTnNaaWxwakxJNDd2c3VubnliY2JqTWdzZjJkWnJXS0NFQ3VrUkt2?= =?utf-8?B?ZHNZN1owNVhiRzJBMGFSMWU2MzZvRXArRUV2RURiSW0wNEZ2MEhob3NVS2tH?= =?utf-8?B?TVNqWDRESEM4eDB0djVnR0dGOHIzM3h1T1ExUzZyYXlDMmEvaXd2cmNWTTBy?= =?utf-8?B?L0dRRlN0UWl1eURUZGlsZXJhZ2xWZmJMVnBCM3l6YjZmOVdHVUhDSFRNWVRB?= =?utf-8?Q?Qov3paE4C0lgy6xTFvfFARIg/e8Ng5Vf?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUJid2k3bmlzQ25mTmdIWEFid1hmck84ZlhEOUVLb0FETVZWZVJmOW02VEpG?= =?utf-8?B?cU1mQnlRSTJQM2tBV2EybTdEd2J2eHZ5NTJOL05Xd29NNEJpMFVTamI3WGZP?= =?utf-8?B?NDRIZ3lRd1Z5Y0ptQlJIUlZZaU9PencvU3RraG91ektvREp3ZEVHVHB3NHdS?= =?utf-8?B?UklMT3o2QW5INjVuL2FnWHRjZTVFZWhqNU5qSW03MVg1RDUxNHdqenAvVW5v?= =?utf-8?B?Vy9aeGc3Mk5hMmJiMFhweVNYTzcvUHpxMHVSSjNaUzBZQlJqazhYdFMycEJZ?= =?utf-8?B?VlhyZ2M5OHdTa05FYjlJVjJJMTQrdVJNOHFVTEJPNFUvekl0dlN3dXV3ZUI2?= =?utf-8?B?bXgvNzMwSTZTTGFJcEpkUmV3ZW52UDlFSE9YcW9lNUc4eEFvcDVCa25WS1BF?= =?utf-8?B?V29BU0YvbFF6SE1GRWxNcTJvTE1tR0UxZjFGOHl1RTNCMXVkdlRSZy9mYmpu?= =?utf-8?B?azdvNTBTeE9uQktMVmxiZVVFcHFJOFFOUkwwN0kyRVVzQkh1b3JrTE9rYVFL?= =?utf-8?B?K2tlYTduVkh6WFdNTGpQelM1TGFZa2ZVR1RXNXZlY2k1dDBWQWlkVEIzYW90?= =?utf-8?B?ZEFTajRyd2JacXprUVNYaWdWa0lNUjZUb0NSMHN5ZEo1UWh1YVA3N3M0eXN3?= =?utf-8?B?NWsyODV6eHBRWUJRWUdZQVcwRC8xaTNWMmtGaEhXRjlNSlNsenVEZXVMNGpM?= =?utf-8?B?Z21xMWM1cUxHL01RRHlGRndaL1hLc0hzWHozc1R6bHM1R0FIeUJybzZaUGhh?= =?utf-8?B?MUlsanZzZ053Zy9wdnlvYUJBcFhyb1J1Y2t5MkxFb3hSZ3l3V3ozeEh1V2ZQ?= =?utf-8?B?VHo0eFdBb3pCQ1h2RFJvL1dKVWV6eFhDb0E2MWNxT3BQMTFNUzVoUmRRM21p?= =?utf-8?B?S3FETHlVR01TZHBsZlR0cnl4T1RxYjl6UXE0SUxxRXc0dFF0ZnpJT2swUXJw?= =?utf-8?B?aVowNUc0ZTNLOGFaUE1PM0VNTlZXWTZReXpybnVxaGlmYXVQMURGSkdnb0Vp?= =?utf-8?B?Y2pGOWx6cE1yZ0kvMTRLM2xJeE1JcXZrMklaWjI4NDlYZitrTnpmbWZaTGVn?= =?utf-8?B?OVNlV1gzM0p2OHd6cWIzOU0xblpnVnE3Z1dlNzRzUlQrb1FYM0U3aUxjaUJs?= =?utf-8?B?cGQvWGZlNlYrY1ptSmErRVNPbEI2QUJmMUxvVVFpK3NxLzdXSG1YeEpURjRO?= =?utf-8?B?WVJITFBtclJPelNWUXFTbGxJczFtYThWS1JNNG1qYzFPRTVJbUZNMnVSVHdj?= =?utf-8?B?dWUwSE5ReVRlNHIzbUs0ZS9ISzFhNWJ1NGM4OHlxSUZoMGxQQjY4VzJ2Sk45?= =?utf-8?B?OEZMbWFydGRNalZudWtITmlFb1c2c3kyTHZGczdCenhOSWlGZDRwODgwck00?= =?utf-8?B?YVo1dHN6VW5kN3ZONzByQ2F5MytSV1lYYVFXb051R2FBcVlncS9ZUU9EZXVY?= =?utf-8?B?K2J2RWM4WkZwZWUrWUQ4VWdxSnRrWWJCMml0eWVueWd0aXAvVDhydzVPeUZi?= =?utf-8?B?Z1ZjZzFKVGRHZHRNc1BlVTRWYXFDekVmWDhEQzkxTCt2VHBVYWtXOGVRRmh6?= =?utf-8?B?UW54VHZXZkxXQ2F6TXNsZmhvNHRPTU1iVXJaY2ZETXhiNGY0VmlncDhnMm4y?= =?utf-8?B?T3FWMThwS01CU3RIN3J1YkU4KzUydHcwbkpBYzZwU1RTejZRbk5NWG5hQ284?= =?utf-8?B?YmRtemgyUDhpVFJJcnlQcmhaQU5za2wzbnJsRWRIblQ0NUJoUnlqQ0tJQ2x2?= =?utf-8?B?eEtsUDgrdEVnZnF1a0tqYjVUclFYZzFLN1Zndy9ieFpqb2Fla3k5dG9wUTJh?= =?utf-8?B?dC9QWHU2aHFhK1JpVGo4eSt0WVAvSmVoQmdTbUtZdzlpVmJ3WkNybzd2bVZJ?= =?utf-8?B?UlpVdXM1bSs4Z01oMjZxNDg2Vm9HcysvQXFOK0VqVGpKVTk0bGlKL0VZZWhy?= =?utf-8?B?ZndrNFFCSHQyUWRWVnJ6cmtCTlY2RC94aVNjVERwYWk3VXRseWVLdVBaSUpC?= =?utf-8?B?N1FyYVBUWjY4Nm05UlVXNk9zcDRPVTJKZGEwdm5nV1dNajlHSkxMMVZNVUdK?= =?utf-8?B?TkJ4OVhIeXR4aXdacmVlTS9teG90WDhZWmp2TlRFWUxKYkhBNmpkczJuYW96?= =?utf-8?Q?j5m0zUdQ93hsTeq1NLF9BgLhT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8ff64c7-de9a-4bfb-c06e-08dd26dd20e6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:33.9459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hD2oFTTUJKXRjZyLT2oh+iao0KNwr0nZ8a2u/HrrvcMaWm+QIY09MWs2jLoUPjFMjxc6FzhvpT3XbtSHfrakHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp= -bbnsm-pwrkey.c index 7ba8d166d68c18b396e616f6f9074ae98c4629b7..5faad2c98af35c52dcacbf25728= dbaf2cbb3c625 100644 --- a/drivers/input/misc/nxp-bbnsm-pwrkey.c +++ b/drivers/input/misc/nxp-bbnsm-pwrkey.c @@ -179,20 +179,17 @@ static int bbnsm_pwrkey_probe(struct platform_device = *pdev) return error; } =20 - device_init_wakeup(&pdev->dev, true); - error =3D dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + error =3D devm_device_init_wakeup(&pdev->dev); + if (error) + return error; + + error =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); if (error) dev_warn(&pdev->dev, "irq wake enable failed.\n"); =20 return 0; } =20 -static void bbnsm_pwrkey_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static int __maybe_unused bbnsm_pwrkey_suspend(struct device *dev) { struct platform_device *pdev =3D to_platform_device(dev); @@ -229,8 +226,6 @@ static struct platform_driver bbnsm_pwrkey_driver =3D { .of_match_table =3D bbnsm_pwrkey_ids, }, .probe =3D bbnsm_pwrkey_probe, - .remove =3D bbnsm_pwrkey_remove, - }; module_platform_driver(bbnsm_pwrkey_driver); =20 --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2081.outbound.protection.outlook.com [40.107.241.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1983C35956; Sat, 28 Dec 2024 01:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348548; cv=fail; b=Q+B6q0F3sPxuWUGna5yA8UGcz8JILMHePJ17aAj8gma8WuZH1HQixRie58wiGR7jrvx/cbFV/tHArjdHmpCcdUa+sYFvdfoBPO7cqiKFoxsHb5CYqfzYOS6VRoIRRBPpMxXhjdejA73XSvTAq4njo2Q7pzlhq2NvIlGeer8YoeY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348548; c=relaxed/simple; bh=yGvaO4CE8KR0YjpwnelDEdIH1YkR2FTo1uOdpptvhd8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g6+Ea6s4UiRoH/ehMhV6cubgcXQCh+oL0zOuTGobSiPaedv2zaKw0RenL/9HgbBfwCjz7rRb2BQUAs++7I96VKHVjW90wkQ/bQGu0HUMz8CUbk4oiRwnJmajPkOkqB91Kr8aqrwss8VUbft3BJlOcBBxwIQTGy5rWCWJMLA6LnE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=cA98UbwE; arc=fail smtp.client-ip=40.107.241.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="cA98UbwE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w/G8BdliSEHx0Q3RhzvHHb4gZDm7nd8U9oyXzHd55Bb4fFKPUAXiMIEYSbuoOtbEdxG0JouEjRZwG3JSzXWYa2OV8J7Gk7+ZQEc5QSYGTDhlk/iMuumAOLuZKALhA0NY7/vvhvFG9E6J3RvOK4CuJX3ub30pcS5j/pJ+/Y64//MDlyaIPcQBdnYWvKbUKXgnYTanlVTNlau9EHKhC7TeeMe22obWcNCu3BzioLHeUiM/sp/w63EIU2byRUTDWY+fJKY/LlUU+wApDaFlHP+nNCJEog4poH3eW2luSbXdaP6qc6Vugkx1/OxtRQRh7JKKZ0RH0vyoKxBye26eqhkfZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=hk8K3Ny6SJcd0oB5CBOmWwUHHYSFPOGMqZiLcSj4I6HIJ+mcVCcEqb2DNKWFrSxsg7MMPlW61S33HVlo8RrKXGhCO9GwYVzE0A8XaLTvuQ+m8ZqiGaIGQ/yauGtSQnN/DAMwxLNLBBbINirOoVBiTvHRX76wXszoypYB9oXLr8Qoe+IkInF7d++7eIU+FWvjTGqnCZ/PlMwd9/Ictqn30TqOvEahUoVBpz+fE2FRcN6Xiyfb/LbtdEagShvRYexD4Fz290E6bv++FkNSGfaA5yzw6nBOxYf8o2junUS+Zuv1dzaDMA3UGJvOzUekw6rxYmqWFeYH+AM4tNyv9GqWjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=cA98UbwEXYy8AaaZCydgYBXUee5xD9rfXQc112Cwt1t46qevMbnGdlyXYxRiyqTMQbRks6yg33cY6oRN6OZESXv4Z+UGTxs66IztXA5iJyQcha86e84XoulwQtFDFqX9GKkq/7PtytAXgXZrhq64S9OFDvN/pYkiXy/+UFZxRnn4iYFMtV30o/1nqulxuWT+7Qeh1jm11T5WQEkaAAEbCtpmWu5IoJ2LQ5YtVblKRfhUc2WZVeYf+1uHerV0p6xCz1jqP1kcSNKhMaQfuHAdumfibwaUDVvTFp91/OEDHehZVmG52FqQ2QrVjS3KMz11Yio0UUsa/IYPVgyu5Isx5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:39 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:39 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:41 +0800 Subject: [PATCH 05/12] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-5-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=3411; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1lZmp/EoQtZDgK9cRNpEHi0IbcGjqZ+/tYP3nl5MGB4=; b=UXvCXFxS0bdNfnP4i9+l23yI6Hpv7q0/4Axzg63Hm6BI7CWYSX2VuRHQZESo9FnGhA2gXLlZK 2S8tSKbe6vRDK3wAMDYcuopjwFCx/eXV4VwLcGndSqEbmeNg5AVJ4EE X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 441ceda9-a42a-4473-1f83-08dd26dd2404 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QWhXcWdxdzZWOUVhdjgxOTB0SFlBaHFKVklxVEw0amhEVE01Nzc4N2V6alh5?= =?utf-8?B?R2N6VnFnaFFtbERwTDhtamJTOS9tN0lrYU9LSHJleDVJM3AxbitlWVdlSCtX?= =?utf-8?B?V2VnQlE4OWF1RE93U0ZOTms4ZTlzT213RFY4enNrVGZ6NWNDeFRYa1hTNzRG?= =?utf-8?B?TkR6M0FGamVyK0tpUUVTTjk5bHRsMVZFMzhvM0pZQWJQTFZGeUdOSGhqcUJa?= =?utf-8?B?TWpLeFAweW5kWk1BQm9mbUg4M1hGczNLYms0R2YwNXFscElXZWhRWURudEVZ?= =?utf-8?B?eDFjMGw5TTlYVlFJbEh5enVNRWRxRHp0N3d1Y3AzSHJrNG9rN1BHVmNUWlFu?= =?utf-8?B?WHM0cjMzems5b3ZHbldLWWFHN09raGhZM1pUVzZnTGtFR200T21WZ0lPL2J5?= =?utf-8?B?eHZJUWdvbFNrRWF5eXV2RzlnVkxyWUd6VjJlT0lHNmkraEQ3dmc4UlR2RkVM?= =?utf-8?B?em5wTGdZQkFKNm9iMU53MFFEbVkzS1ZEMEJCN2daNkF2WlI2bWd0YmlQdVIx?= =?utf-8?B?OEpyTkJNVC9VQ2lhUFlXSU4yWlBjcE1xNDFNSXRjUUY1SGNpd0IzYmFYOUZw?= =?utf-8?B?SmM1N2dCMng1QmNDMnpibHZrV2hYc3FuSVhiM3EyU0ErbFAvcjBCcGVEUkxF?= =?utf-8?B?WUlsYXRrU3VkNGlKMzJkTEI0UFUyejJQRnFjVi80VlJvOVBzV0dueExjNnR1?= =?utf-8?B?bURXbGVFUjNHU2dXYThXWGhqWWM1Q3c0cUdGcWkzN1JkWTBmZUFJVTNrZVVh?= =?utf-8?B?c05ZbDhCZDZoaU4zQzVXcVVLSlFNOU9jSjR3eHBoV0JodnpRamZ5UHJRNWJs?= =?utf-8?B?a3doMThaZmxHUThPdGxicWFDc1hscW0zT3YrMi9QU29WN2lSMklPS0wwbC9D?= =?utf-8?B?MU9EZE1ZUk5nN0N2Mjd6ZkdkdTFseXVtS05ETVcrK1B1NFdXa09YcjZiRWtl?= =?utf-8?B?V2VIcGFndy9UYVI0QUQzSklMT2UyOUVXN1lUUjZzaEtvdEcvUWFhSTNERkFS?= =?utf-8?B?MlNjbXE0V2ZVc043Zkx6TnExWXpTMEtKR2t6L0t1RHFpY1NGSm5PV1dlRTNR?= =?utf-8?B?MFZiaXdNZnMzQ0g5dUJRQ0hIanMxR01jUDVCL2VGZ3VwYTgzRzJxZzZHZEZO?= =?utf-8?B?cGRaY0VkTHZiM2JkeUxudXgxN002RTRhdldtcTMwcEhNcHJybFFBOCt1aTNJ?= =?utf-8?B?M0NVdk5IVFZxbEkvVE1UV2pHOXpPN3FhMTdybzc4NzFQUGN2MDFYdzlXUlgv?= =?utf-8?B?aXpyVzRlU0ErTWpKSGhaeXNXMzlpZjZvN3NCZnhIZ1hudjl3TEp0MnhmWTFT?= =?utf-8?B?U20xejRnbVZzaG5hRkIyQVZLYS8xRW5uakM3aGw0RTNCeVZMYStwZCsrSDhu?= =?utf-8?B?VFhxYnJBendsaHFOVUQ3L1JMbkRuNHoxRlNvWWJXT2lOQjF5dy9JN1l5eDA2?= =?utf-8?B?ZE5TUzBjQStmWTBqR0NVSnBZZHNpMEs3OWpZY3U4TnB2L0RkVDZEbzhJWUJj?= =?utf-8?B?VXJoOFNJWEcxM1luQzVCeVlGc3FYSVRKN0hyK1A5bENCVU1CcHRkdkhXbnlN?= =?utf-8?B?VlJkQ1dRN0l6SGJMMUJrWGlRaW0zcFk4eDVoeDArOG9nQlFhc0liV3pRVE5u?= =?utf-8?B?ZGFNc0VDeEpuUWNCZFNkdm05ZERRWFFlYXE0NnREWEkzUk5aNkgzRWM0RkJX?= =?utf-8?B?UDlTZTV3YW81MFRlalFiaGRSdWlNc2ZpZlB2VUQvTW9vOWhqeU42STBrZVpS?= =?utf-8?B?WHNVVFg1SmNvZEpqdnU3dk9EUWF2bE4yUWllem1SS0NBZDEzc2VaNmNUUktH?= =?utf-8?B?STEzYi9TVGJmMU5lZ2h3c3pzckhoc3BOaTNpcGM4emNXL1pZUXduNlJmTDJJ?= =?utf-8?B?WE1YMmRCYXQvUFZkWUxRL2FtM2Q2OFI1bXU5aW42RzdXVkdoTWFkY212T1li?= =?utf-8?B?ZGdxUjh4TktCQ2E4TDBTZkNTeDlmZGtTZmhxbE80b3B2d1ljVW4zc1h0ZDdx?= =?utf-8?B?WThqNWpzOHZRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFJzWktralFHUDYxNWRDcGYrdkMxTkh0Qm5DeVdzSXRMcnhsSk9KU29EdG9n?= =?utf-8?B?MHQ0QVpjc0FLSmZhdytSdUIrQm1DMjhSZ0hSN2VtT3NoaUFhVDA1MU9wdUlv?= =?utf-8?B?bnczZTM1VDZ4K0hjTHR4UmE3S1lUNXg5YkVTNzNlOFdsMkF2RGRmVXlmajlp?= =?utf-8?B?c1JCTjRjWG1mdysvLzNma255TkJDMUh3aWtiSTU2Rjc4WUo5M0h5UHN2Q3ds?= =?utf-8?B?RmR3SDgwcTRwbUd6NkJDa1YvaGI1VzRxNzdkM2U5dERhZkZ3YWdTYkU4bnFs?= =?utf-8?B?N2FxbWpyS3Z5T1I3MUl5WnpobGc2MlNzVjNkbU1xeUxXOHlXeS96UTVsckNN?= =?utf-8?B?ZThaejQvMlZpMzQ3YXMvLy9kOGFsRlhieGZhV3o2bFlDU2pHOG1FQmhTeURi?= =?utf-8?B?bk5hekpDRWlQL1lCRlZ3d3RVaFhHUk5JdXNseUdlMUltZndJNzVESkNhQ3A4?= =?utf-8?B?Z2ovQ1gweXR5U1BPcjVKcGpVTkpoUkY2RGE1NmszUldVM1ZLc25EdDRyL2pK?= =?utf-8?B?cTRxK25aQ3F2SU1zM29RWUkzWlFsNU50Q2RBU3JWVDYxNUphMkNJeVh1cjBh?= =?utf-8?B?RWFBMDBub1V6dUhyLzZrYmdqNEZQOXZqU1JQSncrZHVka1FJM0J4SDJ1TUd4?= =?utf-8?B?a3MxeGVFM25qMUYvcUd1MC9HbnBwaC91aHB3MjJsRHpZTHpjUzFzTHJQTDQv?= =?utf-8?B?YkZvUXdRN0F2aUlad0RUQ3c1c3dHS2dUcS9YL0Y3ODhMZ2RsOEgzdm9nTWFQ?= =?utf-8?B?VDA5Vm1VZ1V5WngvWHc0RHlXWjJoNkxmckNENUV0blJqZ1lOb0lFOENVNWJN?= =?utf-8?B?aXZZbFgydnRFc0xnL21xVVAvWjN3UWVSVHVLN0d3bGtwa1FVLzZXTHhrUVVs?= =?utf-8?B?ZEk2OVBMMll0OVZSQTdpdnI1T2JEOXB6ZzFVSzFLUEkzNk1BOUU0ZUQ4QklM?= =?utf-8?B?N2x2R2E5NXJiVDdVSVE3aUhtM21ydjFmQlI2NVlodnQvOUk3aEtmN3h0R1pJ?= =?utf-8?B?STFUNmZzV1ZjM0NnZ1RWMVR2Ym5mNlAweFA5bnNlZEZXTW5nK2NUNUxhajlL?= =?utf-8?B?eWl0UllwcGV0N0xVZzZacDlycXZzUGozbmpsc1pVTHE4N1lVZzYxbnYvTmNR?= =?utf-8?B?c0Z1bEJwcUt5c2VzMlFCWHRiRk1kUlZWWnJVRFY2aEtCYXphYjRKVlVtOTJy?= =?utf-8?B?Y2FoaTB4ZzVNZmo3MjhDR20ydG9pZ2Iza3JOcmg1V2o5U0dQYzdLUkYvU05C?= =?utf-8?B?OXZCbUJTQURsSUJGeDhVQ1lyWS8wblFCSkxmbitrVTYyWFpIUnhackxvazNt?= =?utf-8?B?MzVGNCtSRVJPWnl0MkxmVUNyVFlJUWNpTDVXMjdBQXEzY0lnbXIyeElXTjFX?= =?utf-8?B?M2FPNCtKVkdjdi9Ka0d1bE1NVmJmYm1CVE5EOU82YTZTR1RNcXZXRitTZno5?= =?utf-8?B?dmQrWEhMY2xGNTE1V2w1VGhSUnd5SFkxUDNhVyt6WUN2U21kVjFLYTRiZlAy?= =?utf-8?B?aDJmMnBpdlFSTjdnZS9zSU9KWVA1NXVhWEwyWUlkM2dyeWNhZVFpZXE5L2tu?= =?utf-8?B?SGx0MmZHakJmbGEzSFh4TmxDdjI4bnNldUkvQjdXWXFLWWV0V002RklOVVZD?= =?utf-8?B?d2VMeEUwY1hMUnhHb1hVbXRDajFFdXQzejhpbzBzTDY3aTRocmhZN1pvdXhl?= =?utf-8?B?TFY2RmxYSmRIL3VNdWVzS2NCb1dTYmJ2ME5rTWh6WXVYcVQzNi9qN2QwdzlS?= =?utf-8?B?SndldVFVMTd0WW8yMGU4MldpQ2thQXc2Wk45ZFlnZG5iNm93dGFTcG1RSWpp?= =?utf-8?B?SjQ0T0xUQWcxMVIyMnN6NDh3ektjeWdVcmtTYzlueGYrdEdneVdNRkhNYjZT?= =?utf-8?B?M09aczhCU1RWRUxGeUg3cDFYeitLUzhoeWNSK3lXeWs2cDFZSmI3eFpLOEVG?= =?utf-8?B?enJiZ1VnZjc3Yk5oOEpad2RCWjArT1ptOHFQY2N5UDlEcXk0alRpUC9LWEl5?= =?utf-8?B?aUxKTldub2dQa0xUWEFMWm55K3Q4cURPSGNVZnAvOCszWmVBSE9UcmZ5MHJk?= =?utf-8?B?TDREemMrTjhSUWIzMHEwcEpLQy82THpMdDVZZ1BnREU0c0ZhU3QzRnpNbXYz?= =?utf-8?Q?IMMs8AVNBPtcmwXquFGUJw9HN?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 441ceda9-a42a-4473-1f83-08dd26dd2404 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:39.1267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PyPBH4LLq7gK/75BIZcgsVFHklg6gECQ4xtlci2JbjNFipDttoEZuJ9Z+RuUABf1SdXC2y/91QcgaaSnArz1Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_input_allocate_device/devm_kzalloc/devm_request_irq to simplify code Signed-off-by: Peng Fan --- drivers/input/touchscreen/ti_am335x_tsc.c | 43 ++++++++++-----------------= ---- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touc= hscreen/ti_am335x_tsc.c index 93d659ff90aa94ecbd7000fe05e0eef8ab3546ba..aef38b2e4e464e3b76395de5991= a0f41b4f852f4 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -418,12 +418,11 @@ static int titsc_probe(struct platform_device *pdev) int err; =20 /* Allocate memory for device */ - ts_dev =3D kzalloc(sizeof(*ts_dev), GFP_KERNEL); - input_dev =3D input_allocate_device(); + ts_dev =3D devm_kzalloc(&pdev->dev, sizeof(*ts_dev), GFP_KERNEL); + input_dev =3D devm_input_allocate_device(&pdev->dev); if (!ts_dev || !input_dev) { dev_err(&pdev->dev, "failed to allocate memory.\n"); - err =3D -ENOMEM; - goto err_free_mem; + return -ENOMEM; } =20 tscadc_dev->tsc =3D ts_dev; @@ -435,18 +434,21 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_parse_dt(pdev, ts_dev); if (err) { dev_err(&pdev->dev, "Could not find valid DT data.\n"); - goto err_free_mem; + return err; } =20 - err =3D request_irq(ts_dev->irq, titsc_irq, - IRQF_SHARED, pdev->dev.driver->name, ts_dev); + err =3D devm_request_irq(&pdev->dev, ts_dev->irq, titsc_irq, IRQF_SHARED, + pdev->dev.driver->name, ts_dev); if (err) { dev_err(&pdev->dev, "failed to allocate irq.\n"); - goto err_free_mem; + return err; } =20 - device_init_wakeup(&pdev->dev, true); - err =3D dev_pm_set_wake_irq(&pdev->dev, ts_dev->irq); + err =3D devm_device_init_wakeup(&pdev->dev); + if (err) + dev_err(&pdev->dev, "device init wakeup failed.\n"); + + err =3D devm_pm_set_wake_irq(&pdev->dev, ts_dev->irq); if (err) dev_err(&pdev->dev, "irq wake enable failed.\n"); =20 @@ -456,7 +458,7 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_config_wires(ts_dev); if (err) { dev_err(&pdev->dev, "wrong i/p wire configuration\n"); - goto err_free_irq; + return err; } titsc_step_config(ts_dev); titsc_writel(ts_dev, REG_FIFO0THR, @@ -475,19 +477,10 @@ static int titsc_probe(struct platform_device *pdev) /* register to the input system */ err =3D input_register_device(input_dev); if (err) - goto err_free_irq; + return err; =20 platform_set_drvdata(pdev, ts_dev); return 0; - -err_free_irq: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); -err_free_mem: - input_free_device(input_dev); - kfree(ts_dev); - return err; } =20 static void titsc_remove(struct platform_device *pdev) @@ -495,18 +488,10 @@ static void titsc_remove(struct platform_device *pdev) struct titsc *ts_dev =3D platform_get_drvdata(pdev); u32 steps; =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); - /* total steps followed by the enable mask */ steps =3D 2 * ts_dev->coordinate_readouts + 2; steps =3D (1 << steps) - 1; am335x_tsc_se_clr(ts_dev->mfd_tscadc, steps); - - input_unregister_device(ts_dev->input); - - kfree(ts_dev); } =20 static int titsc_suspend(struct device *dev) --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F338578F54; Sat, 28 Dec 2024 01:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348553; cv=fail; b=TbH/d4phBFSxQaGbJVWavxoeKRzlLaaDc1rSdVvT8aGK6v9C8wbP+o7lmwCFz4riLEO+nMR33RL40DRTJ+Kk9MxKF0GytWr2s3L70lU5mXse4TL1akH1KkrZ0qQhcRbPUgXVRRg47qWcn+2ctuXiVU4Ad7dVLIBQXmOzz7tIhx8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348553; c=relaxed/simple; bh=JiSAV7Q4NNZurUbBcswCV+h/Lz5/1lhowxKOZ/KNAmw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FnHOMEVD4smTTu2Ol8haIvw1TLKOreGa2WQ2XHND3UeXizrKvkqQDZOSNqSjBYndGKGkjQIqlUbEkKQbkGtYSakQmYc+Ii2n+iCgrbRZRiA0iXkOea5ThgiwE+VNaA+oPHdPjXfhBnuZiup4mS4MpjfnstcrGRYrJNqCKeQqyCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=fEXGWJJn; arc=fail smtp.client-ip=40.107.22.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="fEXGWJJn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=olPMx0tE6Ed7jYvTX0V9egv8YIGEugwqDV0iITMiFZezT1oYT7/8Zz9jvFnsKfpsIRpZkyuO5miIklunKno1OLDxzzjzZOh4izeWWdt+VX3j2+MVWjjoGjAoKoHMmatYQKZ2R9ZldqBUEUHpm4Dd//NfqPzxEDcGscrocV12fQ6xNrLUETFM+NorUMIDPRNFPuTSempe/5O83GLSZVr29MZchLGstIjW2TzW4eFF6LrRdrnbZzQw+3lsI5gvS4+NYOfd2Wbqp9mXjV/gvNS9dUX1NyfEThs0BHhTIskq2O4v04Q4HlihmMBSqRng5ERqIKX9vVz8lcRq7Hfoo0sciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvRxcJQkTcUxL+UY0CT1LkbMh/5QCJDI8WvxLfFze6k=; b=NdZO4KK6Cnnw4xzoOm5Q6YfK8kZvbawsHzox7CCkum8NdHeT5jCpWpl/7NKdb+jsIivo9XdnDfeUaPW17O4TvNzHkUzVBVGkyKwpr64uMtTlQtmioB14+oS+3TuboxVhzDAAu1kiL/b5z1Xhj0+MnTvQPQjRJ3EUKgTxDfrdYnR8TMl6X6s1CEsMVmGvM2WLX8uq3Gl1W+pGG7bH7FC0Gm0byZhkhLa/NbP8itsVQCuMWsls5vvVdN1nURqvdUpbhCtE8XY6iB9/XHn/MzrDW1yTSrgycb8MkblB7tz6CJ6GsjqI6jjh6XNvYTG/d8mfN4MaR15W2ZUJxYM3qPoZEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvRxcJQkTcUxL+UY0CT1LkbMh/5QCJDI8WvxLfFze6k=; b=fEXGWJJn5P4XNa0sBDtpmP4Mai2h0uOC9b66ZC+Q1ZeRfeaoDlkDtiSVfIVM8mypCgYZxFYnjrDE3JHAfzevvUtMwxGWia5baxtDcRiQJBGPv1YEb2FQaBDEFrY3uoolISyGPba2FYhDFwGmYRyDq/IsnOptfN/MSsC0hD3MKteJm7whbZJwpWo/1SC2lduAFN6Nzwn0kIdZkqXU9KYRmLpCVnNlfoneMIcwST8iRRcb3jNfNZBaDrgCC1gNikHMcmGPqGUKN+NkArdXPK2UT8rGBZIPPlponZXr7V0Qz8OKvQxvGlh9NuqhylK7Tgvn11bpbcWnIWUp68rd5BK1Eg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:44 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:44 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:42 +0800 Subject: [PATCH 06/12] rtc: stm32: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-6-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1529; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=3L5kSry1bFWI+vzXqFXX2mukiWSnq2LH9PLt8NvYjoY=; b=B3T68jTJq1CEoyhrigYxE+0meJO14wNaqx5QKL+LOdMajmlDmTiJD1lez46bwXprMXVKEvpGi mJWb21WGEHODrDQuLK0flOSEZPL8Qlp3R2EjTV1CpPGtdR9Qqxe+1vD X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: c3ef80ce-50f7-4fb6-f7e3-08dd26dd271a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UDlYWHlRbjA4cDVhbkpBUk5DQkdJVlJJMm9JV0xqNWNxYkorc3R6MUJ2akYw?= =?utf-8?B?ZmJ4NlRJUjBrL2dCUTBWRzFXL3l2UXp3dDJPMk92VDBTcXB3eFFpaE1nK1Uy?= =?utf-8?B?a1hNL01SdkdtUjZGRkNnNGRDQnVVazUrL2E5UGs2dHhUYjdRVUhPbkkvck9R?= =?utf-8?B?ajNPdHJsVENuUWtwSWtrTkcvaTF4L2kyL1VrcWhYVnpYZzJwQW9VdVBYOHZ3?= =?utf-8?B?ZjgwM1dDbEV1RTdOSGlvVEtwVFV4d2pGcVIwQmJGeGRNcW0wTTVONlU0M2hF?= =?utf-8?B?djR6YTBxQjRRMEwwSXNkdjNORXdLaEVVazBFbkFrb1ExczlFQkxjSkcySXRP?= =?utf-8?B?OEZjYVhqL0xUZlpUVHFneGwxVWxLMVUzNDZjWm9LZE1rQnJFalNSUjRDWnVu?= =?utf-8?B?ZE1jT1hSeWM4c0tuM1VPN0luNFFqYTJ6UTdwZ3hibGZjWTFSY1BvbEljZFJ3?= =?utf-8?B?V3MvMVpGRklsYkFxUmJEdzJzRXNaSk1rMlpZSDNPbFFsVTZNSThDeE5NcnVY?= =?utf-8?B?TnZueFoyQlo2L1loU3Vzall0Z0VqVVBBQkFhMHYvVlpmMXlHVXdnTVBMbDly?= =?utf-8?B?OFRkd1l6YkZKRTlxL2U5OWdsaFpGMS9BVnlYblpOOTJKc3lhZDFZWG5RLzgz?= =?utf-8?B?NDFIaHJGdXEvL2t0RktDbWFaMVM2QURNVWpnK1JQRUQyZk1hNmIxNGxBakd0?= =?utf-8?B?N3Jwdjd4Y1FNTzIvTTduQmhFYThjS0w0djBEUGdmTDNhUFg0cDRudmJFTHZ4?= =?utf-8?B?eXpqQ05LcktaTkVUS3I5b2lLSldtZXRGNVVqWndzTy9aOXFpU1NMeVdhbWRh?= =?utf-8?B?K3RRNGduZDA3UFk1Zy9nQUdLa1BWdy9QRERGMXFpTzQ1MWFUTlZXOUs1azh0?= =?utf-8?B?TW5YaGRRL3Q1UVQzNGgrMVI5emptbW9vR0YyMmYrdkJNWGcvcHVqWEloMjVp?= =?utf-8?B?RklaRHNGSTRTeFcvMUhHVlh5YkJzaG9OaDZvZU05b3lNOUUyR1ViYmw5WEsv?= =?utf-8?B?Q1I0OUEyMk9LZU9VOXV2eFJWWFJOalExdG1RMGxjeVczOGVRQk5aOGYzbVcr?= =?utf-8?B?dnY3cS84aHZ6WHZrd3FMZnBYajREenhZSjh4ZWx4Y3l5a2ZNQ1ZmeEsxKzVL?= =?utf-8?B?VjlzQ25iRzNmVDBXcW1QWDZISkgvSFRBVEdwcXd3bFdpcWFvNXBqU2NYRmpY?= =?utf-8?B?ZjJIeWhBMDhUdDFoTWl4Uk9LM1AxRitBTzh0WTdPNFNqelRyL05JeGdYbE1h?= =?utf-8?B?amh0bXJxYVFJZ1VBUkROSVY3UVhacWNIcUdxT3pIY1ZsODR6RWdaWVdKb0hX?= =?utf-8?B?b3gzTVZxU1VzQVpUQmc4YWp2RTAwYVJFcjdQRG1Qd3NWUzh0OGFqMnphL2lJ?= =?utf-8?B?VDhiRmUwdkJCNC8zZHFkOEJuVXpwTjdldjdFY3NMbnFENVk3MjdmT2FHZ0NG?= =?utf-8?B?dEFQblRPcWJ0T203MmF3Z2FhK01hQURMbWlFYXFES0g5L3NVZVB4ZHlZajd6?= =?utf-8?B?NW1NeDhkLzI5dlY0MjVYamZzYlMxMWNRQjdSTUpRMTFEbVBhaWRsZmlmWWxG?= =?utf-8?B?eWlpQjZrNDNQbmVsMlRzbXNEK29LczZ1Q25NT3Rpb3huNGZGdjB0T09rQTlz?= =?utf-8?B?bEd5VkNZaC9yMkFJeDE1YUZ0MURQanhQeEpiUnpFUW5qRUM2NzM3cVBtM2or?= =?utf-8?B?OCsxUGUrN2paeUgvaW8xRlBMeG5IRkJVVWhobVN1Vi9HVEY2bTBnL2NkMzhV?= =?utf-8?B?WlhyRVExS0p4WmVhR041ekxZWUd4anQ0RE1UakczZERtcVZJZGxpY1RvZkY5?= =?utf-8?B?dXJ4MkV6ZUk1bVVmWG1CRlZJL0tUYkFpV3B0amNUV3lTRDhEdW9GQXRVdHlL?= =?utf-8?B?TnhxM0NQZzJYL0hTelI3NlptMWJ2TFBpYkZ0RDduVkRldGtDL0lIY09OTDRk?= =?utf-8?B?Vmt5QS91dFZZdU1uK2FidUt2VW5aU3NCZUNFc1NyZGwxK29PZnFTRVJlVDJ0?= =?utf-8?B?KzNRSXpEeThRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXo1QzJDcEhoMm1ZdjRvalcrd3plT1grbXZDODdVbklBdTFhc0dCNTllWFpq?= =?utf-8?B?aEdCcHpLcHBkMEoycXZTMzhhbjB6dHhoM2VKUXdpdE0yeTdoeDZnc0g5VTZh?= =?utf-8?B?elJyYmxWZk5qYU12SVpwWllOeE1lcGhxKzMvZUhJMWUzTjRYTG94QWtURUt4?= =?utf-8?B?SUJuTUhBc2hQWUZ2SWxQT1RCS1RyeGV0ODh2K0tJOUZhYkw2YWZoQ1ZTWm83?= =?utf-8?B?ZFZieXVEUkgzRk9kVWYwMHVDRDBEK25aK0VoNE93c0w2d1dlaVVnSUU1aENi?= =?utf-8?B?dUE3RmFJTGVlY1FQalZiUllWd3gvK1ZOT3lpMVVhMzJjbGxaa0hwMWczTFdv?= =?utf-8?B?eklmb1BaNkVEQUtzM2V0TmwvWnE5TjZ1cklPRXptL3JYWUtmOXRSV00wZ2tM?= =?utf-8?B?Zi9odllNY3pXRUhBNVBHNDhBc013N0NKZzJiR1cxVld0bjdsd2xPandheU9G?= =?utf-8?B?T1h2bHY4YzBnS0FZQmdzSkZoMEVkQ3VOTU1tazlxTFJLVTFsaS96V0FBT21R?= =?utf-8?B?WUYwRHg2UTlJeWNVK0I3SGpiTUhWRWYrT3huaHJNTnUxeVNVdUwxc0tGNWt2?= =?utf-8?B?UDZybWhXTjBDZjlkSzFRYVNmdk5QZkwzT3pRc2tmVzU0TGlUSTFGYTdFbzB1?= =?utf-8?B?NDNWMTJXMXpTVzFlQ0J5VlJ3UEVGbEJiY1IzNXBpYkNHa3UwOTdWZG11VUla?= =?utf-8?B?Y21tamVrRVdSdU9tNjQ5d2F4ODU1UzBpdGpDWFMvREpSRWJwQTNxWG1iWjdo?= =?utf-8?B?YUJxTFJmeDltL3RxN21KeG5zUWNMRWNTb3hVUFl6bUJWL085YVZieVJacGpq?= =?utf-8?B?NHJEWENoT3d3ZlZxVGo2M0Z6dnNLK1lYZ2wvOFlaMW5JN0Ird3d0dTVxWVNG?= =?utf-8?B?dGJvZ3d0dDREN3MxTWVrNDN0SXNzdUI5NzM4VnYwR0ZIWVRYY3pXbUxjc2tv?= =?utf-8?B?WkRoSmNvU2I4WlU5TEo3bVcvSXhSY1V5T21tK0Znck1nVWg4dDgxTFEveVdn?= =?utf-8?B?Q3MxeFQwd2RVZmI3QVg0c1hjekxwQ2NneU50cm8zV3RxSldjM1h2alo1KzUz?= =?utf-8?B?cXEwTXVORjFwT09XNUtjR3l2aDFwSnNyWkVJQzQrbHNlOXZvNjJmYWN2T2JL?= =?utf-8?B?b0xLSGZoK2hSQUlrRURONWNxZWtxOFdINHpwc284QitscjVrWDE5YlkvZlNC?= =?utf-8?B?OHplYytSNkZ3ek5DSGxybEprV2hiVkZaM1crOTdDU3BqajlRcWFiOUNrUk5Y?= =?utf-8?B?V3Z6V1JNWnZidHdvWmlwSmZJYjFETkZ4VTFZbmpqTGV6Z2M1T0lBTlZCUEpG?= =?utf-8?B?Y0dCQTlsUzZ1U3FweTIxeXNrVys5NkJmaXJuMXkrTTBoR2tUSjFlcEtISHJs?= =?utf-8?B?YVVPRlVxOGRJWEtIUlYwMHZYS0I5THBCNTgybkhDOXZTU3hRQlNhMlk2a3o0?= =?utf-8?B?SjJYcmZQU2FnSGREVkpweks5M2hSNm13S0VQdVMrejZrYm12TjZycFJXdFdw?= =?utf-8?B?RHpnSDM5TStGOGZhV21ZTlJWSlNJYlJ6Uzdob2NUUXJ3L2ZOSjJ3N2FxenRs?= =?utf-8?B?L0ZpT2ZXV2NLdVdnbEpENWIvV3g2NnRReHJrcFFqSDZkZU5WYjIwM2xzMUho?= =?utf-8?B?bnJlN1RmT003eXladjVKR0pxTHRSTlVLeWt0WlJyZzJOR2M2anRUdjhkcU13?= =?utf-8?B?RFcvS3djTXR5TXJQK3I1KzJsNXk4QkZSc1FlK0dpY0MrWTJPY3lvU3V3VUwx?= =?utf-8?B?T1NVUCtzV0FzTnZMaG1TcTVwbXRhUkFQeUtUdkg1VHI0S0RQVnFwc1QyV21o?= =?utf-8?B?RFl2L1JjejNReGVhY25HcmJjb011b2t0c3BVWTV2VWZUdVluWVdRL3RFV3NG?= =?utf-8?B?M0w0d2VlRkgrYVJhZkRoYmYwZ3d3S04yT2s2MVp5N0JrdEtPL0JMNy84cmlt?= =?utf-8?B?ZnRFck00T3dDUGdITnppSnovVm1GaGlNV2NsZ0dNeGwvR20zbTZUT2hCOGdi?= =?utf-8?B?T2JhZmNCM2F5eFFQZGRKQ1BHOGNwYU52Rzk1NUZValFGcXA3N1JYbmVuL1Bo?= =?utf-8?B?UVlUVjViLzBVUnA3eUtqTGRRKyszcUtnNG1BUG1BaEVoaU44RGk0TzZ5RWlm?= =?utf-8?Q?LJVbdDObGHOnt0pqQzRAsfaXz?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3ef80ce-50f7-4fb6-f7e3-08dd26dd271a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:44.3329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EASzHYX0Y9Nate1j5d6Lk4cnEVHCD/u8gP/xBHIzZk1pkFSOr8l8qigS2Jf+nvLIykTkPagclVuGWw56ni4Vcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-stm32.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 9f1a019ec8afa57245c6d40d378ec50fdcd64deb..183017b0d33d10481f94891de24= cf2eee95893f5 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -1151,11 +1151,11 @@ static int stm32_rtc_probe(struct platform_device *= pdev) goto err; } =20 - ret =3D device_init_wakeup(&pdev->dev, true); + ret =3D devm_device_init_wakeup(&pdev->dev); if (ret) goto err; =20 - ret =3D dev_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); + ret =3D devm_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); if (ret) goto err; =20 @@ -1216,9 +1216,6 @@ static int stm32_rtc_probe(struct platform_device *pd= ev) if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; } =20 @@ -1245,9 +1242,6 @@ static void stm32_rtc_remove(struct platform_device *= pdev) /* Enable backup domain write protection if needed */ if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); } =20 static int stm32_rtc_suspend(struct device *dev) --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2059.outbound.protection.outlook.com [40.107.241.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86BDD8633B; Sat, 28 Dec 2024 01:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348558; cv=fail; b=oOE5m78b3/2V0q5lN5Mw7hIjkE7STps3/LgoLzyozl1lAm6vv2TtMHvw0fAIEWHmUjS8ij18ddWivfNyekVoGvvj94nUiZ6iw85GBB8B5Zq3TosgrpoNZ0LHPAq/X0B2wj+M8xpt8LowQ4L6SUNWJ7rtG0QBaIRg6yvSVf+YYUU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348558; c=relaxed/simple; bh=bGv4dF3gwaQ8/rybE3qOHzdzrW8kBSYtqBarBhutlJE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FnUjL9sGj92Tvcg0IDWDB+VX16vFTur91yDBxPR8pqwUQvEUIjIbrUdTuxVzKjWToea/SQjxod+218C5pMikMUW0ia1DtE+qWUd7O50G6yF6CcZOszq9AJGLF5Luq1K03aJ9Xqje73S97LpCE+vqo5PNQsjymOqZM2VYohX3oTQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=JboT+Epw; arc=fail smtp.client-ip=40.107.241.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="JboT+Epw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tf/lEd8zbFuK3ibEDx9jGqHKWkgJpK6DF/FCgfeqrd7sG7zUmyFwL3fc6gnpkDM21YlngW8JWnpOvB7zJIlW/HcZBzWRDWjrro7Z6fCyUBbhB4pTS+9JlLPVVhQD5qeHaAv2zDN4lWzPXWino2KN7Gae1X0TOmkk+julNpYBRxYPyy07QljT+n4dKNqEbMAlleGve6i+jjAtIA4mKsQZW+OeQWqw+zw7HdKF2uwiN3NBukOd1VSm+9hGWkrBogitdExYj9ninwBPggHAAzEs/fFH1ACpiozxzaAaKYdjTsWj8GeS4AEuMVKd2nVd8/rlaWXkAuJ9h53jSS8GMERk6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=xeuBrPTlkMx+d+wO/drwBoY5rrdQS42JRT8bU6e4tmfMA/zfsYoX26wys/YQDOW/QMSIItfWaEi+otBczYTvp20XDe7A9Ax2hSdZNx53OShl408PgeZcbraw8IrReWVrA2Dtb8N+ZNpiYoaMiJCHltGMdUB0oA3PM3ipae/lttvgLOKlOUYOY8FezrfcxI4QDsISqyNa6X1Ce8bkwc0njeV+irhG3/sBHN8IxlswWxtxBafG0ed4F8PumFW0f9McwiKTWuib7HoSb8uDXWd19C6qzE+KCKRpyzlRRunWkt+qZH5H58OhQ3jQAhx0T+sd3CoQJDiRTSINal0Q4+tt/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=JboT+Epwb3x2Arjezq5MdwcMSqep2L0tWB1HYJy46fthtfvPQj16Pb31L6cNT4gmoJcp00zTTytgYNpf8UID/tnEBymbNtULU0A480vijRl3LWQbxl2LMkSHrIXCjOwz49gjKaLUsKo3SMPEqhxxbtZoQpCQy86w2qdmABnPaZsuSwCTsqv/2tf76WKQ5JfRZI7vBNomdr7wBLKpo8SkmqTe+chkGXGCXM4ep6Bqg7MgoeY2gZ5oWKrMRGHsxuhivncBxt7W0lMVR6t5KztVEDpXWfjUFKYA3+x9dYPKEDDgvPVagdsroJeCeYJDgP7HDyL4N30GaDsBOvCbUpQ6rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:49 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:49 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:43 +0800 Subject: [PATCH 07/12] rtc: nxp-bbnsm: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-7-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=2071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=VAulaoWVPhHtzgpO1nG1u9VR+bogAGzfLBxhdt2/l0I=; b=/Y2rJW+uvGVymldGjTdqHDl+b4ky/5JEFPBIiquUwbEeAm86Ox9gFX8XXPk1WjXf7BQX3ZFl7 EVH+AXBrsT4CjLNe6ykOi1b3V/H+/sq6s7NoLo4euO+l/d0xsKfEZBx X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a057b42-4d3e-46e2-a3e1-08dd26dd2a36 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OGtMTDVQUFhUNGRmRmthNTR1ZWJnV0ZuSVpTS3lXalA0K0JSNFpyaUxybnpu?= =?utf-8?B?VGFwcHFjd1pSdmZaYjIzYURuTW9MK1NCOXJNMlBJRUdDVGU5N0NTU0VYR2kz?= =?utf-8?B?bzgwYUZyTlN0TS9ESDBxNUE1bFloQXNPWWpFYU52eEhxWkhLL0lIOHBFeFpr?= =?utf-8?B?cmhoN2RMQXZWVW5SYWJwK1ZzM2tjZFg3K2RoVjhsQngyeTFpWk5TdVRnbEVs?= =?utf-8?B?TUlRNnk4QlU1ZmdTRDk1bTFlMlNvV042SkFrWkZpUkpsUEpIaFptdjlIdWVI?= =?utf-8?B?UDEvakthTyt1WmxtNFNSV3pSQVJxQThaNUN5Y0EyTHR6VjdianQ2WERld2xF?= =?utf-8?B?eXpmYTQ2THBLNHBtaFN2eGlsSGhvbUhDNUNwanRTWVVpanBJL0M1aHAzRTRp?= =?utf-8?B?dHVFQTRhOGhSaE1GcnoxRWxiMm5tSE9CNytNcmNwUDJhb2o1aVoxVjFma0dY?= =?utf-8?B?QjlHaHZLYmJmeFFjTzVnU29OUzJLeFQvODRXdE1McXRZaDl2YUp6UC9ULzFt?= =?utf-8?B?TThMcWI3c3haMEVKVGpFUlFEcWM0elVNWVFldmZ6Y0V5OTlnOWxaYmhVWXcx?= =?utf-8?B?dWY1WFZHZDVwRkowejhqWjQ2M0FGZU1paXVnZHZaSmpGTy81bmg5cHE2cytW?= =?utf-8?B?MFhVZHlKV2cwVWw5WnVycUtRUXBjTVpoMTZjcFVtS0czM1NtejhwMjRER0tG?= =?utf-8?B?ZElVVk51RGp6aWdCY2ZMSSt0RkRyZklEZ3BJMENLQ2VwSVZlSDNoS2NzUWtQ?= =?utf-8?B?R3VjSmk1cU55T3IycFEzME05SE5aWEpiQTAzYnZOUlpWL0JlbklOYUFtR2M2?= =?utf-8?B?M1BQQTVYemY3SW1pd3gwT2ljd1ROL1pic1FpVlh3WTRXVXdzYW94aW9naUhu?= =?utf-8?B?TEpKUlRHNnE1eTFKUUlmNHZSKzVQNjlwVDBxMzVNcmZmWXQ1eU5vbW9Xa2U2?= =?utf-8?B?Qkx4VDdGNG04Z0JFNjB6azRkemF5UGJqOVQ3bVpPYkRDdktzb2tjYnpZY2xY?= =?utf-8?B?ZUJPalBiZzVTUmpHYlE0TGZQSVJXTFlCMzZlUEg5MEhxbmhIRHVxb3FYVXpo?= =?utf-8?B?TVppSWJQZi9wOXZPbUlZTDUyamZwN3FoWWJyUzlCRjJMNUJpZ0tWWitMVXZ0?= =?utf-8?B?eG9kbTFqM3NtZ0ZSaWJkcmtjZWhpcVVzb0hPOU0zVG9OYXo0eWNqV2NJL2dD?= =?utf-8?B?MmRva01TbDI0YVhHR1d1em1DWGc0SjFrNHliOEdZNEFvekJ1VG92aHZTR3kw?= =?utf-8?B?YTk0NUZ2RjFRNXQ1WlgxbHZjWWdqVzNuRkR2VzJ0OXRrb0JXdzRLMzZaeEph?= =?utf-8?B?WVo2RHhYUEJsbFcxdTFveHBUekNLTFBWZlAyTUZCYTFRVE9NUWVTQVBOVWVW?= =?utf-8?B?b2QwdVhIcGNyNUdIdHdqSlJmRzdKR3dpRENUT21mZlpURXcxeXVqckFtOHVl?= =?utf-8?B?VmwrcFlCVzVFMUhZbkI4WWpiNnI1a3pxQWNmVW5wOExJNXM0ZkR3YmUyeDFZ?= =?utf-8?B?UTEzQ1UvSFhFSlFmdzkwVElVRmFrSlVMQ3dPTHRHS3pCM2V5TDFpZW1NTUl4?= =?utf-8?B?L00rZ3lkbjg4SVdXUEswR3NLUlFlZnNPbXgrQ0N2a2pWQVI2dzFnWllrdUZQ?= =?utf-8?B?REZrTWRENVVac01VZmZMeTZNV0xXZTZPRUVTbmw2NUlMQWZQT21qUWU5WTZt?= =?utf-8?B?dXp1MURjd0dMY0VIeVV2Q25yTDd0QnJYb3M1STRrYnJUTTh2RWNZaTBGaXVm?= =?utf-8?B?djNvTmsvNDErRlJPSXFZTVRjNUlMZVBXYzVXWS9IbDJZZUUxSzZEakJmc1lO?= =?utf-8?B?eFpWQ0FrU25Qb2MvZEEzWE1RNUd0Q3l6SWVUQ1lBbXV3UTd3VjVHL25pUkl2?= =?utf-8?B?Y0pNbGN4QUhneGNVaExYNDFDbXZ6c3Vsd0JLVkgwMEI4dnNSai9sZ1I0NG00?= =?utf-8?Q?PjkIBcIv0bjmqy7cQ5IkMIMdfnrQi6f0?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXAzTjBUSlRUcHY3QkZySXZ3T0YrUEhNTEV4MzRUUkRxTUlnRnNRSDdtckxw?= =?utf-8?B?RUNsUTB6TlF0SDlDTmpxTkY5M0JVTXREYVZoQ2pNQVFjMnJvbDlNamhMMDBD?= =?utf-8?B?ZGdXeXhJeUdwSDdTMjM5YWJYSW8yUDdYOHVzbmhTSkFHOHlXVnpyclpCWmhm?= =?utf-8?B?WlRPVWdqaTVkMWkyakRvVEdJeXVqMHc1bXZTaXVoUTZ1WC9UQjNTajlYZmV3?= =?utf-8?B?Qk9Xb2w2OEFwVzBQOHd4WjNtSGhxSnc1NDdVOWp6bkk3UmkyWnFibG9zZTB6?= =?utf-8?B?ZElCNG5lTzNWTWhkR0VHVGpMcUFpQlQ5SlBIazc3NVovRHBKQWdLTkUzWElw?= =?utf-8?B?VUdaa2VwbFJmOFVVQzkzeFY4UVljRnh3NG9OblpmNG9rblRrZTZPOG5lUXk4?= =?utf-8?B?dWZMeFNPYWdxaHk0QTdqMmdQL3NraXRyNnI3Z0NhdHE0Qm51SmFlc0ZJWGZL?= =?utf-8?B?b1JKVVpQQkRTR1BJazR3TCtyL0gxQUpmVWZnNVRrckFRQkZXQmd0ekxhK2cy?= =?utf-8?B?SmdoeTRJYVNHVFd1c1FtRGhtZ0ZHckk1SVhoc3IrdEZrcEh1MmJLM1lJUVo5?= =?utf-8?B?Q1BBWWxDUDN0aThESktCSU4rUktpaEdSaEhFZ2huS1dJaU92MTFlbEVnTFAv?= =?utf-8?B?VHoyMG5DbGVFOGRnZzdGa3RzaVQyU09RVk8wd2VWanNOb29NYk51MHlpMlpx?= =?utf-8?B?TWs2M2tDUitMZ251NzZheEpwblkxVFlKOGswbm5RRXdmbW1QWE12Yit6bWE1?= =?utf-8?B?TnFmcTROdVV3eXM3cWltanlCQ1o4cG1mNnVKbjFHZHFjOVBxVWlyUTdKVGZO?= =?utf-8?B?cVRWakVtcnkvWGFtYWNRUFlLQ3lvOW1kUDZ5dTNRZDNpaDJMOGlxZ3ZyY2Zr?= =?utf-8?B?S3FldGRybUo3VXpPZm5XZ0RmODNNTnFNeWpCUkNzNjcycW0rYVl5V0lSMUlr?= =?utf-8?B?YmZEV0dFdGJKYXFwTVVnNk1LYWo0RGd2MHB6NGhLUDRlY3FJdTJFUmtDcWRY?= =?utf-8?B?OW9pdS9TaDhTSjhuSytmdkQrMjR6UEdCUlgyZjRpUG9BSGI2SVlleXVnM1h4?= =?utf-8?B?TkpyZEd2b1JoSUl5M0pxamxqdTlaWDJGY3FZYlQ2QXBjSGdDVjR3dmYzU1Rj?= =?utf-8?B?dC9FWVJ3aFQwdndIYnZ1Y3Nrek1xQm1mZFg5c2RYaWwyVG13S0hiQ2xLMHgw?= =?utf-8?B?QU96OXlUV1piTTZISi9UVG80TVJyYytBKzlBSS9nRXRXamMrcTNrWkoxQVV2?= =?utf-8?B?aC9ub21mODRIb0FOMnRjK2s1ZVRNc0UvRUlQWmFiMFVpTHdRMG8yWE1panRC?= =?utf-8?B?VDRqcUtFYWFnNnZsUy9VaWxFYy9IQ3UrNUdoeE9hUW1OQUZkcnlvMlFyVTUz?= =?utf-8?B?L1VJTzBLb3RleTZncTFDUXE2OG5vMXl3dzRHa2VYUzRsaUJubzYrWjJKTWNp?= =?utf-8?B?WmdnaUJhOC96dm5VcEtyTHFDRE1LS3kwV1VyaGJEM0ZYeFZTUFJyMmUrdlds?= =?utf-8?B?dmdtWm1HMDliaHpvZElSejJqTmNvWEZnUTRNejRaOElxOWFZMlhQR3pMYkRo?= =?utf-8?B?TytGQWpkTk9sYThpOTZ5aXRjSUY3T0Z2UTBMb0lBVHllL0dlWlFzbHo0VlJT?= =?utf-8?B?a3NlS3BkOFU0U1YwdTNhc1N1Z0k0OUQ5UTVQbzBvTldmQUJkOEJvSmJpT0NH?= =?utf-8?B?dXB5aGtFVENYZEJBajRXM09SeHFMRmxqZytXTkpnMUJaMUdKNCtjc1Z3d2Rz?= =?utf-8?B?NGRoc2hPbjZXSXo3Qk54YzZOSjhPR3IzbktQU0pjQi9lRmlxWDZaQy84SU84?= =?utf-8?B?QWdzZzh3dEhpQ0Z3L3RBV1hiWGR2VWd6eDJLTzRjTndxbThNMTlLT3BPdTJw?= =?utf-8?B?OHcvNUNCMkt5eUtmT1NRelRQNHdXcEUzcU5EVkExTlBHUk5QZ0VXeFJxZ2R6?= =?utf-8?B?UzIwZ0ZaUU1TbS81anVWVk5KOXB1MkFMUVhqbzZBZ01vWjhScXRoNlEvM0l5?= =?utf-8?B?YUcrSHJUdXFIL1ZqTmJSNTNtaEplcGF2Z0RHTHl5WnlQcmtwcXI2aWdZTzFZ?= =?utf-8?B?R0ZUcVFNTDNobGdEU1lTbThkUitobVV6blk1WXp0bitQSzd1YjFFeE44WG1Z?= =?utf-8?Q?qcy6UrOLmwIdRZQPdwUPiAF9M?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a057b42-4d3e-46e2-a3e1-08dd26dd2a36 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:49.5526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 037cqaYX6lrRruUNEz7qXHqPSkrDbyK6Dt0fVNXUp1BYwzW6EiUo/aSAYpeURU39MuecTrPOjL+EXWPjkqZtVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index fa3b0328c7a255ff8a902a58d61a4b0e59eac493..d4fc9dc583d317d4852b7d897a6= c45cfff6961a2 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pd= ev) /* clear all the pending events */ regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); =20 - device_init_wakeup(&pdev->dev, true); - dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + ret =3D devm_device_init_wakeup(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret); + + ret =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + if (ret) + dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret); =20 ret =3D devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, IRQF_SHARED, "rtc alarm", &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request irq %d: %d\n", bbnsm->irq, ret); - goto err; + return ret; } =20 bbnsm->rtc->ops =3D &bbnsm_rtc_ops; bbnsm->rtc->range_max =3D U32_MAX; =20 - ret =3D devm_rtc_register_device(bbnsm->rtc); - if (ret) - goto err; - - return 0; - -err: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; -} - -static void bbnsm_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); + return devm_rtc_register_device(bbnsm->rtc); } =20 static const struct of_device_id bbnsm_dt_ids[] =3D { @@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver =3D { .of_match_table =3D bbnsm_dt_ids, }, .probe =3D bbnsm_rtc_probe, - .remove =3D bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver); =20 --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4BEA18E3F; Sat, 28 Dec 2024 01:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348563; cv=fail; b=UePioW2BcwDlVvEbp+stk/7mKtE6BY6Rz8D2GZipLaiOL8QNy7G57FvczvkKM5KuRhDlbmSn8f9DEe5UGAfDwJBHQd99N2/bvxl08/+XUj3y4AEoArd35bYT+BTJV7nqPTMNmnu/rpQ2uK4Gi+5GZIKsBD7s/8jl09rVQPvDNbo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348563; c=relaxed/simple; bh=BO8Hwal6yUEtmatjGxTeE8CGMKa+r4910TYtu1OW9Cw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=aTDNP2jYHGERp5Eu7fKxDUy3dQaTW3PWnXmUnLvTe+6KmyPwKLosSvF9zNgZ7YpzP7Z28aR4jYsZtUno+zZu/YLEdxgKiYZO3zjsWBtQnYxXYodMHag3Y/E3754Yw06yQgbQIE2uouz4aVW6PRIVkAVMBlQsjr0qHmei1Y8Ka5c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=k7BxjQzI; arc=fail smtp.client-ip=40.107.21.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="k7BxjQzI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lHXDjsC32wslnnL7m9PNn1c/gxKJLVmRX0zTPfuCv96TTCJ1jI7rvG+EjP9gt9a1OFDHXkv1YZ0Qz0ilSP1OtSEEY2+APOmrJpqCoyxn1fBOvYEHXZpxAGPhCL6RT/MBUYfJzgQSFRnTahMghOk1oN6O7IT5zC3Vcea+eO+gpF1K7pA/fE78XiCJPtgaWJqzcBMi2A7ibmu/6D3F33FQOPPwShx2hVD8Uyjr1cMGuDvbAKECUHPqMozaJKycfdudvk+KJaxW7mudIbzlZ5DnM3/HBGhX2sj+eF7Ti4LHXlDjxkaQn5a3BGrzC0B5pwIoAHBCCNrdyUlXa15wuaUGyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=Arzkft/TW8P2dsrs3yCzTwNhOzT4Z8ZX7mBWZAGNdZERYI+Kh/6+09nop4ZEhiQpH8RnKrGXHI5wKM5R3pvJ6mQZ0qNgwGJYGc88FXWIaEoFHIZmC+owF4YR5LBNA2QyEkdYlsE739OptvRXXoTfdBu3ns4PCyqDsaA3Q84icEOIyv9DjV6p5g4Q4ytQFesAsOxX4Am2ftVE2DwGpx96RUVQcElEJzlLuJbcDw4uOdTeGpNFsmKj2AaKf5HsWCKK3J7xEbJhfjtFapCNqC08D5sD7IzKF5CLKlhL3ziGD2+F30dSgrNlEnM1HZgHzCABga9ehHccttOJoj1zWDKdPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=k7BxjQzIHzaKczjRlj4gihW8gshonT1kqxqWI170XRTk9p4LDLpDV4vEK6tdiKa5IhvuDbnQmeAAlXJ4hWt1Z5iESGxwAPNiyNo1rfgoYxAzN0gr2pnhdl0iwnvIDHDeA60m4Gx9xhqss1Wz3UfEQUpgHA4lw3lLOJWCRbd3BfSeWqcgcjd0XUdaMAi4RRbAYcq3vjGM0hiECYkJ6nFix2XJIEBzuft461yluK8o+VBdvnRStzYBogStqemonUaqex1MUMRCfVeZDhcwOv5YIw+XUPB9+/LVLzJXpbz9b7oo7Pzw5a2zW/vQM6m4Wzvsvz4+zW7VtA4jSV/NG84NTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:55 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:55 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:44 +0800 Subject: [PATCH 08/12] rtc: ds1343: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-8-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1119; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=yYeVC601Fmqm3h8IRsE1e0gqqkwuyZ6uKwkA4brZ+6s=; b=M+cjMtBJIiSnSiefeaCL1kRXO2h+J0tucG3uxMJe5UH0vh+z5jUGXRMNrSqfIEAjK4/rPhH/h VZWDY4zP6vtDH5h+voA6RkrS/HIpVqO3Z1HUPMPZPVSPN3MNZ7k/Psb X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: a0ec955d-cc44-49f1-cf2c-08dd26dd2d77 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QTIrUlVOQWRYNDI4ODk4cXExS2dKL25Hd0hwbERzRk8rWW5RU3ZlVStUbFpH?= =?utf-8?B?S0FjZlV4eFByczhNeld5RFBlMlVQZTduZHpVWnkwT21MamxKQU0vT0dLSnBs?= =?utf-8?B?emt4bWJnSnpBcjk0R1dCd0x2b21IUDhDRVp1SUErcks4QlJ2QnQ5bE1vQlZN?= =?utf-8?B?YWNrVVZJL0pYSnRVK3JjUjhlWkdKTFhvbEZMNXI2R3ZqSC9TM2dvQnVkcjUz?= =?utf-8?B?WGpUV1ZJUGVBak1ta3NjRERqVGhKTE83MFdIQ2MzekxMaURNaHFKcm9YYVlh?= =?utf-8?B?Vmh0aFBEcFY3NnFROFRoWnJCcnRLM250bExPRkNKajdjMS9qT2VLMFJ3SWpM?= =?utf-8?B?WC90ZVBLTzdGNC82Z25uQ2EvR3VPeEZIeDZhOTdhbFpFcFVYb1hIY1NtUkRQ?= =?utf-8?B?UUliSXd5U0Fnc2xiY0d1UmpXajRDemsya0RtVzlXelZBNWxLKy96aHV0eUdo?= =?utf-8?B?UUlMSFRpdUw1LzZId0NmTGNCZkV4eDdZQTBpVlQya3EvVWw1MldqMUFPNXlV?= =?utf-8?B?bTdCWlJ0REkwMXhOUXdDLytmOE5Ydkt6WE9hdHhOdU15MmNUOE40QU84NkNL?= =?utf-8?B?WWw1K3o3UnhSNTFBK0xhNXdNellQR3FWNkRrVE1EbVZrRDNJWnZUWDBCcWVy?= =?utf-8?B?Znk2SW5heGFFSkxFNUFtalNlMEFsQ1o0MkxGSm1GcTJieHdteVZ3N3dvSXFX?= =?utf-8?B?QWJEajBhOWsyWnFtdVdCWXJtaVhLY21tUDlCdzJnR2dBbUhrTVlOS1RkYkgy?= =?utf-8?B?TXE5T0dPYlhKTWlsWmM0eWJwbDZOamZLbHVtcXpHRTFyQVF6eFBZWno2OXhU?= =?utf-8?B?VnNZOFRWaHVJOG5mNlVmd1VvZ0J0eTdzQzdXc3JwTUVaOHpvWTYyQ2NnSUYy?= =?utf-8?B?dnEreFN5SlpiNXJOVHVIWFl6MldZYnArRGhwV1hLbGY3Nk90YWI0MERxcGdG?= =?utf-8?B?K3NoVnN1OG1naFRsQVhDV1Rqdkc5WmgreDRETHMrOHlDUklSTVBSYUMrRkpE?= =?utf-8?B?dk0zMGZyVWRsSGptdFNodTA5MFMvL1FmWDZyT2IvTkc3c1dESlg4RGFtRlMy?= =?utf-8?B?dDRVS2NIMlRHc1pzbmFJdFRUYzFUQU5PbSt0TEg3b0V2ZzZQdCtlQm1iODN1?= =?utf-8?B?SUZCZnVabm03WkFNY2U2UlpjM1BZNnJZZGlQa1JrMkJQcDgzcnBOeTdUeUFy?= =?utf-8?B?REc4QkFiOEFkbDRuNTVDOG50b3liTWppSjZ6ai9INUZ0UitPQWJDdkpYVjI3?= =?utf-8?B?Z1VNQzczSlJPU0FRT1o0YnMyQytFU1QvVnZXZlIzVzI5WS94RHpPcVVPV2Fj?= =?utf-8?B?N3JkRGo3YUtRbW9KeFpqdnQrWU41WHNEdUY5dDl5ODBYMFJqWlNQaVlGb1lO?= =?utf-8?B?d3J1dFhiN3BneTNDY09iTDE5dTNxb2thL1Npd2xIQk8rY09pUGVTOU4vVDV4?= =?utf-8?B?SDgwV04yL1MvblZvRXBmWEVyVThOalBoenVURUU3a0FMNXNKM2g1SU9HSkpW?= =?utf-8?B?b1ZGdk5SSnlVcFN2RTlVa0xPZjhvVzhHNGwxUTVxYVJOREM4d1hEUXBTWEpx?= =?utf-8?B?OHNmSGtpMnB3Z1NSakY1SThjMkpxbmpjayt0bFg2cTRSNVAwa0tFdHhNQWhq?= =?utf-8?B?bW5waTFDdVJFVkoxVUwvMFdNVnRQQ2x4c0svMkpXMk12V2p4NzRMYXJRVFVh?= =?utf-8?B?MTBqZmhDVjg0amdMdEdtQmNwK1I2c0RZT2FtM0VjR1NYdmJGUmtCaG5IR25w?= =?utf-8?B?L1ZSTlpsS2l6YWgvelVzNjd0aFlPcTAvSkE0bkRUM3VvUWVmaEJXVWRzUFJw?= =?utf-8?B?WEJCQUxHeUZlTlZsdEtWT2hxT0Y0VCs5TnVESGI3V05VQWNQQmVWejdZcmYw?= =?utf-8?B?S2VkbXNrdkh0bEVITjhFVmxMamg1c2Mwc3F3Q1FrTnJqeS9BQ0hPaG1wK0Zs?= =?utf-8?B?R0Zya1dUdUNTdVd4L0kxNGlhL2FDanpFdGVFSE9xTmFVSWEyZUpxUGJPeUhG?= =?utf-8?B?c0ZlLzRZVVVnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUJOWVltdUc3QkpaNlNyNTdLdFR5dGJlT0JobmVPRTdTRldHdEFrRVBya0Vs?= =?utf-8?B?cFhvMlI0OVh6Ky9FTVNsQ0FqVkZ1c2hlL3FGa3paNEhhQmpmd2NNNlkydHI5?= =?utf-8?B?WmxrRnc1RHJKNWdUa0lDU2N5eWd5ZGxlalJlcjRUem4rZGxKY3JFNnpsclI3?= =?utf-8?B?K2R3eDNrQTBhN213enoyL1JNUUltTTZ4NjR1SWZjTUxXT0Z2b2xIVXFETGVa?= =?utf-8?B?OHBPdEJvNWhhN25kSVdjU1BFeHdSTE9zSTdQZzNGaHVtUkdlU0tCVnJGRmJz?= =?utf-8?B?NlU1aVZsZ2RzaUdHQXhrWGxoODRJeXFXVDR5OGU0L2E1TklmeWExbWNWdWZ6?= =?utf-8?B?RFlUVGIrQkxnbGdOUVQ1Mmdwd0d5d1hhZWlEcmFuL3ZEcmlZWmFQd1MrWFRm?= =?utf-8?B?THNXMDZGZkhhdC9IazJBSWN4NFpIeG5STHdpQmpkUFhnOGV4MmcycEFKaitI?= =?utf-8?B?MHhhSS9heUJlUVRVN3c2ZjdZZ29Sc1hLTi8zRGJNTzlyUHhxNkFjbktGYTJJ?= =?utf-8?B?TVVWSHRFcmtvYXc0eWtvYVlrUWZuTEZOc3Z6ZzE5Y1habzc2RnZkeENsQVEx?= =?utf-8?B?K1ZOVDlPMmw1dG55UG1BbWsvRDhkUytaVlQyQllkYkcwZW5ib3p4ZFFEVFo1?= =?utf-8?B?d3V6R1puWDVvSzFzNFRWbkdkZ0d6WHJBOWtBYVlTVXlQeis2U050VzlTZ1d1?= =?utf-8?B?MWdpYUN1V0U1U3duMlVWeFZkeDNMVkVOVnpNRnZkaXZra3FGV0RxZThodzcy?= =?utf-8?B?aGZTN0Y0UUhxL0JQVHd0Y3hsa0gvaFdEaVgwR0VtaGN2MThQeTZuNXVZRmFR?= =?utf-8?B?Z3locW5tdWJzZmFnSkZFa0lOcEhGenQ1YXdnYlFmbzQwb2VhenJ0Kzd5RWRz?= =?utf-8?B?alFmc0ZaTGFWVVZCaVh1UlJPYUdvY3ZEWElzQ0dXSGlYM3JiVm5NeFJaYlFn?= =?utf-8?B?U0VaekFpY0hqbis4TVJON2hyMFQ3dU50N2xoT2RRK2ZxNUw3bWwrbm9OS1V4?= =?utf-8?B?elZVVUh0c0FlUGFPc01KUFBQRW9QMEJ1bjhBOStMU2h0VklvZ0pjemtvRmlv?= =?utf-8?B?MHpIUHIyOWhBOUs2TmJ0RG5vd094Zno5RUhoQS9tMnNHck9iTnhUZzc1cXRx?= =?utf-8?B?MHVCSGJsNjVXcjNJZm5zNDZZakFwZHNZRk5GUUdxTlIrbUsxUmtxeitWOEpK?= =?utf-8?B?N3hFaEpPczd0R2lpMnMxNTIvVkVlUktsQzR1T2ZMdnJCUUFwNTJJeVBtREF6?= =?utf-8?B?WDZSa2NXK3kzTHlISzNYR204Q3NCclhVM3UvU0JldEFNcEcveWJ5b2p3YnlM?= =?utf-8?B?VnVwVkZoMjFYUGs5cFZ6dEVoQXN6b002N29oQUpZLzMvUlJaM25GNlB4emxZ?= =?utf-8?B?bHBWRWtBL1VOdEJJTlIzeUVwRVMzZE5IQkh3OHRHUmxkbm9CVTVCVXhSaUJJ?= =?utf-8?B?NVJFUkFNUDlvbTdRQUM0a1QzYkVQTlpNeEtTc3pxVndyQzd0OEdzVWpMbEM1?= =?utf-8?B?eFVBWkU5ck81TDlMbDdoTVJBZDFXeGhOb0VRR3FrRUI3dENtMG83YkpkR0dE?= =?utf-8?B?aThpOWRTQXNUTlRpaWdzQklCU2RaSDZJcDUvMFlYNjBXQTNlYmkrSVlqS0FJ?= =?utf-8?B?ZnNiNmZPVktsc3VpejB5OCtoemx0YUZNby93a2pzR0NuTFlBTGs4ZUoyd0dP?= =?utf-8?B?T2M2N01Ha0V3cHYweGRJLzhQdU9iUHFNOXZNNXlkMDhDaURBU1Q0M3poU1Nl?= =?utf-8?B?Sy9JbHBiOU8vSWZ5c0lPWXRyR2hHTDNMeDVjWXBQSFhCQnVQRXJQWGFkdXpB?= =?utf-8?B?TVNkRGdteVE0WWxIcnZuYW5YemFZLzhURS8rNkhQUEFGeXFoU3YvOEtzUWwz?= =?utf-8?B?bENDNVJQdjY5bzdqdHlpKzlSd2NzWVBUblJaZkVPYzNuVU9rNGNieXRQTThK?= =?utf-8?B?SVNBWnlXRGxyS0VybmtJdktELzh1UlpIMm5xeGZCdk5DSUFBUkplRWF5eGxO?= =?utf-8?B?ZEZkTjc4SzdSdVZxZnZRSUhwZHdVZGlHeHlTbU55bG9hTENGWUtNOE40cXY0?= =?utf-8?B?NzlRT3NOSVZ1dW95MEM1M2xFWmw5a1RVcUtYUUNSVHJlSzlHUldtblRudHYz?= =?utf-8?Q?kUiFdGBJlb6gcE/RosWJdxGKm?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0ec955d-cc44-49f1-cf2c-08dd26dd2d77 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:54.9933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hwvKbv5GosjWqZa2YcMCtdodJ0R1g3KlLznc3H50OvVOScRvG5ZLdmEa57bndJs7fh1Hwkm/eVx50B3Oq2Iq/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-ds1343.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3eeb2a0b9d6dea3c8b3d40aa2cf317..aa9500791b7e0300b150bd654b6= 9c74f3e5e6e6b 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -427,18 +427,13 @@ static int ds1343_probe(struct spi_device *spi) "unable to request irq for rtc ds1343\n"); } else { device_init_wakeup(&spi->dev, true); - dev_pm_set_wake_irq(&spi->dev, spi->irq); + devm_pm_set_wake_irq(&spi->dev, spi->irq); } } =20 return 0; } =20 -static void ds1343_remove(struct spi_device *spi) -{ - dev_pm_clear_wake_irq(&spi->dev); -} - #ifdef CONFIG_PM_SLEEP =20 static int ds1343_suspend(struct device *dev) @@ -471,7 +466,6 @@ static struct spi_driver ds1343_driver =3D { .pm =3D &ds1343_pm, }, .probe =3D ds1343_probe, - .remove =3D ds1343_remove, .id_table =3D ds1343_id, }; =20 --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEA65D477; Sat, 28 Dec 2024 01:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348570; cv=fail; b=lyGh/zKC2SotZfeyNimfs124UwsQm2Vygm/4dgKtT4iQu13aXwAjqgcSmCszYIUqvgYNHazr0R0mjaO5v4bmvkS9SZzC89EyAwTsrQMZXssLWkONKUVy+BuZiNDDeErMGHzGC0d20KpIf1oSoL8ZEI8NuDdKpdO/+LMRNnZMXFA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348570; c=relaxed/simple; bh=ZKjmg1MtBFOISkDUMyTeytnGcAdAAATDapDdHX79doQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jYwwJRiIhVp8fm6b+a1FkcC/t+zsrlbvCCkHVvHNJapAqMKpgnrr+R9oTxd04sUOUkAWG/weUsslaRkM/A6LVVUXzxmMmAGH+lPvi+LEbVMObokqr1H2MyryYssJTfiQ7AkhXYRnW3EW7teoY/vl7VGKqzhYiiiZ1Uxs6SufXqA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=C/tf/3lc; arc=fail smtp.client-ip=40.107.22.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="C/tf/3lc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TW73kT5SM2qg5sm99Xy7PevMYBjQmCodm7XlAhgWBDpCUxxz1/k5Rpo37/EgD4o5CAADs90yk5vsyGQ747pzPFBGGFYWSomG61TuPRI1Ula4WdZ9Zeerx3ltqT7kPlRS8EfQ2TqTgZYDpYI53g8nmrL6aUfxYohIlMnpHbupJGOskTFaK40Ui9WnulI10E154X/Zrz6VSL8wpE6QqoMK+dDq0YgBstmgH4sXDJq8FNMI64jT6gT5qW30WaNiYwM/Ql2qzsZyQQtVYADpWyX2cjkaB+1UBeEIrBIvSljaCNeyn7pZYqiIkDK3accHSOcWH1gRtNel48ldtowgkxCVfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ukcfnak6rASj1mOqRwYrxQ2oQzH5Bwejo3Xly8lLTrQ=; b=qcOAbfADEE3yCiHYIZ7hnRXsplmajjCKkWDVMtSkoj+NAXsDe+lLJQl/iQ3f0VvaWHLJjAVpLdxiv512Q9dtd1o2Io3vWO+o59c4HEWMyUqcWg9NrTFUHaPJbVclW65+Svrhi7T1+/5lYPgfKrNHgEX9iwX1KhtlIM7tXunenFkOGJZ8XyZ/Ce6ACOEmtD7iqx3KFpQkC+etaXi9O3B5WIOP7yW5dZx0Vr9IMUFm0ElARv8aJAHOwVAydcl3eVzuvLzD7dr7PlTc4jAUt8PykdYqVs8Ca2FQz8VIdomnY761ymzc3Bj2GU3OLFvypmotGUyyZMlim2T5KaBWiP0B9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukcfnak6rASj1mOqRwYrxQ2oQzH5Bwejo3Xly8lLTrQ=; b=C/tf/3lcOThIwmHuUfWQZrYwl3CVThLUQMhCZ9IOzbKddcmYgsdUGK3BuFrXXj00A1E+OOsCOWrjcM9F8RHf+RUiY8/bz0zyAmo/G85apfMwQu/CdCnqW1xd4eVIM+/voXR+Pas7JESQZOuNygFUoFRui5xCDixH1rlUHg91hBiTGqqMkSHz7LIkqxRAbKUj2ZNPjxslLPKwc3CzuzZPtkCZlO/tuLlq88aiIBc4ceQBo7Vp0CGgKzyj4aY46b+usIQf4LPLi1xsQltgpxQk9WVvuXK64On5Lfp2VVJ7Ypm7sy4+ltqcsdvFpVVZnju23wJ2kQKshYn5zBCWgMzeJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:16:00 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:16:00 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:45 +0800 Subject: [PATCH 09/12] rtc: pm8xxx: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-9-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1049; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=GvTygPs23OU+WJ4Ssa5ar7+WSYAkUwf2a/2JL3pAL9Y=; b=fuTuUxBpzA72Kp21pez+zNIQrc7GeIb80GQ6AoCih6Kuf6w5GU3tFr4HYAL2bco0pS2GFVYAx lQXFpAX3Yb9BFXbDZCsQZuX/uNEfUOyCxP+nzE5dENo4Aq3m1j79BLI X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c455295-9197-4e68-5b11-08dd26dd3092 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmFST0IvV2hGalljUFdLcVd6V0hqS25EaitTNWlFYmR1WlF3Y240aGlTaURh?= =?utf-8?B?TkpXMk0ydTdpZXpzN3FDTXMvcUIzajd3cGpFUUZNZXNOYS9zWTNXZldJS3F4?= =?utf-8?B?Z0xkRnJ4dXdCTGpxYmliVnFMOWd3ZlYxd2ZmZ1FxZzdraldiKzNQem9ZRCt4?= =?utf-8?B?YkpBVnRTR0d1bWwzVkdYS2JTbElOUUtENGNtY2lhUlkwQ3BpZTJZeW5QdVlP?= =?utf-8?B?NG5CbWw1WDA1S2d5KzhKbTNkR2R2K21neGFBWldmOUFYYkZiMExvRGVKeDNU?= =?utf-8?B?NzZRQzhWU2dKYWVSWVk1QWlqWTFCcCsxQ2lHbEp3QjZuWDV6UmhyK2xocTdD?= =?utf-8?B?VnEvWGFLWUpiek1tWXFoMVhhWjdUQTJvZC90U25XQTcwbW1reTVwZytZb2ww?= =?utf-8?B?Wnk2V0hkc3NVVzdzMHNWTDF5cnkwT05TMThIRCtIcGpXbDNpVWJpV2NWYTRw?= =?utf-8?B?R0h2djJpdDZ5L2J6N2Z2UUxJVGQzWW1RcDRqRGtycis0RmdJNlp1azNWSHpJ?= =?utf-8?B?K0dBZlNDUmxIV2Z4Z1FQaHJabkEwTXRuc3YvQmN0RmNZL1JLTm5LNHZGRXJ0?= =?utf-8?B?bmE5VG4wZU9tY1YrQkYvUy9SOGYwUHgwRXluTTY3YkVKSVo2UnIwdlFTYWpt?= =?utf-8?B?MXArQjI2bnRoV1ZKcGF5bVFIY2cyR0pSc1BrQm9KcmNFWngwNG1YU01DbVdL?= =?utf-8?B?UWxra0FadFFNcGd5RTAzNU9CcDVmVnlDTE9CTFZFYVBpbkpyTVVLckIvamlD?= =?utf-8?B?NE9tZnpNUS9BdnhSK1pHSUk1dVEwejV1S1FwR01EL1FoQk54MUdIcFU5U0ht?= =?utf-8?B?L0Q1eXl6ZEhmS0lkK2NVVXEzK3JqRU0ySHFSYk9TaVQrTHVFYzIwb1BsY3FR?= =?utf-8?B?cVZCcml5NzA4WnptemJoZmxzb3pISnBIUHVZOWtNQTNxSk0xWDBMNFJzNGhr?= =?utf-8?B?L1kyVDlRYjB0NjkvaGdoN1ZjUzdhNWt5NmZ2TzNWeEZzNHIwSWEyS2s1ekda?= =?utf-8?B?WnhIS29EVmhYZ2dJWDZ2U2dsOEJyc2YzWEUvczZOMjZDdGpZNkJ5bGI2Qkpl?= =?utf-8?B?TmZqRzNkRVRUTmZzN3RYeFhxcm5DZHRhQXNkbTNuSWJMVU9hbXRCSkFLZSt3?= =?utf-8?B?SnRHcmIrY0ZQUDB2N3h2eDJOV2ppcHp5NWpUZnU1MHVra1NkZVVSeVJIRm0w?= =?utf-8?B?cFRRUEJ6YWdZZ3A1WVljbDRUUXhkYVVnc0FybFFFOWNHNllUY3VuOE1RbHp4?= =?utf-8?B?ZnJXS3BnNENHMXVyWUNHRTUyS2V3aHNnVnltSVRMWU5XS1MvUnlLTGVDS1NT?= =?utf-8?B?dFQzUVJqVkVLbVdMMExha1kzelo1TTBHZEF1VnBHM2IrS1YvNFVqNGpDZ0Vt?= =?utf-8?B?cGVlQzlGZ2hBSmIvcnpuQ3lvOU1IeWVQNEh6YmRSZUp3YTRjTlpCcFJYNDRR?= =?utf-8?B?V1FuNkdJV2NmU2xIMEZBalFSczZ6bFZXeHduNmZnZFhQSXptYm94TU53eFBC?= =?utf-8?B?YllCcDd4RUNGb2szcVBOS1hEZnNJTUlFbXBnd0Z5eCt4d3ZNL29PMmUrT3Yy?= =?utf-8?B?MGQwNENHc0dVRXV4OWJ2WXMvbnFKb2lVSkpONWIxM0Q5M2tDRG1nODlhay9k?= =?utf-8?B?ci9qdTdZdWcvRThUazRiS29MUkJhTmR6L3BTbDV6SUNJTHpPbFdZTldHaUxJ?= =?utf-8?B?UjVkU0FXclIxM0dLS2FFUFpHNnB5Vk1tYTNWSWZpUlh2UldBQ20ycVZJZ3FS?= =?utf-8?B?RjVrL0MydSs4NTNCbDJ2WlhJanpOQXVNelEyVDJCVitPemVJaUxWdGhJRHdR?= =?utf-8?B?d3VHMHBRZW5PV0NuRFl5YW5XTkN0ZnBBeklnQ1RHNTB0aHYrUi9JZ2k2MjJH?= =?utf-8?B?NzYyYXBOV1NLYzNGL2EwS2FJZHVQcVcwdVNzc0tSU09US1NxcW9hYm5QQjVy?= =?utf-8?B?TTVJVjNXS281Nk9MWXJwUmgzM0dZVTJ1M2NvbVEvYXNBZWo2V1Fwajd3SkhF?= =?utf-8?B?dXBWTlVjRWhBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHp2cW9PemZCbno4RktGUEJQTitBUjhJOXBtL1FYeEZsbWc3ejdFWVcwYllN?= =?utf-8?B?ME0xRUpEZTI4WDBkcGFqeFlRYUFHQ3JMNFh2NmVPUStUbGsvcy9VQXE5WXpo?= =?utf-8?B?Y2JiY1Y2VWdZQ2xhb0hwVVVLT3RSdTV5dDhJOWFHczE5N0wyd1BiWTd4MmpE?= =?utf-8?B?SWRoSWJ5MUI0TlNJb09lcUFtRXF0RHJ5ZS9kTENUZFEzbnRncGp1SE50ZlI3?= =?utf-8?B?TS82cjFudXJveGwyazN4TElna003WkVEWXZNOUw4bDhHcmFNdlM5RXNMcTJp?= =?utf-8?B?RnZJbFVpOXJuVkZ6aEQ1SkRNNmtjanJlWEl4R0tjQXdGTWdjQnhQNUF4a2JH?= =?utf-8?B?Mkc5WGZwRnViY2xqSGZMU0VEQWo4cmxOeUlTbmtHcVF6WDVPQjFaU0RuUHAw?= =?utf-8?B?bDR6clpMMjFNWjJqV0w0M1U2NkhJMnBHRDlrUFpieUcwa1RudUw1aHR4WXpu?= =?utf-8?B?cG9XeCszSXpUQjRqMGZtaUVGL1ZNYldDZ0UzT1VOMVRiNUFZTWZGbE5RS0h2?= =?utf-8?B?VVkwbXpuOERMQXRqREM0cFR2UmVJREhXUmZRS3R3cVhWRW94TVdYcWZwTTlQ?= =?utf-8?B?dFVvblduVzJSTVV2WkZoekRMR0lSN0ZBUHVNR2QzbGl0RlA0VUx1Uk1EaFhJ?= =?utf-8?B?Skl2VFZSK1pDOHdyYzVUSlpIdjUwL21mVjViUjA2bGtqQWpsWklVbEV6WHFr?= =?utf-8?B?aDNabnJZcXl5Q2ZQZzlNaDc2NGo3NFk0RlhBakhhRXN4U051UXZCQjF3STZk?= =?utf-8?B?YWgxTkt1bVYxbGhPQmMwLytieStXcjMwbUdMeFFEK01SLy9tRk1XV3ZCaG9m?= =?utf-8?B?NlRFT09oMG5ZOTdtS0o5NlY2aktUOFNZQUdhbS9GcVNWNzJ3SHJDT21hU0JG?= =?utf-8?B?d3VSajBTZG1MVWhkTSt6UWpQcnVwMXc5V3RYeTJaZ091VGlGVkhYQnZiMjdZ?= =?utf-8?B?YjQzbGZPaEFTdE1Jc2RJYTFDc2dzOEdBdDlBL09icktXbThsc2JodXNjcE9w?= =?utf-8?B?dU9mbnhMUy84QzJjWHQ4NytFTGZsS2xkNHNBNVBWRUx5VG5xdEV0VW9Lbytu?= =?utf-8?B?M0NjclA1VHcrbVg2SDNOM1h3WTR5N0lESzV4akY3dFN4aUxDUVJRcjdxNGZI?= =?utf-8?B?bGxCRmdud3RvVXJQakUrWUlWKzM1TjY4eDJlNGVBUjBmWFhNUG56WTM4MXhY?= =?utf-8?B?Y0Z6Ni9peUs0Nlc3RjVsUjNqMmsrMTF6bWRlc0NoK05hOWNiUi9MTHhBMHNv?= =?utf-8?B?enBLYnBiaUdsb3M5NGdZM2N5RXFZb3Fvblh5Zm40bU1PRHI2WjcyYzllVnBS?= =?utf-8?B?SUNhS3BvUjBZTmx1Y25NYWUya1dLVk55eWU5bXdFY2tHbGFrRERoSVB4Vzcy?= =?utf-8?B?ckppVTNCTmNKL2tnaXpEVGR4S3RWOGxuYzI3RHRuVWdiVWJiOGhleW0yd2lV?= =?utf-8?B?Tk92TXBvVTM1TElKRWpHblgxY2k1QWE3eTM0WE5WMm9BRWNPNWpPRzNjZ1U5?= =?utf-8?B?ZnZQajZzOXRUbTdZOUlTQWdQSUR4SnZaMVJSbXFLUHVWYUtlaS9iRStnRGM5?= =?utf-8?B?MSs3SDQ0czVOKzlLZHZUZG90ZFA2ZmxLakhrSXpRM2dVcXlzWkw5aTJsczRw?= =?utf-8?B?TURkNExLcEJzdlo0V01DTnpLZ00vMmR1dnRSSks4THFIZ0NRQnpTUTRsS0ly?= =?utf-8?B?OE1ZRWJMRVJRNmsvRUdpTDVoaUxFemNQdXRJMWF6dk8yRUk3MmMrcFdWS1Zn?= =?utf-8?B?OWx2ZWtmTFljUSt3Z3FldTBkVVFSTVJrNFZhZTZ5TWgrVTN2eWRqQXMwTy9y?= =?utf-8?B?dlNvVDNMMm8zU1NUekg0QmFrbUVjUFpGejEzeHhYanVuWUhyMzdSRk4xWm10?= =?utf-8?B?NDZxVHQ2bXYwSGdJbEp3Q0lSUSt0SDFnT0ozeE1QcFBRRjk5SkdHeTZBaWk5?= =?utf-8?B?UXF0bThRTnlEMEJ5TXRJWUhMYjVGank3OUpvMVB1MW1yS2hqMWRSZ1ZDck12?= =?utf-8?B?NzBVN3V5U3lmbXBVK3BnU2Zob3BRZzFYOVl3YW41Tjl3a1k5NzZ6WTBCK1d1?= =?utf-8?B?SWEzaXMxV3UxeW9GWkRGMUJnd2dMb0phNVNQRVh0YVg0ZjhqZ1FWbk83b1NB?= =?utf-8?Q?cg/h5FEdxTGgdKFrYzVyp1rDv?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c455295-9197-4e68-5b11-08dd26dd3092 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:16:00.1862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eyY8PCxEPmljJos9fmkXDE7ay/AXbvO3S/dSe9oHFq23WNU4jI7bbcKJv2IUy3Ml6BGmWmYN3Rh+bC9u3a/InQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-pm8xxx.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index 2f32187ecc8d3276a451a317ab83446b7b04ecc8..f1b620b168fcca8c640e4beaaf7= e8c17776c5ed9 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -523,21 +523,11 @@ static int pm8xxx_rtc_probe(struct platform_device *p= dev) if (rc) return rc; =20 - rc =3D dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); - if (rc) - return rc; - - return 0; -} - -static void pm8xxx_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); + return devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); } =20 static struct platform_driver pm8xxx_rtc_driver =3D { .probe =3D pm8xxx_rtc_probe, - .remove =3D pm8xxx_remove, .driver =3D { .name =3D "rtc-pm8xxx", .of_match_table =3D pm8xxx_id_table, --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A530513B280; Sat, 28 Dec 2024 01:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348573; cv=fail; b=Xv57axFwenmWc4xlN82Ph/YeIFcylA+BCH/DKMA17Y9TnkS3hnYFPTm6+Gng5e9EFT44mHvnmzIKD6CmeASfRixetbdvhwZSbjxDXlS9pPPTy2rg2ylrglWacjJ81NDm12SuS7XCFBApyGM7n1x+jEr5JAV7vteLzZYZhxDymFc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348573; c=relaxed/simple; bh=OXuOFfUQAHPfSnRmpga8T/NGjVQFp8ksF2HNRG5PdzQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iee/Rix9YQ2VH7C7AhnDZ8plgwJfzNYNLL3olGjeV/v2nGCDxEW/I1UeL9kktO4LeEfm/1phvHfBJXgdCgFuyd3irk5URb7QebZ8uuv1ZxQJ6vUJCTsEH0oAJN1VDt+Qh78RApsZUBdUoNECwa2Uyl1flxYfNqpuLz6e45348qA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=uG0Ep0v+; arc=fail smtp.client-ip=40.107.22.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="uG0Ep0v+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CZ6gdXIPLfjHHP2y67U3hO6zvTNAt/t+5ja0q1RDQtY8T7ZVo5AnpHuMyajXYxA9TSffBjaZMdjzP5G68/3cLvIg+HPibX/IuLpWVCGSldWjizgTuglhQrBElvb2Sa1gYdwSjlY2OS1gd4qQhKRUwI88vUEKWcArbDl/KCOuNw/PdAweHf0tSkkdVt0dmXQgZOQatWZ3xtRqdpvOnsXBnxLDKd61aP+OFyc/BkcEMam0FVTrrcEpdq2IUZgvFU00JcJW/7AqGj1+rIuhguhIHtK/7UlXz5repTzsVaKYJIouyozGQQGP14kGO6V5qAj10yUx0gpk54FpDCZUUj1q8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AlobrdkVfX/38MVJCt8Iq+/b3rUpD0WjleMSu5zbIM4=; b=cbKKdlqxlu4F+RwOV3FNhP2MVOYZOvPxDjpQ28hAG9hPT8htRhfHHWoeJ7sODHCo7dKEtvG+UgHqzIU3mvc5VYWOTcvLr6vBA1yPzV/UkkhYWezIInGWlc4RHJfn3Ep6gDIpDnIjvjJ0s/hhBFKGIRB5pdNIRZE0e37ECLcJQwwNJL1kbQbsTTue2GlU2VSfi/JpYhInFSmMzdil7fbrZHwiDOmAeCAMbvp/oivX44uPSFIzvHBqvKNoVeAaEzKrk1j+pg++vhpJblZFrPF2Q1uC224PgpFUkI5b4MqHsLk6So2Gi86N848+9Dq7JkhKwi77/yI5n/VC9Wt5A+RUGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AlobrdkVfX/38MVJCt8Iq+/b3rUpD0WjleMSu5zbIM4=; b=uG0Ep0v+6QTXMa1RdhceJXxdlnGtB9jFpcBl32bUXTUafyTVd2k9XQ7O6ti8rtqw8p/i6hV3UXWrDDRZ/OilXbmmk9JyX7lxYFYECbI+o+m4uxZJvrx55Omeygok35IO9gYuZ12UrT4cX5lm0htNsiz7d5r5TvU7VgCw2BpRoJPP6TzjQVFy4ZnzB8kWVSk8ISvYneurx23imGwUWrE2I6lNefwVmtLlHYz1QnZMbVsVZOruvlXQqVlpwTd+sBxFt017IL8sr3GXgvfL6edpPZogqUeK6hd619vnCvkRJo/u1HwFF7caP7jFwxVxX2t64jesT1d4p/uf542U/s6T0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:16:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:16:05 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:46 +0800 Subject: [PATCH 10/12] rtc: ab8500: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-10-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1542; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=AVqWXSH+9LxOuTXtwUAoRCUt6CUhlH/6QudqZPFpQdY=; b=RhDPsrgbN6Cz12kt87YwDpCKRz6gWnKaN3fVCGjJ3KW5nlRvnx/OLvu3OgFY4hlgaM1G+FH9v hEr8JDrMVBOCCgZCVbKmi6wbwHJhfmvFo2Vahlk48PpOT/3Z0XdrW46 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ba8a545-524a-4099-9954-08dd26dd33a5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dGFydXppQ1RXQWFlcE9HblNBczRzZUJKeFFRMUQrRFpWemE3Y05lb25Wc2Mw?= =?utf-8?B?NkIzL3ZBNHRQcW1JdFRLck9uMDFwSmRFTEs1K0NZTHNBOTJoUGdhMmJGekZZ?= =?utf-8?B?VFR6NVpRR29PQVM1dnRsYmV4eFBMNnF0TFRJazN6eWNNcmZtcFRqRHZUcnZv?= =?utf-8?B?TEFoSlMrQUFVTWt2aG1tV3crZmxXcW5ZVTFzZzJYWnpLcGJrRThnOEptdzlo?= =?utf-8?B?QTRiRUhVenFPUFV1T1ByZkkvdnRCd3h0YzBCa0hSMm84S0tkQnNNcnZaZjVC?= =?utf-8?B?bkFiTWg2ZkR4dUFEQWtsWXA3Wk5udTRKbTNhMXJxQytJNDgrUXBIVDk5b0ZK?= =?utf-8?B?amVrNjh3Y0Q4Z0dqRjk0OFlVRkZoSHBGUWNHS05kN1ROSG5JbkJRVVNVdjVT?= =?utf-8?B?RFhLaTU4WkthTEdDekxrZUxvckN3Q2xBWlFPMDhGMmVuSk1VZVRvTGY4dzRl?= =?utf-8?B?bVl4MUUrMUV4UndGUGpmemFUQ3lRbGJYc0htcEhrOElYU0VkUFdFd2owTFhv?= =?utf-8?B?MVJZdWNqdFFhVnZuaFJpUHZEUGJyZzFmd3AvS24wc21tQkRPNHZiM0VGT29t?= =?utf-8?B?OG1JQTZnajdYNXhYcFZiNzR1STE0TkE4UTB5V0N2WGhmVmJGVE1xaHFOT0N1?= =?utf-8?B?L3RLSGVvR1pHVEVPRHQ1VVRlZ1ByVGVHRVc2RXdKd0oza1B2ZGFwcXd0TEFi?= =?utf-8?B?UU92WDZhTHY0RWVGK1lScEFDUXRmTlZtalorNnhyKzZYWGU2ZjA3dVdibGpK?= =?utf-8?B?Ky94ckFzckFOTUhBbTlGVS93bHh1SDNYSDczMCt5dTJDa0ZIRUVQYUhxRlJF?= =?utf-8?B?R0IyYmpxSDk2bVhzcmxnL2U5VmdNN28yZUFFZlAxNnBtYTNrNDdzVGRLeTFw?= =?utf-8?B?cTJwU2NKek5BaWErQUZ1b3F2WWN2QzZiM043VWc5THM1aUI5QnJ4UndhU3VF?= =?utf-8?B?VHlWWUxXOTU1Wk43SUUyS3pSOHJGVDVMbHBNMW5HUEI4bnI0ZGZ4OFRESzJP?= =?utf-8?B?UnVhMi8rbEdIVjMrNWZaRGZsZk1Lckk4eVB0ZVZqYXUrcjdkejZyK3ZJQSsy?= =?utf-8?B?Y2dGd1JBNE5GTGs4STZvVW81MG1ZOVQ4YXp0QWtpK3pzMlZaZm1QNjFVZFN5?= =?utf-8?B?WnVUWGorVFRHRXZEZHdObXdhK24rK2E5YU94dVNKMUxKSktmT2kzdzZnN2t1?= =?utf-8?B?UXRZVG9JRTlwWDdiazJtcjBjODlJTk1OL2w4aXhVZW5hZ0xCc2MyUVpuWVpF?= =?utf-8?B?N0dra3VxcERKbzVUSCtLQnRVaThxeGNvdkxzRE5YZm13UFNBK2lQOXBVWlhq?= =?utf-8?B?UHRQZkxMWVlMOGFlK1M4ZWt4MXJWUGRSc1pFeU1yZGtQcmwyNjZCZGxCUFVP?= =?utf-8?B?RmJpcmZJcTJMd1dpUFdCREVPc1VRQnRQSzRoYjlZMkpibGhkNlQxcm1xbFAy?= =?utf-8?B?WHZlZG5nVk4yVjFIZEdDOUtRK3NFU2svV0RtZGFXcDM1L3l5VVo2LzlhbkV0?= =?utf-8?B?RGszcGVnZjdLd05ZOHoyTlNMUjhnQ09IVnFUTXZxMHBsbmhWUXVKeUtoWUxS?= =?utf-8?B?WXhsdVdVK0RWSkxydXJMSUxiR25CSUtJcFJKZ2FtNW81QkVob3BERXhyN3dQ?= =?utf-8?B?WEIwSktmNGdFcHFNSVNzUDhZUWNZaGpKZ2NjRHFmVWdzWjNSK3ptamVOQ2Qv?= =?utf-8?B?RTBBVjFNMmZTbzJsSGRHYXZKYUl1ZlJHYWxVQlltRVVpaGJsZFFpRWhGYjJQ?= =?utf-8?B?cUJOWmJzT1Y2L0tOVlJIS1ArbmZFVkU5clBuTTRMQ1hhbUdVVEM1aWVyZVds?= =?utf-8?B?bFU4WFFGWmI1UzFEUGFxalQ2dUFXV3FieStjdnRQejZud3pKWjBSK1VEMHJ6?= =?utf-8?B?T0wyYTN0MEZid01mL3pCNWczV3dZSzVTS2c3cVZ5bWNVT0ZYa3JHbloxQ3pu?= =?utf-8?B?ZWRTZ2dvcEZLQlBEWTZjbnNpQ1hmSGlpR0J5QzhjU29QTTJMWHllSDlQSENt?= =?utf-8?B?QkllWm9aNU93PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmhTZFNXOHlLQmJUN3p2SVhjSmNKZnV3Y1ExcVU4ZTFMcWNrZjY1SEU5dkNC?= =?utf-8?B?bkhhUzF1RC8wMGN1WVAySndUVzVsT091aEM1YVUrSDZLUFZhSTZobEQ3QVBS?= =?utf-8?B?SFA4S1RVK2dkZVJMaGxjRTEyczhlYndOQU5TUlpXa3c2MmlSNjBOTGJWQWhU?= =?utf-8?B?YzZBbE9zeEo2T0U3R3dPaU10OHZKNERlK1ZSdzdmRWpWa0xmT08xbUNNOWQ3?= =?utf-8?B?a29mMzY0M2Noc1N0MUJTamJYSDl3eTlWNjIzaGpxT0ZoSEthVm5SQUMzbW1B?= =?utf-8?B?ZXNjQ29zYVZabVhTVWVoTHQydHljTHlYQ24wR0FOellDOE13WERQNHA1RUk3?= =?utf-8?B?RlFvWloreDMra2dZbXFGd2gzY09vVEhSemRpMDFwdWFjdUovU1liK3QyZFNz?= =?utf-8?B?QjhBME11Tm1ZdWIzTUxHMHlQdCs4OEc4UzdkVzBGeW5DZkhUZ0FXNUxNSjZa?= =?utf-8?B?emRBQ05CQ1A4Z3YvanV4U2o4SXBJeFVYZTNmZklJVkhiY3lmWXpsRXFyQmZo?= =?utf-8?B?ZzhaaVNmMkp5TW9mN3ZaUjZ6WnpKekxIWExSTU44akNKZUlHTGtKVjg4ZDM1?= =?utf-8?B?VFBsTTM4RnorK21NY2FRQzJ2NnYyUVVNdXVSZk9RcjdEOHJEekg4aWFnR2Qw?= =?utf-8?B?K3d5ZlJoRnBrdnNJakh4dk52Q2pEcm5ZZSt5eXlMRnhacmJ1WEtKaWxEWjVT?= =?utf-8?B?VEhPaCtNT1VxUGlreGw3UTYva1pmVngyUDdzQU11YUtYY1hScDlERXZYeWV5?= =?utf-8?B?MXVMK08wTG5uY2dXckVVbXFxTW1TYkN2RDk4SXZSUGZnaUUvRUV0NWFha0Zv?= =?utf-8?B?dzRPN2hRZm1LQk9CQzdXa1VoOVQ3ZzNPc3pHdGRWUDBMb0tFdWVSeC9lOGhn?= =?utf-8?B?bGVDMm4wQ2UwMUdYMUo1OFFrS0FOR2xVVkFTY0tvei95bnZOVDVyckhSS2p2?= =?utf-8?B?d2tSZCsxZ2FiVWFINmp5cnBaUmRSVTJUNXVZUXFzOENxNGx3K0xzNTBraUp4?= =?utf-8?B?bCtFSjlCdk1CamdmTmYrQWFGb2hUOXBIUmVjd0RhZVp6RGNtdm05MzZpWlVx?= =?utf-8?B?T2ZTYTZ5SWNiVWZaNC81d2dFYlV2bE1sUHdFZEY5UHRjSnNZUGY2MXB6MTAw?= =?utf-8?B?bXJITGdFTTM0T1dNcmJMT01FTUxwWjJwblhNWk1oMU5RRE41NlZsYXhmUjhY?= =?utf-8?B?NnM5WGRLaG9zNm1VZmRqdUN6bkdBekVCL0JIWHlRTzVCbW1hK3Y5SkdzaVd4?= =?utf-8?B?R1RtM1ZPSE93c2ljTk5YeEtIVmM1Z25GLzFZVTBvejBPemcrZUk4dWtwV3J5?= =?utf-8?B?REc1emVZaHM5eGN6U0FxR05EVUYzTFdpRUZmM1g4L2tSb0w4eCtjOVl2dis5?= =?utf-8?B?UnQvK0N1VkpBQVo5RmdLZHRuOEkvUUcvWWJVWG1udTRoVitBTWtNb0ZKem5Z?= =?utf-8?B?M2xBVHBZSVlxV1pmZmNsT2JWU3RoNTM0cERlRFF4RDJON0M1Z29laUNpTmhv?= =?utf-8?B?UlMvcDhJRUErYWoxWHFkWmRiL3N6N1pRR1lvNzd1Yk12bmExdEYraS8rRHNU?= =?utf-8?B?QWQxSGFKR29Mb3ZXeVgyeE5lNG9YTGdJc0EyVHd6MUpsa1FSVTdTWDU1VEd5?= =?utf-8?B?dmVlSnhlVVNqRzFjZzdHQmVEL3dRcXAyaDF3bnhtdG4rMVVFNWdJS2JLeWw4?= =?utf-8?B?MUJCd2FMdXVCSEc0U0YydWh6eVVzdHJDSUpuQ0FRb1ZaRkYyVG0vRkNPOEFU?= =?utf-8?B?akpleEx1SHNkaFN1cjBlWmgzQXd4RG95RWlRR1Zab2svTFRQOVViTDVzMVhj?= =?utf-8?B?UGIwK3BLSDJpRGN3UWR5ci9ZMDUrbkRsRWczbmRGNWQ5cUhGM1dSQ0k4SXR1?= =?utf-8?B?VjJBc2Q5NWl5NGkwNVVqd0p5RUtWOXJhMTV2TDBNbnRiVGRkcVMyNnhNMllq?= =?utf-8?B?aGQ1T3FKaGNCTStndzNrV3ZkVGlkWEhEbHBSTy93RzBiMjUxUnlIUFFCdkZs?= =?utf-8?B?T1JpV0RQRkhlUVhSQkNVbWVDcnIzd2k3bldiMWlPa29hUk1uaFF1Y0R0cTJ4?= =?utf-8?B?aTRlSldQdGR5RmhMdWs0bnpIVG9MTUsyc0FmYmJJZzZZY3YzYmQxb0pDMklt?= =?utf-8?Q?0/Zi/r77AnEubdYb6zF4c6fKw?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ba8a545-524a-4099-9954-08dd26dd33a5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:16:05.3762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AKaSLTWiob+/xhXPj8ShaJViObRyPTr6S09bGVRj0rjn9e3njfuuP7OgrpdyUqGfKDiz1EKdAgxuKrtMPmmnug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/rtc/rtc-ab8500.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 2dcda96f4a8ef727514c751322b84d8d2b382b75..ed2b6b8bb3bf8f99fef9f8bee96= 76f71f8a86d2a 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -361,7 +361,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) return -ENODEV; } =20 - device_init_wakeup(&pdev->dev, true); + devm_device_init_wakeup(&pdev->dev); =20 rtc =3D devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(rtc)) @@ -375,7 +375,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) if (err < 0) return err; =20 - dev_pm_set_wake_irq(&pdev->dev, irq); + devm_pm_set_wake_irq(&pdev->dev, irq); platform_set_drvdata(pdev, rtc); =20 set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); @@ -392,18 +392,11 @@ static int ab8500_rtc_probe(struct platform_device *p= dev) return devm_rtc_register_device(rtc); } =20 -static void ab8500_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static struct platform_driver ab8500_rtc_driver =3D { .driver =3D { .name =3D "ab8500-rtc", }, .probe =3D ab8500_rtc_probe, - .remove =3D ab8500_rtc_remove, .id_table =3D ab85xx_rtc_ids, }; =20 --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB77E26AD3; Sat, 28 Dec 2024 01:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348579; cv=fail; b=pL4XfofQkuOIZci5ee1NGWIhmL+7+nKxbx6r1dkymsEHdiezcduMRTN8GDQ4fypZI8Xf//2MMDameSOMzug8/8maW8vmDwvk4qAq7usPLl8JjVqtDGQW8HyquMxjhQwV31joHHsF8MUaD7rnRj68RB4Acxxu5YwQ7V6aEmetlfs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348579; c=relaxed/simple; bh=/EC8zCoNiyDgYUl3GWxR1c0E1R02p9BWvo/Wx1hJgus=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iFkmjSiCsSUPQOIrVCR/DMJFVlVtbVTi0rKCUdmuvqSS9PNSf1SsYIxZ8FhT4TKT3vCgO5qcZM41jdkknjMbdTW046Xjakz68Eq8r0+PnjzecG8q8ibxWJl8H7Aw3dZdFjg55bYSUxFd42looUknE91eiEYKmywWjIciLCkwdaQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=L8NSaMO5; arc=fail smtp.client-ip=40.107.22.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="L8NSaMO5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v7BjqXQfM67sPkUVU8p/a6OUUzCONkcGG9JgkMe/PmMIeQtUivzj/EnG5J50tDl+/wFg4/ca4MZSsNPzSpOnkVzyt8Ren4XSdguF9vgwHPQy/xMfASSO1b8BtxWznwOoJuQUiIYKnAzzVFMinJrlwb7rF9CLD3+4YHNgvonCaN9xjLriv7Yb2UJk739Y+GIBr1t/IuUP6Xot0bi6yDjhNAhS0BbmMgS3k+kzRHFqV/ULzl475z2R+5uhk4fZmq6eKrV44uxX2mySIo38OwnK/G6jrPKlkewmTK5lrnZ469jcJ2z1SRSUwccGlaet0GQClx2SatkzjzpV7sJGlVFriQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=jUi4AC7FKXkStWkLhMCJK6ITtvAugeV+cOSxWiwaW7fmenKLpYY7RPq7pOAoiFeHscel61xZEdpW3AoZaTFu8DAP5r9TVBKHG43zatdo0tB2sHfWtZ/KsJ+cs4zXyr4U9t/eX7gt71dKF5Z939vD3hdHOE2qDQQA4/qyEqSw37EmUIvvDV4k8/Sq90vPBMYmXg8uAnffVqtIkmnRiAIksdgiWDYBkxVurxjofSZn7uFnuOhzL0hql/fbPVOcwm34TS3Nr4PNfMqvdMnSrRmmuP6TanRxN2P4i1BKCchadoI04RLl6SU8Sp0rNgjfXpsULbpwwh+XQCXGVmE71pD4aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=L8NSaMO5bMY3D+ZNNkX9P98p8/aWXPNZSbUcdrvrKlI9jvJU/QAcn4ncVGKm0wr5VJl4PODd8Z8bSxohG2Bv6H2xbDR2FiaTcRhDaKnVscLVzmdERpDo/D0KkHZ3ij2ByV8+AfigSM/NJplkxfWVUMF+iulhDX1GirbPETfffm38glLKAVv2nmEwrWdHbr9JAePm0x3pbdH9N2zvrALFQsltQRPzI1mPaPrMhFsjVvxJ1um6qeF6Xy8Iihm37xTClw1ewV8Sfj+rKurPmyT1v+wYGpMtcVeq/1S0aTtQfFdIjDzvPC6k4jpWTq4YI5j2fFS++lFan0D0yOSC9CBlIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:16:10 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:16:10 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:47 +0800 Subject: [PATCH 11/12] rtc: mpfs: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-11-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1347; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7sZhYfT/a75JkuPsULgAYPAtV5pnc5lWQRqy0mNIenc=; b=C02+WNqxKfAAf7mHi9bvaN45rY3SyyhH/d2aF3re2z0PhFA27PAuCbEo4WSccOkmHtNlPz+yL QsNBVl1prIIDgaoDXhtnsXPRGmUvFDBevQHs2g7/KFmxAsUGG0hhVGu X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ef3df23-780b-404b-c7b9-08dd26dd36bf X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NGtiemdmYkk5dUxxUVNadUVVV0lOVmphODkxazBJeDhsaU80cG9GNUQrWUxq?= =?utf-8?B?bGtTVE9aeE5lVHNSSzllWmUzQUhpYUNqUWxqcUJadE14K2ZndGRnOVk3STln?= =?utf-8?B?YmY2Q3U3NGIreVBxU21neVp6UitlNDRaUE5vQy8ya3lzRzJkOFRRTEtVNnU5?= =?utf-8?B?R0VUMWpLZUJKVUREdGo4L3dsekY5alhSS29heHViL21xVzJ1cUpnNU9aaDFX?= =?utf-8?B?WGNxQ05yTWlkalVyT3psQi9ZeEwyTjUxMVlxK2RvaFNxQjVSQm43TG5YV1NR?= =?utf-8?B?dWEyMHFrUDFGZlJJWnJiZVhBekFKUURtRzVUa2tvZ3dDRnQ0Z0dSK28xc04y?= =?utf-8?B?aG1SZ1RkbGtpWDdnNWc5SlBnZXlCWmkrMmV4SlU5T28yc2xWWU1NUC81Qmxn?= =?utf-8?B?c0l0b3Q1eThnUEpJd1NtSE5ncnRoUGFCdDRBYlloZlBDN2p4Ni9KR0wyeTRM?= =?utf-8?B?RzJLN2UrR2ZEQ1BtRTg0RWNwOWZEekcvVDl6MVpjWFNLQUFIU08yK2F2aWFz?= =?utf-8?B?SlBBVnhqa2t5WHNKb1JyUVIxd2cyR0tvNUR6WlNxQUVjb1ZDMmVRVFoxc3k5?= =?utf-8?B?OHpNaEpHeXpTSnRPRUxnc2hDSkNZdXdxR2RrcmpwZCs2UWRnczB3SjVPUWJ2?= =?utf-8?B?dEFDZloyQU9tRnBHM0RUQUU3ekxtbVVBNlRveUltOUtPMmlNeHBRVXpNQXRY?= =?utf-8?B?V0xHWGsrSGExZHFrbEM3R2kzRHhlODlHOXNvblNPQTFScjJnZ3pKWEdoMUdR?= =?utf-8?B?WFJFaVJnekc3M1liSHBKODJQa0hINUdSdFJLcHJVTmIvU2JjaTQrWkVKV2ZQ?= =?utf-8?B?R25ya2Qra3RSYzU0dUJyazY1b0xmTmtMM0lNWCtKTFhJUHhBeUZSbzd1Q0Fp?= =?utf-8?B?bUNKNUw2b1N6ZUpmRTYyOTJMdDgyeEU0WWxpQ0plME52aXJ1azZyNVNSMjNj?= =?utf-8?B?M1NQUzhXblZRYXRTVGRHWGFFTUp0NEtBelpveEM0Z2p6cXppclJ2dFU2eTlC?= =?utf-8?B?dk9xUk9nRVdBdVJHNEtSL09oYVFIbTZqN0toUXJRbTN4MmRNWWRidStZODVZ?= =?utf-8?B?TG9zNUdnakppOHM5Z1U2enFiTzFzQTVoSVVLM2pGMWFWQlYwdVYyOFZSRUcw?= =?utf-8?B?WUVud1ludmFyUVBXTUVUM1BxYS9HcGl2bGlMZEQ2UnNDU0R5a1d6YTVsK1lS?= =?utf-8?B?NGl5NndROHgzeGZlTEVHVjNzRXdmRGp5d3I4dVo2dW5LSGRpWjRMMEtvZmF1?= =?utf-8?B?K1dQSmV1MEhaeGl3SEorZ1lmamhTMWw1YTNSY2RUblM2VEYwQmVLcWdUMXN5?= =?utf-8?B?YUV4azkzTVJtY1dXVEZyN3FpREhzcFpMeWt6djFIREtaYVBKVkhCejFuNHhQ?= =?utf-8?B?Y3RvaW5oVDdkUWs1QkN5UGM4dGR6ZzNwYmlkZ0tVQTA1M1ZMdE5zdjFFU0ov?= =?utf-8?B?OXRncUQ2MVhxdjA3OFpUdTRPS2tVdVEvQ2dwWW5ZdktwUlNzMHQwV2lzM1p5?= =?utf-8?B?MXViNk1wNGhJWUg0anRZalNhQWF0dlk3RHZYU3pEdmJvSXFFcERRVmZwSGNr?= =?utf-8?B?N09vRTZXOW83R05zR0U3V3JYTDRBa0tTdzUwWDJLWmx2VC9NVzBjSm9IZVUx?= =?utf-8?B?eWlKRThhNHBYbUt0RGxHUlBJWkNqeER6eVlNU0JTdTlaTlg3dExtUTJHMXNY?= =?utf-8?B?Y3plSXFwZ2xBYnZyMUNpUjVDbkJkTWVLMVIzR0JHN2lTR1BMYWtPOWRBeTMy?= =?utf-8?B?VE9kVW52REVjS0N6MEc4NHdkUEgydS9ab1NxaWxFRVpBY3ROcHRvcEI3Z01W?= =?utf-8?B?OHp0Sm52R1VNUnpPRnFWRW84S09naUkwY2RieHV2ZEVROElzN3JmbUVwMlZB?= =?utf-8?B?R3Arb3IxR255cFhaOGwxbjMzcGFGMDVvNFhHV1FieFlSWkxCdnZKY2xKR2pV?= =?utf-8?B?bTVwWDhwbng5a2RyZUd3dVRBUmJxakJwSVlQaDUwUloyUjdwQ1Z2UXllRHN4?= =?utf-8?B?WFBDOElVOFBnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0c0NkxpSHU4dEsxSHI2Mmp6K1pVS3UrcFFxb2loRlYzdzkrR0Jyb2t5cUNT?= =?utf-8?B?aHJ4OGNlbXZDMUt4YjdSa0p2RUF2QXArYkgvclU3ODI0OW5kY1lSUG16M0ph?= =?utf-8?B?aXpNdG52SCtmQmRnVElyOGJpZDNlTm1kOXE1c29JQnhsQ0xyazg3L1ZaUzhq?= =?utf-8?B?T081cEM1dzA3d0ZKVkxFYjNhb0FUUTdUQ0c5Nk9XVUFhUmxmR3dtVjVkV2xy?= =?utf-8?B?NlhRT3pUbDZ3aXFZRXN1ZkdYNFkvRElZS0FTak1qbmNVQmJBWml4Zmg2c0ZG?= =?utf-8?B?YmtoZ3RyUFNERTltN0FjNXdFL1RacHJZZXZtNzhSQk9GSTZBdEZlMTRlMEta?= =?utf-8?B?RGlSSlY5S1BCSDhQWjZGbzZIOE5RcjQvcVNsSEZ0U2JJKy85cW5aMzMxdTZQ?= =?utf-8?B?VzR1YVNVUmJ5S3JSanpLeTdrRXNPQjBTcXJvU1V6aThLSHRtd1RRalVxZHA1?= =?utf-8?B?M25Cdm5iRmg5QXlZL0poNDFRb2dVZi9iMkk3YVlVb3RIbEdCYnI3T2xlR1FK?= =?utf-8?B?RUhDVWd2TFhIbHFscUR4RmNEYVBpZjkya1V0VFV4S2Z6T01oaWg1c1FVNVA0?= =?utf-8?B?OUsvWEFMbXBYQWlBQ1RqVGR4TW1CcFVUeXB4dkd2REVtWmFreGtsUGRxeXRy?= =?utf-8?B?WnR2eU5LQTBtazhMYkExQ2pTZlgvUHloMTd5WEdBY3hlSHJFd1pvTkx3K2tj?= =?utf-8?B?ZDcrbmJnK1JXVUl3TFRJM3g5S1ducTJIbTF1ZFRRYXhKZWI0QWY2SDNaajgx?= =?utf-8?B?NU1jVDhnR0xFTGtTQmFSZzNJUXk3a3gwZE8wUjNSRjlld1JRR0pxeXlGdVRN?= =?utf-8?B?SURjUzlyTnBhTWlnZE0valIvMGhXSTZBbzB6UlJNQWFIcGxqYkhjYTd4OUtY?= =?utf-8?B?cjdMajE1QlN2KzREY3U5YWRJRWErbzVpcCtKK2VxdXJMZEo3dCs5anBHQUxn?= =?utf-8?B?MEVqc093Nm5EZWU5MmxWMGN5a2t0Z2lpeitvZFFGRVRrdmRQcXRCc2psdVFU?= =?utf-8?B?NHVMMnFUM1ZWYVdnbEdhelJmaHQ5U0VtK3JhWmdjTTB4eG5nQzd3Tm1QLzRS?= =?utf-8?B?d0ZoZEN6bVIraHhyV3krbzArSUQ0bkVqQVpncE5RZmVXd2dJSGlRM2RIaDU4?= =?utf-8?B?Z3hOWVlvTkM0bHBIMWIxOUpOdG1xWWVFWm5qQlp5aGpjKzdzbE1TQUNFRmFs?= =?utf-8?B?Z1J1QmFSdGxnb2liTS93WTZobmluYUtqWG4xUUJLNlg3ZTVWd2RTMXU5NHd5?= =?utf-8?B?Nm5GS3pvTkRsTUwraTB6NUI1MjlPek5uaFZBTkllbEdwZG1Rb2thRE9kUWRD?= =?utf-8?B?MkhjQ0VRWUxtd3lRam53NHZlQVlDamkrcUlJUFpEZjRvOGtoNkZNenVwdnlU?= =?utf-8?B?eGkzVnVNdjNNNTQ1M0tUbDFTRCt4YXRQTGhQVVhmVVJmMXdWSS9zVTc0Q2M0?= =?utf-8?B?dGtqTTJoM2E0ZXhVa3c2azZEWXdoV2Y4UFl5WllpVkU3MUV2THFBRERYSU9Q?= =?utf-8?B?WU5Vd0xjZHN4bDlWekpnSEdSSS91bDJVSno2KzNSbmt5eUpJYitGb0tsc1Rk?= =?utf-8?B?bm1tYVRlRElFTWpGdjMvTFZOMVVSd2wybUxvb2p1WUQwcTVCYXVBcEdoUXdy?= =?utf-8?B?VnRZaEpNSEhtUS9KUHhxVCtlWE51dEsvelIzV2NjOHBLZ3Q2c0ptQnArNEJn?= =?utf-8?B?TGZIUVM1cy9lbCtpVDQrckhFM2ZJVFgyQ3l5WmJGOFh1WG1yQk1qa21xQUZZ?= =?utf-8?B?RCtPdkR3MVU2Sm90RkpUeHdGT0wxTUFTTkp5UnA2aWhxenZuZk83Rml4eWhh?= =?utf-8?B?TXZhWktNWkFDVUpaWGhYYzZMdm9GMmV2aVdTZXFBTVBUcnNyNElxanlEWDYw?= =?utf-8?B?N2loQTM0VXU0dnRJbjdEenk5dWhGWG1tWnNxa1htL1ZtSTM1VmZkeGVKVTdh?= =?utf-8?B?SjBibHdEMXoyM1k3cDQwREh2SnFWZHhlK05GT25wM2xCa1BMUGlCS1pUNXdo?= =?utf-8?B?ME1QeWcyb29wakZNNFNMeXEveWFla3RRNWJYb0twYXBpMUdJVUE3UU1WWDJD?= =?utf-8?B?em92aEtEcnVxeXl4U3MwK1dlTUxMa1Zld3NacS9nZHZqWWJaY1Y2QXprUmJW?= =?utf-8?Q?Bi9wwXWxixUSbJY0l7xVzoye6?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef3df23-780b-404b-c7b9-08dd26dd36bf X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:16:10.5601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dSMkfeYsXxTgqcNrLWKeHIr3wkAYAF9gNGHiTcapqOUgG8r/cQkn61igxcVN+NC7nOV/kKRKGuv/LcA7+7L9OQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-mpfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index 3892b0f9917fa7bc4f732cfe2c2b2f548ba7429f..5a38649cbd43b3c6f2fec5db95c= 4f0013deb2a08 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -267,18 +267,13 @@ static int mpfs_rtc_probe(struct platform_device *pde= v) dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler); =20 device_init_wakeup(&pdev->dev, true); - ret =3D dev_pm_set_wake_irq(&pdev->dev, wakeup_irq); + ret =3D devm_pm_set_wake_irq(&pdev->dev, wakeup_irq); if (ret) dev_err(&pdev->dev, "failed to enable irq wake\n"); =20 return devm_rtc_register_device(rtcdev->rtc); } =20 -static void mpfs_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id mpfs_rtc_of_match[] =3D { { .compatible =3D "microchip,mpfs-rtc" }, { } @@ -288,7 +283,6 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match); =20 static struct platform_driver mpfs_rtc_driver =3D { .probe =3D mpfs_rtc_probe, - .remove =3D mpfs_rtc_remove, .driver =3D { .name =3D "mpfs_rtc", .of_match_table =3D mpfs_rtc_of_match, --=20 2.37.1 From nobody Sun May 10 07:14:29 2026 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647FD153814; Sat, 28 Dec 2024 01:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348584; cv=fail; b=lxn1yQwRrv+9m1e53b+/pBZOll2eOh1vnxCkg/PZyZyuuQPTPZKF1HSOxpSghvr3/+74iL/2Cc7HSn1oYCW7KIusvjbs9G4tJo8BlaRNnLM5EI4HV33DIuDlPItH5Gg1a4GCMgn4oU3RbhZtUqG74bLqDYVFDuBEe3/X3VWZMZs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735348584; c=relaxed/simple; bh=SnFy90xLWjBgBtav8pLuycb02r6OH0zBP7HYMzw30Fw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gbOwJtRK8NIRl4O+FtneKTeN+4T1HFJKdov8yEfSYOa4SrHeXQ3VkpPBNVsNa5NnlvOZEqS/p3yVLYq0WDtHNK2IjE5qQBrM7hhBxXwU9wS9oTsN1ggYzMoLjSWFbnkvv+16a5LuGymA/sJUChrDYJezgssaetgXNc+0UH8Pq/E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KqEwJo7Y; arc=fail smtp.client-ip=40.107.21.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KqEwJo7Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=icYCs2ZqekGd+37C3M70wSGEHi/HMxj7N47k06vMhgqNf3RLegI28GAMzILY36lrkRwRwHGOVm1xYxRMWhfi1RK7sOrE7auzvXlviX08nkVSiSJGzW6Epc3Qi8hQAJZ9Ww+l9jyg3t6fgxh3yesIl/f5l/PvT9LJ+H/ramAsd2PFqZzNFYNWMvYvY/7EwlvNPNjqAgr5sJTLNTLwGZ7y2jPITWGV7olA+RWg94m42NUxfpw3jED6+Y7PI814YBt+tujJKWs0dIzvXyjZQpInzbOmBoQZR4fWIhcM3i8pJ4TD3rc4u58SADmRVezauXlDzNPSp+c8OE1oTzefoMgrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SwP/Z30a82zAkoSfiP4uYDFRLsAZY6IC2N1v3ZTRi6g=; b=stm+2Gd5h+s0NxVf6Bc4aYom35PzbsbFxb9TBJT68vkguGCNVjpus5+XpcW4XaPfN5e8lLCupYocEaJvGAX0NklDzEfDiCQZNP+36nu1eoK6qvLjDJyzovcEmO37kkI04kpLhVDgKtKd9ylq8Ax6A+xn7a8OkdrywB/cxpUCuEb8zrl35Qx9lkqlbPW7rPHFx1toFCQjuYhPyNwM/zfqXkepZ/driT17ssDEFuigPsjZ78V9U4S9FZYEg8M7oy4tpoKbgEyT0Gc6hjDQHLwANiDKNQaeaAaZYnaCMzWN/7quyvIZybN1JDj2ppJ/Qyz0HgP3dssRiqnlHxwUmJHEcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwP/Z30a82zAkoSfiP4uYDFRLsAZY6IC2N1v3ZTRi6g=; b=KqEwJo7Yq93VGM33epmbmAouJdXGLda3Q6Sdt0z+hOHEeDX+ctzRAmeVQpWaHQH47WW+mCBLXpEfEZz6uroSsY6C50yRHReawvsjUyZcoxgS8+Gy0MtA2OE7ae9AQ4xjD6cTbntH/DbnsSHHhOxOHFqkzbr7lx/xNWoFNxjmMa8DQ68FjlneXWBefp9I+DaynJqlHiInE/Jq9YcWjmgVOtqFO79vJMbe7Y5r2isr5DLLd4Xse3q0UcxxaMPTRTIuofwp0mDHyF6jlq+E1HQA4ZirwNKcjj9dy/1mdDKnmdYN/gXx8pug2qDPOMmJhmWVvb0zcRgYEmoBHigKzjDTCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:16:15 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:16:15 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:48 +0800 Subject: [PATCH 12/12] rtc: pl031: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241228-wake_irq-v1-12-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1402; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=4BMfK6zSQF5qiBDmk7U70xZY4AnsGczgpoZ/YOkhF9U=; b=pUt4U8/DoSsmmA+YwURboasmkRyxZrbgsS72GSgchx8AvlavLmQcbowWHUf60rQ6f87O4Xu1H zZb3y56hfH4CqUdatq1mfS0i5ZTetyxBOQORYjJzuxq6HS9oK+jnXae X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 6455ec2c-8348-423e-b75b-08dd26dd39d5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SkxpaElxRlo5dk1sdW9nUHd5YWczclN2TitMcUMxVjBFNzFnNXN4SldicDUw?= =?utf-8?B?b0Fyek05TkhEbHRHeXpBenJybFRNd3g4d1ZCMlBqT3k2YmVZempubEpFVDg5?= =?utf-8?B?dHZjMHVGN01OVDRoQnJORlZHTTRGZEZhdjBhWlI4aVJqTm13NEh1SVlTRTV4?= =?utf-8?B?c0Y2RDZlOXU2NnM5aHg3TEhQSlJGVGhSWWFXdmo3SDJaQXRnVTU1RVhOcXg2?= =?utf-8?B?LzVXRlhHWk13ZDRpektydUJreG1TMzY1QjkvdUFpWEVBVlVSNHNobTRFeHA5?= =?utf-8?B?dDhuSTE2SS8zUWs1L0JHdnFSLzlMK3FkY1BvVHhWT3BQWEh6L3BRSnBFOU13?= =?utf-8?B?Zm96KzFiYlRER3NQNm1LaVhVT1g4aGhYTnhSREpYMHpJcVp5b2d6YWZoL0tq?= =?utf-8?B?TWZ6NzVVRWN0bFRiZ3ppT2FKNTRwZUN3L2hiL1NNM2pDMUpST2MvTWQvR3E1?= =?utf-8?B?QWVhelRTYUR6cE8xRmd2YUh1Ty9UNFZCQVVBN3psSTJRZ3E2YUlFSjZibkJ2?= =?utf-8?B?UzdteWk5TmFoUi9Qd3pRVnBWQ1R2aFliZTFRK3BCOTR6OC83ZEtOa0xLYlI1?= =?utf-8?B?YVFDNG4rUUpheWZxZjlEUjIzbW1JTXhiQ2UraFdjWGRTellid3d1Wm05VWpQ?= =?utf-8?B?Q1N0ZlJFSERkUDl1RHBiamU1aEJEMFNLYW5TUG5aT3cyU0VVaHV0VFpvOTRY?= =?utf-8?B?TnBsZW9ZT0pHZmFhc3YwaUc5R08yMHJqb1d2b25HZjRKR251VDVocGNjNW1a?= =?utf-8?B?TmxoOC9SUXdscklsbXRDMFplQlRmWUcxWDVuaEE0TWlFdDdvN0FLdHZhekty?= =?utf-8?B?S2dzTE5pR1lJQjZaUUZYekxFUzhzblNNWGY2ZTYzNS9PNXpjNWxScnlkajl3?= =?utf-8?B?UGY4WVQxNk5ldWJMMi9PZEhWSktDcUgrRC9OWWM4SklOS25LazF2ZXBFU0Zq?= =?utf-8?B?VC92bzMwSmpUMk9EWTN3SE1TS1U4U1hoSGFqck53YWFDeGV3dGt0aDJJb01Y?= =?utf-8?B?VnJlWXJ5bHQxRGl1Z0w0Nzc2UVo3ODc3YnA5RVFPdURqeXJDRzJNWmpqQ21a?= =?utf-8?B?Y1JaRUtnTHFyWmRtZTFPUy9aQkNkdGJJRy8vL3FVM1JnYW52RTBzS2Z6aWVn?= =?utf-8?B?T3Z3N0RRNVRCNXNGT3ZmWkFGUEx2ekFwNW5KdDdnVTg0L1lOV0ZGcVo5dWdG?= =?utf-8?B?M2F4UE50VXNERGlsQ3VwNThWSVdtZDdlMUZ2ejBubFJlWnZRQ0g0amVxMnBk?= =?utf-8?B?amFweTVvRGMvN3VaYW1tRkJ5b0d3NE5zZkc4enpxQUtBWTEvaG16SWVPMmtR?= =?utf-8?B?OStXY3BVdExKdll2azY3UUpIVHhFaTJaNnBmVm1hamUyNVlJakdxTkFtdmll?= =?utf-8?B?V2dWRFZ5ZGJ5TGU5b1o4TkV6SjVDYkl2ZWxhcVlzdjZ0eExOTVRUVmNkWE5C?= =?utf-8?B?WHpST1ZMUDQ4a04zSE5ORGYxNU41T2VCOUdDejBVZjlCbndyUjlXb2NXemVw?= =?utf-8?B?YVJ3Y0ZxNVF5VDJxQ0dFQjhDUzNtRnhMMGJTaHJraHlqLzFpUi8yZy9FUW15?= =?utf-8?B?cmkrWEZvdFkrKy9ZdWRrN1V4Y3hGaHkxN05DZ21wamk2ME85cEQ1eEp5ZFpm?= =?utf-8?B?VTROMG9kT0FpV3NHNnV6REtabDlzbUJrQWVMbHA0RURKd3hvME44L1FVWUZP?= =?utf-8?B?aVF2Mm9EeWtPR1BIZkFORTJnNU5xcHlzUTJFUUk3R0dhSWptOERSaitNZDBI?= =?utf-8?B?eGdHZnh1emI5ekNxdVZzL2pnMWd5dGpuVEREd2Fnck9XeHRNOC9XOGVaamlT?= =?utf-8?B?RUp6eXV3NnhNT0xBMU5yREFNMkhNZlRGdXFIWHMvMkxzVHRGbHkwQm5hUWdM?= =?utf-8?B?VlRXNUx3eTVhNFl2TUhVNmo1aUx0MXVGTWpMSDB6aGxpczFpcC9LVm9iTkk4?= =?utf-8?B?ZnRRakxPd0pQdGJxMkRubUZ5V29hQTlXeVVHMGw2NnNXZ2tIZkN4cXoxV2Nv?= =?utf-8?B?NFBqT201ZXFRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkM2b1J0WktLQXJiM09ydjJkS1RiZEd4bGh5TWtCTGVFU3lzV2dldmRIN2NG?= =?utf-8?B?NE5zbTNXMFFVdVR0aWFyZlQ0WmlWWUpoUnNIVkc0K1g5ak41YXU2S1IyZVFm?= =?utf-8?B?UldrR3VMUmY2Tjd3cEJLZFFyWGVtcjlPOVR2ckU4dzNtNGtvQlA4Mk9hQUtN?= =?utf-8?B?SFdOa3VTV3Rsdlk5MEZKR2xPQ04rdzhrL2RqKzJWcStxWWZFc01lSFF1K25n?= =?utf-8?B?c3JzcUFLWVcxUCs4RkFQM2dia3d5bHZjSncraEtlci9McFpQeElBdC9zVlht?= =?utf-8?B?MVU0VkNibzAxb2pNcGhnbmlNaUdkYm56UHJIcHV0M2ppamhJS3MySWFoT1Ft?= =?utf-8?B?R3MvQVUwcGNQYkhhTXZZN250SWNMT0x2a1ZZTWVDTUxoeUpiTWtwbXZ5Ykd2?= =?utf-8?B?VmhJbnM1UnNRaXlIbnc5TWYxcnVKbVYzQU1vcnkrWURtVUZxM0REcTh4dVpJ?= =?utf-8?B?aE43NEhaM0tubmk1dTducm1TNUduOVYvWGlYbGF6OUFCWFQrdGFxVmlJV1R5?= =?utf-8?B?REFBQS9lM0lkalU3WnB0SlhoVG1NZXFhUklYVm1HZUJ6eW1zaWoyd21RN1Uz?= =?utf-8?B?Y2wxUEFXMWJJNEwxNkpJUWpiTEwzeGtGd3JJU00yK1RMUzJmRlkwOEJqUS9M?= =?utf-8?B?Tk9NN1FlaklIMnJYVHJIL3A1dDBOSm9hWXhRajRBSjJTV3AzTko1MCt6STNJ?= =?utf-8?B?N0xlWE5RNmE0OENjOG1xeUljSGxSakQvSkFTZ1YzVUtnWHhFR0kwYjFQU1lz?= =?utf-8?B?cWx3SWRhOHowd0gvVjA1bCtFK1llajhyRjI5QWpORGVpbmJMN3Z1K0Exdm9a?= =?utf-8?B?d3IvUDBkak00bkUvRHRZc3BaYk1YMThLOEFSWUp3K1hUbnVoVmVBUmJPSW8y?= =?utf-8?B?NlFKQzdkb3dsVk9vTHc4NW1qTHp5c29ic2crQzRvT3U5Vm9OWTJsaUl6bmhq?= =?utf-8?B?QTlSUnVjK1ZuYWpyMzFpeUhKRzVXY0p4NVV1YlR0KzVFWnRuQnpBekpGS2RF?= =?utf-8?B?R01zQUpkUEg0R3ZRV3RXdU00UmIyNHI2M1dJMUMrTU1DUDdNRGZhV1RaWW1S?= =?utf-8?B?WkttV3BOcFprKzlsNGdZRVhNNTE2M01TM3pSOFAyUVlXTDNxS3orMGluZnZp?= =?utf-8?B?RE5qOEd0bjFoSzlJSk1QampwMjE1a1dnbllES1RJYkwvZlJJRG1SNXFsVjRr?= =?utf-8?B?eTVUMmpWUWdjbzQ0K1Focm85aTU0M3hUeXU0RzR2aEN5ZDk3S0Z2QkZ6TjIy?= =?utf-8?B?Q1dYbVZENVQxeEdLb3hMRGNERTYwWmhxUFErbG9ScGtMeElmUkluZTkveGtr?= =?utf-8?B?RVlkQkxDZE1VaHYzdkZKUGNLYkE4TklWM0NXTmw3dXNOMlZhUmFyU0tFM1Vz?= =?utf-8?B?N3djaEd2WmV4QVZLRDBaRHVVOFJGQUVTTDBkV0JUK1N6WVJPa0s5QjZTQ0pS?= =?utf-8?B?WHdvMUZPSWRtWXMrT3VQNTVpUWxBOXphSHRVYUpQQW1BbGd3c1pjaVZzYmYz?= =?utf-8?B?c2FOMTdHSlhWTHFVaDFCcnU0d0FnamREc2dWdytvMGd4TGN5SURXdGFyOVFu?= =?utf-8?B?Y1BHdS95eHZFSFVJR3pEcGREc0pkSUdkaHJwOVJTNnBRRndqT293M2s4Qll4?= =?utf-8?B?NFRrdlkySUpEQiszVDRWK0lLNEx3UjAwS0xvVTc1QmoxWTlWQWlSeXB0MU9y?= =?utf-8?B?a0FyaDlqQzBkeEVYNkh5bFg2MUhoNiszMGxvV04vbHhBSU84MW54L1ZkOUhB?= =?utf-8?B?Z0RJYjZZMlpGemhsdityWE9LNSt1OFdmRS9WTDdYNklzZlVQTlN2ek8zYVFI?= =?utf-8?B?aEdGeWdTb3lpY1c2clV0QmN5OER0ckpkai9ETVp4bWIvNU5tUFpBcWZzZlZO?= =?utf-8?B?VjFrTGh6dVg3WFJNWmYrUVdhSGd0MU8xOHo2RVIrdTFkLzE5NmZaTlB6V0Nk?= =?utf-8?B?Z3ZTVzdFcitFQTZCVC9EWTZRcXZIU1JjSVFMNmJVenhsclhNRVBubWQ0M2ds?= =?utf-8?B?RUNEU1AraFF4M2k5bUc5b05zSmhDd1pLbzg2cEtzUTZGaVBpZzRSSEpqZjVC?= =?utf-8?B?QXk5V2ZrQlQ0SVUrMk8yd0lCUXkwREUzemc0c2kwK3ZFV1BJZXhTaTRVSk95?= =?utf-8?Q?TN56MI5yW3r/hryfPcA1lHOQq?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6455ec2c-8348-423e-b75b-08dd26dd39d5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:16:15.7255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KFUTPpyMWHKSNY6jE6x5gXIMv7hUjizTHKJjCWoGhzxl+RBGvoDIzRWrkNYCt++ZS1gV4fMvqstQmEUt+7Zb+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/rtc/rtc-pl031.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index bad6a5d9c6839ca70905e3d46286b9729c1fd435..47bfc5395e5908b7722b9827639= 9120f1ba65af0 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -284,8 +284,6 @@ static void pl031_remove(struct amba_device *adev) { struct pl031_local *ldata =3D dev_get_drvdata(&adev->dev); =20 - dev_pm_clear_wake_irq(&adev->dev); - device_init_wakeup(&adev->dev, false); if (adev->irq[0]) free_irq(adev->irq[0], ldata); amba_release_regions(adev); @@ -350,7 +348,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) } } =20 - device_init_wakeup(&adev->dev, true); + devm_device_init_wakeup(&adev->dev); ldata->rtc =3D devm_rtc_allocate_device(&adev->dev); if (IS_ERR(ldata->rtc)) { ret =3D PTR_ERR(ldata->rtc); @@ -373,7 +371,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) vendor->irqflags, "rtc-pl031", ldata); if (ret) goto out; - dev_pm_set_wake_irq(&adev->dev, adev->irq[0]); + devm_pm_set_wake_irq(&adev->dev, adev->irq[0]); } return 0; =20 --=20 2.37.1