From nobody Mon Feb 9 14:31:59 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FC4C1C07D1 for ; Thu, 26 Dec 2024 19:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242569; cv=none; b=h82b0Z/JcWpxwdsrlbgA9tj3yPIFyq51T+E6Ji7kn5mDBe1XWzX6Vnl1wBqhdr7XCVGjGUDQfcdYDk2zu3JEcb82kY/wwOkxVMkUY0jTwp0cYk9z9P3fD6NU0ahmnkyfNN2qAnf8wjO/SPMdw/RCntX87D2R0X03wlh4B+Udlyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242569; c=relaxed/simple; bh=o5Q2vj5i6zwZGZjOwqoP1zbV9zKaCIQkqXtEblYsFK8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KCf6oFzZ6DwbWc5XXqxtQua0lowji2ZGtZ7MmD4SdXrKUEquMQ8ZItjoBefZ6uMLhVHtJB6PXGIGaDDw4n36R8rKdAkIvNoMB2CAjBQZG9/cwy0pmNen4X+rbfLe7DfXOrr3JWIeW5Ve7/BeOSOPhJNlhq/cRStEzmYDEg0XK38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I86xT6LV; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I86xT6LV" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2162b5d2e1fso10245675ad.3 for ; Thu, 26 Dec 2024 11:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242567; x=1735847367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qzmfsqIqFBfv5O/wsRIwJBpkRaSj938n7kWMDnZ1VX4=; b=I86xT6LVqh9j8XV1TMZf3Z+G9DK1zeYYaYtfVytaV7AEf3KrhUPbuogPhTtSuU3c4q 7m+mwLgwY3s7Tepidw2qcZdS0EMYb/DaJNIgH/XfpG5a82Y01tVERZ2pbe6ijtuY6s7U CpQbK8O7oEDbJRtt6a8emiOf6vs0wBrTvHux3n14QDLvnwcu7QpvzlFvkPB+i6kadM4N OI+AQ094QwrrJ32CfrL72abQ3W5+Zqqm9GUJiIv/RBMsZPEVFzCb4WzDqU6vO7uxbKm3 55pOPel2M+2avoEHDvImLSFD+Gr9OpCPJlqKdHx6bXO7wzTJBy32vPYKuCRW+g4LsAKy kSaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242567; x=1735847367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qzmfsqIqFBfv5O/wsRIwJBpkRaSj938n7kWMDnZ1VX4=; b=UyzqNxAYunC9ZWUvSB/Es+DIKEEEqYD04fX7DK0Se4qhGNNuX6GGAeozdgOrVWOrl7 6n5fwbC3D/4K/WA1DP53pbu5dYK0bo5szN8I1sHIoPEwocy8TWkjYEZQag97OXh7gAAf UScvfim5vUBw8pZ4rrAXV9oJmD8GD0pAg+pLNbkHm8mt79I7bUiePDcp/0L/E3x2/T1S 4pj5OOPi8UNuzQkkLcRZaJCaFnqGAlPvnT4z5c78G+HHnM0rjBHnRtf10cgzqm5I7KEM qYWwYCENSPalkWoTUw0rv4VqZ322HOBKhRZUJaQZG2IvRnVhxZm/kcOE2m3Z1FaJmJxh BxTA== X-Forwarded-Encrypted: i=1; AJvYcCWGHXfh6RZMujnP+u+Rjth8cL034qLwFR191CZ/CyKTRA9SwOWQtgSTfp/pGUjGBYNcpEhBTFh76js9k8o=@vger.kernel.org X-Gm-Message-State: AOJu0YwX12hW3YG/y6vYsO2N03Su6brzbmGdzmVCoZXHepX5lryF3ZwE 9DB20gR2bS8/kQA2aM5a3euUjrpX7XrGzeI5nM0RvZjNtjSIWhks X-Gm-Gg: ASbGncuqYSfLGN3Rjhvo5Ai+r9CAssSf516Qfr4uI99MnI1bpjANuF+Qe3hu/E+GC70 vk/zf/ywEpsOAkVmcBjg3ECoGIVC+TXDavQ1W3IRUp8DHfkRcEZnBlwpIuxzNtRz6vcBMI4ZI9G KVeqdUuNOo2egFWVEkooZoM09dgg0h0IiTZEgo7ov5Y8g1lhBMJhu0qh0ld6tVYVYhsyGXPfsxO kO0ciJz7lQZdA540b3TgO+6V67ulHqeYXfkft3m7qFVrxJucuuqj9M= X-Google-Smtp-Source: AGHT+IFj7MMCkHOLs6KYvDs7vYIZq9uzlP6PD6aH+BBdTWes7047Hhy+pbDfyeW8aWuh5QdCAG0OiQ== X-Received: by 2002:a17:902:e848:b0:215:740b:d3ec with SMTP id d9443c01a7336-219e6f1db38mr125009825ad.14.1735242566819; Thu, 26 Dec 2024 11:49:26 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:26 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 07/15] staging: gpib: fmh: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:31 +0530 Message-Id: <20241226193637.241049-8-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous platform driver, pci and gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 43 +++++++++++++++++------- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index 62791db1c34a..30676f139a61 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -1690,24 +1690,43 @@ static int __init fmh_gpib_init_module(void) int result; =20 result =3D platform_driver_register(&fmh_gpib_platform_driver); - if (result) { - pr_err("fmh_gpib: platform_driver_register failed!\n"); + if (result) return result; - } =20 result =3D pci_register_driver(&fmh_gpib_pci_driver); - if (result) { - pr_err("fmh_gpib: pci_driver_register failed!\n"); - return result; - } + if (result) + goto err_pci_driver; + + result =3D gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE); + if (result) + goto err_unaccel; =20 - gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE); + result =3D gpib_register_driver(&fmh_gpib_interface, THIS_MODULE); + if (result) + goto err_interface; + + result =3D gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MOD= ULE); + if (result) + goto err_pci_unaccel; + + result =3D gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE); + if (result) + goto err_pci; =20 - pr_info("fmh_gpib\n"); return 0; + +err_pci: + gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface); +err_pci_unaccel: + gpib_unregister_driver(&fmh_gpib_interface); +err_interface: + gpib_unregister_driver(&fmh_gpib_unaccel_interface); +err_unaccel: + pci_unregister_driver(&fmh_gpib_pci_driver); +err_pci_driver: + platform_driver_unregister(&fmh_gpib_platform_driver); + + return result; } =20 static void __exit fmh_gpib_exit_module(void) --=20 2.34.1