From nobody Mon Feb 9 14:32:03 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDC8C1BBBE0 for ; Thu, 26 Dec 2024 19:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242566; cv=none; b=VazREfDS8DYbvL7VqnXUhSValqga5Tj1mJ1Wak6IGNZWlmM2TWDlY8HcIfeCyqYKxhL47Qln9XIg3Be0YBomfzZAap0wJvT9B+JrXhvu5rxwvJX65vuH0e00AuQ+uhVTToIA8oQFv2/Vzlu592443B2Eu1Wb6TMyyjig5z3AEEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242566; c=relaxed/simple; bh=W3ZjR038WD4Bz8igH/5TljAfRXoTF0kna4HuXgpHkW8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GhJ/tR1DO8c/kCSwFisJ8uTjoANacIoXOv2PxZ6y0ySOQSm4DqQAd9dLc8ptc0nzSfXNWHol1voejb9eEVbIzTcLW4+XmXaE6nlVNfelKbKiPXOYW6RW4OQPfBT/kErg98EjuUiIMjPKjdfN9MG7v9/7Xn7hC7N2Kets66rkJ9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kb9bJ6Q7; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kb9bJ6Q7" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2161a4f86a3so7919535ad.1 for ; Thu, 26 Dec 2024 11:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242564; x=1735847364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wWsepmZqswshDonO9fJBx9b75dLoOUCjODKtIvCqx3A=; b=kb9bJ6Q71i0VhfLrx0HWjcvuRftgc3QWamPBnTdmz14p52xKA6YYvjqDUdlrMG/ry5 TjJBuR5okCdrIbONf8sdlw3AI+CDcPfDhvjYCNKJMY/ylz4Ge/HrVjD+4nkDGB+usrUR v4sawa59tyCQT+XAlllKGlFGVyhQ+7T88i1ScShhAPjyFZkfSsyvP0b2zqoItJHgBtFA u+9A2rtXq8ORwRRJK9JD8kbnDtbHYtzdxfBdPuHH1U0pnEn1Ri9OrkKxcwvYTWG5KoRb hKykwLHyXYhRFqE35TnQhOLJlX7IEgVsHVpbTuQ/7robDkGEPDd4q0qko+AFlPTGF1+X 8Djw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242564; x=1735847364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wWsepmZqswshDonO9fJBx9b75dLoOUCjODKtIvCqx3A=; b=lMr9Bv9zcFsGPxhB3rWZGmmQ8XALAlE1FgdC0d78BhMunAqWlBybgCLyrf3GV32pcS KKwhN9Tgxmk5i30iA46PF1aWqommrPjdrhRy5VZoto5799uSVnlvfDxjQWHt9le1PYKO 33oh+pp8cJORQTGEg095G0gcMwThYP7QRZ6Fd7S3dsq6VJHflJl2eVSYNg4ti51Fee3k IAI3R7Jrdw8o7fe4rtC9sM5sZLis+Ct8JTxPfyCZn/0LRMYB1Jk752uhRXrJqV4kXkgg q3m5H3bUUUsLu9CUEQi+3IYcVzOhun1Gz2aMCp4pbB+W4/fj5jkE5AxfVC/JyyblemGO FGxA== X-Forwarded-Encrypted: i=1; AJvYcCUMjdt0UHUZtwfRrK8D4SXvPFMii46iuSiR9LaLQYeoCzSk8GKfVMEO3GXWHkgsn/XWzXd+ljfGUpSkLh0=@vger.kernel.org X-Gm-Message-State: AOJu0YyqoACBYptmxYVsopS+fPx7UW91XUMyF5fAR3WrBMgnleRsq9Zf gKctCJDyOIO+EF4LEYN+v7VMwuz9fjCvl2TGUOXuWhiDkw3W73hg X-Gm-Gg: ASbGncsFU1DGnsDGlb65+0pvkjBnsII2irB5B2f1veu67cDYBsmKbERH+udPcgQf9C4 b4gD9e/8GRfv79guR977FhIio0iUsFi0uYxwzaOTINgz4ROI07mfPDoRicccCvDpDvQfJApfywP AJ8BnpxaanChHUfdFXPB6NLZTkoOWmcRRwcCtIColXENqG6WP8fuSSi8QATp4T2FTI5fc8XxYY+ bqtORqAqbLt/nb1M1Y4uNCd2jGnz6bfdFixjeBoxE4a+ry5EkJTXjc= X-Google-Smtp-Source: AGHT+IFSV+pTPPC3LBKjOHrGxRxrFkz//ki2GUAWYlo0jfonnQE+N294Tc2ESohCWlGyqv3dvEcqIA== X-Received: by 2002:a05:6a21:e8d:b0:1d9:1894:cdc4 with SMTP id adf61e73a8af0-1e5e0847032mr14245160637.11.1735242564259; Thu, 26 Dec 2024 11:49:24 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:24 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 06/15] staging: gpib: fluke: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:30 +0530 Message-Id: <20241226193637.241049-7-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous platform driver and gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/eastwood/fluke_gpib.c | 28 ++++++++++++++++------ 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index 3f938ab0c84d..2efc0226ec2b 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -1154,17 +1154,31 @@ static int __init fluke_init_module(void) int result; =20 result =3D platform_driver_register(&fluke_gpib_platform_driver); - if (result) { - pr_err("fluke_gpib: platform_driver_register failed!\n"); + if (result) return result; - } =20 - gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE); - gpib_register_driver(&fluke_interface, THIS_MODULE); + result =3D gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE); + if (result) + goto err_unaccel; + + result =3D gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE); + if (result) + goto err_hybrid; + + result =3D gpib_register_driver(&fluke_interface, THIS_MODULE); + if (result) + goto err_interface; =20 - pr_info("fluke_gpib\n"); return 0; + +err_interface: + gpib_unregister_driver(&fluke_hybrid_interface); +err_hybrid: + gpib_unregister_driver(&fluke_unaccel_interface); +err_unaccel: + platform_driver_unregister(&fluke_gpib_platform_driver); + + return result; } =20 static void __exit fluke_exit_module(void) --=20 2.34.1