From nobody Mon Feb 9 20:31:02 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660401B4157 for ; Thu, 26 Dec 2024 19:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242563; cv=none; b=bwflwYEN64acqpKRgIs6geX4oiwl6/RXgpdN9s0tQkH66zSLpSUZoY4U662LdBb3Vs2u59h++3COQ1So6K8LavHZRLeUUuO/52JDWzTqGsrJ2lTte7fJ6kwMqXArT4C5LouG/M+qJa7pkjmKQ6kVUp1i5+FcW5iFa1mOE+yutxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242563; c=relaxed/simple; bh=/tWWqyQBjCa37Hoi/rd2gDMGifDNNGuAhp+UsSe++O0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EM7Fb8a8XIu5tkwY4hG2JGZ7oLhUEkys5/SoGPXt5LRIsnQbneHkvzsPxp5IyU1gn30LnZ4lTZwbJz5WfbZ8LRqhDjjNIt8uCgBGvYrEV7d9ZjFiZP0uNqRdCYQrtEwKo4dNT7gGMTcQtjMNdxTWfhz9nyrfdWnVpyshhV0WRME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eFqHzoeV; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eFqHzoeV" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-216325f516fso8594175ad.3 for ; Thu, 26 Dec 2024 11:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242562; x=1735847362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YiGGjLP1sUA3+CKFxkxP+Nzp9uRb7o+38Fzbf0e9QCM=; b=eFqHzoeV539o0txSIXfp+xqePYR4jtyTfwnSvFqsZVVE0IixmJ+bLG0g+9Gmn1bcad 2OAJhLAjzD1/RN8eoku7pVALZvsGPqnQwk4d+xlvcJSkgCLtgpTFtTO+ABFUdxdCY6I2 w61GE5Hw6QOYlx2UThet2DcE+Ws/pTjBpHCvR9w0hF0I6ledu+FUZjqo5QT0V7LEForC 4493elJFbwWNEA1O0mwPr/i0SN4ndFT9+vcltprVgASieQFOuifxYpugUqsdl6mktVM6 L4dPpSFzEVT2RrYG5MdxHO4UdHuZFSXkzQ9l6G9zZ1yiOSaG0DKNgUzCjG4CUh18sW7P 8FfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242562; x=1735847362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YiGGjLP1sUA3+CKFxkxP+Nzp9uRb7o+38Fzbf0e9QCM=; b=jc7X4FdHKixG3zeT7Cwe9RA0hCUaQeOr8Abz5OToq2rUdkDiOvw9Zxl68tDHcjZplL y7Yn/0zQhk6iYRW+1vf/8wJqKfmJ/7PK6fwnyryso6O4SGVBSn+hFHc0YpUcEizW+/gZ AmOkBHUj5opY0n6KVD+QtNItYfe61+csrGhlfsNNPsZ3t5JQiGuV5BGaNWbf+gNx9JEo VJxJXr1UZ764rNg0ns0I7u27lki9gJ0IKk+gDrzzStgHfD7CI4rN5Eppe4uA/GPkKIjC AKL+ggEm9R/dLh4KY8b6PHfCEME4/qBvug0mermwS8rqS4CDqbXo1taEkHMsMS57C8jK MCQg== X-Forwarded-Encrypted: i=1; AJvYcCU8sJAwjjGU16py99puAwwp1QXHLZT8Bzx/h6zYCj2L30zD8S3EtyCX4q2AACgPSp0YOTcfpcGXE8paQqc=@vger.kernel.org X-Gm-Message-State: AOJu0YxyxRPUT4c/Zo/21shGMNvXbR4jvBnB1ncAyUTZx/oxabT8W6QI FWbpkgOC5k6NnO/tEnZA8cqGiMQTKSrW/dIwrKKJ9I28TG5Z8++l X-Gm-Gg: ASbGnctkpru+6Pd9QhMb3d7a8wPTn/+Bs79tpI/qmpXJsL6oWDelfr/A9+YXWLPQqIh HbgGOc9oBVsNYLyQKVGSe7kJ0uBiWAGbkGcKgV+Dq0ddHHKLnq6d2syivyDgqVy1wkE6u6cErth 0aoKYvrluuOS1VlULSMVKTY5/xsJ4cRx4YTkFh+28kX7NdBG2SPw9U6X6c4ZcUygpMZsaXv3ulb Np/wmL47ibO9uSTf21GpruywhPATv9lHVQRhwHf2Cpp1uXiIA3NOsM= X-Google-Smtp-Source: AGHT+IElec6AfBf3JXW3cVhtMs2r2njKuK1M1VQZJYL1H2oIAiZf7mGHRdvGGak3k95nef/cKgQzAA== X-Received: by 2002:a05:6a20:c70a:b0:1cf:4c3a:162a with SMTP id adf61e73a8af0-1e5e047fae3mr14465742637.5.1735242561749; Thu, 26 Dec 2024 11:49:21 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:21 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 05/15] staging: gpib: cec: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:29 +0530 Message-Id: <20241226193637.241049-6-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail and result in a semi-registered module and does not return an error value if it fails. Unregister the pci registering function in case gpib_register_driver() fails and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/cec/cec_gpib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index 3dc933deb401..ffa366c30ac5 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -361,17 +361,17 @@ static struct pci_driver cec_pci_driver =3D { =20 static int __init cec_init_module(void) { - int result; + int result =3D 0; =20 result =3D pci_register_driver(&cec_pci_driver); - if (result) { - pr_err("cec_gpib: pci_driver_register failed!\n"); + if (result) return result; - } =20 - gpib_register_driver(&cec_pci_interface, THIS_MODULE); + result =3D gpib_register_driver(&cec_pci_interface, THIS_MODULE); + if (result) + pci_unregister_driver(&cec_pci_driver); =20 - return 0; + return result; } =20 static void cec_exit_module(void) --=20 2.34.1