From nobody Mon Feb 9 23:44:46 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CBA18C008 for ; Thu, 26 Dec 2024 19:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242557; cv=none; b=UTjSBt+0qQ4T/QjYI9DWFfTEMMckOoCqVnQPniLarxMzzPhLw6omupY18sxNkFn6CUV2tisDAbKqMqlePXEviwiC9dDfKUQsjuBTiTUxCK3KymjepBjyrem3U4rTNhTxwahHNVxkbO368XWobobxl6+hUXs3PuzXr3QIaNGrfSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242557; c=relaxed/simple; bh=u3cJyewB0tyfHja4vFw79gzzgMChdWbHeOvFQeP3HcI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JmtCBVAvtV1YMXtzRDhb30QPZzsFzrqUcShWQTIrMV9jmkdSV11fictySiHVsc++K4qzFd4zJl3/HHpXwSOVh17MWltoLcAyJbbfC5GFjZ77bi7eEp9/9FNcKzB4zQkPMDuOJ2c1YHk5mqLqdbtgqnJUv51vWKO4H/MMGCGtPf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V7NOLdvW; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V7NOLdvW" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21644db9f3cso9239855ad.2 for ; Thu, 26 Dec 2024 11:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242555; x=1735847355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xOoEk0tyYf3jxdc6YHVdHzWzrpuWImBtU+LJtV7lOfI=; b=V7NOLdvWIGE3yq0SsN/1hFH4bBEUaCOu7UsG4RL4vjpWkXR7h+kQ6PRwqmOdV6CyVS CQXzEheZ7VJu6KUNNPNe5M+RoXQWtwK/nb9REFTGTE90x2UgCSO5DAyCTFYh9B90O2zh fWWMiEo+2fBBweAcHQlEJ5nJu6qalpkfrWa/B3fFVUPT59w/3aplDTt6pATAuosn0ton 3I6al/octRccPqcSgPtKWRh1kVvEEumoKTu/B6tBGtRH0q2MUmp53vYqb/4DZDmXK1Jj 6G5r2x2GYXV6fZt6QbDfxOsFw79xldfI7IzxfGwW+HBeTuDZHvqgfgj0vXLEIQQprTH2 ZC+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242555; x=1735847355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xOoEk0tyYf3jxdc6YHVdHzWzrpuWImBtU+LJtV7lOfI=; b=IXsmPBg9oobeCELUckrH8rY9Vf+d2Mr398WkenEzVcCiifSL3q0PvAqcnVpj9YpBIU Iunt9qv3UrYg5lHX+oC0wMuBepdzbKzjNKSt/m5vZQ05JJPO7PCeyJtjzyXw+ktdoMdU 5OtIFInQImOfLeM432sQ6chZfeqSp1gZ0zzxpYoPYFS8N4god77PV4kAIwoONVfO1kt4 0JK8/gpY1EhrKG0ki5Jd0oyIvuKJKzT4T5tH9D6KHrwBzBG1VT32LQumWeyJ8IAbJ6ov ov2hh8yBeSe8SpwUTxljGgPg5lkBufVdKBukkmCkdWv7PWvL7C642tKfBgvRPyXhMqaP AThQ== X-Forwarded-Encrypted: i=1; AJvYcCXciHnHbmAjr7LJtXT8LAL5VsCjxe4IFy9dGIdF2Yjj7/7OWiDbt/aCcKLKAoiYJQwdz11amgy3Fv2R+4I=@vger.kernel.org X-Gm-Message-State: AOJu0YyVdR0KvOwgkF9LXGs7iGJM5GS95mU4QRO+cP++jESRk0GZ0d5j oI44C7H7AppjYGmyXHLbSH2fggGBE9McXSqhZNQgueCXhccid4/f X-Gm-Gg: ASbGncvnBeuY3Tjx/4VJArxsFYkYIOESUUz9qbf8NcEX36dMflipopDGojUZtemeYgp /nbW018wy3XSPjdEf+Cbavfs+FB3t6ZRTtaZ8FZ5uD7fYIjy36Y6eVA8q0vZqmW5cyZsIwLfcVv bbdz8eRTQ6xVpCPyg3FKkIZAv9kbQhdrWfnCOBSPo/7ERYWskTo3tnw/N2ko0Ozehy658y5ZRa7 d31TDQ8fmn1+j6r9HgivI2f4i2MTI7MeS25ibbsWnxw9fBw6iAvKz0= X-Google-Smtp-Source: AGHT+IEg/oi/pjwuWuRYD2MRFmlg7q2JW/QnFqN29cnhbWknm8up6+gUuf9/RBXspHF20GHs/bJ1dg== X-Received: by 2002:a17:903:1248:b0:20c:da9a:d5b9 with SMTP id d9443c01a7336-219e6e9e74emr121940195ad.5.1735242555346; Thu, 26 Dec 2024 11:49:15 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:15 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 03/15] staging: gpib: agilent_82357a: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:27 +0530 Message-Id: <20241226193637.241049-4-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usb_register() function can fail and returns an error value which is not returned. The function gpib_register_driver() can also fail which can result in semi-registered module. In case gpib_register_driver() fails unregister the previous usb driver registering function. Return the error value if gpib_register_driver() or usb_register() functions fail. Signed-off-by: Nihar Chaithanya --- .../staging/gpib/agilent_82357a/agilent_82357a.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index bf05fb4a736b..60311ce8d164 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1691,14 +1691,21 @@ static struct usb_driver agilent_82357a_bus_driver = =3D { static int __init agilent_82357a_init_module(void) { int i; + int ret =3D 0; =20 pr_info("agilent_82357a_gpib driver loading"); for (i =3D 0; i < MAX_NUM_82357A_INTERFACES; ++i) agilent_82357a_driver_interfaces[i] =3D NULL; - usb_register(&agilent_82357a_bus_driver); - gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE); =20 - return 0; + ret =3D usb_register(&agilent_82357a_bus_driver); + if (ret) + return ret; + + ret =3D gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE); + if (ret) + usb_deregister(&agilent_82357a_bus_driver); + + return ret; } =20 static void __exit agilent_82357a_exit_module(void) --=20 2.34.1