From nobody Mon Feb 9 14:32:03 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D15118871F for ; Thu, 26 Dec 2024 19:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242554; cv=none; b=rcLYRyPXyQ5eq40q8bRvPL73GHC9uphkaEFWIUldW82XO3UNaOGCEfrDckv8isIfp1OJjPHem6gJ89z/yUbqgZMpQpRpC7VYq6DWQUgck7zUYn1Ckn67Sz38ykkeTvYSbk0q5EY+21CN/NnEBRKHNA7HiqJxiHo10nNLIOgi2fw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242554; c=relaxed/simple; bh=3xK8YWYKMbM0mF8SiVUuVBtW3m5mFrfCV2KkOgyI/6g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Hgzd58FaFmdRjQ1PD8mUHi16OiedBwmiBCDf/NEP7VElmgYGeppHt1TdMK5tdSPj1mefcbtlR59sJksKMt9sqQSswk8QIr3qbsb7JUQW0pgs2UxdK20ottzOh2Ol81iymLdw8s9VEcuz8r84cKc39Pt4nyDTrP4cHvmmOF6pZ0w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HCGNw18W; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HCGNw18W" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2162b5d2e1fso10245355ad.3 for ; Thu, 26 Dec 2024 11:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242552; x=1735847352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xpms6VJhoswik5SdrxdqcScRWf09VOg6bXYIyYCcg90=; b=HCGNw18WfUO78VRurjhYwZqneR67WIHZK4s3kbBBQvQnw/ruhQynZG92tNu1Rph3ce nW14aPjsQPx4VblunAMQmpFEZ7UPUEBgg8ckRHbRZQFTXkSV2tItvbOP+5vEyOJ0Iw2s C2cbQ0iBsDSWPwW3s+/0n12CdLJz7u8x1PZMA+pTz1t0bjmPThVs2LUnaHo1s+QqEr24 FBYy9bZImwUO6FRZEvtfvBVb2hDRKOIFqlL1FUs/y903AWlApWks5NZ6odzQOsjigq2W +4vR3GEUdNYaLQGFELmhsTerpMWbn+I3V2O1zLPmjsWV+y6uEU9ebLrKi/bDbZkBOEsp 3wxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242552; x=1735847352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xpms6VJhoswik5SdrxdqcScRWf09VOg6bXYIyYCcg90=; b=u4OXIGA+ZM5LL0dkJ73egIZ7ga2rEcxk49uGrH/NjRL2nY2rJVpaq8ztqwInl0hxRh 8x/uElJxsyGBVdHyIopYpFjOpUVcbFz6rZoRSBUEXcd2aNeegQ00qEPZ8RplipDQP0QW TcYM9JdHkLHcKsYc+EItA2Eiq6GNmS+LLd6FcKNYbSZ5NHSQ5vosVyK1zgm1RfMsq8b3 4fjTC27DmaLgmjNeiee6UZ12S4NdXO5QurMT05+MqJpBrM27NIHB1a5FkvSwudJy8gMe j/79k7ymE8XQXqVNAoAHeDRhRZraRRxIfpIyjbDQ/msDRofyxDX0O1hzwSN99oxnLRDm /NuQ== X-Forwarded-Encrypted: i=1; AJvYcCXggzD3avCP90i+yWdRGaW3nnLfs93TripoBeweXmXmha7NrPsz2ouwWAGsI3BYstkAqHACyYo/sOIxpcw=@vger.kernel.org X-Gm-Message-State: AOJu0YxkbX6vt+2B8U3UIqJW0JcrAloXKKTg2soabkQkqzUm4bQewBic DZAf/OgIwCKj8V+FC3IKyAhODiyEfL30H08/2XqCv08nHDuicFmF X-Gm-Gg: ASbGncs2WkZ2XTs4uXommzeL+usimI1pVCfjiOkoHSw1EiYFwYIartNXATVXJFhDR5j af9fdafZXiFDVArQZi8q/Bp4FlEWzz62FSefJWqNW2xkvvCJDCioJFxt7PJbjo2foV/uWvLMYwz cSOxdnq2MNbwD0F0qcDHkZJ7ckW9zPshbQs4U7jRtjebWZMDurQOxEWVXABCyv5RV0xZXdBampI 4M5Xi5XzkTjYThl5zjjwo0N+xEn4j1e/njRm3EPv3hyD0+Pd0H93fA= X-Google-Smtp-Source: AGHT+IG+k5CT+c5AOowokzehQMPwzamNkGyp2o5D6Q6bTpSMc2HBncdJqoX+cMwtCei+Oth9PE2B7g== X-Received: by 2002:a05:6a20:a105:b0:1cf:2be2:8dd3 with SMTP id adf61e73a8af0-1e5e080df5amr15213315637.12.1735242552466; Thu, 26 Dec 2024 11:49:12 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:12 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 02/15] staging: gpib: agilent_82350b: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:26 +0530 Message-Id: <20241226193637.241049-3-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail which can result in semi-registered module. In case gpib_register_driver() fails unregister the previous gpib and pci registering functions, return the error value. Signed-off-by: Nihar Chaithanya --- .../gpib/agilent_82350b/agilent_82350b.c | 21 ++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 53006d0cc79c..39420f2b0b32 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -909,14 +909,25 @@ static int __init agilent_82350b_init_module(void) int result; =20 result =3D pci_register_driver(&agilent_82350b_pci_driver); - if (result) { - pr_err("agilent_82350b: pci_driver_register failed!\n"); + if (result) return result; - } =20 - gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE); - gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); + result =3D gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_M= ODULE); + if (result) + goto err_unaccel; + + result =3D gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); + if (result) + goto err_interface; + return 0; + +err_interface: + gpib_unregister_driver(&agilent_82350b_unaccel_interface); +err_unaccel: + pci_unregister_driver(&agilent_82350b_pci_driver); + + return result; } =20 static void __exit agilent_82350b_exit_module(void) --=20 2.34.1