From nobody Mon Feb 9 23:38:12 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289C1145B21 for ; Thu, 26 Dec 2024 19:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242551; cv=none; b=c7qXBSm/tGI0GIrbMIqhOyi00nWHGEbCTlm+sETLAXWB2+gz5eCJ5K6Um1P0++WFLQOb7Z+SgICkhLmfXEErR/E0atSGn51/olI1ykA+l0cDIUm/NMd7AFvAkiBVsQa175tOYKeuvroE6VBmAMwb4iFhzZ3zHXuWSaHSwYUuQAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242551; c=relaxed/simple; bh=VU/rrhleeS/+15Sn+0xnRSbzdoNVglfA6iecQU6+nM0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=m1S+4C9NJV+bo6CaAf5GsEXMeLsw7WlAzn2Sc2FvFNL/R5Xe8rpdbMU1AXdgISXMYUO+dGheJjNmj9xqiiywXAosdnzvajJfJu3Xh/uyQeKos+wcb57Qtk+SNHvB+CKizT4/aO+1newOMPmXlTl+wNSl229I/fupsltj6V1XvkE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W+r6ovj9; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W+r6ovj9" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-215464b0432so7910205ad.0 for ; Thu, 26 Dec 2024 11:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242549; x=1735847349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CLv/TrsqKNLXFPXLidmCmK90WVqyL60WkqeVoeLIKIs=; b=W+r6ovj9S5mWSjYSSDMVzd1AT7bGnwJraT0lxAUXTzh4Xpw/0BSTN/CQfjkF3g5tnc HbweRT558c+ViS8G36U3rYWgD1mOQkdwV+Lo+HXgRqqqrjxXGAQJEIDyPN7cYYj1XuQr VxQtxyabML10ysmUyg4EvIJjmuDbu8wqC1XI6HT30uW8hoO0DzPLJNIc6is2ad0vbPl0 Mrkt1dhWPLXeRUQLUYi1TEsfQKOSHXBLX76ofXi9pOuBkIHkYC1kvxuwt58KW9gfhoci v0ugIpB0ePadYJDigCN3fhAC+x+aahrNaBBnCwnh5P473oqwUntug4zXpZomaZBKI8RP tmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242549; x=1735847349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CLv/TrsqKNLXFPXLidmCmK90WVqyL60WkqeVoeLIKIs=; b=bhPSHfv7X1b+9SlYdH4h/TYtj8LRuqTnQx7l1h9PnKvK2AkbxPLXhRuiaDsFfLV586 wqarSX4O/jwCExSAGDJ9EhIJDTlsYlNbElnRm8brmEdY4Hzc6nGgvFtPG04Q0UDcei7K E4XlIb8yqOtX2TGsWtCD9pUARYT/mvhZnqTBW4blqPg5McNLwvojDXCnGZINfMH8oUPJ LI9CXK0Cmi/3FDnBip5w43NeN51xblxY1nfmhj7UL7cYqka9c78H736WGxprUGgF3yEk fNcJsVHQCS1tkgNKgAiuGwIfG4AMl4j3zcDAM+/EgqTAyPxEjOgU/ranqmlCR3nqMyN5 VaLg== X-Forwarded-Encrypted: i=1; AJvYcCWfmI2hD94HFdhHYLLO/NkEOo7oeGr5qBTh4eWWtWs0uLO0WwXMpCNCoLV8CxVslKp2Rslm5NbDw0gkvW4=@vger.kernel.org X-Gm-Message-State: AOJu0YzcjYjt5xTYOQV7MSIdyINRkKrdykEh+A+7QLQZiaaSfNiYH9Rm 2IVdvfKE7zNHMl08Z9DCURMOT/D7sP/93ac4bqmR3vZ4Y3CGoBMz X-Gm-Gg: ASbGncs6VsMdVFjVhAyqWO+qT3uXCZq+9bLlTwZcvJudIuDsuAiSqZnfl2po/BhakBS QYSzl03jF3gb+uc/mzyAk/mQQSIXeyybzl4SUo/P2s+lX0rLIGdJhtoitttLl/jj9vN5bzv3HAx IdkQ2dRG6IwzEHdAdERRPbzZ7p5E7QN08IM5y8k1idR7zauzvN30YlHodQ9qBt0wdeYgwqUVmAC Fpv+Fun/L9mwh1vGfytC7cfZ3Y5/gPXzfVMp0iJV2NvuT00ROiLKp0= X-Google-Smtp-Source: AGHT+IGPHRpatZpeO3OHQr6/82Ll3cTeuH2yhyXUn6+2MEIQIMuUxptiY/LzfNwREyNAYRuVbOPSDQ== X-Received: by 2002:a05:6a21:6801:b0:1e5:d3cc:4632 with SMTP id adf61e73a8af0-1e5e04580c0mr13477510637.1.1735242549434; Thu, 26 Dec 2024 11:49:09 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:09 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 01/15] staging: gpib: Modify gpib_register_driver() to return error if it fails Date: Fri, 27 Dec 2024 01:06:25 +0530 Message-Id: <20241226193637.241049-2-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail if kmalloc() fails, but it doesn't return any error if that happens. Modify the function to return error i.e int. Return the appropriate=20 error code if it fails. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/common/gpib_os.c | 7 ++++--- drivers/staging/gpib/include/gpibP.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 405237d8cb47..07795df3b721 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2094,18 +2094,19 @@ void init_gpib_descriptor(gpib_descriptor_t *desc) atomic_set(&desc->io_in_progress, 0); } =20 -void gpib_register_driver(gpib_interface_t *interface, struct module *prov= ider_module) +int gpib_register_driver(gpib_interface_t *interface, struct module *provi= der_module) { struct gpib_interface_list_struct *entry; =20 entry =3D kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) - return; + return -ENOMEM; =20 entry->interface =3D interface; entry->module =3D provider_module; list_add(&entry->list, ®istered_drivers); - pr_info("gpib: registered %s interface\n", interface->name); + + return 0; } EXPORT_SYMBOL(gpib_register_driver); =20 diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 5fc42b645ab7..d0cd42c1a0ad 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -17,7 +17,7 @@ #include #include =20 -void gpib_register_driver(gpib_interface_t *interface, struct module *mod); +int gpib_register_driver(gpib_interface_t *interface, struct module *mod); void gpib_unregister_driver(gpib_interface_t *interface); struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, unsigned int device_id, struct pci_dev *from); --=20 2.34.1