From nobody Mon Feb 9 13:01:27 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB2B1D45EF for ; Thu, 26 Dec 2024 19:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242592; cv=none; b=pPkeRsuMQMUHh2FirnLDh6G59qkAzUNTGUdPEpE1NVoY1+5ozr7aBAIX78sOIyuIfsv2RHhdKqVij3pmiab2CbQRsnnxLiiyCf5005XmYi00SCkJPdTQo3uB+QbQxanMZcI31j9MJkDpxb1zXIlB8TId3QvwWXeYizxW9dL2GvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242592; c=relaxed/simple; bh=uoRS2FQJmsfyJ4pjwVrUVvJUL2CXgWB/WSSSY69yO8o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q6GLA6xlvtZGEqBpHOLImqRCZgITtuxNYVqJkpe2FZu9rPZvXXNNCoPVnGvVxyH6ShO4D0tK4t6CrVsMDQJhkeHVzNOobFOHXjBZebJwI6tnfyh8EYcLOiFkb88N2WFaPqQ3vb9I81dCZsjuQ4L/hzOS5XdqTXYTtMjhGzxq+K4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FfuuZjL6; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FfuuZjL6" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-216406238f9so8990935ad.2 for ; Thu, 26 Dec 2024 11:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242591; x=1735847391; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lzTMfFBlFZr+lpOgXP6pxefjRutEhsyjgWDG/oae2Wg=; b=FfuuZjL6/4QlOBX8sPLqjjvMOPMUolT8ZDGbpiTdJxuaZaimJRmgZzcRAcH0EGsgpk hYy4KnHI+d81awGDXgK/8Q34zNt5KuH59Pgizahq39DVCseYQzsYaa0SdJqCx8sIpjQN c9Sh6uSZavW5OAnEH9uW0ZiLaOMam6/+pUgeJyGJFEKsQYdEn2ZJdf99aou91Z+eZ80m JcKfonIQ00MxBGIK8ASVKx/60ljkstCtrO3R9TaWBCc/Uo2U+vX0FsN5xN9yMwr3Jl8q ZMB9z9lTaXzYA1zk1xjfSPj3i/kLqtch2vsijScbCo1NnnvmyDKOx3n67G/JXDf2eeWQ AZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242591; x=1735847391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lzTMfFBlFZr+lpOgXP6pxefjRutEhsyjgWDG/oae2Wg=; b=s2MiRXgauiX07/qOAVjBufLPTjtC2LxYSPeA2zIv+/9l/OPhMblFlG7u36yTdPFONf l7M/nWsYburS4uh6GBQOSSw7FhS241bQaTqUcWKtWw3yjCrcoOAff8WjbspThUOMBPXt UMD6yeR2TFW5AHAjsHFPoQli2bNQesYg01obZmEQCwsDFXjVl7dpst2jVksenRnq/Vcn 4XKv3xJkSwyYRzg/qru6w3QFkyEG7TRKpP0vJQj0JaRK/8zbMmt9PRduwkb3sn75vMKI rXOKwr5xGZCWpmYHIywnWDxp5mCHgLVs5qmqhnz79eWxbCnq2KRnaDgwAlyFr68pkCA9 b/fw== X-Forwarded-Encrypted: i=1; AJvYcCVu56MBTTZO75M1oCnB+PMWCag7BSpdnSl+3roFf/rYDby5OpB1hnWk1MFNL6J/HqX8Y/YqKlV04OzSAb4=@vger.kernel.org X-Gm-Message-State: AOJu0YyYimsObP5xZrtZbB03T7IdTdf/3aTsa5OSFS+jtUsyUYkP335z peq34T3cCanNYg5BgHejFTJ3XEDlPq8/4FJ3n1I4PmKMzF+JKSK7 X-Gm-Gg: ASbGnctGDX9hsvsEa3eY6ZsK0SmdcmOPqkbQnfJmtHk9NVBqvd9iUrSsoif80ZwF/E5 4Ii+Vtc18j/64bdPy1DVag2pOxyve9IX0Q5TQAgxzLeHRb8XTeGvtIms0olpburgOvSr6iz5LXS UTkCozdtucZFQqeUoKiFMWVgAG63v+h7m80jbfh9NnHUn+I66tIty11Od99vwMgrmWyoMFcm4ok SdraZtXtIdQYe9qqccNdt4UhRdxhVek3Qy7foHA3O/me41kpTTREAI= X-Google-Smtp-Source: AGHT+IEFjWIkssF5xwActXI8r1y01mJnLV/vNZGiVEfCF5IFGTaaL4qeFUKa1NL7iaHwb6KheZ9v7A== X-Received: by 2002:a05:6a20:8409:b0:1e1:c26d:d81a with SMTP id adf61e73a8af0-1e5e080dcc1mr14527061637.8.1735242590764; Thu, 26 Dec 2024 11:49:50 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:50 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 14/15] staging: gpib: pc2: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:38 +0530 Message-Id: <20241226193637.241049-15-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/pc2/pc2_gpib.c | 30 +++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index 7b3b34f47341..1d42ced67b2c 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -635,12 +635,34 @@ void pc2_2a_detach(gpib_board_t *board) =20 static int __init pc2_init_module(void) { - gpib_register_driver(&pc2_interface, THIS_MODULE); - gpib_register_driver(&pc2a_interface, THIS_MODULE); - gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE); - gpib_register_driver(&pc2_2a_interface, THIS_MODULE); + int ret; + + ret =3D gpib_register_driver(&pc2_interface, THIS_MODULE); + if (ret) + return ret; + + ret =3D gpib_register_driver(&pc2a_interface, THIS_MODULE); + if (ret) + goto err_pc2a; + + ret =3D gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE); + if (ret) + goto err_cb7210; + + ret =3D gpib_register_driver(&pc2_2a_interface, THIS_MODULE); + if (ret) + goto err_pc2_2a; =20 return 0; + +err_pc2_2a: + gpib_unregister_driver(&pc2a_cb7210_interface); +err_cb7210: + gpib_unregister_driver(&pc2a_interface); +err_pc2a: + gpib_unregister_driver(&pc2_interface); + + return ret; } =20 static void __exit pc2_exit_module(void) --=20 2.34.1