From nobody Tue Feb 10 06:06:09 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1917C1CEAD4 for ; Thu, 26 Dec 2024 19:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242586; cv=none; b=IDnjoxzlyw+8zGH3Bz/tSkEN/3YW/T+Pkje1A1PusZ3FRqeZmxl6kNptUYUAlZw44L/JlqAeYZSOqSsaW2xqbRLvdEQSK/ydYvmdkoRdhr9SpGlu9TfS/hZVxm9bNa+atV5L8/NKNBf+d8cls4+aRHrsRwDOSQrfnazCyJQoQmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242586; c=relaxed/simple; bh=C1m2qIRcVhbyiBfPZcibOHclNLGXibt0YYCUhqw/+Ls=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qYGz5LK4sZFclYvP/nTvWKCniYElvZdzZpX3YUymQ3JnV9TCvo22JAXFih8aDzAXYJFQCxZ66HS2632duEoDCHt0OsjDasj/zG8YhzDWxxG/6gK5mANAOjOoig6MWurWF2GgZEH+I9bvAXFYywwmCIJAA0qGW6c3jQEd0ZHGJyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8jgQLjj; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8jgQLjj" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2161d4b820bso8094005ad.1 for ; Thu, 26 Dec 2024 11:49:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242584; x=1735847384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4COc1F2QXFTwXqtvB4VWYIZTqsLaKCmT1xH03KuvEOg=; b=O8jgQLjj3ITU4BgJ9XBemFBYv+1gGV2izopyrNYAwC2u7SQUFeWMVdoilWzn01gG6R cTIHBa9i8aSPRDR10R2uFXPUipNm5OANrkykBynndtup6C+2d6zvjX5dWdHv80nB27+9 ohklTYkH/7hiKkEh6I6V+8RVt/9H7j19QFSZ6lo7GNwfuP44mAas3OgGL7kUePXVH3hr EGFST1krzALMG4tsihH9FUXWs9SHF3AaZM9Fabqc7IR4MScMSkKXaCRjVC0BXyoX1/Mt 8TssNUW7dIKmyZDeP17KM6QF6fhULWomNIiISaX1Rkq4zxrhxS3RV57Sbj1/n7kIm6UM 6lGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242584; x=1735847384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4COc1F2QXFTwXqtvB4VWYIZTqsLaKCmT1xH03KuvEOg=; b=m/xu11SlJzyjuYgi1FlYKZ9Ly+08K1/NT1DW2S4nFUzK5qDLAS1Ql/ftIb/cbAHEm/ I7iXm9LQ4+f4ZATiQYQSPV+OVa/REXn5UrBxSa333rtbPsIlcU1xcSFPU+iIT2WkVQFp SZHUGdTaEh/xT/gfFhumJVHcAtlus27TQxIp0QB21f1xI7ilDxxRcTsOS2t8UgsxmU6W 8dqNUL+Y/BucGRJ7NejsXUE9LMXgg/tTIb8WzG1W7IbleYFwACFM083gOxCcgucNO6It qrUijZA3clpvd/qQAqWWXi0TkuwIXGKMMcYN0AdET/7g59n30WUqo+Xol5MXy3XqnA42 mVHQ== X-Forwarded-Encrypted: i=1; AJvYcCUPdGsLkX524Zu0T7s4HfGMohPxegFHyoSMS076pIQdXeAPmyPPAnLOrNudU3BX0t9S5juUP4d5mX58TWk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8OyQdAvPqIWMM7DJ/Nnyd1nvOliPNonv2gjiWgRcm43AbHoh/ Ik/lJZ6Y+9JimVHUXFp4sNU7K0lz5kYRvXTgXs9N+I6IzeEJVUcx X-Gm-Gg: ASbGncsBYb50QmSEtdbRionfKqhgDvT9WMJA5zsWESzJMLRJQzYqbkhGQSDCrdl91zc BLgmVj63bGrI06chyf9DLFYcR53cZa9jAguPw1rSJ95t9oqiEfOPVu/47bIB+Ap2lobEw//+uYO 5Tj4msGMpF65TMFy9jQMEUOoEHfiM3X77USLUNRBV7E6NfPeyOa0fBv7NOSJUDIZ4Jm+1OhHY+G DcL8LC6FrqR3RW8e8EuPKcmISw9xOgT1Ljs7II0jiv8t0XnORQuKRc= X-Google-Smtp-Source: AGHT+IG17vjbgwMDwKMBDYcO5TCiXPz5GHom6B27qRh7AqF7BUvk2ZTdW0B7Pdz++QoHgNIV/bSGJg== X-Received: by 2002:a05:6a21:999e:b0:1e1:94e6:db0f with SMTP id adf61e73a8af0-1e5e07f182fmr14783323637.8.1735242584397; Thu, 26 Dec 2024 11:49:44 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:44 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 12/15] staging: gpib: lpvo_usb: Return error value from gpib_register_driver() Date: Fri, 27 Dec 2024 01:06:36 +0530 Message-Id: <20241226193637.241049-13-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail and does not return an error value if it fails. Return the error value if gpib_register_driver() fails. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 796c3a5be545..d8af811c75ca 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -1181,7 +1181,9 @@ static int usb_gpib_init_module(struct usb_interface = *interface) return rv; =20 if (!assigned_usb_minors) { - gpib_register_driver(&usb_gpib_interface, THIS_MODULE); + rv =3D gpib_register_driver(&usb_gpib_interface, THIS_MODULE); + if (rv) + goto exit; } else { /* check if minor is already registered - maybe useless, but if * it happens the code is inconsistent somewhere --=20 2.34.1