From nobody Mon Feb 9 13:01:06 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 818701C9DCB for ; Thu, 26 Dec 2024 19:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242578; cv=none; b=PQuCFYa/hWZxUeuWVqWLftDSwVMgi/3UCUBO8VvZy1HXfws4/MnINGz8nghFAoWV1nyf5+/pEMf4PxubNBvOpgaQ6v1/3ewFs4OgSOr85jJBFY8X0OxAHLNEQWieA3zP6FetBPrD6UY8M3Yd+bw2nUsAPB8OSwkYB9Nl2CknLWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242578; c=relaxed/simple; bh=4wP+yrbQKdqe7qTF88p0m3AcYeGmFMMgogAzdvOtUzc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TTbz3CWDdF5HnyTEuvXz28bKlTKXCGnk8k+Wuo0VnxL+oVZ7r+mnxmQUNaVQEBKthBpDRNspg/QL6EZ4jeW7VF//acvXDuX8bGqtrDA6G6ucob32QWEQhpeuTh5qhOyjsOKoJvOT1E+Nb6OD3rbAsfxelkHL8Xhwbp2BuhdUZtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DqWpk1ag; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DqWpk1ag" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-215607278acso7769935ad.1 for ; Thu, 26 Dec 2024 11:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242577; x=1735847377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OuuMFLa1FGsu6aUaZ3Bcceiqnb07JBfGbEvGz7MoD9g=; b=DqWpk1agjG6nnomrPzTv3aNN2LtP6LP65v1sTlv6LauTFlQ9LKxCNp9TxuqoofvBUq tCsytu9DHMUqZiwDT7juQI/jC7MNTW0sEqhWZw/VUbqLb5g71EM72c8ZMpseBOJoknS2 kcN5tjkBUkFNG6qqmI35LudeXkV/frAY8AzMa+3EKi4H2ZRwqp6n76BEsAr6yUaVuij/ LR+ViWxJJxuZlAfXWzR1WpyEE3EuNab/ZOawpCuh8CSZJGK2afkQ+G6SqwUJ3V9vzV8p ukWMYTmud3ga1ZkFy4e5NTzwhuxHoS+QEoMd2SnNujMbIsoW7RidvyY8ktjd3ShWuLry mq1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242577; x=1735847377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OuuMFLa1FGsu6aUaZ3Bcceiqnb07JBfGbEvGz7MoD9g=; b=ESLmhK5Wv8i07Ii+zUG2RTnmedyYQ11ZTcMM8oBSmwXKtDbgPASX3jF+ZmrQzOMStE ldMLAeP2pRpfgpOtsFQN9hmS6j3/kndFbWHqAcBHa13A/CmtjXDxqlS5dpZ3rjYZjGVO SeY7l0yoVbh4J3wIXfP8aCs/u0hVzraoYRkouVZ+Lo+iJBa1e1G1ulzE7xPUsbjXwXCK HwlGtStkPrRV1W6JuXq/O77FWW5zF/M/DLL8PNODe1qGMmrLJxMtfYeUWMwaNT1q1OXA eFofOX58IPEPdMyQHry1sEa4WUvmgFBSTe/agbp9ljxnVap5owXXb3qsiuZV5CRdWmGi V49Q== X-Forwarded-Encrypted: i=1; AJvYcCUWLoa7I1/D/s/k3bUeub/Soj/qMsSJPPrAx2FRAS9TOzSAoNsp+S36tUvkYY5KKvUKftC7zqSQ6NDcykA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz66+3l/tDC5tp33Ia54IwGximIw7s2FbublJquf3l75xFP61Vs AcFmvzIINpOe7c++A1qSQNm3uFeI8FPYfyK3vBJIlceS2Wk3rstLkq/0Cx54s6A= X-Gm-Gg: ASbGncscUTKqwVf2yUN1LBlwxf3ixof2Brxe5JYWinP/MuNDqUcWIEQiJdSnW4ys70P j++t7i2yIagZtFhQTI26DnAhjLsbEhwd9OtakV8KHUHXqHsVUXv2lE0mCCpB9qeMSyYqbzc5PMH jDpTpp31lDz//+nBUm5NmN8aeX+yTQJ3ZM9yeX+117vgi7JmmIYRg6JVtp3a4nQubk7mjNpdFOC 1r8wM1tepw7ru8UC71q10wSI9BhCE7JZpCeZQvlu+9uP1JvjAonP/Y= X-Google-Smtp-Source: AGHT+IFgeglFpXFOFkkqQVGIgyPBR0JhX/cLzwgARcPCkBLAZt6ScP+DQGnHBOfy7m0VonZ5DXqjZw== X-Received: by 2002:a17:902:d48e:b0:215:8698:fb02 with SMTP id d9443c01a7336-219e6f05e39mr129712775ad.11.1735242576769; Thu, 26 Dec 2024 11:49:36 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:36 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 10/15] staging: gpib: hp_82341: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:34 +0530 Message-Id: <20241226193637.241049-11-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241226193637.241049-1-niharchaithanya@gmail.com> References: <20241226193637.241049-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Return the error value if the first gpib_register_driver() fails and if the second gpib_register_driver() fails unregister the first gpib_register_driver() and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/hp_82341/hp_82341.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index 8ad1c885a9fb..daf5f6e02bd5 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -807,9 +807,17 @@ MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table); =20 static int __init hp_82341_init_module(void) { - gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE); - gpib_register_driver(&hp_82341_interface, THIS_MODULE); - return 0; + int ret =3D 0; + + ret =3D gpib_register_driver(&hp_82341_unaccel_interface, THIS_MODULE); + if (ret) + return ret; + + ret =3D gpib_register_driver(&hp_82341_interface, THIS_MODULE); + if (ret) + gpib_unregister_driver(&hp_82341_unaccel_interface); + + return ret; } =20 static void __exit hp_82341_exit_module(void) --=20 2.34.1