From nobody Sun Feb 8 21:27:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F6F284E1C for ; Thu, 26 Dec 2024 14:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735223918; cv=none; b=Zll3rPue4g4mUrcX/ssonXPPW35oW8Xh9PqEW5JTGYcNny6ffzxcNfgj7g5bDp22kB2oOMNi5Vce0JizqLuoLmUiGIBAc2X6i17/QQpXXJ7PeDvgFiMxqrt07eQEsGpgy+GxT4XNxSXTeQ+ffH+oZ4Nd+Ra/HrRFXV9+FaTQL1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735223918; c=relaxed/simple; bh=F8ZU1J6J3v96wnfpvt2fJnnNN7cTLssbsHgMQIU6bk0=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=KSJR/gy74iqMjAT5tM7Gf1YAibn8c2s0IYI83J85cGJDvJbMOwY+lxCNiuS4rqGg3YUNJQ158VOM1Fq9D2XWGyLkqs92xxtuz6RyK8wMcDqTpNomXt7GZDFGn9Lb8DwtCQP9L0zIV2zwvcHjeGawKeQnlbxpf2m9X0y2+orTOG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A35C4CEE0; Thu, 26 Dec 2024 14:38:38 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98) (envelope-from ) id 1tQp1U-0000000G1uo-3UJA; Thu, 26 Dec 2024 09:39:36 -0500 Message-ID: <20241226143936.682944851@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 26 Dec 2024 09:39:26 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Peter Zijlstra Subject: [for-next][PATCH 12/15] tracing: Switch trace_stack.c code over to use guard() References: <20241226143914.397394975@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The function stack_trace_sysctl() uses a goto on the error path to jump to the mutex_unlock() code. Replace the logic to use guard() and let the compiler worry about it. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Peter Zijlstra Link: https://lore.kernel.org/20241225222931.684913592@goodmis.org Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_stack.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c index 7f9572a37333..14c6f272c4d8 100644 --- a/kernel/trace/trace_stack.c +++ b/kernel/trace/trace_stack.c @@ -520,20 +520,18 @@ stack_trace_sysctl(const struct ctl_table *table, int= write, void *buffer, int was_enabled; int ret; =20 - mutex_lock(&stack_sysctl_mutex); + guard(mutex)(&stack_sysctl_mutex); was_enabled =3D !!stack_tracer_enabled; =20 ret =3D proc_dointvec(table, write, buffer, lenp, ppos); =20 if (ret || !write || (was_enabled =3D=3D !!stack_tracer_enabled)) - goto out; + return ret; =20 if (stack_tracer_enabled) register_ftrace_function(&trace_ops); else unregister_ftrace_function(&trace_ops); - out: - mutex_unlock(&stack_sysctl_mutex); return ret; } =20 --=20 2.45.2