From nobody Sun Feb 8 14:53:17 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B173182D7 for ; Thu, 26 Dec 2024 13:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735218046; cv=none; b=nBkA3s+/eFvf8rmL5kEis/KIOk/yrzbR5I8cbkruCvW9UwR8Mhs5CdFBl9XO3K9BjTYdfHBzpQNA/KL4vI7zqcXey3cMnTXQCZVmDQg9WUHOfzix7+up2NTmUNQWOaQbnRVnnrDGSSQsAS0ESjZ/CRAyXhLVpvU3fXj51WhnhAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735218046; c=relaxed/simple; bh=So07i7TsRc8MZo97SNl3OBIKdmzGjmYOs15PooVy7f0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=haqoHA7rp1V8lszHBaA6dByVpW4BxMBAiaesh/5iKbLHRiManu1dpiO4sCU85hTngbbYNC1hnTNGpQ2z+U5D3j94M6+NApj7azOom7Ow/SLJ0H+IiK96darny+G9cXzEQRqCQBlt17olPjDa07tqC0xWtTP7NAXEO2Ndh8lObn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W7U6k0N3; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W7U6k0N3" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21670dce0a7so2675835ad.1 for ; Thu, 26 Dec 2024 05:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735218044; x=1735822844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=W7U6k0N3V2mHYibdbaPu2C7cphkTC4jNbx7B/O7h0lebIbWh0iF9L9YocYRGq9cz88 cP8z48UKs1QWOEeVCIe7dtDNxim9579jObgTbxClIBj518GZWIojfVpDMRuRF7Ca8kQN IWJYsKtRktZ/geR04Gv44ZbR5WpxNqxhr74KtrY8f6kXHyM4DAsICKsNkkVUQIOKuZHU ZU9XBFimkOtpMqZ/4AKHneUefVvEI1tVKqU2MZEZAVsWwTAO+JU00tQUObi8bCgcifh3 0NgrkxMfzmKhM/6w6uG8uB/5RkxD/+3Vkhkc2XdGUf24ix5UWE5uQ8o1w3cGgaZzsUvd YvwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735218044; x=1735822844; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=BIIyqPlh3fzHGQyxyRJYspPqDUA1CY2UifzipYNQcXhnruyRdhGOoj2IygPB67ph2K OLukRI/SBd6eR33++YSQgt9QXacjisC8UZXCq3xxuP/i7jYEpwMyyMhZFxgcglLwtZwc qrHFgGs38CXFgX63kk9gX9Fo7guOuG2l2nmSld6AJPTPVI7phM79j3SnxUgpwtFINnx6 2E1piXC72QxFW7XRSRYYOan78iYIG+wUqY1s34N5WW4AH7nFVUJAtoGYTEPBIgLcJ3ZA ewiZicSyW5b8SnowvN7b1uZuTKPqcVyLmIBAwALHw098tyZWeFZdbBZFCMcK886OK/gJ bRNg== X-Forwarded-Encrypted: i=1; AJvYcCXMTI0fMY/ESkAn7oIkRABQnOkp3NGlSt+zgBatLCOoBMeow+NI4ySyLpfbDvageIvf0LPfI4cIU2tEW9U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7j0k7Pmu0JJ2mjvcSH/Nk/Xq96BhYryjJbpoHeYfG1xBb7GlI LiCMwzpOGE7aoXmnETE9dRZ4q8JIE4nO+m95j/8jT8aIaOjv5gVJulDJnbuN X-Gm-Gg: ASbGncvMbiSTmQADV9ewM5Ocv+RvVMMcyj1w6+fS+VivplgNpVRkfbKkPhTmpcypnji hgWpMP4rwlHBAF5jmasAYFO3BEf2JCjyKHE0MpnUvRFUFzCfZw+0S0TURfELB0011AZ/l8jZjem Ar1WBsD8FpmTZhVx7CQQRg2IV0DZlStLAbt/O1vDxA2ATSQYrYezyDBsFoFdctet7j0JUxmZ6Si fDDo1L6Gg9QpUICNjns797J3K/7WX5v/y/BRzdFN9HU4JzJcJ3RVIHH2T2G6mEch7rzRfJd6w== X-Google-Smtp-Source: AGHT+IHyIDpFbtxum2F/FGPlN0OSHNr+7TGpsEQg9dIcrsecQPNRV8FG6NvY3FrlzIr+AdNxjMj9WQ== X-Received: by 2002:a17:902:d4c4:b0:216:2d42:2e05 with SMTP id d9443c01a7336-219e6ea19b2mr377219755ad.22.1735218043773; Thu, 26 Dec 2024 05:00:43 -0800 (PST) Received: from localhost.localdomain ([2401:4900:5ace:1ff:7a15:c610:5444:2ccd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e764sm119364385ad.62.2024.12.26.05.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 05:00:43 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Greg Kroah-Hartman , Meir Elisha , Philipp Hortmann , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix network selection in rtw_mlme.c (completing todo) Date: Thu, 26 Dec 2024 18:30:24 +0530 Message-Id: <20241226130029.1394-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this patch fixes the network selection logic to avoid selecting a network with the same ESSID as the olddest scanned network if it was scanned within the last 500 millisecounds and please give a specific value for "new enough" on line 481, i have estimated 500 millisecound but inform me if the value needs to be changed Signed-off-by: Atharva Tiwari --- Changes since v1: - Changed the "new enough" value from 1000 millisecounds to 500 - fixed some styling issue drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 5ded183aa08c..6604619d1b99 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -481,8 +481,11 @@ void rtw_update_scanned_network(struct adapter *adapte= r, struct wlan_bssid_ex *t } =20 if (rtw_roam_flags(adapter)) { - /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ - } + if (is_same_ess(&pnetwork->network, &oldest->network) && + time_after(pnetwork->last_scanned, + (unsigned long)msecs_to_jiffies(500))) + continue; + } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; --=20 2.39.5