From nobody Sun Feb 8 18:30:02 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8675219AD89 for ; Thu, 26 Dec 2024 09:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735204468; cv=none; b=Np8JzgIbbQ4XMHG7N18efDXXiNMu/UZR6odRPArDF9qcLcLahE11GEWKZ+BA6XIWRzF7Rqrzi8W41JLNM8Apsi2yCDtiY0YagSKSEnSY6zUwBMRDQER+wv55aQB+HP0mg7xm18ox9G60ObhysuDh2zihPeRmn05kswm4A6xSnJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735204468; c=relaxed/simple; bh=RF8Abur1As6TnbgjM1nG8SXYqzMTgqTuhNqUYQ15/IQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=safRv7GssqRTP24WEeueppHcEMvunE0fdwvbFbie9ZaXfegjKeWIV5R+qLaxslKPQotp6MoIQKLON1TbogzmWwFIizYi29Jq7wXYWV1o42eWY8ZdPBKI9ZUoAwnPemDBpejrfsN3kAfDwiGLO+zhqZVlewBVjX8r2o8UfI3xhuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lxt8TgEJ; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxt8TgEJ" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21619108a6bso64957735ad.3 for ; Thu, 26 Dec 2024 01:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735204467; x=1735809267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yRxgseqYg6SG0Gngnlshhg45wwA+5RS6D8NBrS32Xz8=; b=lxt8TgEJnjyTTKaB+ZfpE9RGk5b4CfzemCWdQnAqHf1oVAfqk2A+4ZnjL/JoXOQqOM cMzV/jhBb/M/pagL1VH/NJKgZR7qaI00f1fl5NlQhNjUAZXBw9PwNsrZpW7ALjY9BfZ9 a6SUqvVs0NqdRrYUvDh47Q01US1ayQDN39DPwzYBTTcySaDQGpfvLA+GMRjuxyCT84aH gX+RQI+Ida9WSyPLP1MJhEqLXT60aw5RZsLdXonXympetLQ4eQ/mVKrtjrHd6Z6IOTj6 vg91p/7Ay9zdGC/79qeFwaJZzTAP4uEsDo39Xd91ti+ytZC/aWjI6c54z8X9SCqc4O7X MnNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735204467; x=1735809267; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yRxgseqYg6SG0Gngnlshhg45wwA+5RS6D8NBrS32Xz8=; b=ryzYGQM+LU53DqXaxJ3ywrFWirtlFnZDXRRxhvgHJsw+iw+gevUcZXPsQ5/DjXFm2M 0H78I9ilY1a0UZnrZ3/oTPhAbj7CneDf9nUV7rbgH42Nsqe6et11YC+zjNNYuGwq5NP3 rykWecC+xf16EeUqswInJ6Y2UiEp47yh0cqdMsfTNF7gGicVERn5TsvVyww0rM6hd9fm gGoJTfA8s2oBxV2NjzlxmCOJyun6u7SkkkiVB630NAhwxNSP8R9/KubOxl/SGBq5NoLD 7/gjGH1Q0pNpImSHyk+9zVk7zJZ3MjsQZY7mNZTnRp0JGIHBqPYfnz8L3qtMFxAbcoGU VT/g== X-Forwarded-Encrypted: i=1; AJvYcCWhEELenjgtUud3y2frZZi+56+dl3d18nyNdHLXdyAKTNujaGQzDsnXdWb9m0QiZuludZmqsoPtMYoRhgE=@vger.kernel.org X-Gm-Message-State: AOJu0YyWAEcBmIQrzEVov1PxPOOhYcpy1O/tTikmBWYqVxPKCsVmqK+f jVHb0WwI2QCnx11qHvBsQpE0riGGVv05IjXvTd4Wmyrrq4cUr2ab X-Gm-Gg: ASbGncuF+uC6K7iIq1rGTPxfmjI2c+tBnXZPfiSjdcJb+71uYv623AnpuFAjkH9dm48 gWryske1IiXT3MeIhS3SYd/JK7JiPfBACqZBfVBafpozNZlM7iwSFlFkPL6/B41jlwR2EqZx5+5 Qv+sqZ6n+JAZj8x11/MLwTDqW4FOTq8gjGw1MtmWDN5Kul/J3gTSWjvjZOlLePxUYimG6c4M86C pjHy17uM7NUiRq4gT2lP5GKgK7y9PdPLbwVZks8d446YiwATlW7XWBqXJ4VG8gD2bqv7mI= X-Google-Smtp-Source: AGHT+IEOBHqXUmOzyotxhs3wGIge9btnL6d4lDsSjbWe+s52fbOBUT32V2yHItC2kgcocvbQr0OqIw== X-Received: by 2002:a17:902:d4cf:b0:216:2426:767f with SMTP id d9443c01a7336-219e6f25d6bmr264940005ad.49.1735204466701; Thu, 26 Dec 2024 01:14:26 -0800 (PST) Received: from localhost.localdomain ([2401:4900:5aad:aa2:cbe0:3ae3:20:fe15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02ac2sm115845255ad.272.2024.12.26.01.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 01:14:26 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, James Smart , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] nvme-fc: add DIF support for intergrity metadata Date: Thu, 26 Dec 2024 14:44:15 +0530 Message-Id: <20241226091415.354329-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch enhances the NVMe over Fibre Channel (NVMe-FC) driver to=20 handle requests with integrity metadata (DIF). - Added the inclusion of `` to enable integrity oper= ations. - Implemented support for mapping integrity metadata using `blk_rq_map_inte= grity_sg`. - Ensures proper handling of requests with integrity metadata, including er= ror cases where mapping fails. This update improves the reliability of data integrity checks in environmen= ts utilizing DIF. Signed-off-by: Atharva Tiwari --- drivers/nvme/host/fc.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index b81af7919e94..d0343133413f 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -17,6 +17,7 @@ #include "fc.h" #include #include +#include =20 /* *************************** Data Structures/Defines ****************** = */ =20 @@ -2620,10 +2621,16 @@ nvme_fc_map_data(struct nvme_fc_ctrl *ctrl, struct = request *rq, freq->sg_cnt =3D 0; return -EFAULT; } - - /* - * TODO: blk_integrity_rq(rq) for DIF - */ + /* Handle requests with integrity metadata (DIF) */ + if (blk_integrity_rq(rq)) { + ret =3D blk_rq_map_integrity_sg(rq, freq->sg_table.sgl); + if (ret < 0) { + sg_free_table_chained(&freq->sg_table, NVME_INLINE_SG_CNT); + freq->sg_cnt =3D 0; + return -EFAULT; + } + freq->sg_cnt +=3D ret; + } return 0; } =20 --=20 2.39.5