From nobody Sun Feb 8 02:56:02 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A41A323D for ; Wed, 25 Dec 2024 15:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735141846; cv=none; b=o016L5lRrUw9p7bnM37c5XwPRUv7fYaqc52HSPRTaad9w/1MbRwWHX+bcy2+NY27emcykqW0IHzC105U/g4jkSTTvnJduvBXEYUtqRSDZ8Q3R5/qHthFPdycK3+iZR72f4n2S6+9cNvrVV5J0ElbJb7Z5kJfCZB2CiDHwm7Flgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735141846; c=relaxed/simple; bh=So07i7TsRc8MZo97SNl3OBIKdmzGjmYOs15PooVy7f0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pHl/VHdmBVRZ7LMIwSsnjnbKf7h7Do3oenoW/oD+q3WuP70055lvP3YPYizn8jpnK8rZAMC0yxiD5t+W/Gx59nMhqcVYDaELjcubOqmuIJJDVrvueqgmYM4m8EtLXAnDMTh09ZnbfgrmcAWqKPRLz4wHe5RPsx6DojqTxaHGrFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bkVAsmtq; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bkVAsmtq" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2162c0f6a39so72500105ad.0 for ; Wed, 25 Dec 2024 07:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735141844; x=1735746644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=bkVAsmtqNbTzpptxmU7CFLwfNlJniMQ+09oD/Gyo8c54JCIsx292bnKRt94mZRxbld eHvL775NUMMRdANT5LrXSDgekXF+TRtc8meIZ1C1JhKBSumW1MNtXXiXwfO1kA9pkTmq MtwWVAsbIqGt6ITT0zgwE/UQO2GrOBKiGh7tw2qcrHH3vYpORXBuiRU/V6b1WnMke+xH FNpw6vrzI63mAQP+T5bttIFzI/uqfJg+iAqyNdAM7LwoU1ByEjOBWBfAKVQlylfvPdMl 2mrxSn+PIMtCFWi9TwqSgQXVGrcHEzxhA5hd1lNq/6YrxRNqE/iXmfJmP433rP85UMTg SoOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735141844; x=1735746644; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=FijQBfXrtSkTVO0PuL+79P0ByFNXCwfRRtRhi+a78dop3A53Zy+CoB/DO7sI4+crLS wImiobfLx85IluABDyhcQyrQ1L4oiADakTHIm5WGddlupxcCpUQH2v8Yoqd9BrDrCRmr j+hg5GioKFiKJnHE/fKLacdii/9hPmMvlNvpepi43ozsRnflJUsuGw1UeCfZbdbNMN0b 0qzSYUVkW3zPCpq1loOhokJ28J55Y1uTcw/SAhxen7DOZBtNO37RjOgVzU9eU91FV6KP 87GvHMIlm9S3MJg28dBd+D8Ca1xoI1Ai3HqnzfIzBm7v28mTWKD7P61MV63QPE2Eix1x xaDQ== X-Forwarded-Encrypted: i=1; AJvYcCWRAHkagnAQt1zYWiedCjjMrl3q+FMGpICKHJQAwuEjq6cB2ZvH4k9/jFOB6yLCx8DleVbTus6mzXPT01Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzIYIaZ2QB5kl0DooSbPVFBoSgt12Uiwrv6SHin1nF1y1aw14WA RNu8eIRz4P50dxXdFwL4O07AJZ1Kcw5IHd+/EvGrbrb1hS0Osg4a X-Gm-Gg: ASbGncsSSHswVpz5Ij7fUyXz/ng3nLDy9HDc9l02TR7BNE++jjGrY31wP0bWWmDWD5G D+Gnv9Gmk+9MNjzulqW8m3CMlp+DmGNFdmkrGojhGiLvPkdZHJ+6K1Em61qKWp0+QMtgpQMB6sz F7OLXoqf00qGf8+FVVs5bH1PTEibIa5kz23NrFPfOeozPWc58VRUtk+qD5hhdxlBPRaaZ/DALOj w64LH93CEKtasw05kfJYpFxLfV/p74WPTCsotHujV7Gfi8bNb+RlrU60zFn6Myzp7JMVqzahA== X-Google-Smtp-Source: AGHT+IHk4VCFATM1zibsiLswORFtbMaiQwipNLDFy4J1ilbiYjqVxttiXpAxKNQJyz5/2PmPmD0EnA== X-Received: by 2002:a05:6a21:9994:b0:1e1:a75a:c43e with SMTP id adf61e73a8af0-1e5e1fa1f46mr30696996637.22.1735141844377; Wed, 25 Dec 2024 07:50:44 -0800 (PST) Received: from localhost.localdomain ([2401:4900:5ab8:35e9:ef1:8e18:d059:3434]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8fb83asm11319776b3a.138.2024.12.25.07.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Dec 2024 07:50:43 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Greg Kroah-Hartman , Meir Elisha , Philipp Hortmann , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix network selection in rtw_mlme.c (completing todo) Date: Wed, 25 Dec 2024 21:20:31 +0530 Message-Id: <20241225155034.1154-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this patch fixes the network selection logic to avoid selecting a network with the same ESSID as the olddest scanned network if it was scanned within the last 500 millisecounds and please give a specific value for "new enough" on line 481, i have estimated 500 millisecound but inform me if the value needs to be changed Signed-off-by: Atharva Tiwari --- Changes since v1: - Changed the "new enough" value from 1000 millisecounds to 500 - fixed some styling issue drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 5ded183aa08c..6604619d1b99 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -481,8 +481,11 @@ void rtw_update_scanned_network(struct adapter *adapte= r, struct wlan_bssid_ex *t } =20 if (rtw_roam_flags(adapter)) { - /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ - } + if (is_same_ess(&pnetwork->network, &oldest->network) && + time_after(pnetwork->last_scanned, + (unsigned long)msecs_to_jiffies(500))) + continue; + } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; --=20 2.39.5