From nobody Sat Feb 7 18:21:00 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0F5B2E401 for ; Wed, 25 Dec 2024 05:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735103891; cv=none; b=Qzhsed7IZja+28soK/0pEWasRfqRBYQxxzuZ0PdMg2VyfCb4qjlE5omzh4ygjKwhpKRj1RIyA7CzbjS6rSSU2smmycQF7PBEBfdlSHu+1IcQayhkl1ZCNmbCTXN3OOdnV2eqIEhNhMxwY+4L7b4DJLP2ZqGwHr2mjE0gWPHn52s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735103891; c=relaxed/simple; bh=So07i7TsRc8MZo97SNl3OBIKdmzGjmYOs15PooVy7f0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pte9UXZVqPhTJxOnjHXhlgfK2ISD3C9HodgeqPBb+oomin9YGxcCwVk7VSHkuV1Vp7RsfedoQ136f0H/Klp1MdO79lgzbLzu0f2oiVCgvxrfxcYtOe4GKzSDC4QJE/2EBr8zI3lz7axm6oIC1Dh1y3Y4Jfi3BuA02LTKDHDbbbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WI/tRiKi; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WI/tRiKi" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2165448243fso71269545ad.1 for ; Tue, 24 Dec 2024 21:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735103889; x=1735708689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=WI/tRiKi6swXpkwEsttsVs0I9J2cEDGdhxfGkzj7x3QXOsL6ijHq5GdbRly40VdcnU orvP3gO6Dffft4GuhwH+ZAhGf1lTy6KL2w68Io0Q21CyVYIaqY7VewS7YVKL/p0x2XbG FdabMSgZAjscmQXLg0tzdYKR68myzHc0NTDszeGZkcMyS1c+wcJaugi7I60JFo3fbrzV lY5Jthh5q/oe2ApLX9D/AunMtZ52fUjJeRmbN5hsWODvYRcIrkpWUCVgP9oZUkNVxQ1H AefcWjMRmyrestbTixv8iPsm5JOfbUfP408Pho6BpGadZyDthywxYDzuiq89S3ksbv1+ BqWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735103889; x=1735708689; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=LGkcoJ6ptrU+pSJzHhXwckIakEQuNSwrb9zH4DI4LpQJTfeiPY42MaHWctmXxg0jcz 7J+z9MQZH0qaIr7XbxT3i5SpbJc0D6L7NRLokD1qg6LYqvFAD7DGxwQ5rcIjJQCIGBb5 adDAo5uCR0pISUI4U6OMKBNhWBSBQZRSbtMudwAQITq0i7El3i4jVDdItcOYK2cJ1bBJ 1OwGt35lm9Ti4dRrvoZYvbzIna6GJbnaJGAfGg+Q2M95JCRuSYhxGiLjTngmnmGKeCdO 55tZRsuAuybNP5AIrfxjCeiP3YnTRQYf5sFTfus2Q5OXqnD4VP9wNh4iHWOZwKwTjRC+ 6GyA== X-Forwarded-Encrypted: i=1; AJvYcCWjHrRekozbNErxKAn4LHeosXELQQbIUf6ywPQdKtzBgSJSngwdMhke35WCqfFs0vBCHkIZW9/eY0t/74M=@vger.kernel.org X-Gm-Message-State: AOJu0YywPyLkXRanHZwcZRZbChMrDGLA5ChdHUEl3BlB92Pvd/+iL56J MS3Ijn0XnEH5ZV7nQtnDSQ9krRD7HkmBFVPEu137d0nHxyyJkZiXJO+g7Q== X-Gm-Gg: ASbGnctyjb6orQuR60uVXprx+EqffhvrvmSgj6+rgvTr7Hie0g/UAeJtjZskfiHfYLo dVwPjnGjj7QMUBP7WI/XXx+2mjfD9yS9GExl5gm/sRIlS1EVAO03rwAzXv+59TinWHfB8w2ucA9 lP/4Izaw3A8+1hrn34os/swFuoWHQfZ/R8cuddb07Pbkpd2Ckm6YOYCF54fcm/dSgZOIbjwhr01 RiPPJbNxfKGrIcbbAVOs8UTAJTXZEhekqLZ6Pqs2OA4BGHOx/wNMSTReJavRJFFpB3K47KOX+A= X-Google-Smtp-Source: AGHT+IGnhNeI/o6Z6136CQhEX9o/eHGeoLXSEf1jk3MjOThRIU6D8IChIdqn1YYLplO/yI84hWmsvA== X-Received: by 2002:a17:902:d589:b0:216:45b9:439b with SMTP id d9443c01a7336-219e6f28486mr267496755ad.50.1735103889194; Tue, 24 Dec 2024 21:18:09 -0800 (PST) Received: from localhost.localdomain ([2401:4900:5ab8:f8b6:ea17:916e:35f4:2275]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f51a0sm97584945ad.187.2024.12.24.21.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 21:18:08 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Greg Kroah-Hartman , Meir Elisha , Philipp Hortmann , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix network selection in rtw_mlme.c Date: Wed, 25 Dec 2024 10:47:55 +0530 Message-Id: <20241225051758.1305-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this patch fixes the network selection logic to avoid selecting a network with the same ESSID as the olddest scanned network if it was scanned within the last 500 millisecounds and please give a specific value for "new enough" on line 481, i have estimated 500 millisecound but inform me if the value needs to be changed Signed-off-by: Atharva Tiwari --- Changes since v1: - Changed the "new enough" value from 1000 millisecounds to 500 - fixed some styling issue drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 5ded183aa08c..6604619d1b99 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -481,8 +481,11 @@ void rtw_update_scanned_network(struct adapter *adapte= r, struct wlan_bssid_ex *t } =20 if (rtw_roam_flags(adapter)) { - /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ - } + if (is_same_ess(&pnetwork->network, &oldest->network) && + time_after(pnetwork->last_scanned, + (unsigned long)msecs_to_jiffies(500))) + continue; + } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; --=20 2.39.5