From nobody Wed Feb 11 04:36:41 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2334A2135CD for ; Tue, 24 Dec 2024 23:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735081837; cv=none; b=h/1YC3sKXq4gh6j9wnF52uSO3FiPU9CAALNjAdlsKyokiyPIzA/LPHeLE67igUXVqyXCtTm+OTxy59cwKf9Cpr4vhNgliH0kJZS5th3MWiz9ynVrkkPqxG5qt283Fnvvq3aGTIy4w4+riFFH4sfXRrRDDAVTa9s3emrFwKOMQP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735081837; c=relaxed/simple; bh=Bh587iD2fc71HoCxezk2yuAVtboO7fHMro855SCGYPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gbylcQN92aGu6iRqdWH8ix8PWZNQd8xowdWBSyTFiBPoAQNlHrj8I28PJYfiJqwaECRDy/U+HKzhYPCiEoqPUkvgj5HNXCIq/kOtMl4yVEJZH/JH943FU/sL5aieQDlbAT0E+Pp3KuMvpq2mpGw4/WY770ygW2hwQQR7Au/k+78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xmONXGdL; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xmONXGdL" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5401c52000fso5578659e87.2 for ; Tue, 24 Dec 2024 15:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735081834; x=1735686634; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=efhfp+4qW1iSmQeuDMr+e/8ImYQLWTnZeSHC6Pg4yQI=; b=xmONXGdLC8OYLS7C/8ZDXO1mfP1SZNfJBz8O3rgOWyAa1ZGYC7vfhb/NRdRsHUD+a/ ZblABimEFA45WlRdp60xtlDw7bIBffLkBPaufmdrzj6ORJ5H7fCNqGQcgdfoDRz6RyEO vMOddhMEtTVI5gaTDb9GgOOFeNGXeIfsybexcuf0yhuu+S7HjkmoFyRBWkrhGgOAwuSJ KyEVNJsvTExtEi91VcfS48tE57GpsbRNyuegzFPyfRqpkdkd235Hz2tZN8a5WFsn7BBx xfRaFCcAQ0/g1hg9d/+SJ9xCpRwNJ+xKwuxR4WSxaXdQcUsjlmeE8u5F6gmkughjdZi5 pNLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735081834; x=1735686634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efhfp+4qW1iSmQeuDMr+e/8ImYQLWTnZeSHC6Pg4yQI=; b=H9LPHrAoKyjZal90/37VxlLYM5j4Ji3jlb46iyzpmXJKOeHgRKkMp66Oa10kS4ItvD vQU61vlSAzEB0FasqVmjUb/KkNOz0dffuOoB3BA/+QHQJiFdXbUWcd8MxcxVZWckwC9n uWcyAlxj73V/AykCYLL7tapCytF/xae04hk+BSdnifij55Kf+WXKy35OEtbu9i9PTo9Y kcqkm2BgaP7goyLCY66xyaGFrIFs7OHjJwFSsjtgX8R6Itx8rYxJI698inCpiIPHszKh 8Y1Da6VkByarxGJDm8GS+FfGVjuDAjTfTdalPW7eHY8WI4VuYFNWyI3az5v9+t/WkJVB fnGw== X-Forwarded-Encrypted: i=1; AJvYcCVXCblYMFM/lE8uTziyvCKtfU8iJoXRTlCmIFTHCFrSyG8LZ/GMXrVWQtfPl/NpV5zudVWK+yIHgbexcYU=@vger.kernel.org X-Gm-Message-State: AOJu0YzAG0rAQlqwQnFzgJnHYHqyW1iOjJYmNP5ADRmbUFQrdW+nlnle kt8Z7Jxez4aURB2kqD51k1RNnDA2xvT/dxE0QrBPdwjoNUSLHB+VrGaSFV7gMI0= X-Gm-Gg: ASbGncvGMgapty4dLHB+vn9Duys6prOFkOdnBY401q0bFNEOIEsZTtMx7FpY+jbVHBs x+gwlIJ5ukPkfWFkkGv8eS7SjDM/IrwSffOldOWbDFLhQb/f9ODnAyiWI82GvVeh3fTf5IrExxf BAsQ0WoMZW4m/7cJvRPR8VyCKRujRD8ulUOaFp82lx55wyXc92bHLrd1RxOKGuii+bRHAMLDYnQ PDO7G7s34S7Ni/6sMnI/+cgFWS76Evc20MRdJhV1vgHUFKZ8Gjnk43M42BujQPu X-Google-Smtp-Source: AGHT+IEhaltbYVeYVnWcTZEGij7INLhjOGoVthIuxjQxvZSLrBa/jDt55eu9hG868SnM0PHocdwMyg== X-Received: by 2002:a05:6512:438b:b0:542:2999:2e43 with SMTP id 2adb3069b0e04-54229992e47mr6635799e87.24.1735081834230; Tue, 24 Dec 2024 15:10:34 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-542235f5f74sm1721283e87.43.2024.12.24.15.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 15:10:32 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 25 Dec 2024 01:10:15 +0200 Subject: [PATCH RFC/RFT 7/9] drm/bridge: move private data to the end of the struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241225-drm-hdmi-connector-cec-v1-7-b80380c67221@linaro.org> References: <20241225-drm-hdmi-connector-cec-v1-0-b80380c67221@linaro.org> In-Reply-To: <20241225-drm-hdmi-connector-cec-v1-0-b80380c67221@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1860; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Bh587iD2fc71HoCxezk2yuAVtboO7fHMro855SCGYPU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnaz9WxA+sQ8KjJROIrN1f0Hf4EKmOFjAonnPpL YW1LIJq3eCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ2s/VgAKCRCLPIo+Aiko 1YOtCACyMIuozXLT74TZyjuf318MVOI0LGrevexAAORnXjfKs4jVI5zj0NBxle/Q4OYEKgCL+ia 3sMwKNg495laf8mJGOrgC2iOJ4gjvwTLxApO2F12iPsOsjHBezwr/pYup2f37ktYIKXflBtnYRD K2Bz6u6XGiaVcQR31TH6W2vBjt2g0HRGslOg66IlgR1noYnKJNa16r2kMfAYNUHpDnTv19cZAnB 2oAyJZrMkcuEUA7YvjUkXm665gFMrRIY66sLOgvVpvcMFM6QxvTjyuhxAQuyGemdbjim3AhlQ+a 4FxPKxOKY0nfJwfrDz+sDqVs+/SL3UaeL3JVz8yGvinz41vj X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A WHen adding HDMI fields I didn't notice the private: declaration for HPD fields. Move private fields to the end of the struct drm_bride to have clear distinction between private and public fields. Signed-off-by: Dmitry Baryshkov --- include/drm/drm_bridge.h | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 1f1670e3c6aac39b8b891b0d5e7e91254eb0d3a1..348778f233b06265a6ae577762c= 6558e69cdb396 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -872,21 +872,6 @@ struct drm_bridge { * @ddc: Associated I2C adapter for DDC access, if any. */ struct i2c_adapter *ddc; - /** private: */ - /** - * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. - */ - struct mutex hpd_mutex; - /** - * @hpd_cb: Hot plug detection callback, registered with - * drm_bridge_hpd_enable(). - */ - void (*hpd_cb)(void *data, enum drm_connector_status status); - /** - * @hpd_data: Private data passed to the Hot plug detection callback - * @hpd_cb. - */ - void *hpd_data; =20 /** * @vendor: Vendor of the product to be used for the SPD InfoFrame @@ -938,6 +923,22 @@ struct drm_bridge { * @hdmi_cec_notifier: use this bridge to register a CEC notifier */ bool hdmi_cec_notifier; + + /** private: */ + /** + * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. + */ + struct mutex hpd_mutex; + /** + * @hpd_cb: Hot plug detection callback, registered with + * drm_bridge_hpd_enable(). + */ + void (*hpd_cb)(void *data, enum drm_connector_status status); + /** + * @hpd_data: Private data passed to the Hot plug detection callback + * @hpd_cb. + */ + void *hpd_data; }; =20 static inline struct drm_bridge * --=20 2.39.5