From nobody Sat Feb 7 21:24:26 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361AE1BC20 for ; Tue, 24 Dec 2024 13:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735046430; cv=none; b=EoyMB/c0xNCWljhKOMoVcAlxEapziORRs81ymURvgVe9QfYvO9QFVegKa/lGyJAih+qPJZEsWgL4d+nPE83U3LWeLH3vCipCkTmxkcVdLKPKIzfkAMfayKyXJGLj2gv6faSAQyTx0EE9d+63vrdfMYBCFHH1XlhlXKMNVmJbddM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735046430; c=relaxed/simple; bh=So07i7TsRc8MZo97SNl3OBIKdmzGjmYOs15PooVy7f0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=S6lUEzjacJ9YHFIxRAJ/d4AEQmdLN1D3OMXPOLIausojvQbKDybmKY/3zJGLtaRovfAGFMUF3U2+mS9ETlnhUBA57cPu0J6xbWVC+wORo+J2u7Efy+slrwavagroF4BNl2kAivVKRUczA7UleEPLM+Ts7DQFYcneHfG9xuEnBDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V0r99/tn; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V0r99/tn" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21619108a6bso47005215ad.3 for ; Tue, 24 Dec 2024 05:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735046428; x=1735651228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=V0r99/tnOvsYF9z/XOdEUTSqGB6MOpEtdzoW21QJuz0gXhlslFm3IU+sIyg4c9canC TnC1tZU17arn5rufNjVnKWm8Vrd1UXhI3MVci6jOUJgOL1dBZcL9bZe5dI0yE8ZIznjC uKqIZXthZZzrYMAgpOTxMPSwEVYEVJJsg97G2ExUlmDfoljBGUdvwWbAhSV5toNbGm7V npvzXg2uUfxm/qSpyqwcJHz85LAorJHfb4MJuHbX5wwvmzqCOJCW57LwX6zV+xtj4XWE R/Ibab6SNlAPy9EYaqKfTLmwxR+WbVewzNAjZgACpDU9w19kXiJvFr83qislqS/7Wmho PDbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735046428; x=1735651228; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hhd15APbcYRqWh+wXaifbceYc7BmeJiVjQiC8yBJW2Y=; b=TSAmGF5mdMvdRQLethLf8fHCbkEvzge8BSfJF1XokkCe45tteEIL9B+jDg455IK5tN WybN5rcvT8pcg+E5e59ZK5ujyHAf+QuEdbYXA4eJBRTSQDBev9gVdM6m+P/c7WxuUgap vx3KlXDUAPLCmiR9L2o0CO/UYMalzSmiMTNpYSmQoBobiU16JVG9eL2aAmggeEMpVD2B NZJ24EwO12wFk7LZRhWK+Z0MO8KeW/wCdjiM9DZmxKkKXIV8OD0eVUW8GqbmfxevVRwV HagOPXgxZq3kNWCyzPxiVVezeQ4MxYxOVP4GNKdrqTJswCaskmkUWET1YZzTBKdB9Fuu v5XQ== X-Forwarded-Encrypted: i=1; AJvYcCV8F2vB5hbaXfLq1HlsvchcnYIR22CilCSybEyjjyrUl1wyjroWum+Z3W8ndLhYodilTIuCzdiHPv6bSOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3cNYruZO2r2CXIx8cqSgt4MnVZ4YIkP281oE96jBET3LrvdGT SwAlxy51LKBRqYoh4bAzZ/GZaIdJeyiJqcIgkGkvbnf0bpsLEWRe X-Gm-Gg: ASbGncutqZeT1369SqIzSgQGggcce3rAVZE01Un3URnMCkdEpxV2jw8wDlO1c9qr6/C yCL1WC2wEOjDMWQ8cBGS1ZumVs4/fXy4RAbbp9kx2mo1oRI23rgXaoVDAY4fxyq7BdbkD4VULR3 QkbuGCk9a9IualhsSEWqOhi9EuuonQTfsw20YUA6N9WGs+7rcZz7W3/I1qjIkoHYswnJzbXvbCa G81FKkuvFq36HtEqCCeTVSyceP+ERUcN3V5HJIzstjQuXd09gQMLi4GY15/BAIDbif7OYRIi+k= X-Google-Smtp-Source: AGHT+IHJZM5TNdcX3fuV0F4Sl/9lZE4ImDD1ZRKAbGw+CJz9LYrra657DAAEa2qeZaSgxLGWaQV7nA== X-Received: by 2002:a05:6a00:8089:b0:728:f337:a721 with SMTP id d2e1a72fcca58-72abdd7bc30mr19857385b3a.7.1735046428465; Tue, 24 Dec 2024 05:20:28 -0800 (PST) Received: from localhost.localdomain ([2401:4900:5aa6:b9fe:4943:be7f:75fd:aab3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b2b3e83dsm7545589a12.32.2024.12.24.05.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 05:20:27 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Greg Kroah-Hartman , Meir Elisha , Philipp Hortmann , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix network selection in rtw_mlme.c Date: Tue, 24 Dec 2024 18:50:17 +0530 Message-Id: <20241224132019.75475-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this patch fixes the network selection logic to avoid selecting a network with the same ESSID as the olddest scanned network if it was scanned within the last 500 millisecounds and please give a specific value for "new enough" on line 481, i have estimated 500 millisecound but inform me if the value needs to be changed Signed-off-by: Atharva Tiwari --- Changes since v1: - Changed the "new enough" value from 1000 millisecounds to 500 - fixed some styling issue drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 5ded183aa08c..6604619d1b99 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -481,8 +481,11 @@ void rtw_update_scanned_network(struct adapter *adapte= r, struct wlan_bssid_ex *t } =20 if (rtw_roam_flags(adapter)) { - /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ - } + if (is_same_ess(&pnetwork->network, &oldest->network) && + time_after(pnetwork->last_scanned, + (unsigned long)msecs_to_jiffies(500))) + continue; + } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; --=20 2.39.5