From nobody Mon Feb 9 12:09:11 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B021B4120 for ; Tue, 24 Dec 2024 09:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735032502; cv=none; b=HKRG9AC4VCgDSmq4Emu124LYx6rZJjbRztgVwMjzVJ58aKSCI9k+rLQIuNgOoX/ApOjsLEkSXwl9y/fqql/mmpbMChS94YIpPoZrG57hTRuM8B37KcZsNrxDlaYu9JZmjfWz2HbIy9UbotyltfXhCZVbWjsaoEjaEQzIOtIm+Us= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735032502; c=relaxed/simple; bh=glrL9frKUynd0eooWslKXIli7Wwl1Of8mWNqeP69AkU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=E7gUTBPuzzKq5sgKDP9uoTod6Q9uRkKNRQi8Fb5tURqGv/H956wxmCTtEuRnCRF+YeV3rjMPXCWMMlsWpsd1kQ44CYMS/EIARtU/ZQcDSV9xGak9Xm78uRhx1B7bA8wnjVbHj1N9eC0z5/HWJLhQidqHoymqqWTzG9X7mHWZUEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=CAYi7rBR; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="CAYi7rBR" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2165cb60719so50689135ad.0 for ; Tue, 24 Dec 2024 01:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1735032500; x=1735637300; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=CAYi7rBROIkGlrJ+4szhABKzVk9vFWzuKLlx6WHPvuNodk9UI8+doU07grDd178ANF 3vavNQqeBuWHgn4Afuv2F8YyokGx6dzwIbQwftHCnp1o8HHGm0EeXwyNpTaHu4Pj10AZ +pgRYZP/05OCtlCZ6kY3uWg5ilAb5cLpTWukIy+GhHHWrGDy0pRXLGbwhaW8pRe8EALS yxJ2iMBC1u8xCp8fY5f4kHZU07wGq+o3aCNcqZ6WEN8xd/M1Phyq9WI3mOOTTKs46H6f 2epfuLtGM7Kv80ClUSXlHVYNtiy/dc8xZjlA+BvIo5yYOR46YMOGjWBHmc2YApVCEV8/ 7GXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735032500; x=1735637300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=Ew1Mf8r7Z5GWv157BXM3nlhxeNZnfnNjs4SqIGjo5XXDvqgfijeMEzxBVuTeOEtnlw 9Ph/HaFkJc8Q6P1zPIwYKZQWTVRTD0rdQtgZ5ujJWj2l79OKjeW4b4REuberVXnCryKv /1TOhThCBSzHttG5OcgkWHVKPeezficmvwt5VIjWRTtpUmY1MEZJY1cLsk2HvIDoQiHC 4u3RYk4hulsF7u9FxluwvxVW5HlkHL4X9CyQQXCQcQpE5V5v+ia7liF4lMNb45qgE0V7 dKOLMyw7UrjmEfZfcXWEuXSNskv869jWaRPlfQV1JTh2AAbSRXYB84Q7HBlzp5nVD84p Lp5A== X-Gm-Message-State: AOJu0YzaLvF0zdU8Trw6vZee8dYpmoxGrOwH3bfFcCMk8A5iWXq8Hfkm iwZW7F4mCgnXPpEzmaXuNwbXxjiyZzwVeJ24OQlCC1Fm9NuyYp4ciAZ0BeoooXS88uz49QV3Yrg 2HcZ1Cv+aUvl2jH9/zaUeSj/1SRIW6CX9V+XsgURH7rDeyffEdF9Ue+GoNDCY6ttLa+ny4s4quM b0KxjO8sYEJmsItvvj73EUhIuVSl4HplRJZJPJW2ybIOk7YyU= X-Gm-Gg: ASbGncttg/U6fV2A6A6Y/0dkWQPPySA+UPSO1DIH2I5i03f2U4PSZm23SKbMVgfKoHo DRpCERcPDrwfHuGVybGwVcgrl+5a4bGfqFJ3NOuKQ32UtvPvXKs5g7bNhMFxTZsn+VLAitsbhLf 2GfJfCokZbcIvahTC8yHXgPYMhE2mvVUnXkHHaM7ZJpZlW/vXXXdBCfZ3uBJgtEZCgAH87hb0Km uXMAxnOJAc8GAe84iq+iwzBxRK12BRv9rncvYw79t68xB//Y2iS4/m7J78VVWOz7jFbppn3zuMn LDrXTaaz54a5b8a0vg== X-Google-Smtp-Source: AGHT+IEa+eM9lY5Aysf3MKkJti9gL8QjP+GyONH2JGutRyVpSEtvumQ8tbWG/KyFFjxNZfvlfPun/g== X-Received: by 2002:a05:6a21:6da9:b0:1db:e338:ab0a with SMTP id adf61e73a8af0-1e5e0447f5bmr29850414637.8.1735032499994; Tue, 24 Dec 2024 01:28:19 -0800 (PST) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72af8dcff60sm516341b3a.152.2024.12.24.01.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 01:28:19 -0800 (PST) From: Nylon Chen To: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org Cc: Nylon Chen , Zong Li , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Paul Walmsley , Samuel Holland , linux-riscv@lists.infradead.org Subject: [PATCH v10 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Tue, 24 Dec 2024 17:39:01 +0800 Message-Id: <20241224093902.1632627-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241224093902.1632627-1-nylon.chen@sifive.com> References: <20241224093902.1632627-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=3D1 pol=3D0 1739692/4032985) -> (ena=3D1 po= l=3D0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index bb9146267bc5..6259f8500f71 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_d= data *ddata, =20 /* As scale <=3D 15 the shift operation cannot overflow. */ num =3D (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period =3D div64_ul(num, rate); + ddata->real_period =3D DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->parent, "New real_period =3D %u ns\n", ddata->real_period); } --=20 2.34.1