From nobody Sun Feb 8 06:21:42 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 808BB86250 for ; Tue, 24 Dec 2024 08:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735030261; cv=none; b=MB+pHY6V5qy5HSZW/MQdfUE8ckkYQyvG2ulQIX3YikMNijnHxh0HoKBN33YfzoWcaerQmvbWED2Pzu8A9Zxd/lqjn0I5oI8+qXKD8IoBw5m8QSTPwsI6B1nYNBJq9GMujKcSMkbuwYNiDCJ4B92k0F7zWYwOTPS8YACPRnhTxpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735030261; c=relaxed/simple; bh=X+mZ93ngTaM2XF36TsfdNV3dsZT32YnhrJznnY0wzxQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mhaAEz6SknWOfMKBTSJRuZRMTcMuxA2N6MQr3D7jGdDZbPLLkb80Zdy2Btlvm8QICIvZ54I5yoEPr6OfJINhgoVYr1Qs+XicPKOwDTLSdv9CJMnxeRcg1gpc1vjmREDCZvGkfOuwsFw1xR4+8i4s2pxLHlL9wWvq5iJEt96wwcg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CNvoGp5q; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CNvoGp5q" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2ee50ffcf14so5066340a91.0 for ; Tue, 24 Dec 2024 00:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735030260; x=1735635060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pFaAhG/V1/HrY9oik5GMlHKl+zhkdejR0kTjHoEnx0c=; b=CNvoGp5qpSQLckbYI1zbG7dOwFeec8aMcQQQGwy5pukbkmficJN6q5B0Ha9q8q2q63 MjnOuJ4JY5Hvu/prpIs8FWn5S3Kp1AJz5cuFzXEE0j8LV8FtDdUlmNNy26t7Aw6vgB8R 9wBJGWelm6N1V+tpdwoZ8TK60uTLwH0huN600PTQ07pyRHxYRltFRX3ZvAT2el1gUo1z ou7t1l6vxwFdnMJnNmqe/jhWiTlq+oeP2ZZxdmnIpr8XCsyV1+8VBasqL0e144Jd5BxZ UmAKvvjs6IVvLqF+ew8Jm9637GSWmHzZw5Ltqri0JpGeptBJCyC37uiuwngNzRL+f2fx 3GFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735030260; x=1735635060; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pFaAhG/V1/HrY9oik5GMlHKl+zhkdejR0kTjHoEnx0c=; b=s4Vao5/piLWZk/3/s6PXaLyhLTSs2J/1OS25m7SrGXA7724e2lSbdk/XqjVCgSX+/+ nwhPwtLtNdKnX7RSPiJznblYUppcgkWJx62pEa9/BlHYR8UA8K7L/7lNy40oAR5B0tzV M1atIxawDyHeAYE16+2Gt30UOXUCsk/TG1wYd86RFH+yMViqSEFx1yUBv85A210JR5PO YhSd7Tj6wDNUs5hDRiO507O0iedaiiGkj+lX6z3aSenjseO9FzABEgBP620MByFr6nNO 6hj767o5ZzJdi1pESqiU2/+7zVN1c83H8tiXqlUpUc3FLFD8YAQkqJouQ785Sd4DMYq+ ISyg== X-Forwarded-Encrypted: i=1; AJvYcCVXc7ZSWcdnYQbJMbJaW5W6eyg4UNnpHGpb6Uu3OeQq161CexylpOR5E6hA/PftatG9KESIqmQVP/7aePc=@vger.kernel.org X-Gm-Message-State: AOJu0YynL26wuD8IPvqcowPanitVEE2OXvrvqZIrMrLPj9Ol1nzWZe2s jHl4zUSiPbccx7q1HcghdnVjwQIJhfCTSPaCnPQOPXvZZSG808fJ0euUTw== X-Gm-Gg: ASbGncv8NMRjgcQg5tSNFY5oz8wf85CWhePb2vS8CnZZ/nRqwoROkNu6HUrb9r+LRX1 lXg3ihY/L9/oa00CaVzl64JQcTWKwitDoGF3VsCPhPujXhPu3ZuMXUDSEY2KZxeM/YdWAIWtqT1 Ri4lCrTDNUQbiEH8oVASeNnK7MOSfKU2TUpX+YZ+VqU4mPDudCzEFf7YCRnDVIrIxCLo8OhlTiz Df0cewRHouzsDZvVLv0n9FgJ632aaAuyyuTI0SQB9VwxDm0lGJaFXw8TzkmMNCQACdH4DwEJQ== X-Google-Smtp-Source: AGHT+IHTFzzCAFMgryuHfIbVboE065/VKtWokfxB6FEw4z68RgQT6/HsIeJp+4K+QS92vQVrwDTCkA== X-Received: by 2002:a05:6a00:6f4a:b0:729:1c0f:b94e with SMTP id d2e1a72fcca58-72abdacf751mr18252194b3a.6.1735030259774; Tue, 24 Dec 2024 00:50:59 -0800 (PST) Received: from localhost.localdomain ([106.208.149.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad84cfb3sm9236221b3a.89.2024.12.24.00.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 00:50:59 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Greg Kroah-Hartman , Meir Elisha , Philipp Hortmann , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix network selection in rtw_mlme.c Date: Tue, 24 Dec 2024 14:20:47 +0530 Message-Id: <20241224085050.61133-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this patch fixes the network selection logic to avoid selectiong a network = with the same ESSID as the oldest scanned network if it was scanned within = the last 500 milisecond and please give me a value for "new enough" on line 481 Signed-off-by: Atharva Tiwari --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 5ded183aa08c..06db4f8a7e24 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -481,7 +481,9 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t } =20 if (rtw_roam_flags(adapter)) { - /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ + if (is_same_ess(&pnetwork->network, &oldest->network) && + time_after(pnetwork->last_scanned, (unsigned long)msecs_to_jiffies(= 500))) + continue; } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) --=20 2.39.5