From nobody Thu Dec 18 00:10:43 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68F51D90B3 for ; Tue, 24 Dec 2024 18:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735064588; cv=none; b=J2JuCubo0qPrjC2MpRZPvXCwDFK9LA6wj0qKsUEOk3Q7hXhymRqLGvB/ByfS6iWceRqjFC5A9kEWHyQyLUhnbVtjAZimbQ/luluj+6ztkefaL5QSkpQAbP8o5R4pjYH3JZpOWIZrDBHUXaXqTjE/8Rog6YJ0DdwLbw1Xf728eqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735064588; c=relaxed/simple; bh=8Jjsz71p+pO8R2vGeUCl3K9s4kVlr0+rbkAwH2pfcyw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tkpat4WYyg2CnMUdKg8Smaqiut2J8XGOgMAc3ffZzRWV11XB8lRVxc61xp2AVD3K30rBioOW9OZfE+t5ynFjk8Chp+VTeO4Zvn7CyeU+UBvyA2k43ez34D0FtVSvg2fhklVOkoVXvWNBe0YXl1RW9oC42SoQ92+Jijf5pa04rZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=QRIeVJGg; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="QRIeVJGg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1735064579; bh=8Jjsz71p+pO8R2vGeUCl3K9s4kVlr0+rbkAwH2pfcyw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QRIeVJGgbTqmETgLxMj53o2T/6zEBeKO/gt3vvKujzDRDQY8PiHCmUVPTotOjXnwi /oUzBSgJtiOM3xsXnUOAoYi9mH6l5Fhe4zseJSCcZwi9x5fAcOJrqFxCbBYhmIa1UL UR/XqMWK2sAtZGo2fgO5PIiPm77CX6vkeE6wu7zK0t8k78BSkEcIjQydDg4Cp1Obgr gWSeO0JwPW7IdhSvgU7dnDUEfhez9unl2cR9/V3hDuvgqbK6Vu5iKIKT6YRZfx0wiG MbA30O1Ot78vVALYN9ohfHWzNLK2cvx7WY8SnEr8VDCDBZ8dKwLCmLxL+LaaRMXfJC KgIe+z53WDDOA== Received: from localhost (unknown [84.232.140.38]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id EF73B17E15AF; Tue, 24 Dec 2024 19:22:58 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 24 Dec 2024 20:22:41 +0200 Subject: [PATCH v4 1/4] drm/bridge: Prioritize supported_formats over ycbcr_420_allowed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241224-bridge-conn-fmt-prio-v4-1-a9ceb5671379@collabora.com> References: <20241224-bridge-conn-fmt-prio-v4-0-a9ceb5671379@collabora.com> In-Reply-To: <20241224-bridge-conn-fmt-prio-v4-0-a9ceb5671379@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 Bridges having DRM_BRIDGE_OP_HDMI set in their ->ops are supposed to rely on the ->supported_formats bitmask to advertise the permitted colorspaces, including HDMI_COLORSPACE_YUV420. However, a new flag ->ycbcr_420_allowed has been recently introduced, which brings the necessity to require redundant and potentially inconsistent information to be provided on HDMI bridges initialization. Adjust ->ycbcr_420_allowed for HDMI bridges according to ->supported_formats, right before adding them to the global bridge list. This keeps the initialization process straightforward and unambiguous, thereby preventing any further confusion. Fixes: 3ced1c687512 ("drm/display: bridge_connector: handle ycbcr_420_allow= ed") Signed-off-by: Cristian Ciocaltea Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index c6af46dd02bfa9e15b59e4c460debdd7fd84be44..241a384ebce39b4a3db58c208af= 27960904fc662 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -207,6 +207,10 @@ void drm_bridge_add(struct drm_bridge *bridge) { mutex_init(&bridge->hpd_mutex); =20 + if (bridge->ops & DRM_BRIDGE_OP_HDMI) + bridge->ycbcr_420_allowed =3D !!(bridge->supported_formats & + BIT(HDMI_COLORSPACE_YUV420)); + mutex_lock(&bridge_lock); list_add_tail(&bridge->list, &bridge_list); mutex_unlock(&bridge_lock); --=20 2.47.0