From nobody Sun Feb 8 09:13:12 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530591AE003 for ; Mon, 23 Dec 2024 15:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734966695; cv=none; b=BCIz7ZghtV9pIxuI9gUQB/fGDzZj4Dy5l191qfgkt8aUU40EA8c4M5uXofaT6vjwkS6SJlbtBu+OHd0prJfPoJ8T1nX7rqygvnPcosraG0FDLk7n66c5mOqO5sIxamt2OfMKFghuUcqvDZ3DVUDZiJ9ab4gP7wGuqGAPa78Vb7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734966695; c=relaxed/simple; bh=fTFucDhxjtEGgpn4AzDmmIuzURG6Ys6vAmcUHoLLeJU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JD74z8dqH9xt5Af9S0cRAri5le9j8BjEXUIMZjkg4uyB9hl+9JAuttxFZhtF9yQeJ7SOKYPJOV1qOIehkGMVQgegUcmNXB5rK5K94JgjsUdbyMImsYF0HBlUk9OERO6c+6nsUCylDg6OUGlLM3k31sanz26TAVJQtEBkhNhIVpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bQm+Cgib; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bQm+Cgib" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-725ef0397aeso3396314b3a.2 for ; Mon, 23 Dec 2024 07:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734966693; x=1735571493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lI4kJIa4YMLuNKj11odd7DQVNVxgPQzDSixr+an5cnE=; b=bQm+Cgib8cvWLvdabMvEDZMBYmY564KPkaU53YN9J8ANZoUjtjqcHi/g2t4WFC5zfc KytBQd1uDLb27ps8YCtYhJDXzJ/287pfSchLElJ4ZAcdBR784vd3g0JCvZjtrInfp3k4 E0fJRwwhmymQXwtUWlpYfkl/zKEzGpo/36pFbAwyRxU0aOTALWM/CIOaisITOjyhDHoj PxrLYVTKLwaqc0Zm2lsBPDw9DGz+LloSjXIWe/JPTA7MS8LQScSIGbxHsqzXNfizwzYC 2IAWxa2/hSMJ6zhM/E4o7/RLCFmAGSa4UgFmO9J5uNzHUFiCWMtB3qtOpINh/Fv+ZPVf sHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734966693; x=1735571493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lI4kJIa4YMLuNKj11odd7DQVNVxgPQzDSixr+an5cnE=; b=hp6aEfo4Y1/26RN4466t0vLxVVRnjdEdVl2O5up1oubCf29gXikNESDXjO+YaZ0/Aq XRQOASuLSKCmuw8Kd+XpfePSgdpS+FkL/vOCkaC9w3U7wtcuMQxyZssSpSYEzK1EoLP4 tgxNO/Gux/z+o5ofABHWxDIDEsNVzHK8b72lRTbVrfaptpcGR7hdg6L2YNU2O4csUrnO 84QEM3ewgWXzzTXK/sYKO4nDrkU6Adue69fEQLaYAZT5dvs0Afdz7w51WYPvbVJc31w/ JXXYKNuDSPYtfHBSQcyj487wqCdLRgGQwLaNju1hfwyjc1KIUiwKzPPWDpDIRPQaFu2V Xe0Q== X-Forwarded-Encrypted: i=1; AJvYcCWe0t8rfn6iqLAWSverzwfbASPT13WicrYuhoauqwk4BkpDT/BrwGJfns/FQ8ToKCFpLd++eBIm7oPubhg=@vger.kernel.org X-Gm-Message-State: AOJu0YwhxofpoZTc52ThamiLJ7a69FqBve6Sael8SMomSFOEtOrdhesF xVhYz5ye7IORLNOd3p5D/ziQQ1cB9ZtZ/lPWyX1LUUw4RbyptbwU X-Gm-Gg: ASbGnctUCthc9zn1omULumRKYEV5Kbps6IlNFLm6zQriYJZxeD8ccN4cGNwLliraSax feiCpqLWB6doCbhU+SdviVChdt/TNpwXAEuNozR4ic5CIglSTxjJzU5aohhAV3Pqx0QbaEj5hMt CcLP0j9By6kyC/cQe+LFpkJtzJeTTl0Rk9CiKlXCFCZM/jN1cOldaN7r4HqieIfv5AhQ6xvd71x 3TAEyV365dQgndcnpT1TQEQ5+TWgy/1ihefaeQJ18YcrjwpMvMwwcmlnXCi8f4vGJqzFt0nMg== X-Google-Smtp-Source: AGHT+IHo7Oyow4R0lnqRxcxf+UTkUABGQ7Oh8WLLMujHWeevLJRRTOWxtNS+3YqGLjYxkO9n+LoGhg== X-Received: by 2002:a05:6a00:3c81:b0:72a:bc6a:3a88 with SMTP id d2e1a72fcca58-72abdecc754mr16191289b3a.22.1734966693548; Mon, 23 Dec 2024 07:11:33 -0800 (PST) Received: from localhost.localdomain ([106.208.147.102]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8fd7afsm7944538b3a.139.2024.12.23.07.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2024 07:11:33 -0800 (PST) From: Atharva Tiwari To: Cc: evepolonium@gmail.com, Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: greybus: Remove module from list before freeing in gb_audio_module_release Date: Mon, 23 Dec 2024 20:41:12 +0530 Message-Id: <20241223151112.206908-1-evepolonium@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously,the module was freed without detaching it from the list which co= uld lead to memory leak this patch uses list_del to safely remove the module from the list Signed-off-by: Atharva Tiwari --- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index 4a4dfb42f50f..7e52c3f95692 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -69,7 +69,8 @@ static void gb_audio_module_release(struct kobject *kobj) struct gb_audio_manager_module *module =3D to_gb_audio_module(kobj); =20 pr_info("Destroying audio module #%d\n", module->id); - /* TODO -> delete from list */ + if (module->list.prev && module->list.next) + list_del(&module->list); kfree(module); } =20 --=20 2.39.5