From nobody Sun Dec 14 21:46:11 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364B463C for ; Mon, 23 Dec 2024 04:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928874; cv=fail; b=BbuNAIuXBPBs+05e3V9/AjrrH6mcXBanVBRqlbRHe0tPo2b5fB8pVCY/0jB59szJtEzt8W9UUyxH4rQysQ3Oi7Wqg4OoUmPtzqVAnEKf2QXGCBRSdgDwZX2z/9RbAA6b/VgFTSrYQM9Gu0hAhtlLr5Vn2jYggCzbDFbCmwmxSi4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928874; c=relaxed/simple; bh=wzxq8q2mOo6eLa+RjaZ+fD9X/gkV3vzi2Ee807RJJsM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XXIh96tlU7IA4afORrzsa8QDOJ5ze7f8MD/H+Kylk6hGhuFfmYVfHPlBpVK1X3dqjQl26CHUyBSu5FlOC8dDl4bqHVaW3VRh6EHO8WMUN+L8F1nrlf7HA0RxhbjI+kl0Am0u2Vq741zGDtK0AqIxnDXAer0WKlSm2/cdfd8gYb8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=33rT4LOD; arc=fail smtp.client-ip=40.107.92.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="33rT4LOD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=viMwzQaH6hUDt5wa7qcCGyYClO7KBB1H0O++NLE3LznRRV4gzIpL1EImwxwg6DPza0IQjhlmPNDVQ/4kSQUTZ8qPGwFpCypleG+A4i1G1jJzhOvEM83JbT1sWcYSAFe5ouXE07dmN3+CPC+/JwIofxHwZ3BAM4FB3pPX2RBaYJq5W+RzamX3OhV9oY2v8Y6xjn7inDcA7A5RR3NsnYTwn92Nkfa1XDe651oqAFkXygtIfvbsheP/kpxVVOJxs83cdhXvintaS5sEDZfpZzD7huqVmIPCMe6MNdQW0SPNIAGAm3oKJqeK10gnMREmBoAtT73ZFbvYazYZirqGC9phYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c2SBYwFh+n/7pPDqHMq3kZbaRWkQ8fdZSDVD5uK6JTw=; b=Ka+TCuFVNVEZ0yXJDcBfWRuzfXG+naShckY+f59Ibayx858yQzz7Wzy3W9sPYCvMmAF6Sf+GujwsB5TkkzVrcLN1F5oX0vWFchqW/GUboXiEpAbFRv9o8paOhBefB2uY7YhkrWSFvORq826ph7PENypIHi2VH2ePdwqjC1dF7Rz6+IBTZH9EER2v4AeXycs2uzERQsoz58Voz/FV8R+P6+zDUAo7zmkYd8Ksx0EZax+Ynt8pW4C6oLaGcsbFQt7eNZ6hW5SbDv9oY39kk73k1R9qzk2WnnJnLCeVALAFdh851TfzJet8atEhG2HWj4iwJC1Xmy+4xRiO5uJIoHMQrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2SBYwFh+n/7pPDqHMq3kZbaRWkQ8fdZSDVD5uK6JTw=; b=33rT4LODFQhJmStIndhQJiZEH0LJaBRZ4oCQZKeG3O7T26+BQLU6KPyZujGMUwSutFHf4HVfz9s4Nn4MWzXbJ5vgS02yiiqy6Wj4arWahGGBPQV03oNDKR+sg5FyNUPsZ3TzRFye3dyeRSjA3CiTzFlCyYyBGvqYTS9C0qL1CdU= Received: from BY5PR03CA0013.namprd03.prod.outlook.com (2603:10b6:a03:1e0::23) by DS0PR12MB6415.namprd12.prod.outlook.com (2603:10b6:8:cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Mon, 23 Dec 2024 04:41:03 +0000 Received: from CO1PEPF000066EA.namprd05.prod.outlook.com (2603:10b6:a03:1e0:cafe::d9) by BY5PR03CA0013.outlook.office365.com (2603:10b6:a03:1e0::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.16 via Frontend Transport; Mon, 23 Dec 2024 04:41:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000066EA.mail.protection.outlook.com (10.167.249.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:41:02 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:40:14 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 7/8] sched/fair: Do not compute overloaded status unnecessarily during lb Date: Mon, 23 Dec 2024 04:34:06 +0000 Message-ID: <20241223043407.1611-8-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EA:EE_|DS0PR12MB6415:EE_ X-MS-Office365-Filtering-Correlation-Id: e9e42916-3772-41dd-55e7-08dd230c0194 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?77EIZh9yKPtKDt2M0o09pYhZFI5hNaN2SF/NCs3ckWIYBteKkPfhELRt93+O?= =?us-ascii?Q?XqoD9keHaqC1yrymc2QijLKo2BUbHdD5KWyk5Cy5DLPByciZkEIme0NVVzCd?= =?us-ascii?Q?PPuiYXlZ0ZB0iVynPpfTOyStVqtKONuTTOhYBF1DdlYsolBhevkU+2Ca7ZyF?= =?us-ascii?Q?5tQFMjITw7VI5NfUu2v2XMGVYWEqyEGda+KDblHYNsrJjn4LbipvQ5JHqTHM?= =?us-ascii?Q?SWwRrh/6WvS1mNggzV/YAAf/XRI3mpSk23iGBkBcNWGvbsFfQdNIaaoEpmJ6?= =?us-ascii?Q?okysZMnLhW2p0dWdDQ6oIMHvG07fyUU1PtHMUSxnZgNQGro8QQFOT0E7dFrU?= =?us-ascii?Q?PcRahaTkQnIjvbQ7GMt5UbdjnYKWw8mzxxAwXob/MEEQsQndMXDY3KcOLGpe?= =?us-ascii?Q?slw65dkVbD1ZqWsQSmluIHFbpdZftbKWxCpqw/EsB4eMA+3ZJ/m1+pCbd5X+?= =?us-ascii?Q?j9+fwyvZ9AqyUz19fSNuQWCsPmm0b9zNeuPPqUypPLzn06w8VWkP1zoTAdMf?= =?us-ascii?Q?PlfAUi+khjoy3Wv6jcJDVu0ztqfW0OQgI/VrpFlmsHFrhcYf8/rYna60620L?= =?us-ascii?Q?IDvrHX7AKHalzYcsnb7ucIe7+7+Z3HhIQGUFOSo9/V56KR2pwxNj6hQK7W2m?= =?us-ascii?Q?+2wXdGRimWoC8E8PthnwYoCWbUL08iplZBxXO+ZSvRGr18GR8r15lv2ws2Fr?= =?us-ascii?Q?qqefzRdBsyWJuGbcXn6a5pkYbOeEIq15txFMvZMcKligWOi/FPHw6BfKwv2Q?= =?us-ascii?Q?luuOjyn0t+gJRbW4YKK+OE5w5F54A+POKmlXd3UkgQ5XCyV2M6Dj+FgBMrmF?= =?us-ascii?Q?2Gqd224H/M6JDfFmbaVv9m4gMsAk+2GlOaumd7+GIYkIYS0uSbAZspt5Vht/?= =?us-ascii?Q?XJN7+7V8lBgs6GEWSDTv6fB7GwNs9iBEbuDoPRHGbuTsvj/sXC2bTOHea+NS?= =?us-ascii?Q?6xyDSrApsrnouSBAyZ8QyRVgbLfYazLADnyM9NchVCdZ2fVuF3P1McTqo/Y8?= =?us-ascii?Q?R+vQyqD3nFq/N2+NZM4bAsyIYMo8UeNmvEpdoSQZSFCudHbJQLF61/F6oKNg?= =?us-ascii?Q?+SmLakuzyWjVC0v6UPmGtYzaXsXLZ8r+0K2HHHXHAnccjJcGe4V8YRmvQ9Dd?= =?us-ascii?Q?11fAYDRqtj6GT2tIfi05+Y7ukKLrmlgl4gPgSBolwWMuhiSTT+CeCqmndpV9?= =?us-ascii?Q?58eDwzS+r7rc0Ev77NsBBKiIVGB1ZUMkGxaXmukItZ2qKd1hSrJmpjeDlhKH?= =?us-ascii?Q?ynxbZ0I4RO+dNRM27DVUYmUo2rwvtoyb3hxLpEWzBR7F7IkWdMGKjVGnE/ja?= =?us-ascii?Q?XoFUXCrtLOYRu6yvriFm9gMioRfOcuBb1ajZguGji9vOed09/9rkiyM5aPk8?= =?us-ascii?Q?eWtHnEgRRob4USRhu3jIFug1A8S3uXY4GMsfMT06c5DmA12326iIuIweKhx9?= =?us-ascii?Q?/Rabo/Xm1gjq1XVwdMxbuw3c8EPiDxNTAevc2d4Meeto2sgsGq6J5PER1Ft+?= =?us-ascii?Q?dFVlcujaO31EY8w=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:41:02.8463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9e42916-3772-41dd-55e7-08dd230c0194 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6415 Content-Type: text/plain; charset="utf-8" Only set sg_overloaded when computing sg_lb_stats() at the highest sched domain since rd->overloaded status is updated only when load balancing at the highest domain. While at it, move setting of sg_overloaded below idle_cpu() check since an idle CPU can never be overloaded. Reviewed-by: Vincent Guittot Reviewed-by: Shrikanth Hegde Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Vincent and Srikanth. o One comment from Srikanth not addressed. Awaiting response for the question in the cover letter. --- kernel/sched/fair.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c68ab808d271..f27d7d36a78d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10347,6 +10347,7 @@ static inline void update_sg_lb_stats(struct lb_env= *env, bool *sg_overutilized) { int i, nr_running, local_group, sd_flags =3D env->sd->flags; + bool balancing_at_rd =3D !env->sd->parent; =20 memset(sgs, 0, sizeof(*sgs)); =20 @@ -10364,9 +10365,6 @@ static inline void update_sg_lb_stats(struct lb_env= *env, nr_running =3D rq->nr_running; sgs->sum_nr_running +=3D nr_running; =20 - if (nr_running > 1) - *sg_overloaded =3D 1; - if (cpu_overutilized(i)) *sg_overutilized =3D 1; =20 @@ -10379,6 +10377,10 @@ static inline void update_sg_lb_stats(struct lb_en= v *env, continue; } =20 + /* Overload indicator is only updated at root domain */ + if (balancing_at_rd && nr_running > 1) + *sg_overloaded =3D 1; + #ifdef CONFIG_NUMA_BALANCING /* Only fbq_classify_group() uses this to classify NUMA groups */ if (sd_flags & SD_NUMA) { --=20 2.43.0