From nobody Sun Dec 14 21:46:11 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3391B63C for ; Mon, 23 Dec 2024 04:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928812; cv=fail; b=Nm5K2MB2lIU9HYlxaEbkZrtMcRw0XwuZekAKsSbHMElO5Vp6wy8t5mUGGjBNMaj16AgJHCYe1D9s1A/KZOph8oIKfygoNpfiihbvCYyYGoLkbfAj2mNtnDSxnpWRKkXKBw8t7pk6Pxyoc5GSQUxIQJqLXoeP5XSvM6ZVnw8WQiI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928812; c=relaxed/simple; bh=QNjP/cgAQouWDqnincfjlsL481/iKQakI8jwZPA1dkU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GBip344dw7i9B6uqknDuiDr+hHkIJn4dDp8QZB84nwczB9nP7wCPH2qT+zY9waZdUwZ9OMYMekbaBoRC98JKz/MPYDc2nTblgBX/NVax8udQ8oNNBuh/Us9CNI1kccPdKk4sstH+cTb4SCPHtLru/AWvC7o0v1ktADlOF6LxR2c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fKkI8C9D; arc=fail smtp.client-ip=40.107.223.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fKkI8C9D" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jxyNT39S+SfgrBc8h+WwNReQxcgRM/ZpLzfKYea+o6fN3yHK23nkB8auswzaQ+bXpRYJB6IFLUDK3y2h8hmXwRzRkj+3x4vN55qHkyRZRBLcjoHA0J9BCarxo+5t+FWOXLHAhRHiMJOlL5XgZ9KFVKOD1CJRGM6HFQoeyrjdpYjccuN+M5S+zkOv2rmwOVj+uzX7zEHELM0Z4e/31U4hmRuAWuKWm5YTh85PEchqOxKbbn27jEQKIW/Y1ITd4a18d2f27QGER1PJy8H0074tC6tQojq7ZdZZTc5GXHHICwUePi2is4rifowlYyDiiKsN30kELK8khieAoRmBhlglQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+QfPJn1jxgevndcHI7NA+XtS2IgDlMfl1Tm1L8NHe8=; b=aGHNzM2OKCkZeb+zf9UZKAdsTNP7mm36p0gTCUfNWbgc7Zug3m4B07SfPdlURGTsS6XTVbI1byr8dLrbQ6GGZjPIyLvtQSj/gcrr/Cvn827oqHbFmdHRsxFbZJghxRRWrb6axpWS4Su6GQ9TBjqwJjoqv1MinjEShZNdhqFi0nuJE6ZJNsrnhuqOiLq7yeU00RO49/zNNfgcUfVGakzN5O+doyGYMHKmmvITfKtj6ZYcjeJeEnD59kwYGABvNDtqPkr128JFcDV4DYNSsH7d+VZcO41JculJR7sGshSYuaHXZA6ec10yIQNv0v//SkTpfdWjIB8CAEjuMh8H0/U59w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+QfPJn1jxgevndcHI7NA+XtS2IgDlMfl1Tm1L8NHe8=; b=fKkI8C9DfRqc88RLNrtluEaEZZZzOA70a2DdAjxkm89sHdy6NCJ5iV8C8OCr/icfRozsAz/wuyxS9mEJwsO2XtJcpztPV67DDSZPYyNKoYbIXq2jm7tI8KHjJf7t0fFeEFCrlIPmdH/PWR0qktdNlyqbR22RWoKab5NoYsHzdqM= Received: from SJ0PR13CA0010.namprd13.prod.outlook.com (2603:10b6:a03:2c0::15) by SJ0PR12MB6688.namprd12.prod.outlook.com (2603:10b6:a03:47d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:40:02 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:a03:2c0:cafe::33) by SJ0PR13CA0010.outlook.office365.com (2603:10b6:a03:2c0::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8293.10 via Frontend Transport; Mon, 23 Dec 2024 04:40:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:40:01 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:38:27 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 6/8] sched/fair: Do not compute NUMA Balancing stats unnecessarily during lb Date: Mon, 23 Dec 2024 04:34:05 +0000 Message-ID: <20241223043407.1611-7-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|SJ0PR12MB6688:EE_ X-MS-Office365-Filtering-Correlation-Id: efc1cf80-7e26-4f2f-4cd9-08dd230bdd0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ySOzVr9B6mIXp4RGbFh+pKcAEAEerZ1IJfnbg3sZsvLUJX3GlDZreJyFe7Kb?= =?us-ascii?Q?tdR4Q7ypQql4q+68Uk1D9WbTa2C+o5QfcGdBEUIG8sxTxk6sF6RWoRvyTnZd?= =?us-ascii?Q?oK1wmBFwnufD4nReiYG2+3YBsDCdTPyTbqGkh8cAu3RLmdbKGEtwH9xAKR1o?= =?us-ascii?Q?22DmQUb1C3msLCSVD3WW6F1923D54SJ28THwBvwk68rItLxVyD2hQiBj0ifb?= =?us-ascii?Q?C8GPMMuY4HOf5PUqUGGfv6Rret63Cu7Sx2wS5j3u2fm6chKvGUDwnZ4dz9mk?= =?us-ascii?Q?QAMwV1tnYMAhk5dfhxLWPvwlaPal6TDvZazkrdKMioAbSo7nvkF//GKfgfF3?= =?us-ascii?Q?lgvyOmqwtuyG+WtGJk+1RSyusaSkcF1t241r7kMGDCL3qLLZTn+/CjzgfFLY?= =?us-ascii?Q?RP/HnxZfyV3cxpB0KT0i5BY3YonGDVWAp4lPS5pQJk050D93X9T9kWXUvOTg?= =?us-ascii?Q?yn/6SaqFAtoh1FlXJWobS3HWvBROS2hUA59fPnwV1VW88OM2/J18eH5aazJr?= =?us-ascii?Q?AwAFdkb3t0yCsBs1a4TCCoUgWpqyxbYEIpk9T4l5xkpuzmS33wFXQjnxYiYE?= =?us-ascii?Q?oDGEEaZ563PyKXh0zJpk8LBb22EjzPIsFmLRtf7yvI5SlSXoZYiMqlmLG81O?= =?us-ascii?Q?XrfgJ6Y6Fg6QC1VvZO9qSvP11rOfvukEkJf7XsqVrW+FmacRICMjq3gYpets?= =?us-ascii?Q?Spa2VYYHV4rZOrvZz1gc9DISwkot+4RBCsFmHUJvWjQhfMsX7ADHfMaYIJwa?= =?us-ascii?Q?SpdycP9DIqGocNlPSDFoC6UyTIR44ifH+Qu06dWdH8Q8UoyVM1Ob1t2NYK/u?= =?us-ascii?Q?zT0EQuE6m89QFr33nffZjWrEAzXpa78KUOw1ZsuwWHSJtXGRF35YSXxPE6bU?= =?us-ascii?Q?UhRI3+pvghUEE102haWVHdkWOI+ODP2h68ehvUSJwZ+Q0SdEmKIEJAp/tt99?= =?us-ascii?Q?X4bjn0NzMp/LWHkWv/1gnN77psncFas2JJ8kGwGZx/WkEUltiTC8xxeGXQov?= =?us-ascii?Q?Zy+kg5qz07Q7NGeS8vrDOZIIMVY9tiZy/49cLgiscY4YM2W600QvDv2al+Pb?= =?us-ascii?Q?s9lZW6BHum4Esd3TMC4Km40fMfqh8WwbJaFthT+wGV5LZ8CQKNzyZT1Dk/T0?= =?us-ascii?Q?XOqh1EQOQPKqcyo0Qn6G8VaxFg+mDxTbJpQWoFjDrl21DqGVG9dtxcD5jRkM?= =?us-ascii?Q?uOgZSAGGrGYB1aQLTeVOGubMRAQWbefXp8JtPJGJailG6D+2R8p3BMN7LC89?= =?us-ascii?Q?ePcUNI1g+O9V+zN5XMQ2Dbz73Qw4XItR6uLBkFP68fjClouUAAh6i3VxcIqR?= =?us-ascii?Q?k9wwcBLHMVOPCbcDP8QGBECO18Lol4RN0lPN2ICztlXu60BOt1rOTtAldyv3?= =?us-ascii?Q?b4dkpVL27PBYWKj0HwEgNZh7z/mtNZ3+7xmgK0Bfi5AmHYJ3BkgR2of110Qt?= =?us-ascii?Q?lnqRfgBKdHIvs1dSimOvqM+R8uFe9sPcGVQIR9GfXhXkulbeZBvgz7fRyxg6?= =?us-ascii?Q?HcIJJO4mWg/I4pw=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:40:01.5033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efc1cf80-7e26-4f2f-4cd9-08dd230bdd0b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6688 Content-Type: text/plain; charset="utf-8" Aggregate nr_numa_running and nr_preferred_running when load balancing at NUMA domains only. While at it, also move the aggregation below the idle_cpu() check since an idle CPU cannot have any preferred tasks. Reviewed-by: Shrikanth Hegde Reviewed-by: Vincent Guittot Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Vincent and Srikanth. --- kernel/sched/fair.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8f641c9e74a8..c68ab808d271 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10346,7 +10346,7 @@ static inline void update_sg_lb_stats(struct lb_env= *env, bool *sg_overloaded, bool *sg_overutilized) { - int i, nr_running, local_group; + int i, nr_running, local_group, sd_flags =3D env->sd->flags; =20 memset(sgs, 0, sizeof(*sgs)); =20 @@ -10370,10 +10370,6 @@ static inline void update_sg_lb_stats(struct lb_en= v *env, if (cpu_overutilized(i)) *sg_overutilized =3D 1; =20 -#ifdef CONFIG_NUMA_BALANCING - sgs->nr_numa_running +=3D rq->nr_numa_running; - sgs->nr_preferred_running +=3D rq->nr_preferred_running; -#endif /* * No need to call idle_cpu() if nr_running is not 0 */ @@ -10383,10 +10379,17 @@ static inline void update_sg_lb_stats(struct lb_e= nv *env, continue; } =20 +#ifdef CONFIG_NUMA_BALANCING + /* Only fbq_classify_group() uses this to classify NUMA groups */ + if (sd_flags & SD_NUMA) { + sgs->nr_numa_running +=3D rq->nr_numa_running; + sgs->nr_preferred_running +=3D rq->nr_preferred_running; + } +#endif if (local_group) continue; =20 - if (env->sd->flags & SD_ASYM_CPUCAPACITY) { + if (sd_flags & SD_ASYM_CPUCAPACITY) { /* Check for a misfit task on the cpu */ if (sgs->group_misfit_task_load < rq->misfit_task_load) { sgs->group_misfit_task_load =3D rq->misfit_task_load; --=20 2.43.0