From nobody Sun Dec 14 21:46:11 2025 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2084.outbound.protection.outlook.com [40.107.212.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE6A63C for ; Mon, 23 Dec 2024 04:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928682; cv=fail; b=jM1urkRSptyuF8J/M8bq0YmmH4iHaYNMtLxh7OP7czbWveH/e5E+YR+sQ2/1cU6P2ijkYjWte3p1pBANowlC40Se4JLwaHTm3e6Kmym+xA145Ne7dTWlaqFCSI2RhHHavIkc95bITtktEsIStHTPvtCk7UfPBPwuYO4Sg408kLA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928682; c=relaxed/simple; bh=j5noIcMThfIxhOslzuWl1f5QbsI0fVcpmkLQSAW0lyc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Uv3brmO06EUEGBy7PDUmPsVTWGw+xDXtEeXvcZvKAPrLe5nAs7VX4hImWq1Uca7AkdnxBewgBTk85dhd/hg+vdKDpzzqoVwGczLZ0THMjvem1r6TVtmCMb8lVzzQ7BuUzq5puyXs2xanomNkG6DXk1H3kj4VCdUnLMrzCfME6CQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Wfeq48kh; arc=fail smtp.client-ip=40.107.212.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Wfeq48kh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Uo22FdERXilWiDrTMbPgCtfaVXwRR1n/dSNnQZXmISVE68BGC7tuPl02qQNlSqiD0gzq0gcP4320z9LywSUnicPjk08F5xetj7K2egw3IPvZV8+uTTPXiz1u286u/4xhTp1ZTRGQfve+B9yC2U3WplRi3xhkezqNtyXj4xb4Av47ish6f76EcjLsZ4Xc4JVzjWh7s5uvOLKuvKlLftlb0eOct17GOhqcJfFC2gD2+0nFT3oeG0OV9MFwSYmj1y47jnpLuaw2+8zheJ1wsQdS1y4UCEIgXct98R05fj3PZzkuGRSIo5TxMgA5HaqxnhWzU43KK7Rh+/L1hAvuyCyCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dt3jA//HmvKNsZprmxt8eR2gUjwEbJNJj5MqblhF+MU=; b=y+REFsLWR+42V3aeJT1YbHPyVRXq1oq1XPLJp3bF+1em1Rgc6PU4lk8+xQO1km9nfV8Bq8SMujNZtZgfnw5QuTu/MII9WkCmBKbGP08/jCo+su4tCPgNmu2uEXlVHT0WXmTs4gm+ybKA8e7y86WETpgbHK2dZVdYT2CGeNTJok1QGPQmuy7vg3iEBD6iyws9taShQDhgA93kIjQs4K0iHuGkOFzxsqmJT1pTGFOmmn32/0zg6wRtRRb5FYnud5NNrBJPbDa2dEYpKXopwobDmfgvrKrBWtJMIr4PswZbnCTQtBEuRwez2MNxgLa1Pr9Jt+vGllWFzVPK/zuQECUecg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dt3jA//HmvKNsZprmxt8eR2gUjwEbJNJj5MqblhF+MU=; b=Wfeq48khH0iLR4rSwplGhsq0tLlCefR7FaPZPgs4SLywaVK2mMOvL42ZrJ1lHWHPyDUB2ODy6NnLw3rny50AA12GeGTVDrHTY56Q0OS5/XXBm2TRpHBnGRbkvGS13FKAHyOds66SsHkA9fqIUDeWm1WES3B29NVrlDr0g7+/U5I= Received: from DS7PR03CA0292.namprd03.prod.outlook.com (2603:10b6:5:3ad::27) by SJ0PR12MB6942.namprd12.prod.outlook.com (2603:10b6:a03:449::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:37:52 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:5:3ad:cafe::16) by DS7PR03CA0292.outlook.office365.com (2603:10b6:5:3ad::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.20 via Frontend Transport; Mon, 23 Dec 2024 04:37:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:37:52 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:36:51 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 4/8] x86/topology: Remove x86_smt_flags and use cpu_smt_flags directly Date: Mon, 23 Dec 2024 04:34:03 +0000 Message-ID: <20241223043407.1611-5-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|SJ0PR12MB6942:EE_ X-MS-Office365-Filtering-Correlation-Id: a87d9116-c79b-4ee3-5b56-08dd230b8ffb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kN3zD13PooIAj5aFi4WTor7c95AzJ9vj/ACsn4nM/zMpg0jWs6Mgmu8Tpt7G?= =?us-ascii?Q?oZ1BELPxU+NdSwe1Oby0k22wJDJ/Cy8HZABmtqTjwsG77jCh7TBDMVxbJtUh?= =?us-ascii?Q?N9sG3BdKkIrgCQVx/2p2boch8exH9eHUZv1KGHf4f6KHUPb65NlCkFqHIwIe?= =?us-ascii?Q?Qc8xzZ1R/15Z4vqTAu8sRunwQVhd6hOPzSZynsgqqpteOQupUwUWDCYVBxGC?= =?us-ascii?Q?pig2+Ts6MUquT8z+jK6B3pBXLbWv8rof/V/spTQ+hVBGVh4Ih3ElR+JFf3Rn?= =?us-ascii?Q?WpZCBpfNY//LD0sc7v6GJ+V0X86GKLFdmcCe0Si332iushHarnNORb+v7/0d?= =?us-ascii?Q?MCIA7pNsYPDWdmjKotroDjdHSC0BDnGnTPSPDj6ewe81ZXsmvqhf2ufk5f1J?= =?us-ascii?Q?HM6lYv/N1E4VJWH8c2NMIUSnnIt0dEnd0a9+FCKu36SGUuBzxD1LE8cl9YNR?= =?us-ascii?Q?4Q5DnsTU72osDNaG+cSS0AvNJxT6pclWQqiWpdhh9N0n2D51CGB5DU3VkicB?= =?us-ascii?Q?8Z3nImQINTYG8MREP1+skCxdYGPEBvQrkb659LZ2VUy/cNuOgoewCw6/Qj7L?= =?us-ascii?Q?MRQwZ+9B4dhV8VgiQWl5AmF3eSuogTTLjte0lVD0Xt3MmqDIpBd5/Yp0S17T?= =?us-ascii?Q?LggWlZ4PodtnEaL8WeGbejoEOK82eCnFYuvkfV0+ZVXO70CewNj3+YmAN7gV?= =?us-ascii?Q?Cby2kAHdsv9TCTHF06R+uigjCD9l9+TlLTZ0NbIoX1p8Jvsa6fPeJgmEHMwY?= =?us-ascii?Q?U+8qCjpt1IRd8N+tt4/9V2aE2lh9ER/4zqQj4/gJ/qWWzDohtFPWlpXelQGG?= =?us-ascii?Q?YqpekQleiLQRHXyq1iV8ojWU+I626AmkSngY5+an1eL42W2VaZ+NtZYIt8o/?= =?us-ascii?Q?ayhBXaFWaQuKLKHEfSoBVaC8XdSNhql/7EcrgvAgocL/6g89JyeKk3RmOc50?= =?us-ascii?Q?H9v0ycE/T6ZM0Gf2E/kA8Fr/oUY2zDjaKebbbWWPRNyEsOJ0if6ODLjLLCnE?= =?us-ascii?Q?6IAOwiCyFEoG1eIfGu5hOGKXgLaFZBQymG4LR2JVWueaqK7QnLVZUAN6oZ+7?= =?us-ascii?Q?X83rX8sHX8uFyNPlPAmgvxw8fY1zWI/IXESlOcpGdXyg3JXt8pXj0W/0DJq8?= =?us-ascii?Q?f3tOxDKRbhmurZur5TsF+EmCZy5gEJquOS/vvtmePRT77YAiSWS5X7uDgjAj?= =?us-ascii?Q?1nqM0guPcc4VTKZz0aHx2Jf34zK0hBRmYCxjf26hD57kkFOdzWGKx4k/yFs3?= =?us-ascii?Q?hia59RjGom8BP6qCouQl4zSPsE+6NO0e8mJKjLBIPYLJE9HGmRTG4VNPJDSm?= =?us-ascii?Q?CcD8rG85/++u/NmZmnhWJmOUYOT9GJnAj9ZME3LyLWd6AkGnzifMy8boqlGl?= =?us-ascii?Q?DmyRkEi6PzXHLvmn65LLPtCuj1Duv/1LOz4kfkTqTRqol//cxJLgam4b9ob+?= =?us-ascii?Q?l8QgXhBlGeCFd+m39e2V30lit7YX2w+uD5tb54qEu8SzkqqHP+vDqyjyRQfw?= =?us-ascii?Q?di3/Jy5DZBhUIX8=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:37:52.2144 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a87d9116-c79b-4ee3-5b56-08dd230b8ffb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6942 Content-Type: text/plain; charset="utf-8" x86_*_flags() wrappers were introduced with commit d3d37d850d1d ("x86/sched: Add SD_ASYM_PACKING flags to x86 ITMT CPU") to add x86_sched_itmt_flags() in addition to the default domain flags for SMT and MC domain. commit 995998ebdebd ("x86/sched: Remove SD_ASYM_PACKING from the SMT domain flags") removed the ITMT flags for SMT domain but not the x86_smt_flags() wrappers which directly returns cpu_smt_flags(). Remove x86_smt_flags() and directly use cpu_smt_flags() to derive the flags for SMT domain. No functional changes intended. Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/kernel/smpboot.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index b5a8f0891135..6e300897b7ee 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -482,12 +482,6 @@ static int x86_core_flags(void) return cpu_core_flags() | x86_sched_itmt_flags(); } #endif -#ifdef CONFIG_SCHED_SMT -static int x86_smt_flags(void) -{ - return cpu_smt_flags(); -} -#endif #ifdef CONFIG_SCHED_CLUSTER static int x86_cluster_flags(void) { @@ -519,7 +513,7 @@ static void __init build_sched_topology(void) =20 #ifdef CONFIG_SCHED_SMT x86_topology[i++] =3D (struct sched_domain_topology_level){ - cpu_smt_mask, x86_smt_flags, SD_INIT_NAME(SMT) + cpu_smt_mask, cpu_smt_flags, SD_INIT_NAME(SMT) }; #endif #ifdef CONFIG_SCHED_CLUSTER --=20 2.43.0