From nobody Sun Dec 14 21:46:11 2025 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A514263C for ; Mon, 23 Dec 2024 04:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928544; cv=fail; b=lSXLnpQdWaUdZteErm6ibHNXdiYfhf74j71XPjrTpn4a3nta0No1s4Rjk8GGpZh+VtmzD6M6lqhSKFuQbihYvT55dx/chDNt02y+xMkFM6vw6OroMaT034QbuJa2jVbrtseqAJA1GJ6XUEwnC6N5tqryYxfZfW8VCkB1vJgplUs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928544; c=relaxed/simple; bh=6pzuCk79PMkbRYppI8Jao29+Wi1Lvbl8Qz14Shpk294=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q/mYUUl8vY1MKx9C7z5B1VBMVZlbWcAdLkYC5FaX5WXLfW+Uem2IrIe+j0DunbwDX0RxGkwoRVZ10hHLHoT/524wiuVDSSv/J8wmah1KPye9PbVBr1KSUrawZQjgzobewIEgWp7lWZwr332lNH2MI20PyFeVNDOD5yfMOpHH+yY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Oyi59Elu; arc=fail smtp.client-ip=40.107.243.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Oyi59Elu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j24ndZzZ5irbBE7tz4zl83NeZWCmN6INucWqIQsqrDEEdNPOq741V90OuQOv3XqsnysAmPzr1ezs9u090ZVBm9PKUKMC26RUoWf/eRIim8dZLr0prg87qUelF+dVrA0PkY/svx+geLr11jPaf5JctUy6aUd1cX39aj4VxmIVtj5y2F6TyL39cfHZhf4eyDDsL3fIH8sIvG3H3GVO3To4V1aPCCK7cm3ABoonzYs/sNad0IjQZ7/pmYsjnh4PfOA56oC/6j7M73g0TUmAoABVwszsnb1iae+MBHkrrg8EDbbam4S+Ew7mhsoZ0CEjv0kPFp0ImWys0duoYNvw+//rOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHZXktCR+1OZawMqUdqjVvTYenmZvkoE5f1v4Ig+RQM=; b=XjnaiwI1MKsVdUbGEE9XVZF6K7SQki621dhzubnuj/r6ibjeEvwfPxfsFmalYCuF6aMo2CHatb5+nDJLzVtEarbuiv5I/urUH76ifaeo8hVzeQAJtqB55NZfG9dTZOzrf9XNGKVq0F3Hni9UmyF28U1lvRLKObqt2w2bclUbQO1HRdKTI60rmMxTUuml7hV0mDVeyfeQCUwYztwPNAxpzKM+gcQhd8+WWSH6KPUdjrXeEyBssoI6rXHD80fy5LftloL7KawBwLskodici0YtCE+CU0eBEKRaGDJn9pY2n8/5FUnziFwng7HtUH5/a1pd77QEBkOoRQOo5HgUGkOGrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHZXktCR+1OZawMqUdqjVvTYenmZvkoE5f1v4Ig+RQM=; b=Oyi59Eluq7hdxclC5tBoz0nGj/29p47ov+8/Rh1CTFFQTT3lzH4DFwYh7yirPJCH7ITTJV8Il96gOfgY3yzcgk4NNxfiOfM9P3S3V/ZJ4A93PRHGDMc8zCWjb8FBSs6XdkjqbQ/oInSvvIB2J3TPbLLj27IZI0rCuiStGOTKk/o= Received: from MN0P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::34) by SA1PR12MB8843.namprd12.prod.outlook.com (2603:10b6:806:379::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:35:34 +0000 Received: from MN1PEPF0000F0E2.namprd04.prod.outlook.com (2603:10b6:208:52e:cafe::1e) by MN0P220CA0009.outlook.office365.com (2603:10b6:208:52e::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.20 via Frontend Transport; Mon, 23 Dec 2024 04:35:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MN1PEPF0000F0E2.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:35:34 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:34:43 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 1/8] x86/itmt: Convert "sysctl_sched_itmt_enabled" to boolean Date: Mon, 23 Dec 2024 04:34:00 +0000 Message-ID: <20241223043407.1611-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E2:EE_|SA1PR12MB8843:EE_ X-MS-Office365-Filtering-Correlation-Id: 31547fdc-6fe2-4b22-db19-08dd230b3dd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2C37CnynEX882H8Ssv4r6etORnQ62Gy2HhYFysDKjGobsp/tLiJays8KQYOT?= =?us-ascii?Q?iDPnxf3VX3WByIyts/TBXl3umrzFmZdtlwHZCFP1S41WukCD8RHmcgMYgZ44?= =?us-ascii?Q?qKOK+APsj6R2nvRtaKRrJobF/K7O0bmFhx3Zts8dMTCMB+37jxRjOb5l0GZB?= =?us-ascii?Q?+qGOBcori6vpdl98mcWk5wbHgYiCF5u/giMozI6Y8NZzeZcgPo53o4gwzgml?= =?us-ascii?Q?fpGT1WZzYVmdV+839u8FyViNSyg5GoBbFPUmeM6ByLRLGBPU6Fqncsd+XmEO?= =?us-ascii?Q?bu8rPUSLHXup0zH+WTrvwJ7CyOiuIFZjeR7qktnc8IUM65GFQKH7Ety5/BEW?= =?us-ascii?Q?zodJcWjd5PkivOFnFfnS93SJPQ4f/v0nZ9FSE+YD75DUX/+hHIJNl8SAVJbo?= =?us-ascii?Q?faAG+RUsGneVjXTGjUEAmv4otHPh7MhG4BTuwKG6EV6zOVSmDNkwZOjv4Sia?= =?us-ascii?Q?6JypluBORNWu2B0j4I8H4Sigy2vO6ichC9ByYJ0nsKhPvxUvkAo18XQyR1oM?= =?us-ascii?Q?siArLqcyCG1xDVOfVzNjnz1Ak8FBiYv3+rj89yO+lc28xOxvsKrfXwYvTi4o?= =?us-ascii?Q?QWeP6jBb4pDuQre1i4kBoWUHVsMr6Xry02sSzTvOtmT/x9riXHhZldflOmXP?= =?us-ascii?Q?803xwYijs285/xPBuY4QE4i9G0kBmRkVscYstDIhcOqzeKeRWIKXwVcd9eYM?= =?us-ascii?Q?U55iNBY3CWDuuIAfAuhs40Q/qYTyu20MIjNpKdvAZ38GtzBYzkksr+UKf5l1?= =?us-ascii?Q?e46i8BUEIGVQTo5P53Oa5JAb3mh+Q20uCnlnblrF4jV/v3imIw4G0Pf/J5p2?= =?us-ascii?Q?BR8Yn1kICb3mcZUSEZV0F6MPweU2UuGwEbn0+dv+uOAl7LEuQ7LLdMyYC+fK?= =?us-ascii?Q?3lBphL7T2MfJhejxauRj+p0EttmcDGNBb0GUMloFP+m1rha7vj260sEhbs8w?= =?us-ascii?Q?tqYuOkkMIJgoAwCeSsq/fWheDMnl0AEZ5PfRcMqIA88dR0Vfjvu5Iy/OdwBn?= =?us-ascii?Q?U+fMf+DT+xG2WqQj62Dyuq9RK1LDBZSzIWxPhgf5fZkKtUbKVg20Iq+OuFPy?= =?us-ascii?Q?b0fJQCAoL2/+s3wNEk0txodH3wvKeHF0MM498Bc/2x/27b8u1aHQ456XoN2Y?= =?us-ascii?Q?WZWiSh77Ekz2DK1ZDCR17SLSDRB23/92vyCdLTjY3fNHXpMJ2a+S0sUUR8dJ?= =?us-ascii?Q?1Iq6rnA9TpuEMw9xV6cBQSTWFaV7Ginq5u9u7OXNTKuTZz11HF8iABBKE1VT?= =?us-ascii?Q?551y/oc3WooSTmUV3fEDxNRBwxgk7KMQqk52CduHLUcY436DzqFm8Lhr4yMz?= =?us-ascii?Q?ZaZEbP7K5RtuArebt9Fk3Mol+usjT2Iv4fkABzhcjprAMNle7Jb/YKsIJjUR?= =?us-ascii?Q?UGhn0ZKMrffZP6114MMcAAS36buVrcEhH0ri3fejo3lmKqlCSC4N+8mdFdzO?= =?us-ascii?Q?Ps8qlOy9TwtqUVLL3Pj///ALd4mg3J6hPDKsBCn/7VfOfDufqpgkZNlN5GTs?= =?us-ascii?Q?b2TOrSAXi/5zQ6A=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:35:34.4956 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31547fdc-6fe2-4b22-db19-08dd230b3dd6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8843 Content-Type: text/plain; charset="utf-8" In preparation to move "sysctl_sched_itmt_enabled" to debugfs, convert the unsigned int to bool since debugfs readily exposes boolean fops primitives (debugfs_read_file_bool, debugfs_write_file_bool) which can streamline the conversion. Since the current ctl_table initializes extra1 and extra2 to SYSCTL_ZERO and SYSCTL_ONE respectively, the value of "sysctl_sched_itmt_enabled" can only be 0 or 1 and this datatype conversion should not cause any functional changes. Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/include/asm/topology.h | 4 ++-- arch/x86/kernel/itmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topolog= y.h index fd41103ad342..63bab25a4896 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -250,7 +250,7 @@ extern bool x86_topology_update; #include =20 DECLARE_PER_CPU_READ_MOSTLY(int, sched_core_priority); -extern unsigned int __read_mostly sysctl_sched_itmt_enabled; +extern bool __read_mostly sysctl_sched_itmt_enabled; =20 /* Interface to set priority of a cpu */ void sched_set_itmt_core_prio(int prio, int core_cpu); @@ -263,7 +263,7 @@ void sched_clear_itmt_support(void); =20 #else /* CONFIG_SCHED_MC_PRIO */ =20 -#define sysctl_sched_itmt_enabled 0 +#define sysctl_sched_itmt_enabled false static inline void sched_set_itmt_core_prio(int prio, int core_cpu) { } diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index 51b805c727fc..28f449123d68 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -36,7 +36,7 @@ static bool __read_mostly sched_itmt_capable; * * It can be set via /proc/sys/kernel/sched_itmt_enabled */ -unsigned int __read_mostly sysctl_sched_itmt_enabled; +bool __read_mostly sysctl_sched_itmt_enabled; =20 static int sched_itmt_update_handler(const struct ctl_table *table, int wr= ite, void *buffer, size_t *lenp, loff_t *ppos) --=20 2.43.0