From nobody Sun Dec 14 13:53:32 2025 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A514263C for ; Mon, 23 Dec 2024 04:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928544; cv=fail; b=lSXLnpQdWaUdZteErm6ibHNXdiYfhf74j71XPjrTpn4a3nta0No1s4Rjk8GGpZh+VtmzD6M6lqhSKFuQbihYvT55dx/chDNt02y+xMkFM6vw6OroMaT034QbuJa2jVbrtseqAJA1GJ6XUEwnC6N5tqryYxfZfW8VCkB1vJgplUs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928544; c=relaxed/simple; bh=6pzuCk79PMkbRYppI8Jao29+Wi1Lvbl8Qz14Shpk294=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q/mYUUl8vY1MKx9C7z5B1VBMVZlbWcAdLkYC5FaX5WXLfW+Uem2IrIe+j0DunbwDX0RxGkwoRVZ10hHLHoT/524wiuVDSSv/J8wmah1KPye9PbVBr1KSUrawZQjgzobewIEgWp7lWZwr332lNH2MI20PyFeVNDOD5yfMOpHH+yY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Oyi59Elu; arc=fail smtp.client-ip=40.107.243.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Oyi59Elu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j24ndZzZ5irbBE7tz4zl83NeZWCmN6INucWqIQsqrDEEdNPOq741V90OuQOv3XqsnysAmPzr1ezs9u090ZVBm9PKUKMC26RUoWf/eRIim8dZLr0prg87qUelF+dVrA0PkY/svx+geLr11jPaf5JctUy6aUd1cX39aj4VxmIVtj5y2F6TyL39cfHZhf4eyDDsL3fIH8sIvG3H3GVO3To4V1aPCCK7cm3ABoonzYs/sNad0IjQZ7/pmYsjnh4PfOA56oC/6j7M73g0TUmAoABVwszsnb1iae+MBHkrrg8EDbbam4S+Ew7mhsoZ0CEjv0kPFp0ImWys0duoYNvw+//rOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHZXktCR+1OZawMqUdqjVvTYenmZvkoE5f1v4Ig+RQM=; b=XjnaiwI1MKsVdUbGEE9XVZF6K7SQki621dhzubnuj/r6ibjeEvwfPxfsFmalYCuF6aMo2CHatb5+nDJLzVtEarbuiv5I/urUH76ifaeo8hVzeQAJtqB55NZfG9dTZOzrf9XNGKVq0F3Hni9UmyF28U1lvRLKObqt2w2bclUbQO1HRdKTI60rmMxTUuml7hV0mDVeyfeQCUwYztwPNAxpzKM+gcQhd8+WWSH6KPUdjrXeEyBssoI6rXHD80fy5LftloL7KawBwLskodici0YtCE+CU0eBEKRaGDJn9pY2n8/5FUnziFwng7HtUH5/a1pd77QEBkOoRQOo5HgUGkOGrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHZXktCR+1OZawMqUdqjVvTYenmZvkoE5f1v4Ig+RQM=; b=Oyi59Eluq7hdxclC5tBoz0nGj/29p47ov+8/Rh1CTFFQTT3lzH4DFwYh7yirPJCH7ITTJV8Il96gOfgY3yzcgk4NNxfiOfM9P3S3V/ZJ4A93PRHGDMc8zCWjb8FBSs6XdkjqbQ/oInSvvIB2J3TPbLLj27IZI0rCuiStGOTKk/o= Received: from MN0P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::34) by SA1PR12MB8843.namprd12.prod.outlook.com (2603:10b6:806:379::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:35:34 +0000 Received: from MN1PEPF0000F0E2.namprd04.prod.outlook.com (2603:10b6:208:52e:cafe::1e) by MN0P220CA0009.outlook.office365.com (2603:10b6:208:52e::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.20 via Frontend Transport; Mon, 23 Dec 2024 04:35:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MN1PEPF0000F0E2.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:35:34 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:34:43 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 1/8] x86/itmt: Convert "sysctl_sched_itmt_enabled" to boolean Date: Mon, 23 Dec 2024 04:34:00 +0000 Message-ID: <20241223043407.1611-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E2:EE_|SA1PR12MB8843:EE_ X-MS-Office365-Filtering-Correlation-Id: 31547fdc-6fe2-4b22-db19-08dd230b3dd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2C37CnynEX882H8Ssv4r6etORnQ62Gy2HhYFysDKjGobsp/tLiJays8KQYOT?= =?us-ascii?Q?iDPnxf3VX3WByIyts/TBXl3umrzFmZdtlwHZCFP1S41WukCD8RHmcgMYgZ44?= =?us-ascii?Q?qKOK+APsj6R2nvRtaKRrJobF/K7O0bmFhx3Zts8dMTCMB+37jxRjOb5l0GZB?= =?us-ascii?Q?+qGOBcori6vpdl98mcWk5wbHgYiCF5u/giMozI6Y8NZzeZcgPo53o4gwzgml?= =?us-ascii?Q?fpGT1WZzYVmdV+839u8FyViNSyg5GoBbFPUmeM6ByLRLGBPU6Fqncsd+XmEO?= =?us-ascii?Q?bu8rPUSLHXup0zH+WTrvwJ7CyOiuIFZjeR7qktnc8IUM65GFQKH7Ety5/BEW?= =?us-ascii?Q?zodJcWjd5PkivOFnFfnS93SJPQ4f/v0nZ9FSE+YD75DUX/+hHIJNl8SAVJbo?= =?us-ascii?Q?faAG+RUsGneVjXTGjUEAmv4otHPh7MhG4BTuwKG6EV6zOVSmDNkwZOjv4Sia?= =?us-ascii?Q?6JypluBORNWu2B0j4I8H4Sigy2vO6ichC9ByYJ0nsKhPvxUvkAo18XQyR1oM?= =?us-ascii?Q?siArLqcyCG1xDVOfVzNjnz1Ak8FBiYv3+rj89yO+lc28xOxvsKrfXwYvTi4o?= =?us-ascii?Q?QWeP6jBb4pDuQre1i4kBoWUHVsMr6Xry02sSzTvOtmT/x9riXHhZldflOmXP?= =?us-ascii?Q?803xwYijs285/xPBuY4QE4i9G0kBmRkVscYstDIhcOqzeKeRWIKXwVcd9eYM?= =?us-ascii?Q?U55iNBY3CWDuuIAfAuhs40Q/qYTyu20MIjNpKdvAZ38GtzBYzkksr+UKf5l1?= =?us-ascii?Q?e46i8BUEIGVQTo5P53Oa5JAb3mh+Q20uCnlnblrF4jV/v3imIw4G0Pf/J5p2?= =?us-ascii?Q?BR8Yn1kICb3mcZUSEZV0F6MPweU2UuGwEbn0+dv+uOAl7LEuQ7LLdMyYC+fK?= =?us-ascii?Q?3lBphL7T2MfJhejxauRj+p0EttmcDGNBb0GUMloFP+m1rha7vj260sEhbs8w?= =?us-ascii?Q?tqYuOkkMIJgoAwCeSsq/fWheDMnl0AEZ5PfRcMqIA88dR0Vfjvu5Iy/OdwBn?= =?us-ascii?Q?U+fMf+DT+xG2WqQj62Dyuq9RK1LDBZSzIWxPhgf5fZkKtUbKVg20Iq+OuFPy?= =?us-ascii?Q?b0fJQCAoL2/+s3wNEk0txodH3wvKeHF0MM498Bc/2x/27b8u1aHQ456XoN2Y?= =?us-ascii?Q?WZWiSh77Ekz2DK1ZDCR17SLSDRB23/92vyCdLTjY3fNHXpMJ2a+S0sUUR8dJ?= =?us-ascii?Q?1Iq6rnA9TpuEMw9xV6cBQSTWFaV7Ginq5u9u7OXNTKuTZz11HF8iABBKE1VT?= =?us-ascii?Q?551y/oc3WooSTmUV3fEDxNRBwxgk7KMQqk52CduHLUcY436DzqFm8Lhr4yMz?= =?us-ascii?Q?ZaZEbP7K5RtuArebt9Fk3Mol+usjT2Iv4fkABzhcjprAMNle7Jb/YKsIJjUR?= =?us-ascii?Q?UGhn0ZKMrffZP6114MMcAAS36buVrcEhH0ri3fejo3lmKqlCSC4N+8mdFdzO?= =?us-ascii?Q?Ps8qlOy9TwtqUVLL3Pj///ALd4mg3J6hPDKsBCn/7VfOfDufqpgkZNlN5GTs?= =?us-ascii?Q?b2TOrSAXi/5zQ6A=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:35:34.4956 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31547fdc-6fe2-4b22-db19-08dd230b3dd6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8843 Content-Type: text/plain; charset="utf-8" In preparation to move "sysctl_sched_itmt_enabled" to debugfs, convert the unsigned int to bool since debugfs readily exposes boolean fops primitives (debugfs_read_file_bool, debugfs_write_file_bool) which can streamline the conversion. Since the current ctl_table initializes extra1 and extra2 to SYSCTL_ZERO and SYSCTL_ONE respectively, the value of "sysctl_sched_itmt_enabled" can only be 0 or 1 and this datatype conversion should not cause any functional changes. Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/include/asm/topology.h | 4 ++-- arch/x86/kernel/itmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topolog= y.h index fd41103ad342..63bab25a4896 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -250,7 +250,7 @@ extern bool x86_topology_update; #include =20 DECLARE_PER_CPU_READ_MOSTLY(int, sched_core_priority); -extern unsigned int __read_mostly sysctl_sched_itmt_enabled; +extern bool __read_mostly sysctl_sched_itmt_enabled; =20 /* Interface to set priority of a cpu */ void sched_set_itmt_core_prio(int prio, int core_cpu); @@ -263,7 +263,7 @@ void sched_clear_itmt_support(void); =20 #else /* CONFIG_SCHED_MC_PRIO */ =20 -#define sysctl_sched_itmt_enabled 0 +#define sysctl_sched_itmt_enabled false static inline void sched_set_itmt_core_prio(int prio, int core_cpu) { } diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index 51b805c727fc..28f449123d68 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -36,7 +36,7 @@ static bool __read_mostly sched_itmt_capable; * * It can be set via /proc/sys/kernel/sched_itmt_enabled */ -unsigned int __read_mostly sysctl_sched_itmt_enabled; +bool __read_mostly sysctl_sched_itmt_enabled; =20 static int sched_itmt_update_handler(const struct ctl_table *table, int wr= ite, void *buffer, size_t *lenp, loff_t *ppos) --=20 2.43.0 From nobody Sun Dec 14 13:53:32 2025 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2049.outbound.protection.outlook.com [40.107.212.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2809C2B9A5 for ; Mon, 23 Dec 2024 04:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928568; cv=fail; b=Y4xZ1JOicOCJnsqvECmfK0lSwTqCSfR1RTJ9o2Lw4lR2qNnoiGzbu8BAFJxn0GL2Mle8clfR/NV00uvjWapQ/47bKs4JF6F/wDTkZw3fqEf7/s3Cl5ZGut+JsrbpfxcYLmBUMuZ1/No+6L/TjEOOrmmvDQzUdXJ2COfykqk1lYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928568; c=relaxed/simple; bh=60PMUAzfqClYmUx4kXX7jogkYRzU8BRr/2f2HEY6Mfg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FW4D4YEfk03sPasX/ccum81EwSi5MpnZCDpu5HfCyNBBpKNAO5NHlaDjq25rq2CFX5/AdKmAoY1nBFmU4y3s9ULApkjXYH4uP8ghtneA2ApFKA7Sc8Ya4YZ/WOFFw31p+32LnRB/7RWk3iDoLdXke6ZYcdTsmizWUhI4Lcr91XA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iUOzLekB; arc=fail smtp.client-ip=40.107.212.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iUOzLekB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y0Lqbkzk9QefEN8a8GT0chDcrmX/X2dYAgiddS4YL5PLRYBh5X0t/8RwqcwauduqUo6tG93QOUJhd/TndQKDnAIv74YftRnIlbVB6qGdVg1qX6JPWWxJzOfBflltvkz+Rkr6rKJTE3mFdrs1VvdQK7SRvpuU6H3CyBofTFDiLYcF/HgNDv73RCFY1EFDMSrwpWCPWFuXCHdPXAcZozXM6zu+iysG6ChVbOv/3zX+3qIn4Y537JiRj94D+i7Ji1/cid9qFgK83YaWALInxyQ2AIIQrYkuv5BS8vPCuu+WhPeGSzMjNElPMydytRU5fHygMn12JDAYMvSzvKNAdle2tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0W+6vAaLMWM4YAgzx1wXlM2VmIT0uSsEP2tXq6WzK+s=; b=NOWcfm1PDBRFxFfFIBzDJwqoM+Q9JySmWki1ikknytgxdR0OBKTbMQZsDWbVLFcASiPfyuLScftNXZls+3AppTcB+D83nO8N/HoDYVdd0ZH5pDey2s23532JsQoIww9Ibef5DPkd1ZXGQfb4F1ZAlTm3wU0X1nysfUYlMoBrsi7rzR5242UwwFsiQlM5GYcjUSS1sClO/4g3H4G7VyURiv9NSHbPHkOpeqGStTGqVaEfN05Mv0er1vKY3iyXZpoUWK1GRnIuWbW0E+GxqzHdIw1zQ0lLlkABgzgDRayVMbCwq/AYtFtEl46H9dUoO1ZOGgCcSvE4Ii6wdKAGpJpLMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0W+6vAaLMWM4YAgzx1wXlM2VmIT0uSsEP2tXq6WzK+s=; b=iUOzLekB8tADIuf0cRm5IsPD2/g+PVSDbh6rZNHNcjjkTtwFfkQOA7muva/a4jurGysgxkYE4Tp9uOf/6O1ij4JOXFZJ/DExyuuj7L03RNyGzIUia5VRgokt6EgSzYdYB4js60Dzrm4whu3KZy337YwbEJ/uht4c7YLK1O4r1lY= Received: from CY8PR10CA0024.namprd10.prod.outlook.com (2603:10b6:930:4f::18) by MN2PR12MB4254.namprd12.prod.outlook.com (2603:10b6:208:1d0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Mon, 23 Dec 2024 04:35:56 +0000 Received: from CY4PEPF0000FCC3.namprd03.prod.outlook.com (2603:10b6:930:4f:cafe::1f) by CY8PR10CA0024.outlook.office365.com (2603:10b6:930:4f::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.20 via Frontend Transport; Mon, 23 Dec 2024 04:35:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCC3.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:35:55 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:35:46 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 2/8] x86/itmt: Use guard() for itmt_update_mutex Date: Mon, 23 Dec 2024 04:34:01 +0000 Message-ID: <20241223043407.1611-3-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC3:EE_|MN2PR12MB4254:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c7e5c6a-bfc9-40cf-d4d3-08dd230b4a6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?j58pGon2rEdycarP6Aqvjc62eYm+cC1dTmvga84WfYedNbP2mc7/JFULs0Zl?= =?us-ascii?Q?hvnd0NaxNX5IwLZyhGKUYO8W4yquG3hKLEBcCvHJ1RTJO0wSjktz+dG6PYVA?= =?us-ascii?Q?j++Cpf8EiGJU5zeBX5IwU+0Sru8M+KdX30A7D8vea/nEUcPvoR/pdJupDZTx?= =?us-ascii?Q?mOPUF98S9C2JJdZoVQfFGSqx0+7VQTgPp1LvGqMADDj79JuaDj8Zoq4YZ78u?= =?us-ascii?Q?Uf0fWhu5p0pNOylL3UEDUXnNMZPamaRrmAq4+lPfsHnrJec5FRjDtR9+ztHp?= =?us-ascii?Q?vMZCDbrUWYyL3uqVU5ByZ3xOiodeXRqVhsY9FDzzGveNszD5dodBWIT+li69?= =?us-ascii?Q?3cizqyKMS/63vV/gn4843zQPKxO1sVB6Szp4ev8f311oVSR07/SSfKZuUReJ?= =?us-ascii?Q?puBGnOVG3G/DS3LiwSuueeiop03TEHPOYZvQJ+pUUrxFTlvgH8OI2s12Ny26?= =?us-ascii?Q?DBa2xC199d1o5/XvBxRbk6E/wdRgOvf7r9HOIe3btXgR5PiKoqwupgoJG3An?= =?us-ascii?Q?GvofWzNHYYeqqWeivE2VSOKPR5+b19qMO1cOlQ/vkHBmQyEXGLOegGVuTjlG?= =?us-ascii?Q?nT7fy021UtZ/UV+YUgmH2DNvByOJlj5Lkjuqtlf+hVG329Qq6DkovaZjD84X?= =?us-ascii?Q?28mHumacNAZ4OUKm+t/Vn4+gmqAYDTIK/RWB4htJ8ccCkv8mhSGaZUnbK5MA?= =?us-ascii?Q?zSSF0az0pdXD8x+6SNcb1qWOWFQnN0WeqQxdPfrNLeOaj1ThcG7YHi14x1w7?= =?us-ascii?Q?JMFX2uAwWnwBF8oV3cM1X5iyO3LItG2XtvFbgg3DSLjXY1VerGeddvWSuvFA?= =?us-ascii?Q?NoD3/CcpjW1ec8RK/hoia+gijtrZ8c2i8YBBEHtrw0hS8uKWrb1R04s6qZdM?= =?us-ascii?Q?ZVXn2eVe5RMKkW0bWyodYnEUQdrn4j6D+EQHXCfuWQAgoVG7TL0ThGH7Py/e?= =?us-ascii?Q?UBdxpbv4WQKaYzHK9l2SwJpNHkH4QXDVqvbk75ByVoxUEffjw2Jb6VnuOL9l?= =?us-ascii?Q?6VHb79b360whgTP4tU0Nn4OjeYSzXcmyP5VJhdt64sG1Qa2oLlchKZWx3sVW?= =?us-ascii?Q?cSq4WvjnZ0+x526GyZc0znEBVIJq03XUlJnym9NrB12LOej3H7CbAB9QgrPJ?= =?us-ascii?Q?pZ2/EIV1kR1Fp7cKdud974yQj9/+jXz2lLxYPool6+jQHIj56rLeMP2Z85tG?= =?us-ascii?Q?Vx//sy5qZy8bS4aMpnuqstbsJnf6z4Xa/SeiajnkOhVLJVHT1MfD4cdxuABT?= =?us-ascii?Q?VKjahguiGDqsonbYlS61rER9l+uJe3MKGrf4Wedmh7UfdluakewlckFu2vj9?= =?us-ascii?Q?5oJ0nGdKX2OUOv6ILULfHup3dWEK9JpF1GlFj/WfIXRBkqIBn/n7ov+up37w?= =?us-ascii?Q?6aU/K8KKOwd1bZtqrg3xIl/VZGkMtMAdijyYO2ZmcTtGloJpJFboU8rTFUEQ?= =?us-ascii?Q?RsprX0dGKPWWCHJmoCvafliKp9m6WqKAYX7DAu7y7vGoeCF5auhj7Hwpmmql?= =?us-ascii?Q?05U/sTn3z9RIdCI=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:35:55.5018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7e5c6a-bfc9-40cf-d4d3-08dd230b4a6c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4254 Content-Type: text/plain; charset="utf-8" Use guard() for itmt_update_mutex which avoids the extra mutex_unlock() in the bailout and return paths. Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/kernel/itmt.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index 28f449123d68..ee43d1bd41d0 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -44,12 +44,10 @@ static int sched_itmt_update_handler(const struct ctl_t= able *table, int write, unsigned int old_sysctl; int ret; =20 - mutex_lock(&itmt_update_mutex); + guard(mutex)(&itmt_update_mutex); =20 - if (!sched_itmt_capable) { - mutex_unlock(&itmt_update_mutex); + if (!sched_itmt_capable) return -EINVAL; - } =20 old_sysctl =3D sysctl_sched_itmt_enabled; ret =3D proc_dointvec_minmax(table, write, buffer, lenp, ppos); @@ -59,8 +57,6 @@ static int sched_itmt_update_handler(const struct ctl_tab= le *table, int write, rebuild_sched_domains(); } =20 - mutex_unlock(&itmt_update_mutex); - return ret; } =20 @@ -97,18 +93,14 @@ static struct ctl_table_header *itmt_sysctl_header; */ int sched_set_itmt_support(void) { - mutex_lock(&itmt_update_mutex); + guard(mutex)(&itmt_update_mutex); =20 - if (sched_itmt_capable) { - mutex_unlock(&itmt_update_mutex); + if (sched_itmt_capable) return 0; - } =20 itmt_sysctl_header =3D register_sysctl("kernel", itmt_kern_table); - if (!itmt_sysctl_header) { - mutex_unlock(&itmt_update_mutex); + if (!itmt_sysctl_header) return -ENOMEM; - } =20 sched_itmt_capable =3D true; =20 @@ -117,8 +109,6 @@ int sched_set_itmt_support(void) x86_topology_update =3D true; rebuild_sched_domains(); =20 - mutex_unlock(&itmt_update_mutex); - return 0; } =20 @@ -134,12 +124,11 @@ int sched_set_itmt_support(void) */ void sched_clear_itmt_support(void) { - mutex_lock(&itmt_update_mutex); + guard(mutex)(&itmt_update_mutex); =20 - if (!sched_itmt_capable) { - mutex_unlock(&itmt_update_mutex); + if (!sched_itmt_capable) return; - } + sched_itmt_capable =3D false; =20 if (itmt_sysctl_header) { @@ -153,8 +142,6 @@ void sched_clear_itmt_support(void) x86_topology_update =3D true; rebuild_sched_domains(); } - - mutex_unlock(&itmt_update_mutex); } =20 int arch_asym_cpu_priority(int cpu) --=20 2.43.0 From nobody Sun Dec 14 13:53:32 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84542184E for ; Mon, 23 Dec 2024 04:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928609; cv=fail; b=pau9oBwj1Wvug46WYWFs3XJh6jEd7d4kFAAckk2NVhUNQqswYWAv6D+60T6h96gLjr8AHgahra+NCQBtqo0q3DW3BUy8IgqGhmnYRC/MY78sNhRRop388l5TbkO3946jqoTQkEIWuykOW6dG6t8MGfyeHnPvY6W4oVq33Xmr2QU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928609; c=relaxed/simple; bh=JE9nRtf3RyyDmp2PBCmEv0koJHgp7HQbK/N2b3tfvS4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nwg0BvSeV10YUukslRMO6VPsQ5/IeZfolPKgzLBJJWiUZKTvBIacehviw9djGhFImMbbkv5HYc62lXyFfyoWqjXP1xN+yDbU9Vj2TXLdSHwV4hwd7SVoGNQTNiynhSJD+Kj17tTjPwmxtNI41OCyjiUbzwirAbu6zmzwoP+4pq4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pUXDmfl7; arc=fail smtp.client-ip=40.107.223.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pUXDmfl7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BSJiNgyF5f6UcVfJp5oz8qWX2PHPiDNRSkLvss/1OrcQAJdLY0rrRoPcLwjQnS/ncfSIUWKSn/MefALlJ+MEP/wJLUUOzZpPBNV/gxXfqyRi5TSHoOChx+sXCaFSNi58BuNqdKmHw7fCgA0dpmcmmQTEVGFsxW45yvXv7zakTwVl6qtAgnTWE2KfNV22DJ0YMC1X38uVdoEZzAEL2wArvSuBFsmusOdrv4VkvPUzUvYk+FEbRHsRzDaif9hSXGLDrkDWdHUEDsgtlrNCyFxHJVPAGY7h7HVdlVL88sLPPH0Q6bBGo3g0TVEovX6iupLlBWj5t94FGd4nCl5jvg2YXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O1n0FntR5SUuVYnusUDPrfXwFdnctkrfFq2ctFLZcVI=; b=tQeYt7MgfDDnL3rAZ42y1VSl1XblL8NpT2V3pF1XYwXIWT3yNQA5p/G0js05SKzy9wtdSAj1GPqSRi1pXXeM/qlDrhAbqFyW50PQ+e6lZJrlgqbVbuZ2o3YTt/6PEZ0A+L0SrxuX2XYNATlqKfkY+XK+3Bu2rA5u/YJwWojBDyZBhHaPQ4T/T5oVG+HCBW3Imo+v5ec5+uicvwteN+Gr4dZ4v3vZFSYB4EcWXOFWojIxGbD/z9OtfKJ4TXFfpJLMgKtI9fAieSkyAgNpMzDi/8FSUzA0CxZvzHodv077o1wkuk/dQTGPaIoeK3PrlqjJHxbdLFInMpjAY7uRTPNBoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O1n0FntR5SUuVYnusUDPrfXwFdnctkrfFq2ctFLZcVI=; b=pUXDmfl7lXIdE0gzBc+8F0PJ2DW6q5m5V+hnqrtRAmVi3+xRdzB1PU5D5dy7KnPPlWcVG5yT+QsThWcCavPAHCpND9prwKTAqUuzUtVF5M2jaUmRSSzNL04XNEkZ/zxQcoAw0SimscUEqt2go/td1oV+Dh8Jc35rUruddgDD8oI= Received: from MW4PR03CA0101.namprd03.prod.outlook.com (2603:10b6:303:b7::16) by CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Mon, 23 Dec 2024 04:36:39 +0000 Received: from CY4PEPF0000FCC1.namprd03.prod.outlook.com (2603:10b6:303:b7:cafe::9e) by MW4PR03CA0101.outlook.office365.com (2603:10b6:303:b7::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.17 via Frontend Transport; Mon, 23 Dec 2024 04:36:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCC1.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:36:39 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:36:29 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 3/8] x86/itmt: Move the "sched_itmt_enabled" sysctl to debugfs Date: Mon, 23 Dec 2024 04:34:02 +0000 Message-ID: <20241223043407.1611-4-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC1:EE_|CY5PR12MB6405:EE_ X-MS-Office365-Filtering-Correlation-Id: 742d2ac5-2819-4387-2011-08dd230b6462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rqc+vAF4qBVflbBbRRJJMbNrT7v69loExLxRj5Zo1OO2d81/icqYTS/VPCAl?= =?us-ascii?Q?+Edt3r6NQO8Ut2GyKcjC0hy3qidCAAw/0+yL5yTM31NVGY3rnu79s9I2nI0c?= =?us-ascii?Q?oB6PIFd+gASXwP5kPzYYdC0xbTo8+XTENo+pJZAdJEpTbQalxVVKAnhZj2Z6?= =?us-ascii?Q?TSx7EwkzQYccZW+buqEpYnBwFfbUtxq5KHm0cSQdm+eSiT0Z+HufKsjmdyQT?= =?us-ascii?Q?gbT8oVx7PcWpEsUcTs3o7N2GFTEtsmjrEIfURvckj+mkEe2UUhI6n4tU+o56?= =?us-ascii?Q?YRW80clW7v8A1Q1oNf74t0gREBOLYXGuAcLfKtYRRM5MPK0RyN+sWNiqtHRQ?= =?us-ascii?Q?5/z7RwVPuUWXx9kgL84NgTiVqiNv/VTFdKhbvfiJjtjdLmnw3r+yNS8OCNyA?= =?us-ascii?Q?zUW7ifxUFdW8ftv1OsujR55+LjZqHMO2RUopCb8nR+S55WuWY4ZmKABi5obP?= =?us-ascii?Q?3eMq0b8bqe3YJtv55PH9+M5YMfUEOllVtfffE/y+FPgcHC6HoMYYR+TJXjCZ?= =?us-ascii?Q?vl8SZP7I0fzjnfv0guOdXLa68coMZhIr2mvvvxidIC6d7PdGzBogR+njHAIF?= =?us-ascii?Q?YoIO3ZbImatG7F0Uh0vTOgxVab7DYYz/gTqdzsxbILci6TPcFgBft5zj8FG3?= =?us-ascii?Q?U2om5riDnMaSA7oOgTl9o0LQMm2gLo2egTyTIZYWlAQ8PsgDG5bt8DW3cmmZ?= =?us-ascii?Q?mhiPOc3HreHIpMWm5xcwUGdVJLpeEMW0qzQOQ3NK9YcsZte7+bQz9vCjtshD?= =?us-ascii?Q?4C/bo4G/+SqnL+oOjTd3AjObxzuGTnMKF67Ihr7MPqH5xzaMNav9U2sU+/bi?= =?us-ascii?Q?zsZsbUA3iRhp4uitMO/dSOW0A2QXXQ3EfRK+s5XgW7gLBtnZAAXfO6yQm8KJ?= =?us-ascii?Q?CEe7omGPM8SZ2ay848CPUHl2R4HU9Z4RGMZUvFQl/wVWmUv/b8i51ZAN0v1A?= =?us-ascii?Q?7z0Nxf1xQIyoe65+QWTG0Dq5Gosf0MBOv6QzuIg1+yW75N5m4h7IxTrEYjhe?= =?us-ascii?Q?mOAtctLCCSI9RsrHtpdc1bIjdWDM2Yg4MclOL0PaIBAJ80pzfBlLoJBy/eF3?= =?us-ascii?Q?OIq/zaNHN7qm7Y0vRFNHZimnwPkF8D//qML+flIvJPBnTgWOwYvg4aCCPsCc?= =?us-ascii?Q?FFl6cRAdGt87sxngGbcQIKdIKPSmu20GUMMS6JHlY+NhZr4xfZno+lcVIyZ3?= =?us-ascii?Q?M4zuxkdGu+kdGpe7UMFA4DrAR7GF2wMUGeo4M5TnnPDIS8/y3v82HAefBqCQ?= =?us-ascii?Q?Ayu1jkxiPp30KHCpNW21knhz4+K4qr71QaaCCqNyzNG4jQpQosjZNeSdZlEz?= =?us-ascii?Q?SDWpg/9pSq3fT6icDYaDgXLVkC6mwry00EnSjZrNaathIz/xyFjx9gse5gSQ?= =?us-ascii?Q?9ITVUUpr68rx43qoCguCaw80dUQoMqHZJBDAzFQqjbLwGfgzRwtlA7LFBd3f?= =?us-ascii?Q?mHFZRSyanQBMvtXhX7H68LKHmKxF7XjqSDjFUsT0pAhLqdL7K+7pSdpvLXF+?= =?us-ascii?Q?AQ3QMrssCetcGlM=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:36:39.0680 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 742d2ac5-2819-4387-2011-08dd230b6462 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6405 Content-Type: text/plain; charset="utf-8" "sched_itmt_enabled" was only introduced as a debug toggle for any funky ITMT behavior. Move the sysctl controlled from "/proc/sys/kernel/sched_itmt_enabled" to debugfs at "/sys/kernel/debug/x86/sched_itmt_enabled" with a notable change that a cat on the file will return "Y" or "N" instead of "1" or "0" to indicate that feature is enabled or disabled respectively. Either "0" or "N" (or any string that kstrtobool() interprets as false) can be written to the file will disable the feature, and writing either "1" or "Y" (or any string that kstrtobool() interprets as true) will enable it back when the platform supports ITMT ranking. Since ITMT is x86 specific (and PowerPC uses SD_ASYM_PACKING too), the toggle was moved to "/sys/kernel/debug/x86/" as opposed to "/sys/kernel/debug/sched/" Suggested-by: Peter Zijlstra Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. o Added a note on how "N"/"1" can be used to disable the feature and "Y"/"1" can re-enable it with added nuances of kstrtobool() (Tim, Peter) --- arch/x86/kernel/itmt.c | 56 ++++++++++++++++++++---------------------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c index ee43d1bd41d0..9cea1fc36c18 100644 --- a/arch/x86/kernel/itmt.c +++ b/arch/x86/kernel/itmt.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -34,45 +35,38 @@ static bool __read_mostly sched_itmt_capable; * of higher turbo frequency for cpus supporting Intel Turbo Boost Max * Technology 3.0. * - * It can be set via /proc/sys/kernel/sched_itmt_enabled + * It can be set via /sys/kernel/debug/x86/sched_itmt_enabled */ bool __read_mostly sysctl_sched_itmt_enabled; =20 -static int sched_itmt_update_handler(const struct ctl_table *table, int wr= ite, - void *buffer, size_t *lenp, loff_t *ppos) +static ssize_t sched_itmt_enabled_write(struct file *filp, + const char __user *ubuf, + size_t cnt, loff_t *ppos) { - unsigned int old_sysctl; - int ret; + ssize_t result; + bool orig; =20 guard(mutex)(&itmt_update_mutex); =20 - if (!sched_itmt_capable) - return -EINVAL; - - old_sysctl =3D sysctl_sched_itmt_enabled; - ret =3D proc_dointvec_minmax(table, write, buffer, lenp, ppos); + orig =3D sysctl_sched_itmt_enabled; + result =3D debugfs_write_file_bool(filp, ubuf, cnt, ppos); =20 - if (!ret && write && old_sysctl !=3D sysctl_sched_itmt_enabled) { + if (sysctl_sched_itmt_enabled !=3D orig) { x86_topology_update =3D true; rebuild_sched_domains(); } =20 - return ret; + return result; } =20 -static struct ctl_table itmt_kern_table[] =3D { - { - .procname =3D "sched_itmt_enabled", - .data =3D &sysctl_sched_itmt_enabled, - .maxlen =3D sizeof(unsigned int), - .mode =3D 0644, - .proc_handler =3D sched_itmt_update_handler, - .extra1 =3D SYSCTL_ZERO, - .extra2 =3D SYSCTL_ONE, - }, +static const struct file_operations dfs_sched_itmt_fops =3D { + .read =3D debugfs_read_file_bool, + .write =3D sched_itmt_enabled_write, + .open =3D simple_open, + .llseek =3D default_llseek, }; =20 -static struct ctl_table_header *itmt_sysctl_header; +static struct dentry *dfs_sched_itmt; =20 /** * sched_set_itmt_support() - Indicate platform supports ITMT @@ -98,9 +92,15 @@ int sched_set_itmt_support(void) if (sched_itmt_capable) return 0; =20 - itmt_sysctl_header =3D register_sysctl("kernel", itmt_kern_table); - if (!itmt_sysctl_header) + dfs_sched_itmt =3D debugfs_create_file_unsafe("sched_itmt_enabled", + 0644, + arch_debugfs_dir, + &sysctl_sched_itmt_enabled, + &dfs_sched_itmt_fops); + if (IS_ERR_OR_NULL(dfs_sched_itmt)) { + dfs_sched_itmt =3D NULL; return -ENOMEM; + } =20 sched_itmt_capable =3D true; =20 @@ -131,10 +131,8 @@ void sched_clear_itmt_support(void) =20 sched_itmt_capable =3D false; =20 - if (itmt_sysctl_header) { - unregister_sysctl_table(itmt_sysctl_header); - itmt_sysctl_header =3D NULL; - } + debugfs_remove(dfs_sched_itmt); + dfs_sched_itmt =3D NULL; =20 if (sysctl_sched_itmt_enabled) { /* disable sched_itmt if we are no longer ITMT capable */ --=20 2.43.0 From nobody Sun Dec 14 13:53:32 2025 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2084.outbound.protection.outlook.com [40.107.212.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE6A63C for ; Mon, 23 Dec 2024 04:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928682; cv=fail; b=jM1urkRSptyuF8J/M8bq0YmmH4iHaYNMtLxh7OP7czbWveH/e5E+YR+sQ2/1cU6P2ijkYjWte3p1pBANowlC40Se4JLwaHTm3e6Kmym+xA145Ne7dTWlaqFCSI2RhHHavIkc95bITtktEsIStHTPvtCk7UfPBPwuYO4Sg408kLA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928682; c=relaxed/simple; bh=j5noIcMThfIxhOslzuWl1f5QbsI0fVcpmkLQSAW0lyc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Uv3brmO06EUEGBy7PDUmPsVTWGw+xDXtEeXvcZvKAPrLe5nAs7VX4hImWq1Uca7AkdnxBewgBTk85dhd/hg+vdKDpzzqoVwGczLZ0THMjvem1r6TVtmCMb8lVzzQ7BuUzq5puyXs2xanomNkG6DXk1H3kj4VCdUnLMrzCfME6CQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Wfeq48kh; arc=fail smtp.client-ip=40.107.212.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Wfeq48kh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Uo22FdERXilWiDrTMbPgCtfaVXwRR1n/dSNnQZXmISVE68BGC7tuPl02qQNlSqiD0gzq0gcP4320z9LywSUnicPjk08F5xetj7K2egw3IPvZV8+uTTPXiz1u286u/4xhTp1ZTRGQfve+B9yC2U3WplRi3xhkezqNtyXj4xb4Av47ish6f76EcjLsZ4Xc4JVzjWh7s5uvOLKuvKlLftlb0eOct17GOhqcJfFC2gD2+0nFT3oeG0OV9MFwSYmj1y47jnpLuaw2+8zheJ1wsQdS1y4UCEIgXct98R05fj3PZzkuGRSIo5TxMgA5HaqxnhWzU43KK7Rh+/L1hAvuyCyCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dt3jA//HmvKNsZprmxt8eR2gUjwEbJNJj5MqblhF+MU=; b=y+REFsLWR+42V3aeJT1YbHPyVRXq1oq1XPLJp3bF+1em1Rgc6PU4lk8+xQO1km9nfV8Bq8SMujNZtZgfnw5QuTu/MII9WkCmBKbGP08/jCo+su4tCPgNmu2uEXlVHT0WXmTs4gm+ybKA8e7y86WETpgbHK2dZVdYT2CGeNTJok1QGPQmuy7vg3iEBD6iyws9taShQDhgA93kIjQs4K0iHuGkOFzxsqmJT1pTGFOmmn32/0zg6wRtRRb5FYnud5NNrBJPbDa2dEYpKXopwobDmfgvrKrBWtJMIr4PswZbnCTQtBEuRwez2MNxgLa1Pr9Jt+vGllWFzVPK/zuQECUecg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dt3jA//HmvKNsZprmxt8eR2gUjwEbJNJj5MqblhF+MU=; b=Wfeq48khH0iLR4rSwplGhsq0tLlCefR7FaPZPgs4SLywaVK2mMOvL42ZrJ1lHWHPyDUB2ODy6NnLw3rny50AA12GeGTVDrHTY56Q0OS5/XXBm2TRpHBnGRbkvGS13FKAHyOds66SsHkA9fqIUDeWm1WES3B29NVrlDr0g7+/U5I= Received: from DS7PR03CA0292.namprd03.prod.outlook.com (2603:10b6:5:3ad::27) by SJ0PR12MB6942.namprd12.prod.outlook.com (2603:10b6:a03:449::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:37:52 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:5:3ad:cafe::16) by DS7PR03CA0292.outlook.office365.com (2603:10b6:5:3ad::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.20 via Frontend Transport; Mon, 23 Dec 2024 04:37:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:37:52 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:36:51 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 4/8] x86/topology: Remove x86_smt_flags and use cpu_smt_flags directly Date: Mon, 23 Dec 2024 04:34:03 +0000 Message-ID: <20241223043407.1611-5-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|SJ0PR12MB6942:EE_ X-MS-Office365-Filtering-Correlation-Id: a87d9116-c79b-4ee3-5b56-08dd230b8ffb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kN3zD13PooIAj5aFi4WTor7c95AzJ9vj/ACsn4nM/zMpg0jWs6Mgmu8Tpt7G?= =?us-ascii?Q?oZ1BELPxU+NdSwe1Oby0k22wJDJ/Cy8HZABmtqTjwsG77jCh7TBDMVxbJtUh?= =?us-ascii?Q?N9sG3BdKkIrgCQVx/2p2boch8exH9eHUZv1KGHf4f6KHUPb65NlCkFqHIwIe?= =?us-ascii?Q?Qc8xzZ1R/15Z4vqTAu8sRunwQVhd6hOPzSZynsgqqpteOQupUwUWDCYVBxGC?= =?us-ascii?Q?pig2+Ts6MUquT8z+jK6B3pBXLbWv8rof/V/spTQ+hVBGVh4Ih3ElR+JFf3Rn?= =?us-ascii?Q?WpZCBpfNY//LD0sc7v6GJ+V0X86GKLFdmcCe0Si332iushHarnNORb+v7/0d?= =?us-ascii?Q?MCIA7pNsYPDWdmjKotroDjdHSC0BDnGnTPSPDj6ewe81ZXsmvqhf2ufk5f1J?= =?us-ascii?Q?HM6lYv/N1E4VJWH8c2NMIUSnnIt0dEnd0a9+FCKu36SGUuBzxD1LE8cl9YNR?= =?us-ascii?Q?4Q5DnsTU72osDNaG+cSS0AvNJxT6pclWQqiWpdhh9N0n2D51CGB5DU3VkicB?= =?us-ascii?Q?8Z3nImQINTYG8MREP1+skCxdYGPEBvQrkb659LZ2VUy/cNuOgoewCw6/Qj7L?= =?us-ascii?Q?MRQwZ+9B4dhV8VgiQWl5AmF3eSuogTTLjte0lVD0Xt3MmqDIpBd5/Yp0S17T?= =?us-ascii?Q?LggWlZ4PodtnEaL8WeGbejoEOK82eCnFYuvkfV0+ZVXO70CewNj3+YmAN7gV?= =?us-ascii?Q?Cby2kAHdsv9TCTHF06R+uigjCD9l9+TlLTZ0NbIoX1p8Jvsa6fPeJgmEHMwY?= =?us-ascii?Q?U+8qCjpt1IRd8N+tt4/9V2aE2lh9ER/4zqQj4/gJ/qWWzDohtFPWlpXelQGG?= =?us-ascii?Q?YqpekQleiLQRHXyq1iV8ojWU+I626AmkSngY5+an1eL42W2VaZ+NtZYIt8o/?= =?us-ascii?Q?ayhBXaFWaQuKLKHEfSoBVaC8XdSNhql/7EcrgvAgocL/6g89JyeKk3RmOc50?= =?us-ascii?Q?H9v0ycE/T6ZM0Gf2E/kA8Fr/oUY2zDjaKebbbWWPRNyEsOJ0if6ODLjLLCnE?= =?us-ascii?Q?6IAOwiCyFEoG1eIfGu5hOGKXgLaFZBQymG4LR2JVWueaqK7QnLVZUAN6oZ+7?= =?us-ascii?Q?X83rX8sHX8uFyNPlPAmgvxw8fY1zWI/IXESlOcpGdXyg3JXt8pXj0W/0DJq8?= =?us-ascii?Q?f3tOxDKRbhmurZur5TsF+EmCZy5gEJquOS/vvtmePRT77YAiSWS5X7uDgjAj?= =?us-ascii?Q?1nqM0guPcc4VTKZz0aHx2Jf34zK0hBRmYCxjf26hD57kkFOdzWGKx4k/yFs3?= =?us-ascii?Q?hia59RjGom8BP6qCouQl4zSPsE+6NO0e8mJKjLBIPYLJE9HGmRTG4VNPJDSm?= =?us-ascii?Q?CcD8rG85/++u/NmZmnhWJmOUYOT9GJnAj9ZME3LyLWd6AkGnzifMy8boqlGl?= =?us-ascii?Q?DmyRkEi6PzXHLvmn65LLPtCuj1Duv/1LOz4kfkTqTRqol//cxJLgam4b9ob+?= =?us-ascii?Q?l8QgXhBlGeCFd+m39e2V30lit7YX2w+uD5tb54qEu8SzkqqHP+vDqyjyRQfw?= =?us-ascii?Q?di3/Jy5DZBhUIX8=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:37:52.2144 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a87d9116-c79b-4ee3-5b56-08dd230b8ffb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6942 Content-Type: text/plain; charset="utf-8" x86_*_flags() wrappers were introduced with commit d3d37d850d1d ("x86/sched: Add SD_ASYM_PACKING flags to x86 ITMT CPU") to add x86_sched_itmt_flags() in addition to the default domain flags for SMT and MC domain. commit 995998ebdebd ("x86/sched: Remove SD_ASYM_PACKING from the SMT domain flags") removed the ITMT flags for SMT domain but not the x86_smt_flags() wrappers which directly returns cpu_smt_flags(). Remove x86_smt_flags() and directly use cpu_smt_flags() to derive the flags for SMT domain. No functional changes intended. Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/kernel/smpboot.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index b5a8f0891135..6e300897b7ee 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -482,12 +482,6 @@ static int x86_core_flags(void) return cpu_core_flags() | x86_sched_itmt_flags(); } #endif -#ifdef CONFIG_SCHED_SMT -static int x86_smt_flags(void) -{ - return cpu_smt_flags(); -} -#endif #ifdef CONFIG_SCHED_CLUSTER static int x86_cluster_flags(void) { @@ -519,7 +513,7 @@ static void __init build_sched_topology(void) =20 #ifdef CONFIG_SCHED_SMT x86_topology[i++] =3D (struct sched_domain_topology_level){ - cpu_smt_mask, x86_smt_flags, SD_INIT_NAME(SMT) + cpu_smt_mask, cpu_smt_flags, SD_INIT_NAME(SMT) }; #endif #ifdef CONFIG_SCHED_CLUSTER --=20 2.43.0 From nobody Sun Dec 14 13:53:32 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEF663C for ; Mon, 23 Dec 2024 04:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928704; cv=fail; b=rt6CMRJH+P0RLUXFbaEJaKQj/XBhGibDh1NelX2wDJAf+lDlyGoAOPiI+SFyVbbPIYdMfahPCHPmXu8CmEhm7oOkee6x+3a/CnXY6gCBiJNR6E5aberbYWk6sB731ZOGtqCEibvYVMuwokECUqUI9aXvi150uFi4wlxXqreQLIg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928704; c=relaxed/simple; bh=v6ELstIDbt2XN9DhheegPI/PhDezipx+2lx2LVPE2kU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S5Rpa4RTTh/3gbhx7UVhdGEYp8TFnROaFxXVbzR8g3QMGdpKyDf53WZ6zhMzbMwmYeU4JrHnvcZLfCgrQwjkM50BQDVwxlU2h4MBnody/6vKxvyqhoCeGxlKTmwTE+ip59I5Xapze4zvBLVsnkXyAmLuY3uDAtlVESTZLoPNX90= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=F7u4oDuS; arc=fail smtp.client-ip=40.107.93.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="F7u4oDuS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iGNaWSlgLg6MJ6ksKgEFslYAqoY7ZNaJFK1vUTtj45mPvrw0mpCHC2HVIR+KaxppKeVYLPsooiiKwx+IvjIjb1llBFuKWl85HsqAt2e5aCXRe+y9sg4E25boa1MdS9QQj0V54OcdhFvJvlPK5DDe4Aiw3Mpl9kk1Gp/PBpZ94+Q18Nrgv5s2foXyBsMMg7ersypzVttctK2EW0Y7rZ6Jjzmqooviin02pZqC9AZUj25VSe+kHVcGtFhLxSaHUZlEiMG5SzEdHSAkmhV/tWU6mRDe4IXSkAmrvYnmN3kV0J8bjGya2w/0AqGLRSESztbBncE4ECoRsTZnlTY58XlhyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hORpJfTY0C4VBrOo16+4F6X4emYsEBxOFdyM/by3Rm4=; b=c9IGpW5JTnKH5wGsTo5/rRN+a4SJkFl5ZqixE4997wThMLun4N3rucyGYI+anBUV8dWyciCdBzdy8WUchLFUjhBF0cNJ9NaZsh07Y+UQV7gZsp8/yHAPRj8iSEG5QLYeRaMup5yeogjSXkU4SbOWdYCIgyw+pdo02XDnqBJRQMis90k9LPw/Olag9yUSck53JdufycHU7VHoLIIFJwfl4v1yw9nmHSBJ8rC1as1h5MONOKP2+vzRNHKMZhOeSY0Fqz7tyqysgKg4tBrnHWq0WkwhF2MuEbtvP7n92DmIdIYa/FTd7B2V6zVZZukdxJzoqz2MUZfyeRgfbboFHnHueQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hORpJfTY0C4VBrOo16+4F6X4emYsEBxOFdyM/by3Rm4=; b=F7u4oDuSljv2wVyX8sHie4KuKj6pSD0GWhG/rg8MVlIiGK4pUuRUDUuoXdWnRc/NFCFLN2OVAL4By+lV5HnNKevTWaLJD/bATTxzEhftjm29SOJcBk3v+A5mIXbOlekHrvtg2hAq6RoGlIzi+pxjDZC7HK4Wlj3D5LS1O2EH/8U= Received: from SJ0PR05CA0002.namprd05.prod.outlook.com (2603:10b6:a03:33b::7) by DS0PR12MB7876.namprd12.prod.outlook.com (2603:10b6:8:148::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.19; Mon, 23 Dec 2024 04:38:15 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:a03:33b:cafe::7d) by SJ0PR05CA0002.outlook.office365.com (2603:10b6:a03:33b::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.7 via Frontend Transport; Mon, 23 Dec 2024 04:38:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:38:14 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:38:05 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 5/8] x86/topology: Use x86_sched_itmt_flags for PKG domain unconditionally Date: Mon, 23 Dec 2024 04:34:04 +0000 Message-ID: <20241223043407.1611-6-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|DS0PR12MB7876:EE_ X-MS-Office365-Filtering-Correlation-Id: 41d17e76-3e68-4eaa-d65d-08dd230b9d38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LfL5C6o+Fp2MwfK2sp69ENA4FRishTYPOQUT8omKxbXF8kopTmtVat4R8/Iv?= =?us-ascii?Q?XC4JDvTY5TRfj5PBXR6f4o4V6nfeCskS9gyz25M+HcmUl0bT8yJ7XMLIVdcS?= =?us-ascii?Q?2xYl3/nuO62zcwKK82/UrnkWChlsqdWSKKSDZl06pEYXPBLkd2zSGIdAT6LO?= =?us-ascii?Q?beUiK6VItJbUG3bY5WlHLfIiRF/51JdbG24RriZxZD8jef6K8GkGFEm/JXnp?= =?us-ascii?Q?Ambcfd+yl0eZvZF5RRLz74hKjCUjdUR0kTA/bPm8QecP0We3fjWnazfy8Ae8?= =?us-ascii?Q?tkT0JQcDOZKFNihYzYopLCwBaI8mr2Yq26jeHdFFY1P+e72MPK3Wja2BdaI+?= =?us-ascii?Q?gNRG7DYBb0tYcsAfGl7QyeBhae8gw89QQAegW30vr7AnXJ4GUPihUm9kTfxX?= =?us-ascii?Q?IfXOKAgGRRBM5lTpCx7urB+CW4d7hMVWivL+YZ8OeLA7+idiiar6sykzIibE?= =?us-ascii?Q?SZZxooNj/Jwnuw3g/dw9kqDm4q9AYievmMDlnqIXOpyitYTB/+ue0ghKyzEX?= =?us-ascii?Q?itvfX/JJDKvKYNRgPlQ2vjSLBxS3EKr8QBE7LHk4iMbSO/IMtOi9jQc/T249?= =?us-ascii?Q?zFDl8Wc+swm+jcp74PwS9TxX63x+5NkyqUW/ihmiYg2elRtIsw7RwYEPzmbb?= =?us-ascii?Q?OcX+rrIn1JXP4+5pmo2rFb8R5cp7WevoD42lCkGyqM85ifcFrvlXDczFYQup?= =?us-ascii?Q?yIKqIlrlQu37Rp60oteSBbTo6Tl+1FfKqI33gT96nomjGUNjpqBgSeKvPtHk?= =?us-ascii?Q?sujS8Cs7Wb+ILeTtM0iGjDyhGDH4rpU1LZRUi/3Vm9Sq9AgbiuVq0VcaWx+P?= =?us-ascii?Q?16EuKpCZGOpr4CGsJB5qbNPQfr7Dfg7W1I9Ih2wi0URhZXLd/tQmumdylZcQ?= =?us-ascii?Q?foat4ikgl/ilXQJ6sRHBeo8RCLeLpef/uBpuNXizfOOJ2S0h3aREFpcUB/CF?= =?us-ascii?Q?kxlfQxFuzEa0CremKYXUohNROIkje+FxrAKUHz1Mkk5CtnId/XmsJEDcZvE9?= =?us-ascii?Q?XkOvV/ipE82+JpSYhf6o0OVXGGgF6HvvG0E/xCeHhvZodBRLy7vmFphLBCy9?= =?us-ascii?Q?aLfgVCd4W+a/7rtF3tyzy3N9nIbLCIXpxCeNwa7BnEKq7PVuLXBVfG1oNWab?= =?us-ascii?Q?6QxKTgT5ULIDE9ysIXHLOfs0WadPeSAvGODhWbISwkiueCrUA8yrsJdfLVpH?= =?us-ascii?Q?SjUvP95rPF7Ar2LCfre95I9QUU9KIfAEd5jwWwcWxDA/NnNAXhKN8pe43esM?= =?us-ascii?Q?2WpTV+SJX+JMZqEaEIm4wgCW3IWpFesNdpLzi1yBvFTaTJA/RDE6MQpXC0fb?= =?us-ascii?Q?56rtLPLvmyKxVP4A5PIHyHx0uBbj+pHSFMY5EWJ8CuTsSOsmNtGsJbH8oePC?= =?us-ascii?Q?hzQkGApRgaUgEnM+MBZdI4IKskpLYn1xR4DQfGYb2mJXSJzQEucMiRPGKfFH?= =?us-ascii?Q?qHZN1F/pY4h9EmRKEr2yj7MV0siNnoIJ1TrYpqYg3BmcLhV2QhFPZrTGUHzC?= =?us-ascii?Q?f4P2IYf0+06Ty5A=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:38:14.4276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41d17e76-3e68-4eaa-d65d-08dd230b9d38 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7876 Content-Type: text/plain; charset="utf-8" x86_sched_itmt_flags() returns SD_ASYM_PACKING if ITMT support is enabled by the system. Without ITMT support being enabled, it returns 0 similar to current x86_die_flags() on non-Hybrid systems (!X86_HYBRID_CPU and !X86_FEATURE_AMD_HETEROGENEOUS_CORES) On Intel systems that enable ITMT support, either the MC domain coincides with the PKG domain, or in case of multiple MC groups within a PKG domain, either Sub-NUMA Cluster (SNC) is enabled or the processor features Hybrid core layout (X86_HYBRID_CPU) which leads to three distinct possibilities: o If PKG and MC domains coincide, PKG domain is degenerated by sd_parent_degenerate() when building sched domain topology. o If SNC is enabled, PKG domain is never added since "x86_has_numa_in_package" is set and the topology will instead contain NODE and NUMA domains. o On X86_HYBRID_CPU which contains multiple MC groups within the PKG, the PKG domain requires x86_sched_itmt_flags(). Thus, on Intel systems that contains multiple MC groups within the PKG and enables ITMT support, the PKG domain requires x86_sched_itmt_flags(). In all other cases PKG domain is either never added or is degenerated. Thus, returning x86_sched_itmt_flags() unconditionally at PKG domain on Intel systems should not lead to any functional changes. On AMD systems with multiple LLCs (MC groups) within a PKG domain, enabling ITMT support requires setting SD_ASYM_PACKING to the PKG domain since the core rankings are assigned PKG-wide. Core rankings on AMD processors is currently set by the amd-pstate driver when Preferred Core feature is supported. A subset of systems that support Preferred Core feature can be detected using X86_FEATURE_AMD_HETEROGENEOUS_CORES however, this does not cover all the systems that support Preferred Core ranking. Detecting Preferred Core support on AMD systems requires inspecting CPPC Highest Perf on all present CPUs and checking if it differs on at least one CPU. Previous suggestion to use a synthetic feature to detect Preferred Core support [1] was found to be non-trivial to implement since BSP alone cannot detect if Preferred Core is supported and by the time AP comes up, alternatives are patched and setting a X86_FEATURE_* then is not possible. Since x86 processors enabling ITMT support that consists multiple non-NUMA MC groups within a PKG requires SD_ASYM_PACKING flag set at the PKG domain, return x86_sched_itmt_flags unconditionally for the PKG domain. Since x86_die_flags() would have just returned x86_sched_itmt_flags() after the change, remove the unnecessary wrapper and pass x86_sched_itmt_flags() directly as the flags function. Link: https://lore.kernel.org/lkml/20241203221746.GKZ0-Dii5rnZppkM_e@fat_cr= ate.local/ [1] Fixes: f3a052391822 ("cpufreq: amd-pstate: Enable amd-pstate preferred core= support") Reviewed-by: Tim Chen Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Tim. --- arch/x86/kernel/smpboot.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 6e300897b7ee..ef63b1c0b491 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -489,15 +489,6 @@ static int x86_cluster_flags(void) } #endif =20 -static int x86_die_flags(void) -{ - if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU) || - cpu_feature_enabled(X86_FEATURE_AMD_HETEROGENEOUS_CORES)) - return x86_sched_itmt_flags(); - - return 0; -} - /* * Set if a package/die has multiple NUMA nodes inside. * AMD Magny-Cours, Intel Cluster-on-Die, and Intel @@ -533,7 +524,7 @@ static void __init build_sched_topology(void) */ if (!x86_has_numa_in_package) { x86_topology[i++] =3D (struct sched_domain_topology_level){ - cpu_cpu_mask, x86_die_flags, SD_INIT_NAME(PKG) + cpu_cpu_mask, x86_sched_itmt_flags, SD_INIT_NAME(PKG) }; } =20 --=20 2.43.0 From nobody Sun Dec 14 13:53:32 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3391B63C for ; Mon, 23 Dec 2024 04:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928812; cv=fail; b=Nm5K2MB2lIU9HYlxaEbkZrtMcRw0XwuZekAKsSbHMElO5Vp6wy8t5mUGGjBNMaj16AgJHCYe1D9s1A/KZOph8oIKfygoNpfiihbvCYyYGoLkbfAj2mNtnDSxnpWRKkXKBw8t7pk6Pxyoc5GSQUxIQJqLXoeP5XSvM6ZVnw8WQiI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928812; c=relaxed/simple; bh=QNjP/cgAQouWDqnincfjlsL481/iKQakI8jwZPA1dkU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GBip344dw7i9B6uqknDuiDr+hHkIJn4dDp8QZB84nwczB9nP7wCPH2qT+zY9waZdUwZ9OMYMekbaBoRC98JKz/MPYDc2nTblgBX/NVax8udQ8oNNBuh/Us9CNI1kccPdKk4sstH+cTb4SCPHtLru/AWvC7o0v1ktADlOF6LxR2c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fKkI8C9D; arc=fail smtp.client-ip=40.107.223.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fKkI8C9D" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jxyNT39S+SfgrBc8h+WwNReQxcgRM/ZpLzfKYea+o6fN3yHK23nkB8auswzaQ+bXpRYJB6IFLUDK3y2h8hmXwRzRkj+3x4vN55qHkyRZRBLcjoHA0J9BCarxo+5t+FWOXLHAhRHiMJOlL5XgZ9KFVKOD1CJRGM6HFQoeyrjdpYjccuN+M5S+zkOv2rmwOVj+uzX7zEHELM0Z4e/31U4hmRuAWuKWm5YTh85PEchqOxKbbn27jEQKIW/Y1ITd4a18d2f27QGER1PJy8H0074tC6tQojq7ZdZZTc5GXHHICwUePi2is4rifowlYyDiiKsN30kELK8khieAoRmBhlglQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+QfPJn1jxgevndcHI7NA+XtS2IgDlMfl1Tm1L8NHe8=; b=aGHNzM2OKCkZeb+zf9UZKAdsTNP7mm36p0gTCUfNWbgc7Zug3m4B07SfPdlURGTsS6XTVbI1byr8dLrbQ6GGZjPIyLvtQSj/gcrr/Cvn827oqHbFmdHRsxFbZJghxRRWrb6axpWS4Su6GQ9TBjqwJjoqv1MinjEShZNdhqFi0nuJE6ZJNsrnhuqOiLq7yeU00RO49/zNNfgcUfVGakzN5O+doyGYMHKmmvITfKtj6ZYcjeJeEnD59kwYGABvNDtqPkr128JFcDV4DYNSsH7d+VZcO41JculJR7sGshSYuaHXZA6ec10yIQNv0v//SkTpfdWjIB8CAEjuMh8H0/U59w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+QfPJn1jxgevndcHI7NA+XtS2IgDlMfl1Tm1L8NHe8=; b=fKkI8C9DfRqc88RLNrtluEaEZZZzOA70a2DdAjxkm89sHdy6NCJ5iV8C8OCr/icfRozsAz/wuyxS9mEJwsO2XtJcpztPV67DDSZPYyNKoYbIXq2jm7tI8KHjJf7t0fFeEFCrlIPmdH/PWR0qktdNlyqbR22RWoKab5NoYsHzdqM= Received: from SJ0PR13CA0010.namprd13.prod.outlook.com (2603:10b6:a03:2c0::15) by SJ0PR12MB6688.namprd12.prod.outlook.com (2603:10b6:a03:47d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.18; Mon, 23 Dec 2024 04:40:02 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:a03:2c0:cafe::33) by SJ0PR13CA0010.outlook.office365.com (2603:10b6:a03:2c0::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8293.10 via Frontend Transport; Mon, 23 Dec 2024 04:40:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:40:01 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:38:27 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 6/8] sched/fair: Do not compute NUMA Balancing stats unnecessarily during lb Date: Mon, 23 Dec 2024 04:34:05 +0000 Message-ID: <20241223043407.1611-7-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|SJ0PR12MB6688:EE_ X-MS-Office365-Filtering-Correlation-Id: efc1cf80-7e26-4f2f-4cd9-08dd230bdd0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ySOzVr9B6mIXp4RGbFh+pKcAEAEerZ1IJfnbg3sZsvLUJX3GlDZreJyFe7Kb?= =?us-ascii?Q?tdR4Q7ypQql4q+68Uk1D9WbTa2C+o5QfcGdBEUIG8sxTxk6sF6RWoRvyTnZd?= =?us-ascii?Q?oK1wmBFwnufD4nReiYG2+3YBsDCdTPyTbqGkh8cAu3RLmdbKGEtwH9xAKR1o?= =?us-ascii?Q?22DmQUb1C3msLCSVD3WW6F1923D54SJ28THwBvwk68rItLxVyD2hQiBj0ifb?= =?us-ascii?Q?C8GPMMuY4HOf5PUqUGGfv6Rret63Cu7Sx2wS5j3u2fm6chKvGUDwnZ4dz9mk?= =?us-ascii?Q?QAMwV1tnYMAhk5dfhxLWPvwlaPal6TDvZazkrdKMioAbSo7nvkF//GKfgfF3?= =?us-ascii?Q?lgvyOmqwtuyG+WtGJk+1RSyusaSkcF1t241r7kMGDCL3qLLZTn+/CjzgfFLY?= =?us-ascii?Q?RP/HnxZfyV3cxpB0KT0i5BY3YonGDVWAp4lPS5pQJk050D93X9T9kWXUvOTg?= =?us-ascii?Q?yn/6SaqFAtoh1FlXJWobS3HWvBROS2hUA59fPnwV1VW88OM2/J18eH5aazJr?= =?us-ascii?Q?AwAFdkb3t0yCsBs1a4TCCoUgWpqyxbYEIpk9T4l5xkpuzmS33wFXQjnxYiYE?= =?us-ascii?Q?oDGEEaZ563PyKXh0zJpk8LBb22EjzPIsFmLRtf7yvI5SlSXoZYiMqlmLG81O?= =?us-ascii?Q?XrfgJ6Y6Fg6QC1VvZO9qSvP11rOfvukEkJf7XsqVrW+FmacRICMjq3gYpets?= =?us-ascii?Q?Spa2VYYHV4rZOrvZz1gc9DISwkot+4RBCsFmHUJvWjQhfMsX7ADHfMaYIJwa?= =?us-ascii?Q?SpdycP9DIqGocNlPSDFoC6UyTIR44ifH+Qu06dWdH8Q8UoyVM1Ob1t2NYK/u?= =?us-ascii?Q?zT0EQuE6m89QFr33nffZjWrEAzXpa78KUOw1ZsuwWHSJtXGRF35YSXxPE6bU?= =?us-ascii?Q?UhRI3+pvghUEE102haWVHdkWOI+ODP2h68ehvUSJwZ+Q0SdEmKIEJAp/tt99?= =?us-ascii?Q?X4bjn0NzMp/LWHkWv/1gnN77psncFas2JJ8kGwGZx/WkEUltiTC8xxeGXQov?= =?us-ascii?Q?Zy+kg5qz07Q7NGeS8vrDOZIIMVY9tiZy/49cLgiscY4YM2W600QvDv2al+Pb?= =?us-ascii?Q?s9lZW6BHum4Esd3TMC4Km40fMfqh8WwbJaFthT+wGV5LZ8CQKNzyZT1Dk/T0?= =?us-ascii?Q?XOqh1EQOQPKqcyo0Qn6G8VaxFg+mDxTbJpQWoFjDrl21DqGVG9dtxcD5jRkM?= =?us-ascii?Q?uOgZSAGGrGYB1aQLTeVOGubMRAQWbefXp8JtPJGJailG6D+2R8p3BMN7LC89?= =?us-ascii?Q?ePcUNI1g+O9V+zN5XMQ2Dbz73Qw4XItR6uLBkFP68fjClouUAAh6i3VxcIqR?= =?us-ascii?Q?k9wwcBLHMVOPCbcDP8QGBECO18Lol4RN0lPN2ICztlXu60BOt1rOTtAldyv3?= =?us-ascii?Q?b4dkpVL27PBYWKj0HwEgNZh7z/mtNZ3+7xmgK0Bfi5AmHYJ3BkgR2of110Qt?= =?us-ascii?Q?lnqRfgBKdHIvs1dSimOvqM+R8uFe9sPcGVQIR9GfXhXkulbeZBvgz7fRyxg6?= =?us-ascii?Q?HcIJJO4mWg/I4pw=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:40:01.5033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efc1cf80-7e26-4f2f-4cd9-08dd230bdd0b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6688 Content-Type: text/plain; charset="utf-8" Aggregate nr_numa_running and nr_preferred_running when load balancing at NUMA domains only. While at it, also move the aggregation below the idle_cpu() check since an idle CPU cannot have any preferred tasks. Reviewed-by: Shrikanth Hegde Reviewed-by: Vincent Guittot Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Vincent and Srikanth. --- kernel/sched/fair.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8f641c9e74a8..c68ab808d271 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10346,7 +10346,7 @@ static inline void update_sg_lb_stats(struct lb_env= *env, bool *sg_overloaded, bool *sg_overutilized) { - int i, nr_running, local_group; + int i, nr_running, local_group, sd_flags =3D env->sd->flags; =20 memset(sgs, 0, sizeof(*sgs)); =20 @@ -10370,10 +10370,6 @@ static inline void update_sg_lb_stats(struct lb_en= v *env, if (cpu_overutilized(i)) *sg_overutilized =3D 1; =20 -#ifdef CONFIG_NUMA_BALANCING - sgs->nr_numa_running +=3D rq->nr_numa_running; - sgs->nr_preferred_running +=3D rq->nr_preferred_running; -#endif /* * No need to call idle_cpu() if nr_running is not 0 */ @@ -10383,10 +10379,17 @@ static inline void update_sg_lb_stats(struct lb_e= nv *env, continue; } =20 +#ifdef CONFIG_NUMA_BALANCING + /* Only fbq_classify_group() uses this to classify NUMA groups */ + if (sd_flags & SD_NUMA) { + sgs->nr_numa_running +=3D rq->nr_numa_running; + sgs->nr_preferred_running +=3D rq->nr_preferred_running; + } +#endif if (local_group) continue; =20 - if (env->sd->flags & SD_ASYM_CPUCAPACITY) { + if (sd_flags & SD_ASYM_CPUCAPACITY) { /* Check for a misfit task on the cpu */ if (sgs->group_misfit_task_load < rq->misfit_task_load) { sgs->group_misfit_task_load =3D rq->misfit_task_load; --=20 2.43.0 From nobody Sun Dec 14 13:53:33 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364B463C for ; Mon, 23 Dec 2024 04:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928874; cv=fail; b=BbuNAIuXBPBs+05e3V9/AjrrH6mcXBanVBRqlbRHe0tPo2b5fB8pVCY/0jB59szJtEzt8W9UUyxH4rQysQ3Oi7Wqg4OoUmPtzqVAnEKf2QXGCBRSdgDwZX2z/9RbAA6b/VgFTSrYQM9Gu0hAhtlLr5Vn2jYggCzbDFbCmwmxSi4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928874; c=relaxed/simple; bh=wzxq8q2mOo6eLa+RjaZ+fD9X/gkV3vzi2Ee807RJJsM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XXIh96tlU7IA4afORrzsa8QDOJ5ze7f8MD/H+Kylk6hGhuFfmYVfHPlBpVK1X3dqjQl26CHUyBSu5FlOC8dDl4bqHVaW3VRh6EHO8WMUN+L8F1nrlf7HA0RxhbjI+kl0Am0u2Vq741zGDtK0AqIxnDXAer0WKlSm2/cdfd8gYb8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=33rT4LOD; arc=fail smtp.client-ip=40.107.92.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="33rT4LOD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=viMwzQaH6hUDt5wa7qcCGyYClO7KBB1H0O++NLE3LznRRV4gzIpL1EImwxwg6DPza0IQjhlmPNDVQ/4kSQUTZ8qPGwFpCypleG+A4i1G1jJzhOvEM83JbT1sWcYSAFe5ouXE07dmN3+CPC+/JwIofxHwZ3BAM4FB3pPX2RBaYJq5W+RzamX3OhV9oY2v8Y6xjn7inDcA7A5RR3NsnYTwn92Nkfa1XDe651oqAFkXygtIfvbsheP/kpxVVOJxs83cdhXvintaS5sEDZfpZzD7huqVmIPCMe6MNdQW0SPNIAGAm3oKJqeK10gnMREmBoAtT73ZFbvYazYZirqGC9phYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c2SBYwFh+n/7pPDqHMq3kZbaRWkQ8fdZSDVD5uK6JTw=; b=Ka+TCuFVNVEZ0yXJDcBfWRuzfXG+naShckY+f59Ibayx858yQzz7Wzy3W9sPYCvMmAF6Sf+GujwsB5TkkzVrcLN1F5oX0vWFchqW/GUboXiEpAbFRv9o8paOhBefB2uY7YhkrWSFvORq826ph7PENypIHi2VH2ePdwqjC1dF7Rz6+IBTZH9EER2v4AeXycs2uzERQsoz58Voz/FV8R+P6+zDUAo7zmkYd8Ksx0EZax+Ynt8pW4C6oLaGcsbFQt7eNZ6hW5SbDv9oY39kk73k1R9qzk2WnnJnLCeVALAFdh851TfzJet8atEhG2HWj4iwJC1Xmy+4xRiO5uJIoHMQrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2SBYwFh+n/7pPDqHMq3kZbaRWkQ8fdZSDVD5uK6JTw=; b=33rT4LODFQhJmStIndhQJiZEH0LJaBRZ4oCQZKeG3O7T26+BQLU6KPyZujGMUwSutFHf4HVfz9s4Nn4MWzXbJ5vgS02yiiqy6Wj4arWahGGBPQV03oNDKR+sg5FyNUPsZ3TzRFye3dyeRSjA3CiTzFlCyYyBGvqYTS9C0qL1CdU= Received: from BY5PR03CA0013.namprd03.prod.outlook.com (2603:10b6:a03:1e0::23) by DS0PR12MB6415.namprd12.prod.outlook.com (2603:10b6:8:cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Mon, 23 Dec 2024 04:41:03 +0000 Received: from CO1PEPF000066EA.namprd05.prod.outlook.com (2603:10b6:a03:1e0:cafe::d9) by BY5PR03CA0013.outlook.office365.com (2603:10b6:a03:1e0::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.16 via Frontend Transport; Mon, 23 Dec 2024 04:41:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000066EA.mail.protection.outlook.com (10.167.249.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:41:02 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:40:14 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH v2 7/8] sched/fair: Do not compute overloaded status unnecessarily during lb Date: Mon, 23 Dec 2024 04:34:06 +0000 Message-ID: <20241223043407.1611-8-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EA:EE_|DS0PR12MB6415:EE_ X-MS-Office365-Filtering-Correlation-Id: e9e42916-3772-41dd-55e7-08dd230c0194 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?77EIZh9yKPtKDt2M0o09pYhZFI5hNaN2SF/NCs3ckWIYBteKkPfhELRt93+O?= =?us-ascii?Q?XqoD9keHaqC1yrymc2QijLKo2BUbHdD5KWyk5Cy5DLPByciZkEIme0NVVzCd?= =?us-ascii?Q?PPuiYXlZ0ZB0iVynPpfTOyStVqtKONuTTOhYBF1DdlYsolBhevkU+2Ca7ZyF?= =?us-ascii?Q?5tQFMjITw7VI5NfUu2v2XMGVYWEqyEGda+KDblHYNsrJjn4LbipvQ5JHqTHM?= =?us-ascii?Q?SWwRrh/6WvS1mNggzV/YAAf/XRI3mpSk23iGBkBcNWGvbsFfQdNIaaoEpmJ6?= =?us-ascii?Q?okysZMnLhW2p0dWdDQ6oIMHvG07fyUU1PtHMUSxnZgNQGro8QQFOT0E7dFrU?= =?us-ascii?Q?PcRahaTkQnIjvbQ7GMt5UbdjnYKWw8mzxxAwXob/MEEQsQndMXDY3KcOLGpe?= =?us-ascii?Q?slw65dkVbD1ZqWsQSmluIHFbpdZftbKWxCpqw/EsB4eMA+3ZJ/m1+pCbd5X+?= =?us-ascii?Q?j9+fwyvZ9AqyUz19fSNuQWCsPmm0b9zNeuPPqUypPLzn06w8VWkP1zoTAdMf?= =?us-ascii?Q?PlfAUi+khjoy3Wv6jcJDVu0ztqfW0OQgI/VrpFlmsHFrhcYf8/rYna60620L?= =?us-ascii?Q?IDvrHX7AKHalzYcsnb7ucIe7+7+Z3HhIQGUFOSo9/V56KR2pwxNj6hQK7W2m?= =?us-ascii?Q?+2wXdGRimWoC8E8PthnwYoCWbUL08iplZBxXO+ZSvRGr18GR8r15lv2ws2Fr?= =?us-ascii?Q?qqefzRdBsyWJuGbcXn6a5pkYbOeEIq15txFMvZMcKligWOi/FPHw6BfKwv2Q?= =?us-ascii?Q?luuOjyn0t+gJRbW4YKK+OE5w5F54A+POKmlXd3UkgQ5XCyV2M6Dj+FgBMrmF?= =?us-ascii?Q?2Gqd224H/M6JDfFmbaVv9m4gMsAk+2GlOaumd7+GIYkIYS0uSbAZspt5Vht/?= =?us-ascii?Q?XJN7+7V8lBgs6GEWSDTv6fB7GwNs9iBEbuDoPRHGbuTsvj/sXC2bTOHea+NS?= =?us-ascii?Q?6xyDSrApsrnouSBAyZ8QyRVgbLfYazLADnyM9NchVCdZ2fVuF3P1McTqo/Y8?= =?us-ascii?Q?R+vQyqD3nFq/N2+NZM4bAsyIYMo8UeNmvEpdoSQZSFCudHbJQLF61/F6oKNg?= =?us-ascii?Q?+SmLakuzyWjVC0v6UPmGtYzaXsXLZ8r+0K2HHHXHAnccjJcGe4V8YRmvQ9Dd?= =?us-ascii?Q?11fAYDRqtj6GT2tIfi05+Y7ukKLrmlgl4gPgSBolwWMuhiSTT+CeCqmndpV9?= =?us-ascii?Q?58eDwzS+r7rc0Ev77NsBBKiIVGB1ZUMkGxaXmukItZ2qKd1hSrJmpjeDlhKH?= =?us-ascii?Q?ynxbZ0I4RO+dNRM27DVUYmUo2rwvtoyb3hxLpEWzBR7F7IkWdMGKjVGnE/ja?= =?us-ascii?Q?XoFUXCrtLOYRu6yvriFm9gMioRfOcuBb1ajZguGji9vOed09/9rkiyM5aPk8?= =?us-ascii?Q?eWtHnEgRRob4USRhu3jIFug1A8S3uXY4GMsfMT06c5DmA12326iIuIweKhx9?= =?us-ascii?Q?/Rabo/Xm1gjq1XVwdMxbuw3c8EPiDxNTAevc2d4Meeto2sgsGq6J5PER1Ft+?= =?us-ascii?Q?dFVlcujaO31EY8w=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:41:02.8463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9e42916-3772-41dd-55e7-08dd230c0194 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6415 Content-Type: text/plain; charset="utf-8" Only set sg_overloaded when computing sg_lb_stats() at the highest sched domain since rd->overloaded status is updated only when load balancing at the highest domain. While at it, move setting of sg_overloaded below idle_cpu() check since an idle CPU can never be overloaded. Reviewed-by: Vincent Guittot Reviewed-by: Shrikanth Hegde Signed-off-by: K Prateek Nayak --- v1..v2: o Collected tags from Vincent and Srikanth. o One comment from Srikanth not addressed. Awaiting response for the question in the cover letter. --- kernel/sched/fair.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c68ab808d271..f27d7d36a78d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10347,6 +10347,7 @@ static inline void update_sg_lb_stats(struct lb_env= *env, bool *sg_overutilized) { int i, nr_running, local_group, sd_flags =3D env->sd->flags; + bool balancing_at_rd =3D !env->sd->parent; =20 memset(sgs, 0, sizeof(*sgs)); =20 @@ -10364,9 +10365,6 @@ static inline void update_sg_lb_stats(struct lb_env= *env, nr_running =3D rq->nr_running; sgs->sum_nr_running +=3D nr_running; =20 - if (nr_running > 1) - *sg_overloaded =3D 1; - if (cpu_overutilized(i)) *sg_overutilized =3D 1; =20 @@ -10379,6 +10377,10 @@ static inline void update_sg_lb_stats(struct lb_en= v *env, continue; } =20 + /* Overload indicator is only updated at root domain */ + if (balancing_at_rd && nr_running > 1) + *sg_overloaded =3D 1; + #ifdef CONFIG_NUMA_BALANCING /* Only fbq_classify_group() uses this to classify NUMA groups */ if (sd_flags & SD_NUMA) { --=20 2.43.0 From nobody Sun Dec 14 13:53:33 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2076.outbound.protection.outlook.com [40.107.93.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 766EE184E for ; Mon, 23 Dec 2024 04:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928894; cv=fail; b=uv12sTOHV69YXVZ9AVIgxRJpEr4nI9lcu3F8Fyzo6fimVKHyM/AIxjtx7fImwov6q3CTKgrM4RFoqvt3sykA+34PrEgvWrXND5lkL0QqTmMnMknnaysPQZgeyoUbkdJm4D+qcxFrJeZd5fn80kN3fiNkKwdcQd2cRDKCcRudq2I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734928894; c=relaxed/simple; bh=gN1U6DBHgwDGVHX/EdBl3dw0lPUjb2E4YS+51Pcg1Jo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MnaCuRI1LJUsJVVJKy7DE4B/afe+ZaSbSadC+ifIIkEEYDrhCIUsubj72KyK55UxCrLic5evD5UZEHqM4xS3nJ7uEPcO9JZDdAc+WgU7wrolVipHtZO7rR4ULGC11e3d12AC0KLoN0nzFTeXv+8OwbY58LevhDi1/pkKd4Y4I/M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=VrVW957W; arc=fail smtp.client-ip=40.107.93.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="VrVW957W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ayjMhuJ7waltUiXEL1qqjhfdOKciIvA8w3fLQ5D1MDB3rY400D2GnQZsV9+p6S/8snzV6U/FmxxrdW9LXYoxpyOq96NJgTp05PKEECrAbgKJbTc7fcTkwIzv5yuUekLCZjztVDeSya5Y1t5dKROKctRHKUriWPTDAgWseXpSzztIINesizcEHkmZ7XP79t83Os5DoRcMmqxNqVQYcJE7eZSkArFakND5DVj1KikoMGIhlF7oEl7nIWVxdaEgx0MmHZSJQa8D6D5LWHlgT9HdixBXsJE7HFwwseExfw7yEp4vcn5HSQUUDr6ePYSA6HeqXfv+KK7fY8gdFJFtghd8Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BixxblLDKqQJxFWIqT8tTUhjt0vilXurJ1jZwrjGes0=; b=Wjjddlb+wYde48gBIG+bz8XYQ7SQJa/SeIfP1HN6QgOa66T4b8BaMcQLBFeHlhB04bgcG75kiE7SXRe/+qUDY1buTKdABoYp5sasCE8fKFHQwtLUfIDhfBOQqMVBMahg9pzuQIbMkUncAwp5fmfAkjXXZi3sQfkBcTpw5a+X0BjFA/uGziy8/JlLqqjlbmIJpUD2AYyTgBMwUW2JEUtkR0JavzmeQ1fW2oblvIXkAh+6R+RF8fGP1BbzRYnl8juTrfQ/u/qV6YuHdPVCREbufaPRc0Tai2u0u2AHOZksU+3vsNtnjnPec5LJzx9Y2L3+K0ZKEK1bK2F4mXwIHr23Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BixxblLDKqQJxFWIqT8tTUhjt0vilXurJ1jZwrjGes0=; b=VrVW957WQuiBwg/B4NfO4AbcNQHwpMly/7JKktyouie+PeA5k0J2NrkMPyb9WoAv9sWfjcSAsS2mPp7YOX+5fd/v6doPwJWCvLJssGh6EX0qIM4OGmW45a3DoM3eIC2w3wKAUWy/womsTJY4ejr/oQYtNayn8WuFfJBk63R/nYQ= Received: from SJ0PR13CA0128.namprd13.prod.outlook.com (2603:10b6:a03:2c6::13) by CH3PR12MB7595.namprd12.prod.outlook.com (2603:10b6:610:14c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Mon, 23 Dec 2024 04:41:24 +0000 Received: from MWH0EPF000989EC.namprd02.prod.outlook.com (2603:10b6:a03:2c6:cafe::4d) by SJ0PR13CA0128.outlook.office365.com (2603:10b6:a03:2c6::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.12 via Frontend Transport; Mon, 23 Dec 2024 04:41:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989EC.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.12 via Frontend Transport; Mon, 23 Dec 2024 04:41:23 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 22 Dec 2024 22:41:13 -0600 From: K Prateek Nayak To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Juri Lelli , Vincent Guittot , , CC: "H. Peter Anvin" , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "Rafael J. Wysocki" , Ricardo Neri , Tim Chen , Shrikanth Hegde , "Mario Limonciello" , Meng Li , Huang Rui , "Gautham R. Shenoy" , "K Prateek Nayak" Subject: [PATCH RFC v2 8/8] sched/fair: Uncache asym_prefer_cpu and find it during update_sd_lb_stats() Date: Mon, 23 Dec 2024 04:34:07 +0000 Message-ID: <20241223043407.1611-9-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223043407.1611-1-kprateek.nayak@amd.com> References: <20241223043407.1611-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EC:EE_|CH3PR12MB7595:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c69ff96-1112-40cf-9609-08dd230c0db9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ydoGaZs4e1sgrftLrinaD6SGqDy5mnrF5Gsp8lyJVMlLpW5ozzUXLbhBuuqS?= =?us-ascii?Q?oc4aZBnmZyioKbW3dlb7naBXKWjvVA+YQNDwXx6an65fsa4mQF0mq54Kgx7Y?= =?us-ascii?Q?hDhXUWEDUx0bEz4B2NPkHb50+j8cHtoDfIBIn51I/S5Is2TK7N2Us+Pt0kT3?= =?us-ascii?Q?QWrhcU9WCYHTyCIxcSty7EoQYQ4zQVJSJtqq5PFTRn7MqHbD2hzyZ+tCSZLD?= =?us-ascii?Q?XYp9ZIf/Tq1d/tekpFJjniLCrbJ8vHpk9A+T3fKJErVTrg+dvYehx/H6DGLL?= =?us-ascii?Q?erjQlV8rXkZHR8J8bbPrdDaHGFYLqCxW+yn6GKQejVOTLabDZLvEXGXsvAFr?= =?us-ascii?Q?1iImNmine3XpVAK8WyalqAdKi2jcFnHNR97VAcA/FfVV826sGSh8qKVSfHu1?= =?us-ascii?Q?4hsiDi5eq5/BRDbnfxyBmHpUeWPebZMHeff3G557pcO0vQTm9SJLN7tU/ZIG?= =?us-ascii?Q?1GoSyGIQEGe8TrKK+CrAt/IRpi1mk/LxB9JbXng3WaJZLrGm7SDkjhtel1fM?= =?us-ascii?Q?p2S6LIIaFRhETkI5Gp2MXkKtxpARcjRRwsaW4G2sjFDpqZ8L1iXtnq1yPCZb?= =?us-ascii?Q?/nuHjMd9OOm6sfIVtssdOnl1/+clYozzgJMwrPB8HvR2R+kr8yNNiTx7vsF5?= =?us-ascii?Q?HOB1Tc1aVE/+06JANoz75J7cskI4Jw+Uz/pIO4J1v1rTVASvk07ahHh/C+fB?= =?us-ascii?Q?hPwPtERu1UTl4odPKQ9VAO07t5OC/FTrEpwM013wF7tYWhD3om95yagKSaYC?= =?us-ascii?Q?pO0OT6rnfGLBLMR//xIaUePmRx9IWaJLW67Vi8m0kuPAXRiTAO3WtakKaivl?= =?us-ascii?Q?8/F46K6G8yNa1unph9xV4EtoSV1nh+vo5mAre6g9Qyfvh0azgQZoP/YU/AAc?= =?us-ascii?Q?cL/apF97LtnuCp/vuDQJVnCSjPRg4huHnO28Zk9J29bO6SuIehuHRIz2ibWb?= =?us-ascii?Q?by9zQm0e1eF5SpLtv64Bkn/gMoPMTNB8F+ffdsKmOwM6bXve0sv+tVNaL8Dy?= =?us-ascii?Q?vhPtSSNyTNTYUeHRDJ8onN+OqC7pMBKzExmSNc/aZd5rl9LUyemGi1I775Q7?= =?us-ascii?Q?LEGEo0bAxE2sO2Ngt8U71vSPFfmJuhDgdo+15HmqZdVajVIurx24Q2wDTxo1?= =?us-ascii?Q?RSRlQx7BEdw0KZz15jj3B9qZihyeFlFk006DcDCwmenIuj/3GV6d5OG6QCTQ?= =?us-ascii?Q?3h7+64UXKt0ulFh2NjN8uWb/V4Fq2tztGmxmFjeAqoVUHaVSYFBDvCodyGpa?= =?us-ascii?Q?XeCcrPh23uppsVxYuIa9rrKOAV31bIC/vrKeeTYcvMu0ZtVagx/jLEmsm5QZ?= =?us-ascii?Q?LNs/JmSThltw8cSAsbW1bu1RtN/84YHAzK6+/5V6RPce3n3THaa+uJ6zI4Ho?= =?us-ascii?Q?N0hH3wblI/hXNNVogIyFoxc5iIVsjhKqKNDAlKXuadB4iheyDuxKI5LUVUlp?= =?us-ascii?Q?EP/e+4WQEEt0cpgZTZd8Vh+/ylSj75cSn8GFNXgmEwGuUvExygj6BglMek2/?= =?us-ascii?Q?YB6XCiSrJYJPmcY=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2024 04:41:23.1762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c69ff96-1112-40cf-9609-08dd230c0db9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EC.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7595 Content-Type: text/plain; charset="utf-8" On AMD processors supporting dynamic preferred core ranking, the asym_prefer_cpu cached in sched_group can change dynamically. Since asym_prefer_cpu is cached when the sched domain hierarchy is built, updating the cached value across the system would require rebuilding the sched domain which is prohibitively expensive. All the asym_prefer_cpu comparisons in the load balancing path are only carried out post the sched group stats have been updated after iterating all the CPUs in the group. Uncache the asym_prefer_cpu and compute it while sched group statistics are being updated as a part of sg_lb_stats. Fixes: f3a052391822 ("cpufreq: amd-pstate: Enable amd-pstate preferred core= support") Signed-off-by: K Prateek Nayak --- v1..v2: o Modified the layout of "struct sg_lb_stats" to keep all the SD_ASYM_PACKING fields together (Srikanth) --- kernel/sched/fair.c | 21 +++++++++++++++++++-- kernel/sched/sched.h | 1 - kernel/sched/topology.c | 15 +-------------- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f27d7d36a78d..f088dd4a527c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9920,6 +9920,8 @@ struct sg_lb_stats { unsigned int group_weight; enum group_type group_type; unsigned int group_asym_packing; /* Tasks should be moved to preferred CP= U */ + unsigned int asym_prefer_cpu; /* Group CPU with highest asym priority */ + int highest_asym_prio; /* Asym priority of asym_prefer_cpu */ unsigned int group_smt_balance; /* Task on busy SMT be moved */ unsigned long group_misfit_task_load; /* A CPU has a task too big for its= capacity */ #ifdef CONFIG_NUMA_BALANCING @@ -10249,7 +10251,7 @@ sched_group_asym(struct lb_env *env, struct sg_lb_s= tats *sgs, struct sched_group (sgs->group_weight - sgs->idle_cpus !=3D 1)) return false; =20 - return sched_asym(env->sd, env->dst_cpu, group->asym_prefer_cpu); + return sched_asym(env->sd, env->dst_cpu, sgs->asym_prefer_cpu); } =20 /* One group has more than one SMT CPU while the other group does not */ @@ -10330,6 +10332,17 @@ sched_reduced_capacity(struct rq *rq, struct sched= _domain *sd) return check_cpu_capacity(rq, sd); } =20 +static inline void +update_sg_pick_asym_prefer(struct sg_lb_stats *sgs, int cpu) +{ + int asym_prio =3D arch_asym_cpu_priority(cpu); + + if (asym_prio > sgs->highest_asym_prio) { + sgs->asym_prefer_cpu =3D cpu; + sgs->highest_asym_prio =3D asym_prio; + } +} + /** * update_sg_lb_stats - Update sched_group's statistics for load balancing. * @env: The load balancing environment. @@ -10352,6 +10365,7 @@ static inline void update_sg_lb_stats(struct lb_env= *env, memset(sgs, 0, sizeof(*sgs)); =20 local_group =3D group =3D=3D sds->local; + sgs->highest_asym_prio =3D INT_MIN; =20 for_each_cpu_and(i, sched_group_span(group), env->cpus) { struct rq *rq =3D cpu_rq(i); @@ -10365,6 +10379,9 @@ static inline void update_sg_lb_stats(struct lb_env= *env, nr_running =3D rq->nr_running; sgs->sum_nr_running +=3D nr_running; =20 + if (sd_flags & SD_ASYM_PACKING) + update_sg_pick_asym_prefer(sgs, i); + if (cpu_overutilized(i)) *sg_overutilized =3D 1; =20 @@ -10486,7 +10503,7 @@ static bool update_sd_pick_busiest(struct lb_env *e= nv, =20 case group_asym_packing: /* Prefer to move from lowest priority CPU's work */ - return sched_asym_prefer(sds->busiest->asym_prefer_cpu, sg->asym_prefer_= cpu); + return sched_asym_prefer(busiest->asym_prefer_cpu, sgs->asym_prefer_cpu); =20 case group_misfit_task: /* diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index aef716c41edb..a3f0d326bd11 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2047,7 +2047,6 @@ struct sched_group { unsigned int group_weight; unsigned int cores; struct sched_group_capacity *sgc; - int asym_prefer_cpu; /* CPU of highest priority in group */ int flags; =20 /* diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 9c405f0e7b26..20aa087710f0 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1302,7 +1302,7 @@ static void init_sched_groups_capacity(int cpu, struc= t sched_domain *sd) WARN_ON(!sg); =20 do { - int cpu, cores =3D 0, max_cpu =3D -1; + int cpu, cores =3D 0; =20 sg->group_weight =3D cpumask_weight(sched_group_span(sg)); =20 @@ -1314,19 +1314,6 @@ static void init_sched_groups_capacity(int cpu, stru= ct sched_domain *sd) #endif } sg->cores =3D cores; - - if (!(sd->flags & SD_ASYM_PACKING)) - goto next; - - for_each_cpu(cpu, sched_group_span(sg)) { - if (max_cpu < 0) - max_cpu =3D cpu; - else if (sched_asym_prefer(cpu, max_cpu)) - max_cpu =3D cpu; - } - sg->asym_prefer_cpu =3D max_cpu; - -next: sg =3D sg->next; } while (sg !=3D sd->groups); =20 --=20 2.43.0