From nobody Mon Feb 9 20:59:42 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C20B17BB16 for ; Sat, 21 Dec 2024 16:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734800390; cv=none; b=JigVw7shupfK6w4V1dnybMw295fAsYa8oHQQv7oJssJeBtPiwan0Km7TpuH9SByKjNzNBal0drRTvoRfILiTCBzp9e/C8y8xFW6BR4lLIiLBsC/Q0pwoSZtaTwkQB3NkXylK0lWX+rALpMxRN/zFCi4VVv8lDrmMIlL7suSSsCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734800390; c=relaxed/simple; bh=VIxjk73ewn/+4jk0d3Xt9Enh1ZCT2cQWGU3ArUx5zAU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JAH0i2+rF6Duv0AUZkbVPFpsABtYpB7v4I8rD+wTpwdg4cJWJ0OSoyiVMRgXcSTnUKct8ZZMImUXApPFVUg2RAcnqdkUNLtGj+os53IcgMld56bjVTcPc7rK0E6vwyiUE2SQ02xdV2KF5WQsJ6WUB7+g0SRZdMsEjLRjvnWOleY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33A981A25; Sat, 21 Dec 2024 09:00:10 -0800 (PST) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D15FB3F528; Sat, 21 Dec 2024 08:59:40 -0800 (PST) From: Yeoreum Yun To: suzuki.poulose@arm.com, mike.leach@linaro.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yeoreum Yun Subject: [PATCH 3/4] coresight/etm3x: disallow altering config via sysfs while enabled Date: Sat, 21 Dec 2024 16:59:33 +0000 Message-Id: <20241221165934.1161856-4-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241221165934.1161856-1-yeoreum.yun@arm.com> References: <20241221165934.1161856-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When etm3x configuration is modified via sysfs while etm3x is being enabled via perf, enabled etm3x could run with different configuration from perf_event. To address this, disallow altering config via sysfs while csdev is enabled. Signed-off-by: Yeoreum Yun --- .../coresight/coresight-etm3x-sysfs.c | 120 ++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/= hwtracing/coresight/coresight-etm3x-sysfs.c index 68c644be9813..b3ae9aba7490 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c @@ -75,6 +75,9 @@ static ssize_t reset_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + if (val) { spin_lock(&drvdata->spinlock); memset(config, 0, sizeof(struct etm_config)); @@ -117,6 +120,9 @@ static ssize_t mode_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->mode =3D val & ETM_MODE_ALL; =20 @@ -202,7 +208,12 @@ static ssize_t trigger_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->trigger_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); =20 return size; } @@ -232,7 +243,12 @@ static ssize_t enable_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->enable_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); =20 return size; } @@ -262,7 +278,12 @@ static ssize_t fifofull_level_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->fifofull_level =3D val; + spin_unlock(&drvdata->spinlock); =20 return size; } @@ -295,6 +316,9 @@ static ssize_t addr_idx_store(struct device *dev, if (val >=3D drvdata->nr_addr_cmp) return -EINVAL; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + /* * Use spinlock to ensure index doesn't change while it gets * dereferenced multiple times within a spinlock block elsewhere. @@ -343,6 +367,9 @@ static ssize_t addr_single_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); idx =3D config->addr_idx; if (!(config->addr_type[idx] =3D=3D ETM_ADDR_TYPE_NONE || @@ -403,6 +430,9 @@ static ssize_t addr_range_store(struct device *dev, if (val1 > val2) return -EINVAL; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); idx =3D config->addr_idx; if (idx % 2 !=3D 0) { @@ -464,6 +494,9 @@ static ssize_t addr_start_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); idx =3D config->addr_idx; if (!(config->addr_type[idx] =3D=3D ETM_ADDR_TYPE_NONE || @@ -518,6 +551,9 @@ static ssize_t addr_stop_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); idx =3D config->addr_idx; if (!(config->addr_type[idx] =3D=3D ETM_ADDR_TYPE_NONE || @@ -563,6 +599,9 @@ static ssize_t addr_acctype_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->addr_acctype[config->addr_idx] =3D val; spin_unlock(&drvdata->spinlock); @@ -597,6 +636,10 @@ static ssize_t cntr_idx_store(struct device *dev, =20 if (val >=3D drvdata->nr_cntr) return -EINVAL; + + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + /* * Use spinlock to ensure index doesn't change while it gets * dereferenced multiple times within a spinlock block elsewhere. @@ -636,6 +679,9 @@ static ssize_t cntr_rld_val_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->cntr_rld_val[config->cntr_idx] =3D val; spin_unlock(&drvdata->spinlock); @@ -671,6 +717,9 @@ static ssize_t cntr_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->cntr_event[config->cntr_idx] =3D val & ETM_EVENT_MASK; spin_unlock(&drvdata->spinlock); @@ -706,6 +755,9 @@ static ssize_t cntr_rld_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->cntr_rld_event[config->cntr_idx] =3D val & ETM_EVENT_MASK; spin_unlock(&drvdata->spinlock); @@ -752,6 +804,9 @@ static ssize_t cntr_val_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->cntr_val[config->cntr_idx] =3D val; spin_unlock(&drvdata->spinlock); @@ -784,7 +839,13 @@ static ssize_t seq_12_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_12_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_12_event); @@ -813,7 +874,13 @@ static ssize_t seq_21_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_21_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_21_event); @@ -842,7 +909,13 @@ static ssize_t seq_23_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_23_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_23_event); @@ -871,7 +944,13 @@ static ssize_t seq_31_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_31_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_31_event); @@ -900,7 +979,13 @@ static ssize_t seq_32_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_32_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_32_event); @@ -929,7 +1014,13 @@ static ssize_t seq_13_event_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_13_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(seq_13_event); @@ -975,7 +1066,12 @@ static ssize_t seq_curr_state_store(struct device *de= v, if (val > ETM_SEQ_STATE_MAX_VAL) return -EINVAL; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->seq_curr_state =3D val; + spin_unlock(&drvdata->spinlock); =20 return size; } @@ -1008,6 +1104,9 @@ static ssize_t ctxid_idx_store(struct device *dev, if (val >=3D drvdata->nr_ctxid_cmp) return -EINVAL; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + /* * Use spinlock to ensure index doesn't change while it gets * dereferenced multiple times within a spinlock block elsewhere. @@ -1066,6 +1165,9 @@ static ssize_t ctxid_pid_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + spin_lock(&drvdata->spinlock); config->ctxid_pid[config->ctxid_idx] =3D pid; spin_unlock(&drvdata->spinlock); @@ -1112,7 +1214,13 @@ static ssize_t ctxid_mask_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->ctxid_mask =3D val; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(ctxid_mask); @@ -1141,7 +1249,13 @@ static ssize_t sync_freq_store(struct device *dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->sync_freq =3D val & ETM_SYNC_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(sync_freq); @@ -1170,7 +1284,13 @@ static ssize_t timestamp_event_store(struct device *= dev, if (ret) return ret; =20 + if (coresight_get_mode(drvdata->csdev)) + return -EBUSY; + + spin_lock(&drvdata->spinlock); config->timestamp_event =3D val & ETM_EVENT_MASK; + spin_unlock(&drvdata->spinlock); + return size; } static DEVICE_ATTR_RW(timestamp_event); --=20 LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}