From nobody Sat Feb 7 21:08:11 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA353594C for ; Sat, 21 Dec 2024 14:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734791674; cv=none; b=IqxWO65PbJKzWt08FjYqMYzKDknhawHLovvPhYDtjoc4memAuOoyQ2CGcKSpmwnJIXShSUmjOkbWbwB+7BWFILaOGDY+tS6DlS5OIHm5zzkz+gMwgNUw22gIULMdT12KpcLBXs4VClpUc/7/kO8a2pWtDaWCSu3w4aRnAu7fjLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734791674; c=relaxed/simple; bh=H/utCNcl77WbD0bGakzt9oI7+907m36qYZz4tB+/uE4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HkPykr4Qj2Gw1VQakHVvP+yMa1n2lvGcqZfJgO5Nr33aJNF23t2gjQWSiYldjd9rb5EkEQZYv/aMsl2YAp4sZbA0/AufkNgqevT3qCyKG/XSn9kBM8a+sP/oTtKBYXI5xL8zdl1QrL2EJpm5BUKDT/DGBret4JHIk6mNhvjKoRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=BjA4+mEd; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="BjA4+mEd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=KsAUtwESBoAEGukCvUJ4WAnh5Hf9oMdH9Xar5HAAyu4=; b=BjA4+mEd5w764+xW FbqPHkYZH8rSvA6BIwzzN1amiwnvn2Qsw2Wf5XKXrgL6zPloQfxunGjkftCr7JMXdYOcKi9Dob2YI iSThJfjGJKWOTtgJtuDP8SHqmGLp6LN5CjfaFYLVRiy7fAdoNaJ6cFkIgeOo4oPALusxMJ+jMWhr6 TjZ2MRKgWDS6+a+MHCPMeFQ+pGO3VbCySFzaXlaDZf+GuIm0QgivCw5jx22eRu20v0uUOeGfAiIDo edkW9kuLd4rXr4VjmGU8cofR/gXjLh0P3ps9rMrlHCs7qz/8b20xyjYTGBLxMRwwpYbp+EOY44BOr I9nq0ZFjl+xjysQpEQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tP0Yd-006gOA-0z; Sat, 21 Dec 2024 14:34:19 +0000 From: linux@treblig.org To: alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH] i3c: Remove unused i3c_device_do_setdasa Date: Sat, 21 Dec 2024 14:34:18 +0000 Message-ID: <20241221143418.86012-1-linux@treblig.org> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" i3c_device_do_setdasa() was added in 2022 as part of commit 672825cd2823 ("i3c: export SETDASA method") but has been unused. It calls i3c_dev_setdasa_locked() which is now also unused. Remove them both. (This is effectively a revert of 672825cd2823). Signed-off-by: Dr. David Alan Gilbert --- drivers/i3c/device.c | 20 -------------------- drivers/i3c/internals.h | 1 - drivers/i3c/master.c | 19 ------------------- include/linux/i3c/device.h | 2 -- 4 files changed, 42 deletions(-) diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c index e80e48756914..984976f28314 100644 --- a/drivers/i3c/device.c +++ b/drivers/i3c/device.c @@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, } EXPORT_SYMBOL_GPL(i3c_device_do_priv_xfers); =20 -/** - * i3c_device_do_setdasa() - do I3C dynamic address assignement with - * static address - * - * @dev: device with which the DAA should be done - * - * Return: 0 in case of success, a negative error core otherwise. - */ -int i3c_device_do_setdasa(struct i3c_device *dev) -{ - int ret; - - i3c_bus_normaluse_lock(dev->bus); - ret =3D i3c_dev_setdasa_locked(dev->desc); - i3c_bus_normaluse_unlock(dev->bus); - - return ret; -} -EXPORT_SYMBOL_GPL(i3c_device_do_setdasa); - /** * i3c_device_get_info() - get I3C device information * diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h index 433f6088b7ce..842e1a865877 100644 --- a/drivers/i3c/internals.h +++ b/drivers/i3c/internals.h @@ -13,7 +13,6 @@ void i3c_bus_normaluse_lock(struct i3c_bus *bus); void i3c_bus_normaluse_unlock(struct i3c_bus *bus); =20 -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev); int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, struct i3c_priv_xfer *xfers, int nxfers); diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 42310c9a00c2..000187339400 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_control= ler *master) } EXPORT_SYMBOL_GPL(i3c_master_unregister); =20 -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev) -{ - struct i3c_master_controller *master; - - if (!dev) - return -ENOENT; - - master =3D i3c_dev_get_master(dev); - if (!master) - return -EINVAL; - - if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || - !dev->boardinfo->static_addr) - return -EINVAL; - - return i3c_master_setdasa_locked(master, dev->info.static_addr, - dev->boardinfo->init_dyn_addr); -} - int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, struct i3c_priv_xfer *xfers, int nxfers) diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h index 0a8a44ac2f02..f4e924c179d7 100644 --- a/include/linux/i3c/device.h +++ b/include/linux/i3c/device.h @@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, struct i3c_priv_xfer *xfers, int nxfers); =20 -int i3c_device_do_setdasa(struct i3c_device *dev); - void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_i= nfo *info); =20 struct i3c_ibi_payload { --=20 2.47.1