From nobody Sat Feb 7 12:36:31 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AADC282EE for ; Sat, 21 Dec 2024 02:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734748154; cv=none; b=prehOgk4+8lIhiy0i5xCUq8ZP7EP9mEeE4Q5uQr6KjVckrvn/YJ1SMVd8Rbp+wIG07W5Yfx+FkjnyY+dWTzPKxmCqTWePxMQg5yJOOdd+ah5M3/B/kmMqoERdaQ3rEcguOnL62m4LwDsjdHhVc6Y6H7gRq9vlYjNq0SQm3UXmB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734748154; c=relaxed/simple; bh=jW2s7RJUHRghP1fOQgih6ZZaQll5CX3zRM/GLImoz+8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QHFdQBySZollHu1AtOaQ8otPNMbLC+pDRKh3OZOVUPWrjP+DUPfu4qd3NGsOyDlKL6slAzDDC3qgUSaatRZmXfPbjUK7q/5JM0yTCzHlHcwk0cTXzOZLLTg9+yND4GtIcDI0U9lfmjDed3ZfnmU0abscv/hKqjgw6vLo028nbIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZNRVbCgm; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZNRVbCgm" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7feffc649efso302209a12.0 for ; Fri, 20 Dec 2024 18:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734748151; x=1735352951; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ytwnypYKm5KIEZXfVxN9e7QinVFawxspxP9AVMExicM=; b=ZNRVbCgmG+RG5UFGD7e0QGYecyvj7kkwBCn98EUF+ZzRjleF2hoPuuu3p6bHvDMyQp D1KeijHrC8m5Y0INozIsFGZjAvzodpXTH42oNAQQXyFTC/FajymGDOLqH4Qz++0QsbRW ykB9MKEjeffi5kur3SYnKpM/oLqXRu5WOvVdHTCMMQjHMvF2OqG/44nHQ/PLw7g+UiNH E71mQhPOy6eyTiP3RJYiUDE1mWXikFmMvaHK5YFfRpoybiPiH4h5ig/v9YEdvYWmSrlN bLCUELtmOXeu2EiaYzQS8FN/qP9lTpL5sn3hp595/AKMp0dtKfBFl0IwobH1p9OqFyVR IDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734748151; x=1735352951; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ytwnypYKm5KIEZXfVxN9e7QinVFawxspxP9AVMExicM=; b=BSyRxdT65xuaelJZ7yrxPmGjhX5O0CZJ7FgTLgooHYwQ28vfRKtE/EY7WVnWjwz58H sce6yMI4m9izuuuBAy3Vq4SQjNRvTgYhGs+MfT4WgIjmV05qfaaOl3crqRN4MaXyOdVN USjs7BTCsKbvPwVYnyafIMrTwdXa+h7kYfhUz3HLNZbv+h3mj3qbGLBmQIy5tRVkfHZw 5rLgYLJVxNOvL0kCHOdWQvU8HZfxsziFAlM+L0edsCpt3kHgh4blBVahTNz8L73ERZoK jviLYkft39Z+mLsyK18qYEJT9SN3yhe3woj1TSYYEt7mOVorQa55U/xO7md/fZn1HreI bb8w== X-Forwarded-Encrypted: i=1; AJvYcCWhXe9t8foPSJ0JByls48yP+jjYqCE5LsRayjSrseirZkT+H3gdkL9lhm3YdM2SbIthMWspIGAP2hp8530=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/MrjT0SfWpXRU+uy1gW9vOb010wFGwn8BBevRqOjja8Ew68sw cFZRYO4RS/oDzC+/8vBPC3dhWPSFP9fk+sBYF6FTM97Ut88xyXea X-Gm-Gg: ASbGnctvH4yawZsmz2c7tY0QQ/dRpQCrC9XHdHHKV+WfhHRL2zAChG5+Fat3xCbxwGG OdcRIEFQgVzfRaK/GXjaN8u3Mbwma6sbQ3r1UCRcgX7ncB7/OiJCuFHpifXXmgJRT1V623bJX5F 36mIEDkeVChfYIZYBsIjrzku0Hj50oP0iV+Ufb68z7ZDGoNPTiydwIvE7OntWgkGWVY3Sq/S4CZ Beyn8wZ/lbKb24ZmWAaMHDOO+GQoeHcGRRkd5cJtOs/YwfZUuc+EW8= X-Google-Smtp-Source: AGHT+IHxClqSmhHbj4Zsql9nnKv0TR8qBSevFg6l22q7gs1dSV5+EnRJ1bRom8zMkxaLVW3QLTfZLw== X-Received: by 2002:a05:6a20:c70a:b0:1cf:4c3a:162a with SMTP id adf61e73a8af0-1e5e047fae3mr3334363637.5.1734748151356; Fri, 20 Dec 2024 18:29:11 -0800 (PST) Received: from ice.. ([171.76.86.134]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad830adasm3786302b3a.44.2024.12.20.18.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 18:29:10 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org, dan.carpenter@linaro.org, niharchaithanya@gmail.com, roheetchavan@gmail.com, arnd@arndb.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: skhan@linuxfoundation.org Subject: [PATCH] staging: gpib: cb7210: Add error handling Date: Sat, 21 Dec 2024 07:56:33 +0530 Message-Id: <20241221022632.20931-1-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The if condition in cb7210_init_module() would always fail as the value of err is constantly 0. Add error handling to cb_pcmcia_init_module() where it returns appropriate error code if pcmcia_register_driver() fails. This issue was reported by Coverity Scan. Report: CID 1635894: (#1 of 1): 'Constant' variable guards dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: return -1;. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/cb7210/cb7210.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index 63df7f3eb3f3..b2f6ad70ccaf 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -1353,7 +1353,11 @@ static struct pcmcia_driver cb_gpib_cs_driver =3D { =20 int cb_pcmcia_init_module(void) { - pcmcia_register_driver(&cb_gpib_cs_driver); + int ret; + + ret =3D pcmcia_register_driver(&cb_gpib_cs_driver); + if (ret < 0) + return ret; return 0; } =20 @@ -1528,9 +1532,10 @@ static int __init cb7210_init_module(void) gpib_register_driver(&cb_pcmcia_unaccel_interface, THIS_MODULE); err +=3D cb_pcmcia_init_module(); #endif - if (err) + if (err) { + pr_err("cb7210: registering PCMCIA driver with the bus core failed\n"); return -1; - + } return 0; } =20 --=20 2.34.1