From nobody Mon Feb 9 01:51:46 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F622E64A for ; Sat, 21 Dec 2024 14:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734790191; cv=none; b=gDunRWmLaoOuB3rBJqko/9J0tyDdkU82lzjnF7ac98B+QTEMvlHt/8J/HBhdD+AGvZWZTrjIR5uGcQBpxbj77sTCZ4uDgQG7JtKBONNVhvfmoKbou8wHv3Ko74ct1AKrrdIiKHCnRzpXJKUVI9LkbIGaiMhioi0viirVGzLhx8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734790191; c=relaxed/simple; bh=Ewn3VSE/Iq+ZwnbaNNYoBJ7d4OkSKeCHtTdP3Ou4cZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=TG0GGR36lSRHcO4ER0WhfN+XMKzs2fC0DvH7IAIDsBFGFYjP5AaHw/Id52SOl1fwbgLnpodDcPY5yqVHe7d9eChiCjgS7p7w6xXS8+MduZYumOafbg45g+7/xMxCUwodUgOxRAV9jPAy0Cflc2cQq/mkYKBdksE3630eNHdp+jc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=O3+d+oEf; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="O3+d+oEf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1734790178; bh=Ewn3VSE/Iq+ZwnbaNNYoBJ7d4OkSKeCHtTdP3Ou4cZ4=; h=From:Date:Subject:To:Cc:From; b=O3+d+oEfa/lIeHBn1xQr4Q/ISrn5j3mXFD/Hv/OO40FgI5vpiIvs1uic3Gs/QZdzh dxNXM7xdZL/n/LaLuku6lzXMHoLnq/4bkhxuOKDp3MqMPQFTtQo0ulktqTVY5f7vM5 OaUvAUqkSIspcFRIYd0CvFss3Vygw1aZK8FGBurM= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 21 Dec 2024 15:09:34 +0100 Subject: [PATCH v2] kheaders: Simplify attribute through __BIN_ATTR_SIMPLE_RO() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241221-sysfs-const-bin_attr-kheaders-v2-1-8205538aa012@weissschuh.net> X-B4-Tracking: v=1; b=H4sIAB3MZmcC/43NTQ6CMBCG4auQWTuGDiWCK+9hiOFnsBOTYjoVJ YS7WzmBy+dbvN8KykFY4ZytEHgWlckn0CGD3rX+zihDMlBO1pApURcdFfvJa8RO/K2NMeDDcTt wULQ2r6rTSEVVE6TGM/Aon71/bZKdaJzCst/N5rf+W54NGixM3XVDmTORvbxZVLV3L3f0HKHZt u0LpUZugM8AAAA= X-Change-ID: 20241215-sysfs-const-bin_attr-kheaders-440887f23892 To: "Joel Fernandes (Google)" , Greg Kroah-Hartman , Kees Cook , Masahiro Yamada Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734790178; l=2111; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=Ewn3VSE/Iq+ZwnbaNNYoBJ7d4OkSKeCHtTdP3Ou4cZ4=; b=RlaYN16WzQ7NnW4ZJ+10hsmuFCfddtTaKKH4QxaqK84SkiRfccUm6t7H/0wd1D1pg2iBRrk9t gZN3hXx8l4OCLpRN1qHaurpvNqBL6F/ew/zTZKYvEBnY5cImE9KDibs X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= The utility macro from the sysfs core is sufficient to implement this attribute. Make use of it. Signed-off-by: Thomas Wei=C3=9Fschuh --- Changes in v2: - Use __BIN_ATTR_SIMPLE_RO() (Thanks Masahiro) - Link to v1: https://lore.kernel.org/r/20241215-sysfs-const-bin_attr-khead= ers-v1-1-319bbd50e224@weissschuh.net --- __BIN_ATTR() is used over the normal struct initializer because it is shorter and can also handle the transition to const struct bin_attr callbacks. If you prefer, I can switch that back, but it will introduce a trivial conflict with [0]. Note: There is no formal maintainer for that source file. [0] https://lore.kernel.org/lkml/20241205-sysfs-const-bin_attr-simple-v1-0-= 4a4e4ced71e3@weissschuh.net/ --- kernel/kheaders.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/kernel/kheaders.c b/kernel/kheaders.c index 42163c9e94e557c5043e2ac7987b567f23087ee2..378088b07f46d643736c04b9075= f631e0dc2a53d 100644 --- a/kernel/kheaders.c +++ b/kernel/kheaders.c @@ -29,25 +29,12 @@ asm ( extern char kernel_headers_data[]; extern char kernel_headers_data_end[]; =20 -static ssize_t -ikheaders_read(struct file *file, struct kobject *kobj, - struct bin_attribute *bin_attr, - char *buf, loff_t off, size_t len) -{ - memcpy(buf, &kernel_headers_data[off], len); - return len; -} - -static struct bin_attribute kheaders_attr __ro_after_init =3D { - .attr =3D { - .name =3D "kheaders.tar.xz", - .mode =3D 0444, - }, - .read =3D &ikheaders_read, -}; +static struct bin_attribute kheaders_attr __ro_after_init =3D + __BIN_ATTR_SIMPLE_RO(kheaders.tar.xz, 0444); =20 static int __init ikheaders_init(void) { + kheaders_attr.private =3D kernel_headers_data; kheaders_attr.size =3D (kernel_headers_data_end - kernel_headers_data); return sysfs_create_bin_file(kernel_kobj, &kheaders_attr); --- base-commit: 499551201b5f4fd3c0618a3e95e3d0d15ea18f31 change-id: 20241215-sysfs-const-bin_attr-kheaders-440887f23892 Best regards, --=20 Thomas Wei=C3=9Fschuh