From nobody Sun Feb 8 15:43:04 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 211F5210FB for ; Fri, 20 Dec 2024 16:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734712374; cv=none; b=OJJyRCYlklD+TthTgQ4hNV7LwMox25e7uzWNrHRX/vCgsgpa+W8cJIN4rURJZlLyyaZwY9I86H1AN50qeU9G5aojSYFpXjvJUjNinzkJsxfg30brRdtn+fg5y9nC3BztfZNB+L4tibjNw972z1QLBQsdcJaZZpHYnWpXJMGjssc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734712374; c=relaxed/simple; bh=GxpbI/hnI15l3LFPs23HErqWdHdxsCaTj+l/83Cmuxw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tnWEwREdmCKtAUJ8tupr3uIHOtsfl8oDi2FKKtnyiW68v7poo4eWHLrTZ6Z5zx4CKzJeOqQz3BaUZV/JJNN15EFTUsxDm2Sbv4xetgF+olMCiyqROuwsG9UPZu3F2/mqSST3QhMe1xlHSMDbB6qlT6uwh416jzhPA2aexuSEIFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=XB8kMrSe; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="XB8kMrSe" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-385deda28b3so1641696f8f.0 for ; Fri, 20 Dec 2024 08:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1734712370; x=1735317170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2l7F3pjuoDH3GKZ6bPXFtH3xTXOQ8g8lc//roM40EcA=; b=XB8kMrSeuEAEs77YZtFkF/IuQHsujX3SfhKL57gWWeLZkDP+9PChh7bMtxZo8dhvAI hXW8oSUxRkbxr6MD0wjmGrdkkgOV6Isf0E3SR7BC5+fly3S6NOcb3TumxpltFSi4xq62 O/Ww7lddclpIRAzRhgFOfoEoZwDn8yqwlcdPp6h4vfQLr4utMai4zOaJyGPEpp0br1Db tSb76z3PoeNWNrBgGYBwDi/nSe9hzWemimvjbjS6eovtaBkP5+ZMoBiIZ9YTRKG7QUrM 2bC/J5QTbrf1BujUeTRW5RbBah3V+sH3FmapYDOHEc1cnbVIBBA1FOfMXisIiVhh5/gz HhVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734712370; x=1735317170; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2l7F3pjuoDH3GKZ6bPXFtH3xTXOQ8g8lc//roM40EcA=; b=fX+mN88dOQVNaaYgWpxiTx/l6MEbnbXD2YcY8DZXcrE/gcXBGBkzPY91U+aIQvM4IL TtU2BdzjhQbaUmekpqe+Wjk74JKkY7AHwL7iWfcVbX5Z/Pdbpxx4imC4KGegcqwl+j9A u6FBtnEmVQQq8qvWyr8cJUmBbUhRI3624C0ZzSAOQWiXQY8sn3TMw7VennyvMVkDyAnw 77QzFY4JQP89Ip0s/QvDrQYrm/5K3HZp8tXt4vmGmaebe3MALLZGozmd3837xtZEf65w AC2UMFmwje1OXc1RxvWj/7F0O/sXpIyY24UIG1t7QYKbXcq+d+iSL9LOrz+QlAYbGW6R GVgw== X-Forwarded-Encrypted: i=1; AJvYcCUKxdihXTy2A2nsGTq4ZcbbFoTPz/DIPusR44xbtM3YoAejfKcs3nxLNSF7WzqwpyTrvOQ/FpkwP+NONfs=@vger.kernel.org X-Gm-Message-State: AOJu0YzRBuT73ssYeZOuAuH5oP3JCS24SdmX9X2FhU1Mrpe1h4cFHJee 14pyNvJtrmdfNWnOdqVSzInpiJLo9FnAH6YHy7XdiQnrss33zozqZ8Lbcknfa/0= X-Gm-Gg: ASbGncuTg/UUHCpJBCMda6E3klV2Lhh5WNIVo5fuADAd3lqJ2kBzhVuRJDENzb8IqfY o7rajpoJN1soCZmvxXyHPSMKBHYvvt2bMMAJu/QUb4dVCW5rdznVwc0DnzXuvrdwMFRRxqhECwN q5MpnVeFFUlOIQZrE/C63xi5Ph0/BCZ80Hs/ux1GUUXyMmZrdgVEEMMADuUlPVF0mWYnB8Pe/nU um7ZvYvYmRkdJLgTUroOMTZ/UnyMeVxkIkvKxDNh15ei0aIN8HCvgVbtH2hbQi1sDTCnh9eBmRi 7XwDUtiZZ8K4gGYGwt+R2jycpYjZK9OeRcOSIY+VTo72DkuFSxvdBJ3rYw== X-Google-Smtp-Source: AGHT+IGAt3760Qhq8XM3fVQ4ouCmUKpaz/sP4mtLEw32k0+oB77VuzIh0ce8Xp3r2hz5RJC3cF50Bg== X-Received: by 2002:a05:6000:1a86:b0:386:3702:d2d8 with SMTP id ffacd0b85a97d-38a22400b0emr3189544f8f.58.1734712370342; Fri, 20 Dec 2024 08:32:50 -0800 (PST) Received: from elemental.sec.9e.network (ip-078-094-000-050.um19.pools.vodafone-ip.de. [78.94.0.50]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1a1sm4365193f8f.69.2024.12.20.08.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 08:32:49 -0800 (PST) From: Alicja Michalska To: heiko@sntech.de Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alicja Michalska Subject: [PATCH] arm64: dts: rockchip: ROCK3B: Correct clock rates for Ethernet PHYs Date: Fri, 20 Dec 2024 17:32:27 +0100 Message-ID: <20241220163227.1501912-1-alicja.michalska@9elements.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Built-in ethernet PHYs did not work on mainline kernel: fe010000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0 fe010000.ethernet eth0: __stmmac_open: Cannot attach to PHY According to the board design, they need to be configured as output with static TX/RX delay. This patch sets it accordingly. Signed-off-by: Alicja Michalska --- .../boot/dts/rockchip/rk3568-rock-3b.dts | 68 +++++++++++-------- 1 file changed, 38 insertions(+), 30 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/b= oot/dts/rockchip/rk3568-rock-3b.dts index 3d0c1ccfaa79..5350158302e4 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts @@ -183,37 +183,65 @@ &cpu3 { &gmac0 { assigned-clocks =3D <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; assigned-clock-parents =3D <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_= 2TOP>; - clock_in_out =3D "input"; - phy-handle =3D <&rgmii_phy0>; - phy-mode =3D "rgmii-id"; + assigned-clock-rates =3D <0>, <125000000>; + clock_in_out =3D "output"; phy-supply =3D <&vcc_3v3>; + phy-mode =3D "rgmii"; + phy-handle =3D <&rgmii_phy0>; pinctrl-names =3D "default"; pinctrl-0 =3D <&gmac0_miim &gmac0_tx_bus2 &gmac0_rx_bus2 &gmac0_rgmii_clk - &gmac0_rgmii_bus - &gmac0_clkinout>; + &gmac0_rgmii_bus>; + snps,reset-gpio =3D <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + snps,reset-delays-us =3D <0 20000 100000>; + + tx_delay =3D <0x36>; + rx_delay =3D <0x2d>; + status =3D "okay"; }; =20 &gmac1 { assigned-clocks =3D <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; assigned-clock-parents =3D <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru CLK_MAC1_= 2TOP>; - clock_in_out =3D "input"; - phy-handle =3D <&rgmii_phy1>; - phy-mode =3D "rgmii-id"; + assigned-clock-rates =3D <0>, <125000000>; + clock_in_out =3D "output"; phy-supply =3D <&vcc_3v3>; + phy-mode =3D "rgmii"; + phy-handle =3D <&rgmii_phy1>; pinctrl-names =3D "default"; pinctrl-0 =3D <&gmac1m1_miim &gmac1m1_tx_bus2 &gmac1m1_rx_bus2 &gmac1m1_rgmii_clk - &gmac1m1_rgmii_bus - &gmac1m1_clkinout>; + &gmac1m1_rgmii_bus>; + snps,reset-gpio =3D <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + snps,reset-delays-us =3D <0 50000 150000>; + + tx_delay =3D <0x47>; + rx_delay =3D <0x28>; + status =3D "okay"; }; =20 +&mdio0 { + rgmii_phy0: ethernet-phy@0 { + compatible =3D "ethernet-phy-ieee802.3-c22"; + reg =3D <0>; + }; +}; + +&mdio1 { + rgmii_phy1: ethernet-phy@0 { + compatible =3D "ethernet-phy-ieee802.3-c22"; + reg =3D <0>; + }; +}; + &gpu { mali-supply =3D <&vdd_gpu>; status =3D "okay"; @@ -512,26 +540,6 @@ &i2s1m0_sdi0 status =3D "okay"; }; =20 -&mdio0 { - rgmii_phy0: ethernet-phy@1 { - compatible =3D "ethernet-phy-ieee802.3-c22"; - reg =3D <1>; - reset-assert-us =3D <20000>; - reset-deassert-us =3D <50000>; - reset-gpios =3D <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; - }; -}; - -&mdio1 { - rgmii_phy1: ethernet-phy@1 { - compatible =3D "ethernet-phy-ieee802.3-c22"; - reg =3D <1>; - reset-assert-us =3D <20000>; - reset-deassert-us =3D <50000>; - reset-gpios =3D <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>; - }; -}; - &pcie2x1 { pinctrl-names =3D "default"; pinctrl-0 =3D <&pcie20m1_pins>; --=20 2.47.1