From nobody Fri Dec 19 04:54:33 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2056.outbound.protection.outlook.com [40.107.247.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93997215198; Fri, 20 Dec 2024 12:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698169; cv=fail; b=PGbYoHH/5GeBf09O1WvJPbVPkCSjdWD+0P3gcVOPdNst9tDXOsaOz+bx12eUT5KaXu5J2cYl5wNHFc/cGv1MAo+3HQy0ThYrK2likviWLpG2Qp9LF73dpUrWmeQurnLA1kiKkm4q4U+5F1jT7EYM/wkinE6bD9i/8U0rOqQiluI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698169; c=relaxed/simple; bh=fgmnUM5+DfxZ2551PiU1M1gvecssHhkodQh/F4aJlnc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Fkfh24rxJ4VUbvzAc2k1VHOE198ckA7cgLRuV4+RIzPCxjT64zEHTW2pvjbtky+PcrIUIkJ8n2oRXz7qz/9f9UmkI0EGwBD2CXXw1kU/x2oQccMWly9pMGRnf3hiwx3c8V1VQIDodoKa+xzj0JDkb0KMGeF6f+Rcs71yonBHVjM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=cUJ4Ninj; arc=fail smtp.client-ip=40.107.247.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="cUJ4Ninj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vg6DWu/ypJvlIDUeUhen4UfrlAr7sKgt9TBovUuaaHiBSccznSSBFNKB0SlqTNcsjyaT1SoY6aJ2Av6GGIQjDc0GX0Dm4K8fVqklFh9NozFPggGugCmiJPNm3BOjG9XwiOrxzdniIIrxPs4ADoP1vvgifdNdduBueqKZtK5sQ+lEIelYpQyOeDXCjYV6cVYXNI1jQZthAPxB7nQ3uKJJ+KAdFYT0FvcVgXyW4fLN9WVx6LF4/n28uMoz5d1XoPI7xb66HVdcuZeVQ4LPbERSIWwVYdgh8KkYIzqEcdxqkFsZqFB4rTHQnnCA5HQgjbpUouWLbdUPOvWjXHEPFXOdAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pQIpKB7yu3QVnJOnzy0O5IgwDdSSdcNr6tiwZ67nQpA=; b=N2wuYSbaEwdNNn/I4uWmaR7l/jtSLP/IdDmyi8zhT4RppbT94gte1pk+b+VSiEJHMW8TnQldlgjHS8kS6ZSWW4bHQQzvt6qtNDxJmn2uC0ZnHUz0sU8GNDKfW7xzYdICpGK7ckRoyIwWsuAxwSBerKPzilaGoFLr79zxTxomoxbCJi37sbMZoDm5HIYVg3UDq2HHJHoQUjkWh6UTWk3c2qWT4trR+h2YEpLKjg5X4OlZHa3NOtWmKwk2arlgDXFurOhHd8ysqMScXXA8HsQ4ydzIsua2W/+RoKbq+j+Y/eWDK6aWi47MUYK0Wex8V+i2In9HKSk6BoEtQOOqWYjzqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pQIpKB7yu3QVnJOnzy0O5IgwDdSSdcNr6tiwZ67nQpA=; b=cUJ4Ninjx1T06C7mxIRqXCuggllzMgPEBWXVZxXk5HI3b38cSJDEi3XRFI2TGYBmTe6bnyg53gx8iZNcV/9MxKYhMwi+l6WEeeM9XfpmADmP7bA3He9QIv6jPEntjweqV29keHySZEhsXRQMLrhP++hiuuUw81q2ATjnVWgTmvc/kqFRMu9ftDZ5BMPiGelOATtnTY9UEBpxDbUF6mb0Dl8bse8Htk6JwLBN+ycHqFFWrnynajUIdtU7N5vjWL1YcrBQPATiUFgwoRYmEjXuCUs/YAcO8gliEdJTX6jtqje/+hGyJRJr97iFb7BpRSSrCW2G6e5tkpUiWRMiDTkMBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) by GVXPR04MB10047.eurprd04.prod.outlook.com (2603:10a6:150:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Fri, 20 Dec 2024 12:36:04 +0000 Received: from AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30]) by AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30%4]) with mapi id 15.20.8272.005; Fri, 20 Dec 2024 12:36:03 +0000 From: Laurentiu Palcu To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Laurentiu Palcu , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 1/3] staging: media: max96712: fix typo Date: Fri, 20 Dec 2024 14:35:48 +0200 Message-Id: <20241220123551.696330-2-laurentiu.palcu@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> References: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0072.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::25) To AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR04MB9576:EE_|GVXPR04MB10047:EE_ X-MS-Office365-Filtering-Correlation-Id: a246cd42-adb6-429a-efe3-08dd20f2de2b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3NSUG40aHhZVlkvWmZ1MlFtL2RPZmdpL1doYTVqL21ZaE9aYlk2NVI0UVhJ?= =?utf-8?B?bHhKME9CZkpncE84VUVOT2FabVRuZThtVG1zZjJETTlabXJVYkJibGpLUXpT?= =?utf-8?B?SmlYdmZzbE9BcEVaTzBPRE5ueGFRTGd1ZVNJeEhDQ25GaGExdXZya2tNUmJu?= =?utf-8?B?dkFnMW5GeFdoU05mR1FEU1NOc3ZVQ3EvKzQrVmdNVU1VVWZrVCswSEJWTm1i?= =?utf-8?B?bndST1hTK21tUHJSTkFkVHEvaDRMZXI4SmM1b3VnMDBTZDFYT0h0YUxiRmU1?= =?utf-8?B?RlYxUXlFdWhoZlNNdU9LVXE1N05CVW13T3ArR0MvV1JQRFFvNGx0VXJ2c3Br?= =?utf-8?B?OS9ZeTlHT041WGp2RzBQanBGa2h5c1dYV3h5Zmd5aHJpcW4zbk1Qam9sNUlk?= =?utf-8?B?OEt5Sm94NURiYUR0Q0drcjVNc3piUVpIT1I2UjR4VlVIU3lIQUNVZ2dobXNo?= =?utf-8?B?ZXl1TllnZnMvL0xQdThkYmtZUTZqb3B3UEhkQzI5bHdkMWI2VGhOM2Y3UWlU?= =?utf-8?B?ejl4aEdGREZuWTlQbk4rNUV6dzErd0dtL0hxTkN3MnR0N3Z3V1o0NnJvZ2NM?= =?utf-8?B?dk5ESUp2eDU3SlY0ZWRiQTVTVmRRUTE0M1h5dEhDTFB2V2t3MUZaVWsyNE1Y?= =?utf-8?B?VFlobCtuZjFScm5HZ0NBRXdEd0lKclBxNWFDQkVkbEp3cHZ5TmlqN3cxR056?= =?utf-8?B?T2FqQnYySmd0dFo1d1Raa0VLRWFCU3FjV3hIL1RDZFM4Um50TkdZOWN3SWdO?= =?utf-8?B?UlhkczZ0c1lwbStIOFVRK1ZqTmZ1L0I0ckd1TzVPTEJnc1dkTEYvZHJjSURJ?= =?utf-8?B?ak1KQ0g2cE1PemhBMjVSUnRIREtEckt5cnUralRWbXg5WUk3blBTZHpoR3Q1?= =?utf-8?B?Umt1azk4MUtRSjl6eko5bElnWWkraDRyb2NjWWJnb0ZXdmcrbE9rRmk0Z3Rj?= =?utf-8?B?bXloa1NEVERYK0Q3TmhaaW1Qc0grNUJaT0lHdUFLV3U3SXI2RS9uTkFRa1NB?= =?utf-8?B?Z0tFWVBiZFZiZlRqbGgyVldVQ205c0I3TXF6clJTdVREemlsMlNWNExTRmhL?= =?utf-8?B?d1NFeWQ3L0doUmFMUm8zejlQNDVLV0xqcFZRbGZ2QnRVbEgxMDNVM0htMHRZ?= =?utf-8?B?ZTlGZjdGTHhpVGhqOTNERGx6d1FpQUxqbEtRNlp1Qm1FUFhNNFN1RXJidDJz?= =?utf-8?B?QTg4Ni9SUzJCcVFvcnYvSlF6czliV1RkcUNFK1dYUktmaHdOZDFIcFd6Uk9Z?= =?utf-8?B?M1dRUllOZUhldDBHMXUyaFNGeG1NcVBQcWprNThjeW5aVk9HL2FYYmpDK2Ru?= =?utf-8?B?dmI5eElENDdIWm9ZbFBlUy92ZmhtQ1ljTHAyTFhuYmE2YkJFSjRmNmNTRHQr?= =?utf-8?B?bWJGWi9ValRsYW1CRStMTmZVUnh6cG4wei9kRzRMdjF5aXV0RDk5K0hLM3VC?= =?utf-8?B?VjlERTNFNDhiejVoclIvcXZZeXVCTS9BQitHQk1JZ0x5cFM1VnlCMTdSNG5O?= =?utf-8?B?b3dxUUxWT0ZBMGgxck03QWxwZXNXQ00wdnJ5SkkrcG1jYnhxTFBXdnBSaHpM?= =?utf-8?B?T0lMVzdBdlowbHlnMVdzL0U2QnF0WDd5c0dNbmdZSVA5L25XWVE5UldGc3NV?= =?utf-8?B?bjl5V3M1VHNlcVNkOU8ySzJyN283bmovRnJmUGowVjYyRGMwWllJREVZdVdB?= =?utf-8?B?QkxYbTFYd3MzWklvbnNzcXVMS1BWY2pDZXdPUlNOMTRUanR0cXZoMHM2S2cw?= =?utf-8?B?OU5Uc3dSb212RGNpZnR0VWJDOGxYT1Rrd1R2Q0xDQ1MzaG9SVldhSlB0ejFo?= =?utf-8?B?b3BvSm5SdEE3dG8vcGpoNGE3TS96SWZNU1NuNlBQWDRxUXpZMTZWd21UYVNO?= =?utf-8?Q?YAZ748KXB4W8j?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR04MB9576.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UURnVkhGZ0FZTTNlVzBMK1g5N0FxTWJLOTRyM0lsMVRwbmtRVFA4bUpuempp?= =?utf-8?B?R0luaVIrejdyQWNrcStFWG11OUFTRzdXcVhYQWZqUmlMdlZocFU2VUJPSnlU?= =?utf-8?B?dmN5L1UzUGlQZ2NYajY5UmJNdG9kMzQwd2dSLzZNMEh3dU9LVTRETTdERmsr?= =?utf-8?B?emdQM3daNFBRRS9lbzczenhEMTE0WTRTLzY3K1QrRDdneVpRSlJPUkFTS3Rj?= =?utf-8?B?UFk1L2NpZUpjS2tOblNES3BCVkNNRURzUU5GeC9xTEtjKzFianJ2WThRVlhs?= =?utf-8?B?em01NTRPaC9FaUVJTnlpQ1Q3Q3FpTUtYZFZ1OVZ3dWFLL1lweE1PV0ZyMWlm?= =?utf-8?B?clZ3amhsT0VWNWF4NWw4VGRoeUpGaFFTUzVoWmdReVRlaUhXZzd6MHp3UUd6?= =?utf-8?B?S0huUnR5a3d4Vm5WL1pKcGtwZ3liRkRsaXdRNm1rd0diUFB0R3ozN0ZSeUQx?= =?utf-8?B?RzdUSDJjWENtYUNFQTVDcGRlVEZuTnZHSnIvMHFnb1NQOTZGQmx2eDZ5Slho?= =?utf-8?B?SUlCdVBraVF5cGZTRUdKeFpORnZHdFR2ZVlObFVMekNYOUg0S1ovSWg4UEtD?= =?utf-8?B?YURESjJZRHltS045c29aZVdkNDltZGlsRHgwRTkxV3hMN3pURzV3SWpEcE9S?= =?utf-8?B?dmZ3N1h4ajdRelBrMFdrdUY2N2NxYi82NkZRcXVIYUNvUHhVT2IrWXBmdVZ2?= =?utf-8?B?YUFpQ0wzSEx2czdpSHVTcmtWYXdrakVNMTJxY1JxRkpnTWtRVnRTVzlwUHdE?= =?utf-8?B?UFRqVUN1N2Z5VEtQU3QvMW4zMEhzOWE5V21GWmJPRlVQUkhvckU2YXFtblEw?= =?utf-8?B?MGpmQytYdTFXYTZuM3A5ajlYQUc2RUdTWFhobnhVdGM5MUg2b0tBOVhKdWlC?= =?utf-8?B?Y3o3amZrRFZaQWVrQlQwZ21scnB3ZlpJOUVtTGJHeStFRmVpV3ljTE92ZUFv?= =?utf-8?B?SWZXZVBJb2FlSDlTYUpyOWVLcXNvT1U0VGR4TTJqS3owRGRrMGZxcnVMbWRa?= =?utf-8?B?QWRYOGd6VGpMazFYbC9Hdmh5ZElaWnBRdG5keFMrSzVIK2pSQzJ6OHFUZW9I?= =?utf-8?B?M1pVU0ZOSkFlM2V3RHR6T0QzazB0UGJzcS8yUnpYYnpzZ2JndTMyZnJBclBn?= =?utf-8?B?SWR1OFFlTlQzcFRsLzlOc2JJRlJTWjVHUU1SaTMvcCtZRVFCd3FrQWZlTmY2?= =?utf-8?B?OVU2dGQrc0pBUEtpSkNUR2YxdmFtSXVLaFI2V2oweXQwQWlXZ3RNZGhoT2RN?= =?utf-8?B?Nzk5M2wwU2R3Q2Q5bjdEQVF4NUNRb1RHVSthL3YvQXhxNnpKZklpRTF4enpu?= =?utf-8?B?a3NETS85M204dS9udkJiVUdkRUtZTE9hVVNCdWhJSm54aGRyTEJFRDUxMThY?= =?utf-8?B?eGtQcnlGZFE5WWRNR2RTcW1aUXZpQVV2L1NwZzJMdTlNYkRnUGNHYTQ5Uzd6?= =?utf-8?B?TW5waERmbFdvQnJOTFVBeFdDSmpEWWZBaUI3VE9KaGpEL0NNdzJ0SHVXN0Fy?= =?utf-8?B?TGFETGozOUVXTUVCaWpCWlJ4QVJoamM0NVZZa3dFeTBsUmlheVNrbEh6djNE?= =?utf-8?B?K3lNYk1ScGRCV09NdTNWMkxraE5OdERkV3Q2ZE5uRVZEd1dTRVlDTC9keXBq?= =?utf-8?B?N21SanNXQ2F0R2NHREQrZDhUOEVzcFNMMGgrWVZBK1E2YlkwRnlqVG9CaWVV?= =?utf-8?B?NjY0YmQrdUlKWXJMbmxnZzJqZ2JHK1ZYeWVmeHhVd05ZL2JtbmEwemt1ODR1?= =?utf-8?B?N2I5R2NLMVJFZmhvdmFtQWtKczRlK1BlallKclJ5Y0tqaU9Ya0NXYyttZEJj?= =?utf-8?B?bWxob0JQVzU3aTltN2dvTVhycWJ0bE1ya0EyZHRIWSttVytXRzNFYStMWGtv?= =?utf-8?B?c3p5NHhRbWQ1cmR2em1qdmlhZEZGaHR1c3k0am1WVk16ZkJpQU5KTjlQWVRF?= =?utf-8?B?cDFFR2hSZ3pEaE1BOTRBc1VEaGttaFFQU0c4eGU3LzRJckp1YitqOGFOYm90?= =?utf-8?B?Wmg3MU1Wb2YrTUNKZklua0hvcjNnRDhLcVM4Rys1SGFzbVhjV2tUT1VDcEtK?= =?utf-8?B?SmFvTk82aC92YlNXSXVBVFk0cDV4ZXNzVE5yK3hoT0FYU0cybFcyUG1TOHhV?= =?utf-8?B?azlRamkzOWlpSy9vck9zZXp4ejg5Wk1oM2djVjhJMXlWZnk2QnczSHplSTYx?= =?utf-8?B?a0E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a246cd42-adb6-429a-efe3-08dd20f2de2b X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9576.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2024 12:36:03.9418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7+kaJxoFyXNnyxsZSyz71oAWWlQ4Lo0GK1YAgKuNwOPE+khLysPvnJ4iSwh+VUayCATMRPv4vh/DwuStYOzexA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10047 Fix a typo in VS_LOW expression. Signed-off-by: Laurentiu Palcu Reviewed-by: Niklas S=C3=B6derlund --- drivers/staging/media/max96712/max96712.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/me= dia/max96712/max96712.c index 0751b2e048958..5228f9ec60859 100644 --- a/drivers/staging/media/max96712/max96712.c +++ b/drivers/staging/media/max96712/max96712.c @@ -182,7 +182,7 @@ static void max96712_pattern_enable(struct max96712_pri= v *priv, bool enable) max96712_write_bulk_value(priv, 0x1052, 0, 3); max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3); max96712_write_bulk_value(priv, 0x1058, - (v_active + v_fp + + v_bp) * h_tot, 3); + (v_active + v_fp + v_bp) * h_tot, 3); max96712_write_bulk_value(priv, 0x105b, 0, 3); max96712_write_bulk_value(priv, 0x105e, h_sw, 2); max96712_write_bulk_value(priv, 0x1060, h_active + h_fp + h_bp, 2); --=20 2.34.1 From nobody Fri Dec 19 04:54:34 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2056.outbound.protection.outlook.com [40.107.247.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1DF32153F3; Fri, 20 Dec 2024 12:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698171; cv=fail; b=KnUfsv3FtxDoEYJF7FMajt6mRKnDVR3LDbNCLWPjAiutK87i1OJjnotE6+bytg39YDKH0VJ8JIN4GVa3MsgYchwYGfEu40HxaF44eBRyIi04astpc7rmcttXTFxsy2Y4FoExQAnUe+meWxcQH6foUFpWK+fucGhAZY6Oeim45tQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698171; c=relaxed/simple; bh=JDEjsM7wAChbeFdO2CG1vB7vCO/Q2PZe5Xo6Jlf4sqA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ZqCwjKqCvYhcy+1ZeiOrREybaDqO40yBN4OuSeVIY3AEPauxj5UNrJHs4rZDYtkE+hFwlWnjUzfSjD1GAtU3FUmOpBSbK2YnQcWaXvL01gQfsErxWSuvO36TvxIKUDXCbSaNrguj5apl4L3ERz4f0BAshvADJ5TyDdenw0wCGys= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Dt4QvuwI; arc=fail smtp.client-ip=40.107.247.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Dt4QvuwI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e/zJ03Xn9y9EGtIuC/xP9XnGW/iXlTm6PcfTEelSatnRShuN6fDRGUZUH1+g63ux4GFqSGEhWPW2M0RIteYlHVm0QLGsYGo3boi74Kz8MIj31UDK41zCqlCeJIkRiTc9BY66OnRGifzC0LmxVPoGhso9ATiMu3spmlt6Xi9mn0cmLJuo1cl19tQdXhhj59SpMYVnP4Wegxj//6IZ3CuBWJjknGXxVF903/j8c40UiydV1N1XDDEhc/aPD5e+U6XfJSDKs7TJfmZ9JaVouLTXVfgeItDBAsHJBAnzFZxXUZTS7+X2InDynMozkLNfGktJv/t3MMA9OsW4wbyUIiiY3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCfbsqE3Rmf03txvCD4DMR0ugL2hywW2KxTwbvFn3Vw=; b=n7ZZsF0S8DtMdcgtavCrGbo3472gsn0r66NbJ8C+cWj4JxvtDufpLCZY+eVhjUnO3ddSDJae1vr2FdirIcPAaE/RI2cZda7PaY9vp1HCDGjFTicun97Amt/tcdMXVR8PLQ1mzNF516nzGL4Q/C89tRap1INebRqgcrWxEuxwvlWgBcsKiUOfUhbAC3TM1psKnMm/OcHirAjMiMiR0WV/Ocme/Pi18tHfbJUwdKKZ8Ec1Jnr460np1Gd+atMuY4lyl+kIwtUXZNzZ57ZmPSOVFhIo+T7ByeqYQe+jqpINohTHUwjX65K9zw4AYjfl7kNpdnT/SK6Ga+7DUy2fQxAMmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCfbsqE3Rmf03txvCD4DMR0ugL2hywW2KxTwbvFn3Vw=; b=Dt4QvuwI1kPltl+9B4W6sAFdBJnZYpHOXEV+ZBj6KVJFBoYPzI7kYm5hXXgC8jvXQylMbjnwhDpShw3t4dQhNEsv0kQq1JqooxrtUh5PGiSaHNr4QzcZY2tICgaZINq75BAFUoQsXdEzm3wipkxZSh73XIbFbgsJ2TSOEu8SgqdbXP3H5UJZRSfa7pPtYk4QKKD+3lqFoHu9YlDVD0R18Uw7RYOtaYhUujpix5xHRgaEKeDCcEe28mO9lVCtdpF+oiTNWxvlh4fKel6XfHUcjvSavsWzU8sj4k5vObSfin7D+2Se26LF7eMtLjcY/56qeGTyEf7UrVhvpk05nf9VFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) by GVXPR04MB10047.eurprd04.prod.outlook.com (2603:10a6:150:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Fri, 20 Dec 2024 12:36:06 +0000 Received: from AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30]) by AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30%4]) with mapi id 15.20.8272.005; Fri, 20 Dec 2024 12:36:05 +0000 From: Laurentiu Palcu To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Laurentiu Palcu , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 2/3] staging: media: max96712: remove extra debug register flag Date: Fri, 20 Dec 2024 14:35:49 +0200 Message-Id: <20241220123551.696330-3-laurentiu.palcu@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> References: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0087.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::40) To AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR04MB9576:EE_|GVXPR04MB10047:EE_ X-MS-Office365-Filtering-Correlation-Id: d44e4c08-d188-4091-5cdb-08dd20f2df60 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y05Gcno2YzRxT0t1K3JzU0xac2Y3dFRIcENkQVpwa1hyZE5xSVFpdXFxUnRp?= =?utf-8?B?RDRJaGVuNnFrM3RvZWMvNGZQZzdoVnJ0dWtGejdIWEs1U3lNNW55Qi9UMEZu?= =?utf-8?B?K0k3N1M5Sit5cDIwYkpDc0JMS3JMMmRVRmJIZkFWRFVCWWlYbUdCd1MrVWM0?= =?utf-8?B?MlY1ZEFWZlo3T3hoVkw5eXB6Q1lhdm1ZQlBac1ZwajdJQ0MrQUZ0M3lMZzlI?= =?utf-8?B?cnBadExnbjhiUXUzTkZDT2FZd1NiL0Ria0J3c1VORTVDNTZEWDA2cFg2MDNk?= =?utf-8?B?TjJzY1UyVTVJNEcvdkp2eTNacVczb3Y4Z2hZYXpHK0JHZDdBR2hxdDZqUE00?= =?utf-8?B?blNHb0djOXZESDh3bHZWbW5QTml1V3ZUZDNsVTNtK2pzZnRrbm8xTDlBRGhm?= =?utf-8?B?bCtCQ0I3L2hsOStRY1ZBbmZDczNIY2pvMEw3dEFrdXJaS1oxc2JEc3NINkpi?= =?utf-8?B?WVM5TXhFNnJGWkRDNWRUcEd5cE9la1Nja2pQaG1XUFE0U3B0T1V3U0JCSnhW?= =?utf-8?B?bDJ6MVJDc01OY0RqMVRVLzltbjlCNDFudm5Ma091ZkphTFhDRnJrdVh5K2li?= =?utf-8?B?QTg5NlJnWTJzWjBlMC9sNnFYbEZIU0Q5MnFVUmhzR3IrNFZkbk1OMHU1Nnkr?= =?utf-8?B?OE1jVUprcWJsVDdmNmRVSlBEWmNpTFgvczFxMFJxV3kzbVpQOWxIV29kejFy?= =?utf-8?B?RW9YT1NHbGJnOVRHUEFSQldDVG5OdDBTWU02bVVjaHdCM2tZS3FIZUZndnZm?= =?utf-8?B?bE1CMnBpMUpBNWRMVmJxYlZ5ejV6d3FCRDRoV0ZaV0IvY2lQVXNXZzJESjgy?= =?utf-8?B?K3dGalQ2T3ZDL2RRSk9YVFV4VjJtd0tBeFppMXBFRVFuQlEySEdkQmZvUjE4?= =?utf-8?B?ZGV5VWJXK0lzdk81bng5bkRBMjhWMTY1cGw1aTREVlVQYlc3ZHdiYld2NU5E?= =?utf-8?B?anJTb0RxVXovaG41c2QwcWY2c1dWMmxqd2lDNStGRXowdHM0KzNyZm04a3hi?= =?utf-8?B?QTEzalBJMkNibkFOYzdMaHBoR0Vmb1VrY1VYOXVKL051RHRjak9zMUg4YWhF?= =?utf-8?B?YXA2U0VSaFVjKzhyR2xBZWd1dXR4YXU1WnROQ2VPYUQxUzJxV3VKZkM1a2pD?= =?utf-8?B?SEYzTGFRMWx3UzJBSEk1Ujc5NGRZaHB1bk9JMGQrcEhwWlVtRmJjYzBzcUdL?= =?utf-8?B?czY1aVp0R1FRVW5nN2hCZERTNGtKelVzTzhPazhWNGtTMWtuSmJQRi9FNURY?= =?utf-8?B?NWZUWTBNVyt4RytiRXRwQnBiN21NSllRSjJ1UlpZaVJwZUNpcnVUNi96WDZC?= =?utf-8?B?K1V6d0tuT3VjcFJPRXl0dWE3QVd3N0JHd21LSGxISWFKNlBPWTRlZHpIZXdo?= =?utf-8?B?RDV3Y3g1SG55bllLZ3c2R1YxclB5WXp2RlNQYi81V1BGdmRiZG9RMjRsT1JE?= =?utf-8?B?Uk8zOHhpd1NXYlRwaTBhTWpTUVh1c0NRVVFUVS9PVW9OVE4wN2d6S0tMNjVm?= =?utf-8?B?WUllQmtabUE0azlGTkVOVGtPakp0cHZZUjFENTRBajdXQnU3YldhNUc2cDZx?= =?utf-8?B?M2dhejFwV0NJSUVDSVNFKy84OVhJc05BVG9IVEgyRUw0UTdnbW1Xb01NZEpt?= =?utf-8?B?UmllWk9PREhnR01hNHk3dCtuTlhtVXk3cVpGN2QzQTFUZUpLVURsc01jZjhH?= =?utf-8?B?Mng1QUh2UmVzZTRSL0Y5KzE4eEw1Mi92MUg1VHFXUmNRMGFLWHVKSUdaV1U3?= =?utf-8?B?aHRrRHJITGJZcGlWNGNPQStTZlpzWmNiZVp4UUE3MjZGT3NYYnhYUG9RYW0w?= =?utf-8?B?eFhpUEl0ampNblA2bXRTbXZybVZDY0ZxeFpMVDNRaXZFbDJjK240QUJHWllx?= =?utf-8?Q?NXF4q51P4owgf?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR04MB9576.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVg1bUZJY052VFRBb01rSjFibDA1YlU1NDQ0cDVBb08zQnpCNCtXc1NqQlRB?= =?utf-8?B?Z2d1eWk4ekpvcE5NbEhKRmxZTHFKRjRDcFMxQXJNbi9wYk5uckY1VngzWkdY?= =?utf-8?B?d1N5ZDRxd2NtejNmWldiQjMyVTl1ZkJidlJMNHc0ZUhFRTh3QjAvZFErZStt?= =?utf-8?B?SWtsbFUvVkNFOUFVei9mTGdMdTY2UDkvSWl0LzdpZ2huTHV3a1QxZWI5N24v?= =?utf-8?B?ZjlLSmQ1WmFNTkxIaGJ2YTBDWDNQNjBlQWZ6QjV2ZzdVd2pPalpGNHd6SFRM?= =?utf-8?B?QUc3UGJVbEFJbnRiaHY5WlJWcnBLZ0k0dTFPclROTTIrK1RrZlZnUUY2c1RL?= =?utf-8?B?RWtBTy9jeWt4WitxWGR6RGlMdzJaaU1LclRUcWJuM09QaVZ0ZTAyd1poZTF0?= =?utf-8?B?OHRwVjJodllnRHl1ZC9ra3d6V0xXVVJFc2hWV3ZRcTVjd2JRbVVtQTg0Ly81?= =?utf-8?B?MXE4UjNzakFKeUhRWWJNa2dYc0tyVFlEMXZLa0lkeFdUWVVBVFR1dFVldGFD?= =?utf-8?B?eXdtZXNhcUU0N3BzWXdtZGN2a0UzR2RFN0kvTmxUSXBvOUdsUFFZbUVaWkpQ?= =?utf-8?B?ZERYVmlHRjlDNEFkcWdCNjhUcktwSWEwU0twanlPLytEdXNEV294eGdmM1V5?= =?utf-8?B?ZHBwVkN0RjZSQko5dnREZXdZUFFLTEw2cnhTbW5CWFpoUkJVUkpPdHBEaDlq?= =?utf-8?B?Q0VyRDNSbEUvMDV5NWw4UTR5V3QxT3QrZWJqbG9QOGllYjBJSkRLck1Mbi9m?= =?utf-8?B?YU9wb0V6U3VEWmdIL2I4ZjhUN05DWUpGenRxQ1dNVTZhclJrK2pHaVNPZWw1?= =?utf-8?B?ZGRma1FsL2xZYktmRDUvOERub21qVjJSTUtDa0hXVlplSjcrbUNEd2xqYm5M?= =?utf-8?B?aDBqcHhpWUJNODhvbXlvRmMrZGNianhpc0NZNkxWRWZZRmxkSG91SHFIYnF0?= =?utf-8?B?enJIWEdMdWRkOGhhdXl1aVkvRXFVa0hPeG5mM1BuejBxS2pYN3ptNzdIc1Zz?= =?utf-8?B?UjlKQWZaMkVhM012Nmd0MHpSZmhqYi9yYUNxSDk1NHQvcXFOeEh1Q3l4dDBM?= =?utf-8?B?bUFRZ1FDeXhwMDRURGpNSWtyRzcwOE5EUFRLRkVFT1lzLzZpUDViN0VHZzZF?= =?utf-8?B?a0JDdTFNUlNUNUh3STl0Y3NhVnBQV05aUHhWRThBVHJnbm1qNThnbDVmQnI0?= =?utf-8?B?aHJ5amtiNnUxYm8xQk8yZitWTllGOHpSWVo4WUVaWWZKUWJDOEU4SmlMTjJ3?= =?utf-8?B?NGlUVjBySGEydmhiK29uZ0ZpUCtyeTRDL1JwLzJHUFYxaTJvWVd1YnFZSllH?= =?utf-8?B?azZpWlY3Q0RFMTFmZUJkSVhqMU56ZmR4N3ZUWGNFN2YyblJVNm5zYTE5L29z?= =?utf-8?B?cnpIOVllT0g1ekxiQ1hZWnU3UURSSFZLWmowbDJSems3YnZaSlN1alV6eTdE?= =?utf-8?B?RjJ5eFVxbEttUGsreXFZM2t5SVhwVUIwd2R6MGwyQWpXOWZwTG9nd0RlNzhj?= =?utf-8?B?cmpFRG9GZHRNTmhtcUsxNE0yeG16MVN2VEVMYW9tOTZpQzlvRitEZ3creUhz?= =?utf-8?B?ME5HVG1paWFuSkFEd0FtSDlTRVRhY2h0TWhEdmxCWlZ5bm8yQmFFOU9WQ1Jy?= =?utf-8?B?MGpETUxVYTFKdU9JMEQ3R24raVJnZnVwMWN6aTlLRDNjTHpRalhEWkhPNzV0?= =?utf-8?B?M0YxUXJmU1JWOWRnTE1yVG5xRVRZVHkvSjIwTkFEMmVXRHRMZVpJdmlZMmd2?= =?utf-8?B?WXFqWnkxQVpyakJqTktBaTRTYnhOaTgzb1NWRWhMVUVSUTJvL2lSa3VYYSs2?= =?utf-8?B?NDBVNyt3ZjZTT1YrSnlxeCthY1p6M05DUlFVY0M0VU5VRm5rK0hpRHJxUlFS?= =?utf-8?B?a210TVRncDB1MmJWMGRULzdQR2Rib3FtbXNlamZCMU5JTkFqZnRqUmZ2dlk4?= =?utf-8?B?T25JalZaOFB5UCtiZDllbzJlZkpTVU96V3JTellXZTZ1UnQxTEIycWtnRURj?= =?utf-8?B?aGZXR1hrY3llY044YXNIUmJIYlI3MnpocG1hZ1JsbUFLWFpSZ09UWGF6UzFS?= =?utf-8?B?Q3BCOXR2K0N3NmpJN016UVlISVJmTUN3cTdHZ1RlOXBtVXhrZkk5TUpGZStx?= =?utf-8?B?a3QxWnY4a29JZnBxWTYxSnBGdzRld3MwQ3FsMHlBUmlFUTVYSVk4RXNjcUlH?= =?utf-8?B?ZHc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d44e4c08-d188-4091-5cdb-08dd20f2df60 X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9576.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2024 12:36:05.9429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rGtnrb7xwEHu3jgaBUAJBrV+XdbNYAp3jUc/LotHNgX8aq+P/9mu54E3GLxA4MeD89IJNQVdQ5ZdubjTwU3x/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10047 The current implementation has the register disabled since it is not documented in the MAX96724 RM. However, in the chip's user's guide [1], in the Video Pattern Generator section, the register is documented and it appears to work just fine. Before the change I was experiencing approx 10fps when streaming, after: 30.3fps. Hence, since both max96712 and max96724 have the register, we can remove the flag. [1] https://www.analog.com/media/en/technical-documentation/user-guides/max= 96724fr-user-guide.pdf Signed-off-by: Laurentiu Palcu Reviewed-by: Niklas S=C3=B6derlund --- drivers/staging/media/max96712/max96712.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/me= dia/max96712/max96712.c index 5228f9ec60859..ed4d5db1ff8d1 100644 --- a/drivers/staging/media/max96712/max96712.c +++ b/drivers/staging/media/max96712/max96712.c @@ -27,7 +27,6 @@ enum max96712_pattern { =20 struct max96712_info { unsigned int dpllfreq; - bool have_debug_extra; }; =20 struct max96712_priv { @@ -174,9 +173,7 @@ static void max96712_pattern_enable(struct max96712_pri= v *priv, bool enable) return; } =20 - /* Set PCLK to 75MHz if device have DEBUG_EXTRA register. */ - if (priv->info->have_debug_extra) - max96712_write(priv, DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); + max96712_write(priv, DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); =20 /* Configure Video Timing Generator for 1920x1080 @ 30 fps. */ max96712_write_bulk_value(priv, 0x1052, 0, 3); @@ -457,7 +454,6 @@ static void max96712_remove(struct i2c_client *client) =20 static const struct max96712_info max96712_info_max96712 =3D { .dpllfreq =3D 1000, - .have_debug_extra =3D true, }; =20 static const struct max96712_info max96712_info_max96724 =3D { --=20 2.34.1 From nobody Fri Dec 19 04:54:34 2025 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2056.outbound.protection.outlook.com [40.107.247.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D09F215700; Fri, 20 Dec 2024 12:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698174; cv=fail; b=MSeoXdJm3qO8wUeo4RzjHc6sXyRHdZZcFYfC0hUFLY9+XWOALHaDfRbEzn8gM3GIrdaPY6PfXqoyjTCOMyCMoO9ekw15o1fkAi61z84p1OxLxO6qPc6b5JRmKWzpRm24/pH2hO9HxPE7KlgZN0Kc8VEG1tdsyABdGv96gjTYnr0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734698174; c=relaxed/simple; bh=d7rx16iuunYyzwYqV5f76SdIYc6rma3RKAlhk1WP09Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mREozNCkSNNOZZztiAyfwUH+qQP+nv7lBYPa/LTENa/yj+En6oQziM75je63iWUAjHdXDjnHDPrm6yrXfYTYYyF2AtBl0IpUws8tklNaz7A5cbVREe3Sr8dmEIxjw9MXAyRXqIbqdt5PhIFtY+EnqW2pJSf9wOst8yOl1CePQG8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=i1SdScFi; arc=fail smtp.client-ip=40.107.247.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="i1SdScFi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RqQQ68d7eYqtRJQZvyEh63W2yVWx1N/8YHrJHCBNAjTm9Bkppy8KSMbn9Am+c+9iasW+wgChtTk2XBXGebEBQrXcRW+JQwDcU08uXZNA00bO7hLo6St3FMzVnQwRBMJ4bh+/7CXa2st2EwNicSiS7KZ8H6xMswNK6HFSIr50vRqqldUzzjb0MrLebDB3Fp9MKcZwkIgfWIbrAGEAPnoa38R9xbPpecGAN87F4WGE67VJUJrhocKgkwZ/SJ8me3aufc6tw9gA8Rouc7sp6GHmbykDLe+w1jtV8s2sAZH4nwKFMQ3gOFaXZKI9SgfKUGEm36ZDhXrnUS7iAux/92xIbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5mepgUvYk1Ss+E7HkK/KQ1om12+km3pIIRhGaSIFfhY=; b=SF/OpHsNthOi1eKOFy2AbEcl8/XWDHAV7wzv0C+5u2azJ1wX++F68v7EGJ0cjwQmFma2OeNWc8O0Er4HhM1DTXhCTmedoheajNBz/bRNBN0v8+5xJq+Zucy9Tn3qI57tznqfRsVM7grkUpk1o80kiuMEauf3ao0RE9yRG+CGHtPno2mvMipmuGX6wKVPhtkDnVF4PAWmunWwGs5P4em8gKXJvYb0ti27N5LtahNDRRttCPHxuB1jiMu83dJ+M11Pu109mn5ik5V3ce8q+SECyfCNWcWY+8i/BulCHELcEO4velKDnzsZYmBF7F23gRBT8FUZW2vJPvijsLw5pVXAsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5mepgUvYk1Ss+E7HkK/KQ1om12+km3pIIRhGaSIFfhY=; b=i1SdScFinchwyzY/fAqdhJe7gx5XJNCegn/+2s2NkViyaVffhtc2OwwHLWWfbkprdIU29D7pEnzrECk+E2C+E++pIMca4rlEzRXkZZ9/sHn264e6pTuR2fnfFAOYOEUBgVQISiSsf0A0fkT8d8nsPNfsfVf9u2ov0vFjzkOcYxNo1SBE9IOf9DpKPorrMbOhYKrN6ozwPMpU5yDvd+BlUTsh1PyJNcjHOBF/+FKIXc+RkqRUbGVSNwmffOf6dUm9pxGWlcj37XDjpnUiZIGXhMDxhJR1P41Mj6ovKY+eFwYjPszytX6wWYSgdn7nK42JEoWOx7kF+9o6ti719CslTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) by GVXPR04MB10047.eurprd04.prod.outlook.com (2603:10a6:150:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Fri, 20 Dec 2024 12:36:08 +0000 Received: from AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30]) by AS4PR04MB9576.eurprd04.prod.outlook.com ([fe80::9cf2:8eae:c3d1:2f30%4]) with mapi id 15.20.8272.005; Fri, 20 Dec 2024 12:36:08 +0000 From: Laurentiu Palcu To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Laurentiu Palcu , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 3/3] staging: media: max96712: add some register and field definitions Date: Fri, 20 Dec 2024 14:35:50 +0200 Message-Id: <20241220123551.696330-4-laurentiu.palcu@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> References: <20241220123551.696330-1-laurentiu.palcu@oss.nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0094.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::47) To AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR04MB9576:EE_|GVXPR04MB10047:EE_ X-MS-Office365-Filtering-Correlation-Id: 5255676f-3e32-44e2-eb22-08dd20f2e0a7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aTVHdGJ5RUttK1UrMklkT3IzWjd5MmFaL0lNWkxpcjl6U2l2NmcwSDVmTm9t?= =?utf-8?B?Q3NKOWo0T2hXaFJPcWlHSk9jYU5Mb29qOXZCKzd1Wk5hMSs2eU5ScXJuYlZj?= =?utf-8?B?cUdyQWM5ZDNwanQzNFBNTXJhM2xUV2J0dG40Qi9pcUJQU1BmN0lDZ2FTM2pj?= =?utf-8?B?cGttUDBPdmNhOVlBK3J1Mkt5SnpENFJhZ0FWcUt6QUxMeTc0dFFucXRLbjJW?= =?utf-8?B?MHM0YVc2NEJKQ2VFMmE0Z2V1UzFFdVY3clhISkcwRmVSZzlLNFhwVldvU21T?= =?utf-8?B?U294Z01TYjUxejlmV0NVcmpWRFUwYytwUHNYMWpZNjhwemYxOStIVUcwczVZ?= =?utf-8?B?UFZDbWdFTlZ4cHExaDE2eVkzTkoxRzlSRENwbHRGOE8zS2FUMTFVZDNYTHVq?= =?utf-8?B?OFVBcndObTBnVk4ySHBqMkt4WG9Sb1pSU1ROZG5OdGRLbFJHRDlTYWYwellV?= =?utf-8?B?cVFiQzlmeEZBYWVJTGU4ZDJKZDVaa0FJbFdmSnVKR080YXVSdjhBRWt1RnZa?= =?utf-8?B?VHhlK3FYWDU3Nm44MWIyUDVSdW16T2xZbHFIRlYzQXBKV0tXODVxWkZsdTQ0?= =?utf-8?B?YnJTVWx3K1o0WkJ1bjZIYjBRSlhLMjhKdUtFdWdtK3hlN0k0QzZCRzBBNXVn?= =?utf-8?B?d2lHS1Bvakxhdm84WU1TZk1qZm54cnJ5akdjR09VYlU2b1NITlJVbVA4a2Ey?= =?utf-8?B?aHI0cHV0aHo5YUpXR3htTkxSV1FjVk1udExKemFoYjltRlNxMUc0a25jN1Rv?= =?utf-8?B?OUg3NktMV1NobWdXdlE4aHh4cnc2cUtGWVdSbGMwWDF4cXkwcEt0ZkhPQm9Z?= =?utf-8?B?NEtRQmlKSll4SnBQZDl6M0Q3NU5jMzlJaUNFNXhmK1ZjL2hZa2VPamFDRk81?= =?utf-8?B?WC81REhnVDFCakJQaHJUczlSeTltS1dOMnpIZVVtYWpPb2cySUlTWUx3aUxV?= =?utf-8?B?ZTRLNzgrTzh4bTJDSzNHcGZlNEZQRzFWQkppOEgzNWt1all4MzFwRVE3YzA0?= =?utf-8?B?dzlBaDlHTUpOYW5wUmRqOW5EMnk3TTV2d255TUNRa3p6Q0hLWkpzVU4zYktL?= =?utf-8?B?NVFIbk5PMVFLWlVVdXhldkZSU252MDlsUmJmY2FoUk1RTk9SR0ZDTUJhRjFh?= =?utf-8?B?WTU0cWZzSC9OR0VOMUp2Y1dhNzVHUTgzSFBPOGNmMXUraUNaT2w0U1g5NGV2?= =?utf-8?B?OWlkV21pcmZ1OG8rL0ZCY21VeXNXRWpudEpLN0RIWUczMDU3SFF3Y2o1dFZY?= =?utf-8?B?ajNqSWh6YTgyc1h5UXpEK05VNGlMejJDUGJjSTNjMVZmSklIV1hGc0ZVQVhO?= =?utf-8?B?YkQ3Z0NjMUNCakl1ZmtmS3I2dkw5Nmk3RG5Yc0F3SUltWE1NbGp4clRHK2dZ?= =?utf-8?B?QmZaVDBENkZwQ24zR2lwNFQ1SThUS2ZUV2VoOSsra1d5UlRoKzBHQkhUOWZK?= =?utf-8?B?TVNud3RReFJwVWNmYmJGNzVlbDJuaGZaWDJNQTdyTElaNlo0cmlhcEFHTnFo?= =?utf-8?B?WDU2Y1UvS1pwdFQxeWptbmloTk1Xa0tJSXlmcEJPMVNYc04wZnNueEtVUE9W?= =?utf-8?B?bzVYTG1sanpzdWNaNjUxL1ZsNGorYkJpY0hnbXd3amFmM1ZXTVR6RDMrRWJ0?= =?utf-8?B?S3hHSm9LUlE5Y0xoMElVQTU4c1plS29uNUY3L0VaWldFNVpkZnlpZ0lrektz?= =?utf-8?B?aFZGY2NDdVBsUkNUdjRrc1VIOUhkek5vME95STgwWmJPTldGU0FiRVhhK2No?= =?utf-8?B?QmxFVXN0clRweWZrVEVZWHFOTU9DeGdBY1RqeUFqSFI2UDhRTUFkVjBJanVs?= =?utf-8?B?WUhEWVQwZGVUeTA2K2paeWMvdE5PTHdBaW9VWGpabGFPQUs2M0xqeGtlL0VY?= =?utf-8?Q?ILcZmnqyoSIJk?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR04MB9576.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjhnOGEwUjNPb1kyRVFxZWRCWW1nS3FFT0JGU3lka1p5SFNkY3RRRGVCbEV1?= =?utf-8?B?bHBLamE2dTBRMGVPbmFlbFY0L1Y3c0dWeVBGV25iREo3N05RdHUybkhpdUZl?= =?utf-8?B?RE1Qa0x3N2RMRDFlOWJOMWw0MnJLTXgzMk92a1Y3T2hBc0ltNXBUWENDNkcv?= =?utf-8?B?VWJtMnorMW9IM0NUbHV5aHpJQ1BYd29wSWNMaCtxeC8zbWNtajFsRjcwYzBp?= =?utf-8?B?aGRaZlVsa3Vnb3ZmNTl1RXdVZDhOZzhSVzZaRVRNNTNWeEZNaHBRczBxYXZB?= =?utf-8?B?NW4wdjdKY3FqaDJZQWVJUVk1OEtiUUl3VTMxc3cxcHQ5L2xoNlJKT09YS0FZ?= =?utf-8?B?dFRxR0xqS1VTVjhBYXZoWlk5ZDQxL3Jpay9KenZqREsxa3lEekVraVMyYVhl?= =?utf-8?B?bWJoak5MYTd1R09SQzUvYWlQZHNjcFplS0VOa3pLUXdFakI3UGpFN0RuU084?= =?utf-8?B?anA2ejl2aERJdGxpMU5TbXNGUU5kRlo2dEY1WUZtb0IrNTZKY0pYQ1pvRVpV?= =?utf-8?B?V3pTcVNUdU91dXJxOGl4OGJ0ZkpnVU9NNXhkMmZ2SnRTZDByNDB1ZG4vclU0?= =?utf-8?B?eFJHZVhVV0RRZDNBZll1ZDVsSU1BZ3oxYXBHRmszUm1XYmlQdkJaMytIS1Jw?= =?utf-8?B?UjF0NHpIclZnLzRLMXQvTWxvSnhWS1owOFF2a3lPOE5sNy9ueEhwaGo1Z2VB?= =?utf-8?B?cG5EWitTZlA0aTlXMTgrczdBWW52WmJMOGVKYWYyeldwUGFucFZnenliZFRi?= =?utf-8?B?VUFCL2xZVS9INTBNV1NFNEFmVk1YQlFHNElMeHN2SEZFaHh0MDFONko1Zytj?= =?utf-8?B?SkZmNVJxMWR5MXZPUnhMZ1dqUzh1VUxzZ2VZWHRVWWRkTXJ0UXF3NDhiNzBt?= =?utf-8?B?UGRFSHFRc2xMS2JuTGlqdWMxVXVtVjZMQi84Qm0vNDlYQ0svbU1VY0lBMjR2?= =?utf-8?B?OVhRenozdlYxMkZROWZVLytOZkZFSTY1QllNTVVHMU94TkdOaEFGOFNWVEt2?= =?utf-8?B?aTlaTG91aFpqTWVTYUx1TGxEYm5CV1V3K3ZIR3NBY0xudVdmYldMOXdJNUpQ?= =?utf-8?B?ZTNKNHk1QS9hcHh1U204cmZ4QzdWWHA1ZE5YTnZoTUY4T0tadkl2QmZLdmc1?= =?utf-8?B?dDZVTjJFcHJuTk1pYU1STXNVdEp3YTBsRldqZHVZSWd2WnVRWloxOU9HTFVo?= =?utf-8?B?dWF4VnVpM0dnOC91UVZrSnY3Z3hsYlFRT2JtN3RneGEyQXk3QVdDVmVNOG0z?= =?utf-8?B?MDhTcXR3VDRpTXpSVnVOdnJ2YUxsTC91NEE2ekN3akhkNEN6Y1ozRk9HMVF3?= =?utf-8?B?eXBycVFCTzF1RHZVcEd4VXdEdm1kZjhNZU5BS2RVQUtBN0pyT05pYlpURUhD?= =?utf-8?B?bS93NnYrN1IrSENETlphS2lTNlNJQWhsMmptanFhOW9YSmVXSE1zTzBFYk13?= =?utf-8?B?MWxRT2ZnY1czN2xQbVpoQmlQVW9PNVZZU0JLU1JBVTFNMVF4SjVvOVNuMktU?= =?utf-8?B?cTdPK2N0ampUMmJtb3NOUWs1Q2tWeGZyZUtIOFdyNU5NWExWMHpCekJISU9j?= =?utf-8?B?UlZDdDJKUlpQUTVIUzAwa1VCRUdMV01ZL1ZMYkVTT3ZIVE1vZnF4MktrNmsz?= =?utf-8?B?MXF2SVBISEVxSkdiY041anhzTTdYWGFzSDVvL3FUcGpTWHBIYzFkUzk3VnA5?= =?utf-8?B?WjlhMjFwdEZFSGZqT1FsMFVFYktHeWFJd3dHVCtyQkNvcG1GNGE3RE0wc0xB?= =?utf-8?B?Y3crWjdZOU5yR0NqcXNCZEd3SG9TK3VXQWIyOU9nZVA1KzBNOVZ4MENXQXAw?= =?utf-8?B?UXJmVDNEazhDSU16MUZYTE5uVkYwWjc3a24xSmpKR1UzekttaUJvUEJiVXpP?= =?utf-8?B?QkhSbkhFSExjTFBtVUV4dnVQZ3pzZ2o4cWN3YUlTQStDRzR3RUlxQXoyVHVK?= =?utf-8?B?MkZjL1M3Zklhb25FQ2sxaTZqSWU2MzN5R3o3YTdYWTZzTEJFVEhPajJDTjND?= =?utf-8?B?aUxMdjVvMjFyN1o1Z2IrenlEdURaNlZ6bW9pa1M2bDVOY0U0b3pPckxWc1FR?= =?utf-8?B?cSt6OEtMSU5tOHF4YnFDSWNQcG5WYVhGbFVtSUtRZzl3NEJSQ1BBd253bnVn?= =?utf-8?B?QTkvTGZNMnYwQ29pRUV5RmlndVBpRThLOTBWV1F0eFN3UVFCOW8vTkl3clUv?= =?utf-8?B?c0E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5255676f-3e32-44e2-eb22-08dd20f2e0a7 X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9576.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2024 12:36:08.1294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ye5iJTi/nGHVV3Z186I0aaAhEA6Fz7ZS/dTJttrFUnzWaYp5NnBp5wAxl6iyFfuDxBD0bHt80L4UxJ2AlS4lqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10047 Most of the registers in the driver, and their values, are hard-coded which makes the code rather difficult to read and maintain. Add register and field definitions and use them to replace the hard-coded values where possible. This patch does not change the driver functionality or its structure. Signed-off-by: Laurentiu Palcu Reviewed-by: Niklas S=C3=B6derlund --- drivers/staging/media/max96712/max96712.c | 207 +++++++++++++++++----- 1 file changed, 163 insertions(+), 44 deletions(-) diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/me= dia/max96712/max96712.c index ed4d5db1ff8d1..47842facec125 100644 --- a/drivers/staging/media/max96712/max96712.c +++ b/drivers/staging/media/max96712/max96712.c @@ -16,9 +16,118 @@ #include #include =20 -#define DEBUG_EXTRA_REG 0x09 -#define DEBUG_EXTRA_PCLK_25MHZ 0x00 -#define DEBUG_EXTRA_PCLK_75MHZ 0x01 +/* TOP_CTRL */ +#define MAX96712_DEBUG_EXTRA_REG 0x0009 +#define DEBUG_EXTRA_PCLK_25MHZ 0x00 +#define DEBUG_EXTRA_PCLK_75MHZ 0x01 +#define MAX96724_TOP_CTRL_PWR1 0x0013 +#define RESET_ALL BIT(6) + +/* BACKTOP0 */ +#define MAX96712_BACKTOP0_12 0x040b +#define CSI_OUT_EN BIT(1) +#define SOFT_BPP_0_MASK GENMASK(7, 3) +#define SOFT_BPP_0_SHIFT 3 +#define MAX96712_BACKTOP0_22 0x0415 +#define MAX96712_BACKTOP0_25 0x0418 +#define PHY_CSI_TX_DPLL_PREDEF_FREQ_MASK GENMASK(4, 0) +#define PHY_CSI_TX_DPLL_PREDEF_FREQ_SHIFT 0 +#define PHY_CSI_TX_DPLL_FB_FRACTION_PREDEF_EN BIT(5) +#define OVERRIDE_BPP_VC_DT_0_2 BIT(6) +#define OVERRIDE_BPP_VC_DT_1_3 BIT(7) + +/* MIPI_PHY */ +#define MAX96712_MIPI_PHY_0 0x08a0 +#define PHY_4X2 BIT(0) +#define PHY_2X4 BIT(2) +#define PHY_1X4A_22 BIT(3) +#define PHY_1X4B_22 BIT(4) +#define FORCE_CLK0_EN BIT(5) +#define FORCE_CLK3_EN BIT(6) +#define FORCE_CSI_OUT_EN BIT(7) +#define MAX96712_MIPI_PHY_2 0x08a2 +#define T_HS_TRAIL_MASK GENMASK(1, 0) +#define T_HS_TRAIL_SHIFT 0 +#define T_LPX_MASK GENMASK(3, 2) +#define T_LPX_SHIFT 2 +#define PHY_STDBY_N_MASK GENMASK(7, 4) +#define PHY_STDBY_N_SHIFT 4 +#define PHY0_EN BIT(4) +#define PHY1_EN BIT(5) +#define PHY2_EN BIT(6) +#define PHY3_EN BIT(7) +#define MAX96712_MIPI_PHY_3 0x08a3 +#define PHY0_LANE_MAP_MASK GENMASK(3, 0) +#define PHY0_LANE_MAP_SHIFT 0 +#define PHY1_LANE_MAP_MASK GENMASK(7, 4) +#define PHY1_LANE_MAP_SHIFT 4 +#define MAX96712_MIPI_PHY_5 0x08a5 +#define PHY0_POL_MAP_MASK GENMASK(2, 0) +#define PHY0_POL_MAP_SHIFT 0 +#define PHY1_POL_MAP_MASK GENMASK(5, 3) +#define PHY1_POL_MAP_SHIFT 3 +#define T_CLK_PREP_MASK GENMASK(7, 6) +#define T_CLK_PREP_SHIFT 6 +#define MAX96712_MIPI_PHY_13 0x08ad +#define T_T3_PREBEGIN_MASK GENMASK(5, 0) +#define T_T3_PREBEGIN_SHIFT 0 +#define MAX96712_MIPI_PHY_14 0x08ae +#define T_T3_PREP_MASK GENMASK(1, 0) +#define T_T3_PREP_SHIFT 0 +#define T_T3_PREP_40NS 0 +#define T_T3_PREP_55NS 1 +#define T_T3_PREP_66_7NS 2 +#define T_T3_PREP_86_7NS 3 +#define T_T3_POST_MASK GENMASK(6, 2) +#define T_T3_POST_SHIFT 2 + +/* MIPI_TX: 0 <=3D phy < 4 */ +#define MAX96712_MIPI_TX_10(phy) (0x090a + (phy) * 0x40) +#define CSI2_TWAKEUP_H_MASK GENMASK(2, 0) +#define CSI2_TWAKEUP_H_SHIFT 0 +#define CSI2_VCX_EN BIT(4) +#define CSI2_CPHY_EN BIT(5) +#define CSI2_LANE_CNT_MASK GENMASK(7, 6) +#define CSI2_LANE_CNT_SHIFT 6 + +/* VRX_PATGEN */ +#define MAX96712_VRX_PATGEN_0 0x1050 +#define VTG_MODE_MASK GENMASK(1, 0) +#define VTG_MODE_SHIFT 0 +#define VTG_MODE_VS_TRACKING 0 +#define VTG_MODE_VS_TRIGGER 1 +#define VTG_MODE_AUTO_REPEAT 2 +#define VTG_MODE_FREE_RUNNING 3 +#define DE_INV BIT(2) +#define HS_INV BIT(3) +#define VS_INV BIT(4) +#define GEN_DE BIT(5) +#define GEN_HS BIT(6) +#define GEN_VS BIT(7) +#define MAX96712_VRX_PATGEN_1 0x1051 +#define VS_TRIG BIT(0) +#define PATGEN_MODE_MASK GENMASK(5, 4) +#define PATGEN_MODE_SHIFT 4 +#define PATGEN_MODE_CHECKERBOARD (1 << PATGEN_MODE_SHIFT) +#define PATGEN_MODE_GRADIENT (2 << PATGEN_MODE_SHIFT) +#define GRAD_MODE BIT(7) +#define MAX96712_VRX_PATGEN_VS_DLY 0x1052 +#define MAX96712_VRX_PATGEN_VS_HIGH 0x1055 +#define MAX96712_VRX_PATGEN_VS_LOW 0x1058 +#define MAX96712_VRX_PATGEN_V2H 0x105b +#define MAX96712_VRX_PATGEN_HS_HIGH 0x105e +#define MAX96712_VRX_PATGEN_HS_LOW 0x1060 +#define MAX96712_VRX_PATGEN_HS_CNT 0x1062 +#define MAX96712_VRX_PATGEN_V2D 0x1064 +#define MAX96712_VRX_PATGEN_DE_HIGH 0x1067 +#define MAX96712_VRX_PATGEN_DE_LOW 0x1069 +#define MAX96712_VRX_PATGEN_DE_CNT 0x106b +#define MAX96712_VRX_PATGEN_GRAD_INCR 0x106d +#define MAX96712_VRX_PATGEN_CHKR_COLOR_A 0x106e +#define MAX96712_VRX_PATGEN_CHKR_COLOR_B 0x1071 +#define MAX96712_VRX_PATGEN_CHKR_RPT_A 0x1074 +#define MAX96712_VRX_PATGEN_CHKR_RPT_B 0x1075 +#define MAX96712_VRX_PATGEN_CHKR_ALT 0x1076 =20 enum max96712_pattern { MAX96712_PATTERN_CHECKERBOARD =3D 0, @@ -96,18 +205,18 @@ static int max96712_write_bulk_value(struct max96712_p= riv *priv, =20 static void max96712_reset(struct max96712_priv *priv) { - max96712_update_bits(priv, 0x13, 0x40, 0x40); + max96712_update_bits(priv, MAX96724_TOP_CTRL_PWR1, RESET_ALL, RESET_ALL); msleep(20); } =20 static void max96712_mipi_enable(struct max96712_priv *priv, bool enable) { if (enable) { - max96712_update_bits(priv, 0x40b, 0x02, 0x02); - max96712_update_bits(priv, 0x8a0, 0x80, 0x80); + max96712_update_bits(priv, MAX96712_BACKTOP0_12, CSI_OUT_EN, CSI_OUT_EN); + max96712_update_bits(priv, MAX96712_MIPI_PHY_0, FORCE_CSI_OUT_EN, FORCE_= CSI_OUT_EN); } else { - max96712_update_bits(priv, 0x8a0, 0x80, 0x00); - max96712_update_bits(priv, 0x40b, 0x02, 0x00); + max96712_update_bits(priv, MAX96712_MIPI_PHY_0, FORCE_CSI_OUT_EN, 0x00); + max96712_update_bits(priv, MAX96712_BACKTOP0_12, CSI_OUT_EN, 0x00); } } =20 @@ -119,39 +228,47 @@ static void max96712_mipi_configure(struct max96712_p= riv *priv) max96712_mipi_enable(priv, false); =20 /* Select 2x4 mode. */ - max96712_write(priv, 0x8a0, 0x04); + max96712_write(priv, MAX96712_MIPI_PHY_0, PHY_2X4); =20 /* TODO: Add support for 2-lane and 1-lane configurations. */ if (priv->cphy) { - /* Configure a 3-lane C-PHY using PHY0 and PHY1. */ - max96712_write(priv, 0x94a, 0xa0); + /* Configure a 3-lane C-PHY using PHY1. */ + max96712_write(priv, MAX96712_MIPI_TX_10(1), + (2 << CSI2_LANE_CNT_SHIFT) | CSI2_CPHY_EN); =20 /* Configure C-PHY timings. */ - max96712_write(priv, 0x8ad, 0x3f); - max96712_write(priv, 0x8ae, 0x7d); + max96712_write(priv, MAX96712_MIPI_PHY_13, 0x3f); + max96712_write(priv, MAX96712_MIPI_PHY_14, + (0x1f << T_T3_POST_SHIFT) | T_T3_PREP_55NS); } else { - /* Configure a 4-lane D-PHY using PHY0 and PHY1. */ - max96712_write(priv, 0x94a, 0xc0); + /* Configure a 4-lane D-PHY using PHY1. */ + max96712_write(priv, MAX96712_MIPI_TX_10(1), 3 << CSI2_LANE_CNT_SHIFT); } =20 /* Configure lane mapping for PHY0 and PHY1. */ /* TODO: Add support for lane swapping. */ - max96712_write(priv, 0x8a3, 0xe4); + max96712_write(priv, MAX96712_MIPI_PHY_3, 0xe4); =20 /* Configure lane polarity for PHY0 and PHY1. */ for (i =3D 0; i < priv->mipi.num_data_lanes + 1; i++) if (priv->mipi.lane_polarities[i]) phy5 |=3D BIT(i =3D=3D 0 ? 5 : i < 3 ? i - 1 : i); - max96712_write(priv, 0x8a5, phy5); + max96712_write(priv, MAX96712_MIPI_PHY_5, phy5); =20 /* Set link frequency for PHY0 and PHY1. */ - max96712_update_bits(priv, 0x415, 0x3f, - ((priv->info->dpllfreq / 100) & 0x1f) | BIT(5)); - max96712_update_bits(priv, 0x418, 0x3f, - ((priv->info->dpllfreq / 100) & 0x1f) | BIT(5)); + max96712_update_bits(priv, MAX96712_BACKTOP0_22, + PHY_CSI_TX_DPLL_FB_FRACTION_PREDEF_EN | + PHY_CSI_TX_DPLL_PREDEF_FREQ_MASK, + PHY_CSI_TX_DPLL_FB_FRACTION_PREDEF_EN | + ((priv->info->dpllfreq / 100) & 0x1f)); + max96712_update_bits(priv, MAX96712_BACKTOP0_25, + PHY_CSI_TX_DPLL_FB_FRACTION_PREDEF_EN | + PHY_CSI_TX_DPLL_PREDEF_FREQ_MASK, + PHY_CSI_TX_DPLL_FB_FRACTION_PREDEF_EN | + ((priv->info->dpllfreq / 100) & 0x1f)); =20 /* Enable PHY0 and PHY1 */ - max96712_update_bits(priv, 0x8a2, 0xf0, 0x30); + max96712_update_bits(priv, MAX96712_MIPI_PHY_2, PHY_STDBY_N_MASK, PHY0_EN= | PHY1_EN); } =20 static void max96712_pattern_enable(struct max96712_priv *priv, bool enabl= e) @@ -169,49 +286,51 @@ static void max96712_pattern_enable(struct max96712_p= riv *priv, bool enable) const u32 v_tot =3D v_active + v_fp + v_sw + v_bp; =20 if (!enable) { - max96712_write(priv, 0x1051, 0x00); + max96712_write(priv, MAX96712_VRX_PATGEN_1, 0x00); return; } =20 - max96712_write(priv, DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); + max96712_write(priv, MAX96712_DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); =20 /* Configure Video Timing Generator for 1920x1080 @ 30 fps. */ - max96712_write_bulk_value(priv, 0x1052, 0, 3); - max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3); - max96712_write_bulk_value(priv, 0x1058, + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_VS_DLY, 0, 3); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_VS_HIGH, v_sw * h_tot= , 3); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_VS_LOW, (v_active + v_fp + v_bp) * h_tot, 3); - max96712_write_bulk_value(priv, 0x105b, 0, 3); - max96712_write_bulk_value(priv, 0x105e, h_sw, 2); - max96712_write_bulk_value(priv, 0x1060, h_active + h_fp + h_bp, 2); - max96712_write_bulk_value(priv, 0x1062, v_tot, 2); - max96712_write_bulk_value(priv, 0x1064, + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_V2H, 0, 3); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_HS_HIGH, h_sw, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_HS_LOW, h_active + h_= fp + h_bp, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_HS_CNT, v_tot, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_V2D, h_tot * (v_sw + v_bp) + (h_sw + h_bp), 3); - max96712_write_bulk_value(priv, 0x1067, h_active, 2); - max96712_write_bulk_value(priv, 0x1069, h_fp + h_sw + h_bp, 2); - max96712_write_bulk_value(priv, 0x106b, v_active, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_DE_HIGH, h_active, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_DE_LOW, h_fp + h_sw += h_bp, 2); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_DE_CNT, v_active, 2); =20 /* Generate VS, HS and DE in free-running mode. */ - max96712_write(priv, 0x1050, 0xfb); + max96712_write(priv, MAX96712_VRX_PATGEN_0, + GEN_VS | GEN_HS | GEN_DE | VS_INV | HS_INV | + (VTG_MODE_FREE_RUNNING << VTG_MODE_SHIFT)); =20 /* Configure Video Pattern Generator. */ if (priv->pattern =3D=3D MAX96712_PATTERN_CHECKERBOARD) { /* Set checkerboard pattern size. */ - max96712_write(priv, 0x1074, 0x3c); - max96712_write(priv, 0x1075, 0x3c); - max96712_write(priv, 0x1076, 0x3c); + max96712_write(priv, MAX96712_VRX_PATGEN_CHKR_RPT_A, 0x3c); + max96712_write(priv, MAX96712_VRX_PATGEN_CHKR_RPT_B, 0x3c); + max96712_write(priv, MAX96712_VRX_PATGEN_CHKR_ALT, 0x3c); =20 /* Set checkerboard pattern colors. */ - max96712_write_bulk_value(priv, 0x106e, 0xfecc00, 3); - max96712_write_bulk_value(priv, 0x1071, 0x006aa7, 3); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_CHKR_COLOR_A, 0xfecc= 00, 3); + max96712_write_bulk_value(priv, MAX96712_VRX_PATGEN_CHKR_COLOR_B, 0x006a= a7, 3); =20 /* Generate checkerboard pattern. */ - max96712_write(priv, 0x1051, 0x10); + max96712_write(priv, MAX96712_VRX_PATGEN_1, PATGEN_MODE_CHECKERBOARD); } else { /* Set gradient increment. */ - max96712_write(priv, 0x106d, 0x10); + max96712_write(priv, MAX96712_VRX_PATGEN_GRAD_INCR, 0x10); =20 /* Generate gradient pattern. */ - max96712_write(priv, 0x1051, 0x20); + max96712_write(priv, MAX96712_VRX_PATGEN_1, PATGEN_MODE_GRADIENT); } } =20 --=20 2.34.1