From nobody Sun Feb 8 19:03:07 2026 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238EA13AA35 for ; Fri, 20 Dec 2024 08:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734682963; cv=none; b=J1oVfuLGbJkp2bGvQTqhoFYadnsK9sAxMv/2bjsiUmEFhYW8Wa91cKdsneVS+fMcbOaZpASw3U1EqQ/KDgH0DV/SiBKhHTRs03jQqLq7NaZGTslJxksiqVKJbYW9jXi2hpAWX2NjnsCPcbJssyZiP3vJzj6vgU1lNNpkJUf7Vck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734682963; c=relaxed/simple; bh=0OC55Al4J0J7rKt8QDIR7HjE47S5GI/De2AjS2HTTyI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kzKq1hHzkAAadEaOWlKAUojCQLxyNS70WaBrCLnNVq8LQNW9GoK6ktWjxRCDaTvHLZq8FSU7GLPJkHjVv21uXpzbl3z7WaMnMnZyLdWf1Yfg/+rxbzYu19W/w6VV4gxr6bVt2AUz2Tfemxd06DT38j3fOzjviqHFYhde5yM5IWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=egiE2J2e; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="egiE2J2e" Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 7E9B33F84D for ; Fri, 20 Dec 2024 08:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1734682953; bh=ZKWxqv+/d/UlGXH+lUF4T34EylRckkfoJKBfUXiLv0Q=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=egiE2J2e6yZLLbkEBiGyXih8cF2H17+a9WefKzEklYz9n6r970vd0aWx2nWMTlaLb g7or3YwuesAR8s3iIPZEwikOKWhYry7Ka7o2ofgJpKVoyx9404C5coqLuhzrhaiGGb 34FTyWIa6GOQmgEEDQ/7f+raEPNaZHoYPtBAwUOm155u9HytCPx77HmnQgvbqfW73Q hExLHSqcZWBW10q/Usyb/34YvRnSFeNzL+Z0fs1LkE3uaow/7oMD2Xkce7dt8gvz4U yaCQHQSGAP2T8ohgdkbRpelPPGSy/sjANe4dN8XdIUCGG0f4x+tjEmd81R1dFVfcvL gaE6nbthTTSHQ== Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-7f8af3950ecso1199611a12.3 for ; Fri, 20 Dec 2024 00:22:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734682950; x=1735287750; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZKWxqv+/d/UlGXH+lUF4T34EylRckkfoJKBfUXiLv0Q=; b=Zdsm9JAcLcQIAPi6YShDfFzPhfoUdL7yVDeAUQQPZ2XP52KJKfNTC2eNUAgIC84vE0 JCLClWu06XGfcavADj3gzgKs22qJ67vLlD0nHkmmKJwANkDbVY22qKuWfHFHxwH4xT70 f35sYjbE0QWoRECGDxTAmRR0dNMfuRSpUa6eP9ZAfGh8DDcMOkuKRwJ0g5ijdgQvTidU Vs1kZDmrpVgpa5Jy99qxOJF1HtDQ+fBQwv8X2nsDO6u34Mb1vb8TaiMv/sN8mFjpABcj oed3hPISm+kpWL4SCvEhyQaudVx3p62TKiOA8CrR2pKxGdbYFuBtRGA+fVVem7NTiRrx cp5g== X-Forwarded-Encrypted: i=1; AJvYcCXe85rNULZ4l6B9ffa/GJcVln4pURYpwwGbCz+mEUNRCOusY8TF7tpgGaiJhy1UJBCNEHTgvbBVkGMouMQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn6J/BeqTih1E0B92OpWdUeTHHObAb0n9qVjC/TnFqzdsXmWb3 vYwKQdvbKFYe7enK9NrxGP+M2bbNQ4upNSdkeEGeCjHgIpJ0NaQPVbzQSo0H0wR2jfbVeQQKPBr ib+b2lNzYqzpaXT7lNTtsemF5WXfYV7iFKCFXyEvmmadz2GcHODGbSmOfwuxV0e29G8m92wOVCR 2nGA== X-Gm-Gg: ASbGncsr/y/1Ha9N3iijGQtfdx8/nbWzsVoRBrwuzxlpG+EVuYbJvYdUGpAK7V/ulkN dykJt0vjUTw2G/HPSFBD7f+CtgnEhQtMRxbU8SoCYuRiq5Xq2RGZWqfCaaJjxQeKXCxNgyizMEJ w2Ag/NABZb6ZylVz5l5Gem/9Pn6VlvsP7I9srBrlv5otw7uO07/2b+JxNaRzArGD2SFksoMM2WW Fv6mTwWtgwljgHWBWKcs55mQ/kWDyZFQml+Kh29ddt1zRdf5raGRsW5B30x4Gnn6B0t52gx5xjF mrPd2RFqi9EoKsej2w+aDzLtxul5g615zewEz2lBk7/ZYmlKMMBFzEa8UNw= X-Received: by 2002:a05:6a20:6a25:b0:1d9:18af:d150 with SMTP id adf61e73a8af0-1e5e05a9e39mr3675552637.21.1734682950649; Fri, 20 Dec 2024 00:22:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFm7GX+pP1g923C5hQQ0a9bh32CJGMl4Fogybf96/cjd8Uk0Kyt2ntUkVZ/cENoayYT+cCTTw== X-Received: by 2002:a05:6a20:6a25:b0:1d9:18af:d150 with SMTP id adf61e73a8af0-1e5e05a9e39mr3675527637.21.1734682950294; Fri, 20 Dec 2024 00:22:30 -0800 (PST) Received: from rickywu0421-ThinkPad-X1-Carbon-Gen-11.. (118-163-61-247.hinet-ip.hinet.net. [118.163.61.247]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad90e439sm2567942b3a.178.2024.12.20.00.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 00:22:29 -0800 (PST) From: En-Wei Wu To: marcel@holtmann.org, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Bluetooth: btusb: Add NULL check for data in btusb_suspend Date: Fri, 20 Dec 2024 16:22:25 +0800 Message-ID: <20241220082225.1064236-1-en-wei.wu@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When performing warm boot tests with an MT7920 device, we encounter NULL pointer dereference with failure rate 5/30. The crash occurs during device suspend when btusb attempts to access data->hdev where data is NULL. This may happen due to a race condition between PM suspend and device disconnect. The root cause needs further investigation. BUG: kernel NULL pointer dereference, address: 0000000000000000 Workqueue: pm pm_runtime_work RIP: 0010:btusb_suspend+0x1d/0x1d0 [btusb] Add a NULL check for data and return -ENODEV in this case to prevent the NULL pointer dereference. This indicates that the device is no longer available, which is appropriate when the driver's private data is missing. Signed-off-by: En-Wei Wu --- drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 279fe6c115fa..a0461528548b 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -4096,6 +4096,9 @@ static int btusb_suspend(struct usb_interface *intf, = pm_message_t message) =20 BT_DBG("intf %p", intf); =20 + if (!data) + return -ENODEV; + /* Don't auto-suspend if there are connections; external suspend calls * shall never fail. */ --=20 2.43.0