From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED314C6C; Thu, 19 Dec 2024 03:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; cv=none; b=lA3QUEuzwjGxSjcndR88UJ4bWltrkyr6lTJ4hk+rDkmG4fQsuxSYVhUTSsgWhzS11R6fgaCPtIcmjcjLU1SghKE0t8nRuBOuYo4UA4osqRJF2uCDPFdc6ZW36dL4SqpMRfabrzml8TtjAwWx61c3bmND/A5TiR3pNeE9UKQVp7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; c=relaxed/simple; bh=f77/BUhvVUMSp4EMYuMM8mhFo/d1naob8C7Z+9LksYs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=B5aNhL9D56jyqvlENU94L1uJBHHDuHhzGEP7j/YPah921KXy0nSG/ZY5JHs2iWgHz/XOjMB+exlEi0IElprmkWRZ7L7Z/smhwZKHNO9CzWYp+rDGqZf9p+hNRdNKiqUAGi5GfgluWvNHl9S+plkEXLdWeF3Nmen5B/EDxQxG4ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=none smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4YDFhC2ZNvz4f3kFP; Thu, 19 Dec 2024 11:02:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id D9ADC1A06D7; Thu, 19 Dec 2024 11:02:22 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S3; Thu, 19 Dec 2024 11:02:22 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] ext4: add missing brelse for bh2 in ext4_dx_add_entry Date: Thu, 19 Dec 2024 19:00:22 +0800 Message-Id: <20241219110027.1440876-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr47Xr1UGFWfGrW8WryxAFb_yoW8Cw1xpr W5KF97ZFyxuFnF9FsxA3WUXF13uw1xCry7W3y7GrySk347Xrn3Wasrtw1FkF4UJay8u3W5 XF4UKryUua1IyrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUGwA2048vs2IY020Ec7CjxVAFwI0_Jrv_JF4l8cAvFVAK 0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4 x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l 84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64 vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07js2-5UUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" Add missing brelse for bh2 in ext4_dx_add_entry. Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo Reviewed-by: Zhang Yi --- fs/ext4/namei.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 1012781ae9b4..adec145b6f7d 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2580,8 +2580,10 @@ static int ext4_dx_add_entry(handle_t *handle, struc= t ext4_filename *fname, BUFFER_TRACE(frame->bh, "get_write_access"); err =3D ext4_journal_get_write_access(handle, sb, frame->bh, EXT4_JTR_NONE); - if (err) + if (err) { + brelse(bh2); goto journal_error; + } if (!add_level) { unsigned icount1 =3D icount/2, icount2 =3D icount - icount1; unsigned hash2 =3D dx_get_hash(entries + icount1); @@ -2592,8 +2594,10 @@ static int ext4_dx_add_entry(handle_t *handle, struc= t ext4_filename *fname, err =3D ext4_journal_get_write_access(handle, sb, (frame - 1)->bh, EXT4_JTR_NONE); - if (err) + if (err) { + brelse(bh2); goto journal_error; + } =20 memcpy((char *) entries2, (char *) (entries + icount1), icount2 * sizeof(struct dx_entry)); @@ -2612,8 +2616,10 @@ static int ext4_dx_add_entry(handle_t *handle, struc= t ext4_filename *fname, dxtrace(dx_show_index("node", ((struct dx_node *) bh2->b_data)->entries)); err =3D ext4_handle_dirty_dx_node(handle, dir, bh2); - if (err) + if (err) { + brelse(bh2); goto journal_error; + } brelse (bh2); err =3D ext4_handle_dirty_dx_node(handle, dir, (frame - 1)->bh); @@ -2638,8 +2644,10 @@ static int ext4_dx_add_entry(handle_t *handle, struc= t ext4_filename *fname, "Creating %d level index...\n", dxroot->info.indirect_levels)); err =3D ext4_handle_dirty_dx_node(handle, dir, frame->bh); - if (err) + if (err) { + brelse(bh2); goto journal_error; + } err =3D ext4_handle_dirty_dx_node(handle, dir, bh2); brelse(bh2); restart =3D 1; --=20 2.30.0 From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED611EA90; Thu, 19 Dec 2024 03:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; cv=none; b=YqJERDgwhrNhJxOjkbsQbLAGFG+N8/FBYXxZGIOOZerI+tDNHBSHnSLxl3Fuv0uPzAehkx71bb8nM7I+5+PB4oNZl+Qld4aGALJ7/2Ucpp06U8ldiaImxuIe2mFtsqvJ0Qs0k/GLe/gfpghf54waUoAWLvVzUs+TiJIOOqpL5Jw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; c=relaxed/simple; bh=nOrJFcJYLVFcmoUVY4GVB8jgP1zQjtf7+BZ3PWqOcDQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WhiPAFh64azXt0Za5J1bfhJOtdOwKbvq1r32TtexAqiqfgePr39JqrOYZNS/PLIyvYrdWJ88RJfFJ22SW85FNy89WTtFa5ATk1eQSXJ/w4zmsNPi9fEmGAaWe5+46S3zTzdjS9QGGX5nxo3QPq5od4d4T5f1YwERL1fRDO17VgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4YDFhC4TvJz4f3kFQ; Thu, 19 Dec 2024 11:02:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 28D9E1A07B6; Thu, 19 Dec 2024 11:02:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S4; Thu, 19 Dec 2024 11:02:23 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] ext4: remove unneeded bits mask in dx_get_block() Date: Thu, 19 Dec 2024 19:00:23 +0800 Message-Id: <20241219110027.1440876-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S4 X-Coremail-Antispam: 1UD129KBjvdXoW7XFyfGrWrur15Aw13Gr1DGFg_yoWfKFbEya yDAr4xWF4fZ3ZakF1YyrW7trn5KF4F9F1UZa4fXryfZFn8JayfAw1DZrn8Z34DWa93Xa45 CrnYvryUCr13ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVWUCVW8JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j-BMNUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" As high four bits of block in dx_entry is not used by any feature for now, we can remove unneeded bits mask in dx_get_block() and add it back when it's really needed. Signed-off-by: Kemeng Shi --- fs/ext4/namei.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index adec145b6f7d..8ff840ef4730 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -561,14 +561,9 @@ ext4_next_entry(struct ext4_dir_entry_2 *p, unsigned l= ong blocksize) ext4_rec_len_from_disk(p->rec_len, blocksize)); } =20 -/* - * Future: use high four bits of block for coalesce-on-delete flags - * Mask them off for now. - */ - static inline ext4_lblk_t dx_get_block(struct dx_entry *entry) { - return le32_to_cpu(entry->block) & 0x0fffffff; + return le32_to_cpu(entry->block); } =20 static inline void dx_set_block(struct dx_entry *entry, ext4_lblk_t value) --=20 2.30.0 From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2031350285; Thu, 19 Dec 2024 03:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; cv=none; b=p3f1OXP00HlwoksrzX6e0gdDG4JUFECLNCRm+S3PWc5Opl9qeQ0k+vM2DXXrYxo7Gnsa0GDg3wTm/1DbmJUPfV+d6PGFo49RUhCEP0xw1iVLFjfYHWoLLfuj02jhTbnZipw2LOwcU79Wbie7inz6V5iTrlSLT9sByph0MtfSg7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; c=relaxed/simple; bh=4NF5PJEuPc3gpNPNtaQ2hIGJ9bYr0mNJNEskpB2NmmU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qzuP5ZfL/WPJBYepeZi4pAVeLV+99z7RfvdwLt/cLaMqPh+VjK+kjh0tCgctwl8/VG8DGUjS91rBWB1UJQdMYdIIaO6v96c8sEQ/eFy/Fw8pEGwNrkHawwPDOeqYw6EeTmLczST/VAWEOnOe5rECJOtKhDylWcePy9MwOZKb5fk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4YDFhC66DRz4f3kFT; Thu, 19 Dec 2024 11:02:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 617041A0196; Thu, 19 Dec 2024 11:02:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S5; Thu, 19 Dec 2024 11:02:23 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] ext4: remove unneeded forward declaration in namei.c Date: Thu, 19 Dec 2024 19:00:24 +0800 Message-Id: <20241219110027.1440876-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S5 X-Coremail-Antispam: 1UD129KBjvJXoW7uryUKFW3XFy8JF43Jw47urg_yoW8tF1xpF 4rJ3W5Kr48XF1DuFW8Zw48Aw1a9w1vgr9rJrZrG34FkFy2qr12q3ZrJr4xZFyrtry8WF12 yFs8Kry5Ca18WrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB0b4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK 0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4 x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l 84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64 vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU3G-eDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" Remove unneeded forward declaration in namei.c Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo Reviewed-by: Zhang Yi --- fs/ext4/namei.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 8ff840ef4730..33670cebdedc 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -291,36 +291,6 @@ struct dx_tail { __le32 dt_checksum; /* crc32c(uuid+inum+dirblock) */ }; =20 -static inline ext4_lblk_t dx_get_block(struct dx_entry *entry); -static void dx_set_block(struct dx_entry *entry, ext4_lblk_t value); -static inline unsigned dx_get_hash(struct dx_entry *entry); -static void dx_set_hash(struct dx_entry *entry, unsigned value); -static unsigned dx_get_count(struct dx_entry *entries); -static unsigned dx_get_limit(struct dx_entry *entries); -static void dx_set_count(struct dx_entry *entries, unsigned value); -static void dx_set_limit(struct dx_entry *entries, unsigned value); -static unsigned dx_root_limit(struct inode *dir, unsigned infosize); -static unsigned dx_node_limit(struct inode *dir); -static struct dx_frame *dx_probe(struct ext4_filename *fname, - struct inode *dir, - struct dx_hash_info *hinfo, - struct dx_frame *frame); -static void dx_release(struct dx_frame *frames); -static int dx_make_map(struct inode *dir, struct buffer_head *bh, - struct dx_hash_info *hinfo, - struct dx_map_entry *map_tail); -static void dx_sort_map(struct dx_map_entry *map, unsigned count); -static struct ext4_dir_entry_2 *dx_move_dirents(struct inode *dir, char *f= rom, - char *to, struct dx_map_entry *offsets, - int count, unsigned int blocksize); -static struct ext4_dir_entry_2 *dx_pack_dirents(struct inode *dir, char *b= ase, - unsigned int blocksize); -static void dx_insert_block(struct dx_frame *frame, - u32 hash, ext4_lblk_t block); -static int ext4_htree_next_block(struct inode *dir, __u32 hash, - struct dx_frame *frame, - struct dx_frame *frames, - __u32 *start_hash); static struct buffer_head * ext4_dx_find_entry(struct inode *dir, struct ext4_filename *fname, struct ext4_dir_entry_2 **res_dir); --=20 2.30.0 From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 286977080C; Thu, 19 Dec 2024 03:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; cv=none; b=KL4guDol13I8Gvc9DsYJqp7lL7/JLhYlWY5InZEFNBhoswH2MZ7V/iAi9CIGcamVxBjwkBMdAoWjPtOW4Qt4NQeKuKjDVBP2hrXVj8kyrRHbLvzSQSM4Io/SS8jny3VTzM/kvDyPUtlJfc93Fcvg/RKXIjQTuCOiDTeg64/s2HI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; c=relaxed/simple; bh=wshM5qvFK71l+sonYWvX9REVawk0v+hdKgD/3nCzDjQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IqyiOkaQVEetvCoyXfPKzrz+JSCq+4jkGdVVzXkijLi1GAoki9BlavjSCCrjX07kgVzjpfk9LtpJ8QjYp5Qq7FO5HNPq6M8LMfD0xqdO21+ZRxMLWj6L5jDO6K+GqRYKFL7vGqCcL2bRF84mw2KHVnvFv7u/G3KiC16Xji4DdtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4YDFhC0bzdz4f3lWD; Thu, 19 Dec 2024 11:02:03 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id A2D871A018C; Thu, 19 Dec 2024 11:02:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S6; Thu, 19 Dec 2024 11:02:23 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] ext4: remove unneeded check in get_dx_countlimit Date: Thu, 19 Dec 2024 19:00:25 +0800 Message-Id: <20241219110027.1440876-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S6 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYA7kC6x804xWl14x267AKxVWrJVCq3wAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62 vIxIIY0VWUZVW8XwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E 14v26r4j6ryUM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI 8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vE x4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzx vE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU JVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7V AKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr 1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IUnr9NDUU UUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" The "offset" is always non-NULL, remove unneeded NULL check of "offset". Signed-off-by: Kemeng Shi --- fs/ext4/namei.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 33670cebdedc..07a1bb570deb 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -434,8 +434,7 @@ static struct dx_countlimit *get_dx_countlimit(struct i= node *inode, } else return NULL; =20 - if (offset) - *offset =3D count_offset; + *offset =3D count_offset; return (struct dx_countlimit *)(((void *)dirent) + count_offset); } =20 --=20 2.30.0 From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202DC40BE0; Thu, 19 Dec 2024 03:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; cv=none; b=VHFVE2THK6QXysPjnEBeyXve4/6k1RKTud8UtlwdKCsIKW3XEXfRuNPVX5V+WgikRsbDUSbKjOLq3s7+eHDukOaCIsmEiyUAYobwssjvIBDqgkfRt3Ryr84VE25IcJkEilpdI6BdQslhcl+PnHklUYCpcUS37AYG13JkwJvRV7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577350; c=relaxed/simple; bh=bRgG7RBPMdd0JDNJacgTScno2ctOnq2j+mW2PpWJVJ0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g4O0adP46CieXdjdvsB4r+ACAzquoQ38LVka0yNhqOqTqmihOFvRpjxJUAdMTQvVzst3BaCako8gjNIZmGA51OYnq+8wzESpOB63BHP6LOBd0Su7CyTje3qXjlDnMQJijfhgxa8lm6Z4954slLBc5zLnwikXOj6ic6idUqtOEdY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4YDFhD33zDz4f3kFL; Thu, 19 Dec 2024 11:02:04 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id EC60D1A07B6; Thu, 19 Dec 2024 11:02:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S7; Thu, 19 Dec 2024 11:02:23 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] ext4: remove unused input "inode" in ext4_find_dest_de Date: Thu, 19 Dec 2024 19:00:26 +0800 Message-Id: <20241219110027.1440876-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S7 X-Coremail-Antispam: 1UD129KBjvJXoW7ur1xKw1kuF1ktF1DZF45trb_yoW8tF15pr Z8JF1DCr47WFWq9a1xuF4UZw1avwnrGrW7WrWfG34rKrW2qwnYqF15tF10yF15KrWrZw12 vFs8K348Jw1agrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB2b4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAv FVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3w A2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE 3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr2 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU3XTQUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" Remove unused input "inode" in ext4_find_dest_de. Signed-off-by: Kemeng Shi Reviewed-by: Zhang Yi --- fs/ext4/ext4.h | 3 +-- fs/ext4/inline.c | 2 +- fs/ext4/namei.c | 5 ++--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index bbffb76d9a90..f7cec0de2790 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2821,8 +2821,7 @@ extern int ext4_htree_store_dirent(struct file *dir_f= ile, __u32 hash, struct ext4_dir_entry_2 *dirent, struct fscrypt_str *ent_name); extern void ext4_htree_free_dir_info(struct dir_private_info *p); -extern int ext4_find_dest_de(struct inode *dir, struct inode *inode, - struct buffer_head *bh, +extern int ext4_find_dest_de(struct inode *dir, struct buffer_head *bh, void *buf, int buf_size, struct ext4_filename *fname, struct ext4_dir_entry_2 **dest_de); diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 3536ca7e4fcc..29081a04aef5 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1012,7 +1012,7 @@ static int ext4_add_dirent_to_inline(handle_t *handle, int err; struct ext4_dir_entry_2 *de; =20 - err =3D ext4_find_dest_de(dir, inode, iloc->bh, inline_start, + err =3D ext4_find_dest_de(dir, iloc->bh, inline_start, inline_size, fname, &de); if (err) return err; diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 07a1bb570deb..aee1858e6482 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2024,8 +2024,7 @@ static struct ext4_dir_entry_2 *do_split(handle_t *ha= ndle, struct inode *dir, return ERR_PTR(err); } =20 -int ext4_find_dest_de(struct inode *dir, struct inode *inode, - struct buffer_head *bh, +int ext4_find_dest_de(struct inode *dir, struct buffer_head *bh, void *buf, int buf_size, struct ext4_filename *fname, struct ext4_dir_entry_2 **dest_de) @@ -2111,7 +2110,7 @@ static int add_dirent_to_buf(handle_t *handle, struct= ext4_filename *fname, csum_size =3D sizeof(struct ext4_dir_entry_tail); =20 if (!de) { - err =3D ext4_find_dest_de(dir, inode, bh, bh->b_data, + err =3D ext4_find_dest_de(dir, bh, bh->b_data, blocksize - csum_size, fname, &de); if (err) return err; --=20 2.30.0 From nobody Fri Dec 19 04:53:37 2025 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539B267A0D; Thu, 19 Dec 2024 03:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; cv=none; b=XSTys6EXYNeu+MS+V/rni9TI1HonQoyFAoLWAIFjcR2fRdoUSVpmtx2ST6Oqd193IfvlA6qjc6v1N6OoluI1y6Liq9bFl0qC0aEskDzbWxa9GsyaUxGkcAC4SRp299Xu+ciCbNnMJ56IbAtZK1LLczOY+fIAnlPoieEYKHmh+zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734577349; c=relaxed/simple; bh=vz/EyrA1zAvl4TvtFV1uyrhlBtXhbu1yV2u2FzRGu+4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MQeJPKmova77l/zks5Mw8qU8fRzP8RD+xFWqKDXHIg6HU/72GflsmxoTi3Hp/pPevguwQHy82R1in+KoPWprwjsxjf7/Kvd2ahBKy+KBtABfTSr7+I7GSd8SNpPFEjpk5aTfTIfCEL/4SDFid+J7S0GMFNZ4sUmXnPRex1vjpxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4YDFhD4jv4z4f3kFN; Thu, 19 Dec 2024 11:02:04 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 2D52B1A018C; Thu, 19 Dec 2024 11:02:24 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDHpMG9jGNnctd0Ew--.54838S8; Thu, 19 Dec 2024 11:02:24 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] ext4: calculate rec_len of ".." with correct name length 2 Date: Thu, 19 Dec 2024 19:00:27 +0800 Message-Id: <20241219110027.1440876-7-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241219110027.1440876-1-shikemeng@huaweicloud.com> References: <20241219110027.1440876-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDHpMG9jGNnctd0Ew--.54838S8 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWUXry3KryUXF45ZF13Arb_yoWfWwc_Ca yDAFnrXFW3A34xK345ArWYq3Z0gan5Cw1DZF95GFyvgFn0vFy5Aan8ZrsIy342gry5tr98 Cw10qrn0qrW3ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbS8YFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jstxDUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" The rec_len of directory ".." should be ext4_dir_rec_len(2, NULL) instead of ext4_dir_rec_len(1, NULL). Although ext4_dir_rec_len return the same number either with name_len 1 or name_len 2, it's better use the right name_len to make code more intuitive. Signed-off-by: Kemeng Shi --- fs/ext4/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index aee1858e6482..24cdeb2aa0d5 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2925,7 +2925,7 @@ struct ext4_dir_entry_2 *ext4_init_dot_dotdot(struct = inode *inode, de->name_len =3D 2; if (!dotdot_real_len) de->rec_len =3D ext4_rec_len_to_disk(blocksize - - (csum_size + ext4_dir_rec_len(1, NULL)), + (csum_size + ext4_dir_rec_len(2, NULL)), blocksize); else de->rec_len =3D ext4_rec_len_to_disk( --=20 2.30.0