From nobody Fri Sep 12 12:21:13 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782C71FCFEF for ; Wed, 18 Dec 2024 23:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734562889; cv=none; b=mBcUmkQxfd1cDIZvM5b4EVR89dd3TdZK0dN4yS2T9WtBn4xPGfuS1YBb/qTxJImxFC36rZYjK3BA2JLG2ODRvAgDPaDHR81FilCEC0z7bPlULggue1/JYW5L+ytO+605S2PYAuJo7fVw8MuQql3X3gTJqXnJ3Mb7ZV0uaF0GDMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734562889; c=relaxed/simple; bh=m1RG8uDj8WQP7hbZHg/PSSoUtWF3HmCISvW9JYlyfUc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qzAxGZUEmKDOrv4p0ijhACceAL5nQjqGyXK+5xehWmr4+/Xl702YOeOBCX1d+EdGEdJ3Mi2FwQPOGgeMwAjqYFLWzAxX5chTFTuP6ZN0nSHM680acmycQ34khEeSjr9VfwbTZXt59y92Ed+BtuisoKMEHkbR3xOphCcsENYfZ54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u6QjTsV+; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u6QjTsV+" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4362f61757fso1645565e9.2 for ; Wed, 18 Dec 2024 15:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734562886; x=1735167686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QqYUm1i7e1fblFqY9jJKn51mYoOB0b0xVEyAilyqTvk=; b=u6QjTsV+dbQ2lVDURCew9QNBKtNTmWXViNwy7e6U9tBRn7skue6GfNi/JhBB2FMnXG 2c/shA5O7FMv75OCqBpCu0EbBmvKmHcfYzdXmLi5W58It1+ojgOsg3DOol4OV2vF9icc rdigTF8bW2PA1ihZ/iGxNuBGTFVNaYmDMyBnoFeqRzVEFUsPNjeFxi/ZRJ6FGKzgpuUm kLuymTvmDsH/m9q9hDF9XhFA+WiSJ8tyvhkw1vIKcjGsJeevl1MeGTsz6AULNJFbC6jw oCD7Nay8irSpUJ8IQQz4qjGrtb8ZeF6Jewt0DHaqFd+y+2PBnsZSqBicVPsT8gLb8z46 CFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734562886; x=1735167686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QqYUm1i7e1fblFqY9jJKn51mYoOB0b0xVEyAilyqTvk=; b=pt7ASWbKapUyUGEi1hYCs2qqg94clx68To74a3GfKABfQHhvKKTKvZrHXJMAjFAdMl zaT3MBwFBW4MqABcHi9T+Nlk/n3RkjEVoN/bFmTfkoGnyNmCe8pcNxVs1S8BqfPiQYPz HS3WLxlowv4gdJbZzsHFnDjw4T7MrF0h3zQfg3hoXc30wiQGhky7U13FU56SyO1fL1ir lsejw2y+vpVQCUzepwVSZ1JqbR/CudcgMPkIDqjQ0GjbIviul/PhzbvuY785ZXpSgryJ eAztb+uNxI85/JKnURdOvZ3TzDYwtVEqHjcKnkg/g0u827/YJqDRP7I9EZwP+wKQA9Ne zieQ== X-Gm-Message-State: AOJu0YwL1b+2O4ye/Ekp4/3A7Ta8eF6+/AxsRfthlavSnjwft/Fv7OKO 2MWqA4PX5eHH2CqjCmxbtqgPql647UZHu5aRftjeb5LjcXVzUS+nVqJUcusmNXhzNxnIdYJWcZ7 X X-Gm-Gg: ASbGncusNuANfJnGDBzeFPZTgYeL8vAknBqKe0r1guQnX9Ku0tQt+PYEAo4PTVRS//Y qqLpMmWdHebg0ympoAYgaG/DaS1mwNNU0OwgY214tyaAdCNxoEgjJRi6mX83TTsFzS/9RxzeCqD Pr10HhWcBD7ahOH2UN9IVB3B53LPc+KMCqqIJbLBi61X/3G4Aj8SmQzuGjN5Ye8S2WLsT52JKsj tCOn4K2YiWKgJqHQXUVFiUmGNLI4LhU5XlCjq8fExxK9yVikodHGZQZKm4= X-Google-Smtp-Source: AGHT+IH1H5gzkXGiuEoDmhNHJ2hwnBCSMabu2fmzR+8En/9OikahIreXFTalAusBqUZe4sYSxVeucA== X-Received: by 2002:a05:600c:4fd1:b0:434:f819:251a with SMTP id 5b1f17b1804b1-4365535b124mr42404355e9.9.1734562885805; Wed, 18 Dec 2024 15:01:25 -0800 (PST) Received: from linaro.org ([2a00:23c5:6829:901:7895:12a9:ae3b:17a1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b190f3sm33291835e9.32.2024.12.18.15.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 15:01:25 -0800 (PST) From: Mike Leach To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Cc: james.clark@linaro.org, mike.leach@linaro.org, suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com Subject: [PATCH v3 3/3] coresight: etf: etr: Update logging around flush_and_stop() errors Date: Wed, 18 Dec 2024 23:01:18 +0000 Message-Id: <20241218230118.999859-4-mike.leach@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241218230118.999859-1-mike.leach@linaro.org> References: <20241218230118.999859-1-mike.leach@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Insert additional context around tmc_flush_and_stop() errors. Signed-off-by: Mike Leach --- drivers/hwtracing/coresight/coresight-tmc-etf.c | 12 +++++++++--- drivers/hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++-- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtr= acing/coresight/coresight-tmc-etf.c index d4f641cd9de6..62b4b685c1a1 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -84,7 +84,9 @@ static void __tmc_etb_disable_hw(struct tmc_drvdata *drvd= ata) { CS_UNLOCK(drvdata->base); =20 - tmc_flush_and_stop(drvdata); + if (tmc_flush_and_stop(drvdata)) + dev_err(&drvdata->csdev->dev, + "Flush and stop error disabling ETB\n"); /* * When operating in sysFS mode the content of the buffer needs to be * read before the TMC is disabled. @@ -146,7 +148,9 @@ static void tmc_etf_disable_hw(struct tmc_drvdata *drvd= ata) =20 CS_UNLOCK(drvdata->base); =20 - tmc_flush_and_stop(drvdata); + if (tmc_flush_and_stop(drvdata)) + dev_err(&drvdata->csdev->dev, + "Flush and stop error disabling ETF\n"); tmc_disable_hw(drvdata); coresight_disclaim_device_unlocked(csdev); CS_LOCK(drvdata->base); @@ -496,7 +500,9 @@ static unsigned long tmc_update_etf_buffer(struct cores= ight_device *csdev, =20 CS_UNLOCK(drvdata->base); =20 - tmc_flush_and_stop(drvdata); + if (tmc_flush_and_stop(drvdata)) + dev_err(&drvdata->csdev->dev, + "Flush and stop error updating perf buffer\n"); =20 read_ptr =3D tmc_read_rrp(drvdata); write_ptr =3D tmc_read_rwp(drvdata); diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index a48bb85d0e7f..122a067d1bb8 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1139,7 +1139,9 @@ static void __tmc_etr_disable_hw(struct tmc_drvdata *= drvdata) { CS_UNLOCK(drvdata->base); =20 - tmc_flush_and_stop(drvdata); + if (tmc_flush_and_stop(drvdata)) + dev_err(&drvdata->csdev->dev, + "Flush and stop error disabling ETR\n"); /* * When operating in sysFS mode the content of the buffer needs to be * read before the TMC is disabled. @@ -1578,7 +1580,9 @@ tmc_update_etr_buffer(struct coresight_device *csdev, =20 CS_UNLOCK(drvdata->base); =20 - tmc_flush_and_stop(drvdata); + if (tmc_flush_and_stop(drvdata)) + dev_err(&csdev->dev, + "Flush and Stop error updating perf buffer\n"); tmc_sync_etr_buf(drvdata); =20 CS_LOCK(drvdata->base); --=20 2.25.1