From nobody Fri Sep 12 07:36:08 2025 Received: from mail.fris.de (mail.fris.de [116.203.77.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5C81C2335 for ; Wed, 18 Dec 2024 15:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.77.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734536211; cv=none; b=IeIXV2v6a+Pd/7Y+H8mq+cgxWoC5gvGO6Ky9aAtg+oOODrX1yD4wE+S2x79+J5bSfMgQt9R+an1jbNPoSPhoqtz7N0Zly5mEtYi24MlheCbVXpthp80C/deB+Ro5ZDnB0LV6jwusjkJDiRDnfufxI0E8RQTT5mUx4ZaJ4wveseI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734536211; c=relaxed/simple; bh=6s+lwSMPhCZzzL4PL7cadnOiHs0troU9au5cGIEaCfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OMrhTiIwCI2dEb5adWbK4cThO2RR1Wmoz0N5tZLg9rlBpTS9U4dd/wGFMlAmqPeYsBtaGkv9i8kbiLGc2pAxixI2oPZosHUU+8dtADrSGXmUbNk7n1UXuoLopsnJw6lx+QK3h0heo2Fpai4IZk0APDVJxFuffdktJ+OmnO2mXI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fris.de; spf=pass smtp.mailfrom=fris.de; dkim=pass (2048-bit key) header.d=fris.de header.i=@fris.de header.b=Rqm+vuKl; arc=none smtp.client-ip=116.203.77.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fris.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fris.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fris.de header.i=@fris.de header.b="Rqm+vuKl" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 254EFBFB71; Wed, 18 Dec 2024 16:29:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1734535788; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=HjozMOsMtZ5TwghDOEmqXJ6JAY4r0rRBxbKRxT00hdw=; b=Rqm+vuKlBLH5Asa0NSbWGR8djdOdUjz5bqKBT28KCUDihQ8cfLZzQZ9LIphXcqU7f5icVN 7tOut9gktho+TMQ3jsMj3uOmEHuFJt1pJkbJbnK8DpwquuRek8L5voWys47HCNqbBkf1WE rPV8SaHVUam6DnvbLS2NlCBt5gmefPEUqZHO0C5vHXzpPn6OK6P5L0l41ganib+hPTLzBN vnmGc50YHSv8hOzjWKTR0YFDg1+YtF6B+qf8SvRcCFWXHtjlT36F/Z6zqyAnkqB+pApMWz klrUj24RbC+CurLUm5vIG/hPw79tRqRCiKC9UU6oc3O5XVxyFB9ZuixZbvJR0A== From: Frieder Schrempf To: linux-arm-kernel@lists.infradead.org, Marek Vasut , Conor Dooley , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown Cc: Frieder Schrempf , Bo Liu , Frank Li , Joy Zou , Robin Gong Subject: [PATCH v3 3/9] Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5" Date: Wed, 18 Dec 2024 16:27:26 +0100 Message-ID: <20241218152842.97483-4-frieder@fris.de> In-Reply-To: <20241218152842.97483-1-frieder@fris.de> References: <20241218152842.97483-1-frieder@fris.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" From: Frieder Schrempf This reverts commit 8c67a11bae889f51fe5054364c3c789dfae3ad73. It turns out that all boards using the PCA9450 actually have the SD_VSEL input connected to the VSELECT signal of the SoCs SD/MMC interface or use a fixed level. The assumptions on which this was implemented were wrong. There is no need for a GPIO-only-based approach and keeping this will cause confusion and lead people to implement non-standard setups. All in-tree users of this have been migrated and we can savely remove this now and allow for a more future-proof approach of syncing the actual status of SD_VSEL and the PMIC driver. Signed-off-by: Frieder Schrempf --- Changes for v3: * Rebase to next-20241218 Changes for v2: * rebase to current master --- drivers/regulator/pca9450-regulator.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9= 450-regulator.c index faa6b79c27d75..9e5e81a9315f6 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -5,7 +5,6 @@ */ =20 #include -#include #include #include #include @@ -32,7 +31,6 @@ struct pca9450_regulator_desc { struct pca9450 { struct device *dev; struct regmap *regmap; - struct gpio_desc *sd_vsel_gpio; enum pca9450_chip_type type; unsigned int rcnt; int irq; @@ -1031,17 +1029,6 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) "Failed to enable I2C level translator\n"); } =20 - /* - * The driver uses the LDO5CTRL_H register to control the LDO5 regulator. - * This is only valid if the SD_VSEL input of the PMIC is high. Let's - * check if the pin is available as GPIO and set it to high. - */ - pca9450->sd_vsel_gpio =3D gpiod_get_optional(pca9450->dev, "sd-vsel", GPI= OD_OUT_HIGH); - - if (IS_ERR(pca9450->sd_vsel_gpio)) - return dev_err_probe(&i2c->dev, PTR_ERR(pca9450->sd_vsel_gpio), - "Failed to get SD_VSEL GPIO\n"); - dev_info(&i2c->dev, "%s probed.\n", type =3D=3D PCA9450_TYPE_PCA9450A ? "pca9450a" : (type =3D=3D PCA9450_TYPE_PCA9451A ? "pca9451a" : "pca9450bc")); --=20 2.47.1