From nobody Thu Dec 18 20:20:41 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 415B01990C1 for ; Wed, 18 Dec 2024 11:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520589; cv=none; b=NXS4MzfC67ap1Rhgr6B+D8MAxlDcPgFHxw7derARF45d+QCv7CfmMi9nRdyA8hjKibuUXA7WPfcxqfRLkXLKpXs355T+cD3CKrXkYw68jLlrx/7ROfmozNyToe+TK3P3cko34L6qmt2MMlfKGOVYMBKEK5b3Tw3h3r1eIgD2+oE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734520589; c=relaxed/simple; bh=2Yf9dTHoYaby3VbY12Yk9sfWH1gdnumaX6lKBWWsHvg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ChwV7VmlaIW2ujtWaWCJEZyqFf/O8AuV+OIMG6RgaV0KDbrGBmwGRA+XOepbOeKQRQoG7SLo9QQFBeK3oaRW6lvBGXxVqKduYDzbOE0V4MBQugMKNefScaUFBcrFfKzMANBnE51ePwq8f8rbMUBxqbv488mGlR1lZV6Bimd2U0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=yqu28+AF; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=akULtRY/; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="yqu28+AF"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="akULtRY/" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1734520586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WP9NALlVKbZdzyimsq9a3cjbsLLj2+xhboLJAEJ0CvY=; b=yqu28+AFKTJHgRFGWNdKThyTi3LmLiCeZ1j1JCbgGePz8X+3QLkrS9mJxojU+93pbwe1KV 8BPSSi42940a9VWDfT964hO1umBDD3GrnVl3y9OarkPaUHVtnu2lbweZzEMJw6/rNOLmbH YjDg5wFdsYnczO9sD5CzINFIshYCWBgh+x6lyLfmRPDkzwrn68uiEPBV3Tx/Cweu3tfjS6 lgEorQdOVW8Sk+76W572qab+gEyZtKTM9GHx6nSyIGHtmmmusGe6BtfcWSOYAUYMoet8H3 GumdkJWX4UTM8rSLagncnCIx/lhx6i7VKKHZlIY8J2O3kwH/cvXRFDCLqLmI4A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1734520586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WP9NALlVKbZdzyimsq9a3cjbsLLj2+xhboLJAEJ0CvY=; b=akULtRY/cLH+3+pl2cW92/kDeDIJJ93LZG7+S7o3kH+vZuaK1h/+px1IjvQ8rMulWVMc2w XwGXJzc7w2Jw2hDw== To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Andr=C3=A9=20Almeida?= , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Sebastian Andrzej Siewior Subject: [PATCH v6 03/15] futex: Allow automatic allocation of process wide futex hash. Date: Wed, 18 Dec 2024 12:09:41 +0100 Message-ID: <20241218111618.268028-4-bigeasy@linutronix.de> In-Reply-To: <20241218111618.268028-1-bigeasy@linutronix.de> References: <20241218111618.268028-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Allocate a default futex hash if a task forks its first thread. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/futex.h | 12 ++++++++++++ kernel/fork.c | 24 ++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/include/linux/futex.h b/include/linux/futex.h index 943828db52234..bad377c30de5e 100644 --- a/include/linux/futex.h +++ b/include/linux/futex.h @@ -86,6 +86,13 @@ static inline void futex_mm_init(struct mm_struct *mm) mm->futex_hash_bucket =3D NULL; } =20 +static inline bool futex_hash_requires_allocation(void) +{ + if (current->mm->futex_hash_bucket) + return false; + return true; +} + #else static inline void futex_init_task(struct task_struct *tsk) { } static inline void futex_exit_recursive(struct task_struct *tsk) { } @@ -108,6 +115,11 @@ static inline int futex_hash_allocate_default(void) static inline void futex_hash_free(struct mm_struct *mm) { } static inline void futex_mm_init(struct mm_struct *mm) { } =20 +static inline bool futex_hash_requires_allocation(void) +{ + return false; +} + #endif =20 #endif diff --git a/kernel/fork.c b/kernel/fork.c index cda8886f3a1d7..95d38709fde10 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2130,6 +2130,15 @@ static void rv_task_fork(struct task_struct *p) #define rv_task_fork(p) do {} while (0) #endif =20 +static bool need_futex_hash_allocate_default(u64 clone_flags) +{ + if ((clone_flags & (CLONE_THREAD | CLONE_VM)) !=3D (CLONE_THREAD | CLONE_= VM)) + return false; + if (!thread_group_empty(current)) + return false; + return futex_hash_requires_allocation(); +} + /* * This creates a new process as a copy of the old one, * but does not actually start it yet. @@ -2507,6 +2516,21 @@ __latent_entropy struct task_struct *copy_process( if (retval) goto bad_fork_cancel_cgroup; =20 + /* + * Allocate a default futex hash for the user process once the first + * thread spawns. + */ + if (need_futex_hash_allocate_default(clone_flags)) { + retval =3D futex_hash_allocate_default(); + if (retval) + goto bad_fork_core_free; + /* + * If we fail beyond this point we don't free the allocated + * futex hash map. We assume that another thread will created + * and makes use of it. The hash map will be freed once the main + * thread terminates. + */ + } /* * From this point on we must avoid any synchronous user-space * communication until we take the tasklist-lock. In particular, we do --=20 2.45.2