From nobody Tue Feb 10 00:21:39 2026 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07DDE14F126 for ; Wed, 18 Dec 2024 04:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734496953; cv=fail; b=aG/ImXZJU3Mf/e3yXpPxBedRGdhzc0yI+V6Sw2IlViD8r975MOdA7HTWUfGWUzGOjZhMTA+zVGlDRfHAGQxvKeZ3jh3Yezx4+d0vE7UXuAe34eu/sA0MlprQjfFGg5YLy5YuIeERmar+tGuKPUxyUDyhtHYry2I2ZoXMi+v0MZY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734496953; c=relaxed/simple; bh=lMaURls81W5jPLhUyI85atwKnu0+gW+pr0RNtMeZ3ks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gHToItKbKbDr388RKgHw6Ss4BzREu/UOv4/2WURLmWYeT/+wmhiMWGUzxv4io7r1/ciMJjDDFd7f9a1BVDG0OIwsW4KmT2WXmuqYQS7HICpZr1Vv23y2HLvySqSvHs96ylIH7/nO5j7ELKABi6xWbjyRNUI3H/QUvjPD22hM3oo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=L+nrzm8J; arc=fail smtp.client-ip=40.107.92.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="L+nrzm8J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jKDm7r1UefwKmyMNsXc9gRwdet7uBaEQpj+ReJZ0/GogGUhJYJNefqADdOIxeq76hntkLNNSVcU03PIKSUgqS7mNncRCCHKUADWaCsOtpLnyHHWgGnzEzODkQ7bMW1q7b5XeiDQItzltHQiNjowcLzjg50NVfJJakwZRbD+3Hnut3m67LWEmb9aP2EfLsEViFnWiMGkXempjIsGSN7WMa6ANzNHiw+Vr2zW71dheHpJgu0Ohytm1cRLm8/JBf0wQfrKsAjXJmVIn9GXqbu7zfdjiBjP1NbKJITsaRWE59QnGgzi+dm07xeHhvFgIhyLXZVTmUS4wuF2s3aAxf7O1CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RNGokLLyNI2K8xHMjMjWWfL5lcR1Ftp8Z/enlUalMYc=; b=wB6bM2Kx2PQ1lpo2FdBrTcMu9XlKHpC/UxCvNAaWjrtBgTFQG3mkqKoxbr9KiIG65T3mM8a38PSJunfP7mPdjtoDfQBw0413DfBmYCqh3vvWKq7aMWCabp8mkWnc+qUllUz78J4R0wyuhB0EXhn6RgohidtpNiZTwElxVd3wN0b/1WnKcMC1UB1Q1ZwW5naXeh2xvPf26w7au9POv2WNdWyJvsd44PeJG/HfPbDWRKlHqIWe1Q2XAtBOcFAog/pXdBwN5i/WTWEk8ZnBQ4EruaReuHo3z5kEZoI8gCOdXDChS67ibcOF1JisysIAl8Diut3YD7ooSEUv5OFX1YQ59g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RNGokLLyNI2K8xHMjMjWWfL5lcR1Ftp8Z/enlUalMYc=; b=L+nrzm8J0Jr/V/BsUVXQyxO9w85uFQN593M3s6JWo0cDRykd45Zi9TufTw3KGikAwDPM9CeMmLTo4eEC60uQKUWMf8Pl3TwUGKGC/Du1g68ZoTtGwe823yzTZJfpTCqbDi2JOqnw184gi3C+MDAGCXiJrsA0bupJs3yXBYvHtGc= Received: from SN7PR04CA0202.namprd04.prod.outlook.com (2603:10b6:806:126::27) by PH7PR12MB5973.namprd12.prod.outlook.com (2603:10b6:510:1d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Wed, 18 Dec 2024 04:42:24 +0000 Received: from SA2PEPF00001507.namprd04.prod.outlook.com (2603:10b6:806:126:cafe::36) by SN7PR04CA0202.outlook.office365.com (2603:10b6:806:126::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.23 via Frontend Transport; Wed, 18 Dec 2024 04:42:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001507.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Wed, 18 Dec 2024 04:42:24 +0000 Received: from tapi.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Dec 2024 22:42:19 -0600 From: Swapnil Sapkal To: , , , , CC: , , , , , , , , , , , , , , , Swapnil Sapkal Subject: [PATCH 4/6] sched: Move sched domain name out of CONFIG_SCHED_DEBUG Date: Wed, 18 Dec 2024 04:36:27 +0000 Message-ID: <20241218043629.1142651-5-swapnil.sapkal@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241218043629.1142651-1-swapnil.sapkal@amd.com> References: <20241218043629.1142651-1-swapnil.sapkal@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001507:EE_|PH7PR12MB5973:EE_ X-MS-Office365-Filtering-Correlation-Id: bcf83f1c-a45a-48b9-d1dc-08dd1f1e5e4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6Vz0lfdCFUQiieRCfqLE6PXT7DoiIjwy00Nd602/WxFEFt206EjW2D6hEM0o?= =?us-ascii?Q?mzd49krHpEAlvajpLrOo38w1bqWwpiofxIbrsxUdUXxNmfEXVKBdhsOcjQX/?= =?us-ascii?Q?ISdFQ0ll6wS6ev40w2QZxFLe6ZKR2AjzqHBjEvmyT3iAzcL+Q//xVeLkKgAW?= =?us-ascii?Q?uY4FeRc35s8SXtx38VTVb4AU4XBFXc7d+z1G/4nOFwl7NahHMyLiD8wuXTmQ?= =?us-ascii?Q?+ydGOrX1bH64WwlpBykZ38SUMXzsxANV4aUweVahU5WCNyt7ue2c3hinBci+?= =?us-ascii?Q?pn8skkaxuHcCMbWycnjX1HeY49dy9Cpp6qrUApQ+mWaYK8DoASL3T5Ca3v+d?= =?us-ascii?Q?5zGUIAVojFWD/UFj025+LVSxedqUgp7Vl1+sb7dQciMNL5c0Fb6wmYRrHDcU?= =?us-ascii?Q?GSbGTbHgst19o+GPkxkDuJ8kLxx5Mw9Ca2EAQZ1DSCpcklh7sYAr2AyRviVo?= =?us-ascii?Q?EaikDORNZbQQKYqjXa4aLcd4Ezr1q6Jo/oLpSAZ7ee2n0KkxnzC89ojP+R0y?= =?us-ascii?Q?mD6YE+3HBSZW1M+oIxxWVD9MplL2JnHnz+vJmnVw+sfRvxzcWNkAJyU2GzkB?= =?us-ascii?Q?qdxHFKNfPrHHRFg9aOW389Rb700fsiTkveJm6qVpUuvhPPmwBC4948szB5is?= =?us-ascii?Q?8sh0WLUXG8qNK951pAJd3pFSVEd0jYanq8YBRQO3dBz4dZUJeJXUis+X/i2G?= =?us-ascii?Q?jN5YX2Zic93kjAXgg4WTB+MlTTtRzkv/kp+YWiAcwKdgsYahWP+qtvWflfnM?= =?us-ascii?Q?Ve2x/OVyhFUl/+7AjZ3ZMYFBH0gvLmD1sY5tln/+SpaSzrnRaMRAkqvA6TqA?= =?us-ascii?Q?RkhCyIITYItRpHU3IWUYp57CRF7tPUmGHmaNkd/WE/wy48us0PhSzyUGN/gX?= =?us-ascii?Q?5+1u6z2k3UZhrr8KHlGvFNhogUUCW6ytZ6SbTQ7jXTWKxCP7qQdx5zMXiLeP?= =?us-ascii?Q?s4M/Awdo1uH8K26aJXL0vSir9M7q2VM//WXIyo5SSGgr/BaQFkeQhk9arDM3?= =?us-ascii?Q?kVSFSZc8O9gGp7He4upTMEYo74S72++XuX+uhKLetpyBjhKcfamIZWwXBqcp?= =?us-ascii?Q?fRJ9B8H8Cu6jvFE/8dsjFMYWD1cCb5zwWCc45LGL5W2Nq/GGaSsmDDd5KIGX?= =?us-ascii?Q?e1TnTynf/GJ8GuVdIqwyCdibojMacmn4FdfOwOiwdAaimVZdUmfzAiuaEx9s?= =?us-ascii?Q?qF0aNTot16wtVhKFk4ByZ7atWkJKQoIXSFwtmDfM5zGktPGlxAsRFenrff96?= =?us-ascii?Q?8nQVlrHXgLSrkT8jubou6BRrQh6ryZb3oFBl9a392/mWUha+b3FK5psvXs1n?= =?us-ascii?Q?rE+oHOJqn+zu31dv9XkwP5bQa+EKuXkqnStqAKbjUz2yZXQzVigqkXdio/6l?= =?us-ascii?Q?P+dm8Bs26Ylrr/fje+ISxmwIGxl2eQNCbOHAv00lArOi3T7/rUEVYlhAtAIm?= =?us-ascii?Q?QngOi9qN9iOt7s9B8Pdl+zqtqw+WMujJ3FDia76C6G3UqORz1a0Jl436cC9g?= =?us-ascii?Q?uO7U+gge1MHyxWI=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 04:42:24.7138 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcf83f1c-a45a-48b9-d1dc-08dd1f1e5e4a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001507.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5973 Content-Type: text/plain; charset="utf-8" /proc/schedstat file shows cpu and sched domain level scheduler statistics. It does not show domain name instead shows domain level. It will be very useful for tools like `perf sched stats`[1] to aggragate domain level stats if domain names are shown in /proc/schedstat. But sched domain name is guarded by CONFIG_SCHED_DEBUG. As per the discussion[2], move sched domain name out of CONFIG_SCHED_DEBUG. [1] https://lore.kernel.org/lkml/20241122084452.1064968-1-swapnil.sapkal@am= d.com/ [2] https://lore.kernel.org/lkml/fcefeb4d-3acb-462d-9c9b-3df8d927e522@amd.c= om/ Suggested-by: Gautham R. Shenoy Signed-off-by: Swapnil Sapkal --- include/linux/sched/topology.h | 8 -------- kernel/sched/topology.c | 4 ---- 2 files changed, 12 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 76a662e1ec24..7f3dbafe1817 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -143,9 +143,7 @@ struct sched_domain { unsigned int ttwu_move_affine; unsigned int ttwu_move_balance; #endif -#ifdef CONFIG_SCHED_DEBUG char *name; -#endif union { void *private; /* used during construction */ struct rcu_head rcu; /* used during destruction */ @@ -201,18 +199,12 @@ struct sched_domain_topology_level { int flags; int numa_level; struct sd_data data; -#ifdef CONFIG_SCHED_DEBUG char *name; -#endif }; =20 extern void __init set_sched_topology(struct sched_domain_topology_level *= tl); =20 -#ifdef CONFIG_SCHED_DEBUG # define SD_INIT_NAME(type) .name =3D #type -#else -# define SD_INIT_NAME(type) -#endif =20 #else /* CONFIG_SMP */ =20 diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 9748a4c8d668..88bd9344730d 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1635,9 +1635,7 @@ sd_init(struct sched_domain_topology_level *tl, .max_newidle_lb_cost =3D 0, .last_decay_max_lb_cost =3D jiffies, .child =3D child, -#ifdef CONFIG_SCHED_DEBUG .name =3D tl->name, -#endif }; =20 sd_span =3D sched_domain_span(sd); @@ -2338,10 +2336,8 @@ static struct sched_domain *build_sched_domain(struc= t sched_domain_topology_leve if (!cpumask_subset(sched_domain_span(child), sched_domain_span(sd))) { pr_err("BUG: arch topology borken\n"); -#ifdef CONFIG_SCHED_DEBUG pr_err(" the %s domain not a subset of the %s domain\n", child->name, sd->name); -#endif /* Fixup, ensure @sd has at least @child CPUs. */ cpumask_or(sched_domain_span(sd), sched_domain_span(sd), --=20 2.43.0