From nobody Mon Feb 9 19:38:08 2026 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2051.outbound.protection.outlook.com [40.107.102.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF3E14C5AE for ; Wed, 18 Dec 2024 04:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734496928; cv=fail; b=p7nRfqlacNBprKPOEH5PiMIi9iHzAZzusrvAzgtrIe40TrEBAMnrXtJV3aJZXNFuc4ETz5fLpsUtf0r1MjmoArNWK1xXz2O91sB1kvXFyM3/0Ghr7ZSfY4/j+S08uRk5ZTj6vWkQhoKaB1ZadYttrz0MlcMYIl36KVZUEhzyAF4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734496928; c=relaxed/simple; bh=i8azNZxjepl7pyHNOMW+0mTY3oHzGYx5skBE5Mc9ocs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MJ5VyV0CAfBbBBdzZDIhbOeUJ/bc/HKL1x/s3zCLWtWGDrYraYHi9RrpzyULDutGF40t3tOdhnztlXA9elp0phuemh7+IIdb0KJ0VXjacKnx6+BmyvJR20wOkxJfsn8meW3GnFb0utJjf25dItgLmo8oBG40Yts0MYDWguC6rSc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yrsSh7sM; arc=fail smtp.client-ip=40.107.102.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yrsSh7sM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iEwqMVlxTKcHiaiILoZg64YSiDdN4xDkFrAS9vr2vw0HLX24KjOSwGZqllM++PaCMnMSmVh13jWrmshGmQUgNhEhceHLl33TpxxjDH4B+4TcDgAWp13smTdG7ntuVqotiX6bu4pp64m9qN6n/I9vD2CmKT3Kl2SRhG/MWBiHvzIwZS2XyslZ/YZxESgP/WZ9b0vfUjeNsDBT2yZOQ7HHVcfbL3ckvN11X9Yti+2YAY5/IS4BqbRLPrHM/RNVX76DL76faNH58I1ydICbSTJLMI9TETbR/TVYdclFylpcQvAiiW/Kq3uYL535U/6iLeER/WEnULqryEFAO5ae1wmF6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aGYVzc2sx2R9lYsNYnNaqCFlzEFS/FgxzISItGwk+XU=; b=pfrEUgfxxZaJdBoGkMZ0vIdDqI0cYyZLvqMSoNTLkC6Mx2N61+rOvZMjHsKfvSNn0IZweN9fxesfCBwNYh7RJnyo38fgmQyRPhn0Lbg6qSDdaKKxS6MWTaWQ4B/W1t5WdIe8af57H8Vmx5p5vITDbOTjVSkjB/D8QOMunpgAn5enm3MufQUE9MaHp3jdPFEuSKD+K5U4PH60CM8G4HRnnHALbqCXctPPg2E+4HTIRgVu0iJcx1HwAs16jrg8wALmVPpVYHMK22Rx/pqYdgAWNjqA3U4CHbGbV0Aewr5Lr4hx42T00gwvDaKA7LQv2kM1Ci4oPEtuz8f98fXktKN8kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aGYVzc2sx2R9lYsNYnNaqCFlzEFS/FgxzISItGwk+XU=; b=yrsSh7sMhwQ8W+7Ja6D2q2OR8Lay8kb06uGcgihqx5zFlTSWW55Vl8G8YBGDAathQHa4syU3jrI3QxBOyf98ydKZXeN8QJ1yCRD15GG6JrSW37LiXFlig8vQ7X8U9fsL3Nxydr0J0SEf5/ypkss1prRNsQ5ATcuSl4PJlc58LRI= Received: from BN9PR03CA0064.namprd03.prod.outlook.com (2603:10b6:408:fc::9) by MN2PR12MB4109.namprd12.prod.outlook.com (2603:10b6:208:1d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.22; Wed, 18 Dec 2024 04:42:03 +0000 Received: from BN2PEPF000055DE.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::dc) by BN9PR03CA0064.outlook.office365.com (2603:10b6:408:fc::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8182.20 via Frontend Transport; Wed, 18 Dec 2024 04:42:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DE.mail.protection.outlook.com (10.167.245.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8293.6 via Frontend Transport; Wed, 18 Dec 2024 04:42:02 +0000 Received: from tapi.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Dec 2024 22:41:16 -0600 From: Swapnil Sapkal To: , , , , CC: , , , , , , , , , , , , , , , Swapnil Sapkal Subject: [PATCH 3/6] sched: Report the different kinds of imbalances in /proc/schedstat Date: Wed, 18 Dec 2024 04:36:26 +0000 Message-ID: <20241218043629.1142651-4-swapnil.sapkal@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241218043629.1142651-1-swapnil.sapkal@amd.com> References: <20241218043629.1142651-1-swapnil.sapkal@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DE:EE_|MN2PR12MB4109:EE_ X-MS-Office365-Filtering-Correlation-Id: 15765374-912c-4b75-bed9-08dd1f1e50ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KIw2KJXgLnryNqjfJt16ejnFwnj3X7L0BkuR7bcW4drulemIkxPqor531b5o?= =?us-ascii?Q?gx3JhfaLeNd0Sp0yvqW3fiSL54naBlU3VoEh7RPWFp8itgwR7jMcGUw4EIFg?= =?us-ascii?Q?WGBaJGrvLFJ/5Ma2Na2WJtqEHYenyvt1ai/obi0a7ZhGmfUZHDDsqWKS9TR/?= =?us-ascii?Q?GLo2FYXokS+A2S4AIMNRtbrUuRoVEB9DOmwUo9eWHZE2Txxwm71x1Ae6HWz4?= =?us-ascii?Q?GKuLBMrf2Pi18HJMqIqfJYyrYYfd4pPHoJ+1jJihzsffgSIJpKDylCKzin1r?= =?us-ascii?Q?cNcYD8TOTkk0S2Do8zoyKszRJn/JNikrEqNx1zUTWeI8Y9sg4tZxJn9OIQpY?= =?us-ascii?Q?0XBd0Q0LHNEB2+swrayEQScPBrXyKZV78YbrmXhh77Nj06M50Z7Bmnih+OPy?= =?us-ascii?Q?Cis4SefXIXYsmJ+GLo3zUrElrBEtC50K3geOyeoYXdzzjJlyiGFdv9Toxtsf?= =?us-ascii?Q?L4AekJpyFjD6zH4RDTGn0uYnJvHPydzR/8GC3PPBH45Bjk0jPTrP/IWLFMBV?= =?us-ascii?Q?QcYMUg/sNcNT+b/t5VRYXLPLn21L1quwEHdwbGVjdCttY3KI4U4eD7JhgSo6?= =?us-ascii?Q?SC+yiWi0IoT+acy0g2LGATfbLi6tkGvFKekZ/OH/iCer71kRkxN9F9JFTfHG?= =?us-ascii?Q?6bAQmPEyz7/LzV6unk7SB5T8fQm+DgEnxg5ygjXfjUKMHbhgVJx9nxzx7eoG?= =?us-ascii?Q?N2+l3zdMrF8nXw1uNC3+C3qbjDw8CaNDRmKFhkpQZGycJ4rYLaRXVw7HdpHs?= =?us-ascii?Q?QCsWZl/dLYfPu1iS+JhXkcaFzFcQdadxP2J1GzbuH73CnI0/myMpJF68EGuz?= =?us-ascii?Q?zBrQBMqWnKRY8pmvGEPalrrZX+Vovpwoiya2AUhOLULjIOO0xnCHvNMIwUls?= =?us-ascii?Q?4ks0NQJigQDWFBpb6dgnrE8XL27dJO2f7ZvKfswItOULAJKHNPZ/P5l0Drbg?= =?us-ascii?Q?A8arzoE2wV+Xat3YIRgk7wKoO23YSTIUa6FQ/RXK1bI3e7dyHqoK5qpC4jio?= =?us-ascii?Q?N4Aojgn9WjRTuizSF5vc25py3zyMumddj42XPJHgNK3dDOUTGiH4ci93k2ey?= =?us-ascii?Q?Puv6e5b3bR+mYUlkZOP+2whwuM4B9LubMxlG0EcPRntjUK5sCLZkiagX+Zjf?= =?us-ascii?Q?gNOQEK4bCnvNQwxaAlTwPPb5814eJvEyRZyPyGeN4oS5GOZItGi2YDS0Yef7?= =?us-ascii?Q?qbovWJefua+ONIZbK2oBZrBGagte/DN/7j2ircIBiuR7UPUVqIYxqbW5UCyA?= =?us-ascii?Q?ype1kJqi3pEb1Tk7/uEhK9KEf8J8hb0HKnhYOrI7lqO2P88tggb7gSD/qqNv?= =?us-ascii?Q?M2eHuTAr7aE7z4x4I9aAO9DdDuklncd4Myd1Fx799/sLcGkYL/cFVG29sgdn?= =?us-ascii?Q?4phWsemQDCGnTnsquPIAvYInthfR6Zjbr5OE2Cj4/tLuIe8Ve9rOOUxUsvc5?= =?us-ascii?Q?WLB0FP/mpRnZWdSUlFk1FPhPsExrftO+?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 04:42:02.0641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15765374-912c-4b75-bed9-08dd1f1e50ca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DE.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4109 Content-Type: text/plain; charset="utf-8" In /proc/schedstat, lb_imbalance reports the sum of imbalances discovered in sched domains with each call to sched_balance_rq(), which is not very useful because lb_imbalance does not mention whether the imbalance is due to load, utilization, nr_tasks or misfit_tasks. Remove this field from /proc/schedstat. Currently there is no field in /proc/schedstat to report different types of imbalances. Introduce new fields in /proc/schedstat to report the total imbalances in load, utilization, nr_tasks or misfit_tasks. Added fields to /proc/schedstat: - lb_imbalance_load: Total imbalance due to load. - lb_imbalance_util: Total imbalance due to utilization. - lb_imbalance_task: Total imbalance due to number of tasks. - lb_imbalance_misfit: Total imbalance due to misfit tasks. Reviewed-by: Shrikanth Hegde Signed-off-by: Swapnil Sapkal --- include/linux/sched/topology.h | 5 ++++- kernel/sched/fair.c | 21 ++++++++++++++++++++- kernel/sched/stats.c | 7 +++++-- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 4237daa5ac7a..76a662e1ec24 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -114,7 +114,10 @@ struct sched_domain { unsigned int lb_count[CPU_MAX_IDLE_TYPES]; unsigned int lb_failed[CPU_MAX_IDLE_TYPES]; unsigned int lb_balanced[CPU_MAX_IDLE_TYPES]; - unsigned int lb_imbalance[CPU_MAX_IDLE_TYPES]; + unsigned int lb_imbalance_load[CPU_MAX_IDLE_TYPES]; + unsigned int lb_imbalance_util[CPU_MAX_IDLE_TYPES]; + unsigned int lb_imbalance_task[CPU_MAX_IDLE_TYPES]; + unsigned int lb_imbalance_misfit[CPU_MAX_IDLE_TYPES]; unsigned int lb_gained[CPU_MAX_IDLE_TYPES]; unsigned int lb_hot_gained[CPU_MAX_IDLE_TYPES]; unsigned int lb_nobusyg[CPU_MAX_IDLE_TYPES]; diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ec403e81ffef..91f33cb9fb23 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11659,6 +11659,25 @@ static int should_we_balance(struct lb_env *env) return group_balance_cpu(sg) =3D=3D env->dst_cpu; } =20 +static void update_lb_imbalance_stat(struct lb_env *env, struct sched_doma= in *sd, + enum cpu_idle_type idle) +{ + switch (env->migration_type) { + case migrate_load: + schedstat_add(sd->lb_imbalance_load[idle], env->imbalance); + break; + case migrate_util: + schedstat_add(sd->lb_imbalance_util[idle], env->imbalance); + break; + case migrate_task: + schedstat_add(sd->lb_imbalance_task[idle], env->imbalance); + break; + case migrate_misfit: + schedstat_add(sd->lb_imbalance_misfit[idle], env->imbalance); + break; + } +} + /* * Check this_cpu to ensure it is balanced within domain. Attempt to move * tasks if there is an imbalance. @@ -11709,7 +11728,7 @@ static int sched_balance_rq(int this_cpu, struct rq= *this_rq, =20 WARN_ON_ONCE(busiest =3D=3D env.dst_rq); =20 - schedstat_add(sd->lb_imbalance[idle], env.imbalance); + update_lb_imbalance_stat(&env, sd, idle); =20 env.src_cpu =3D busiest->cpu; env.src_rq =3D busiest; diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c index eb0cdcd4d921..802bd9398a2e 100644 --- a/kernel/sched/stats.c +++ b/kernel/sched/stats.c @@ -141,11 +141,14 @@ static int show_schedstat(struct seq_file *seq, void = *v) seq_printf(seq, "domain%d %*pb", dcount++, cpumask_pr_args(sched_domain_span(sd))); for (itype =3D 0; itype < CPU_MAX_IDLE_TYPES; itype++) { - seq_printf(seq, " %u %u %u %u %u %u %u %u", + seq_printf(seq, " %u %u %u %u %u %u %u %u %u %u %u", sd->lb_count[itype], sd->lb_balanced[itype], sd->lb_failed[itype], - sd->lb_imbalance[itype], + sd->lb_imbalance_load[itype], + sd->lb_imbalance_util[itype], + sd->lb_imbalance_task[itype], + sd->lb_imbalance_misfit[itype], sd->lb_gained[itype], sd->lb_hot_gained[itype], sd->lb_nobusyq[itype], --=20 2.43.0