From nobody Mon Feb 9 12:38:01 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F6C126F1E for ; Wed, 18 Dec 2024 03:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734493202; cv=none; b=IkEogAl4pJzYGDhES6Z57MNz5/aL+lmUUZ6xe5jDlhAR/enlr2HtRXWjwKHXFV0++f+A5W7q5fMmXsQTYlWHOcHGfLf9ZtAQDvsgoawhm1t+HNP4TFOz3J6t+xFWLtBEz9YUAWlxwrrrRnCRwaIb1b8y8O8Gb1/X6LWwjuFBX6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734493202; c=relaxed/simple; bh=LPWz2sDPapOxa2hV5coj1rs/SVArKFy4Iqh3DcyI3M8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Zn1f3a2qFCS8mHTDxCsRUlWXlaKNkp0E39HjsWeIN/YOzL1Ytu8RuBQflLg8PrV/pP1x+7VevCna2kCJP5Zs+0gfogXge59kxTn9Vk84u0h5/hVSlq2u6l7I0uHT9MKFw2mZIFbnGuRSpAD3vI7MIRqEz3vMwajron5li8Mx8WE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=pf.is.s.u-tokyo.ac.jp; spf=none smtp.mailfrom=pf.is.s.u-tokyo.ac.jp; dkim=pass (2048-bit key) header.d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.i=@pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.b=gGcfBQjs; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=pf.is.s.u-tokyo.ac.jp Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pf.is.s.u-tokyo.ac.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.i=@pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.b="gGcfBQjs" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-218c80a97caso14264235ad.0 for ; Tue, 17 Dec 2024 19:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com; s=20230601; t=1734493200; x=1735098000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2kx7Yo+7qnP6zfIGZjLQySFm7/eIdSqP5AxosAbTzEI=; b=gGcfBQjso4JF8mYSRKTs1bkVgW4NEMi0lBZ3hyZnj2y8iDN0+FqCFvOy+/c1fwuQq5 5HQ8Sp6AqhU4GpVuaeFxk9Dbz3aQE2B00RgxUbMAxfRivFbe89VMsIxUsCXPgLUl71ur W36hzUsUJwAzybLm9qgD3mLEbrNM5NSZWs6CCIsb8GBN0v03ljFAHqwb/tB9ZEU0ZgBb fYzS0UOBg3xpQJvJ/4RfWM7luws//y25SfiOKHcmwB8LXlQggLnxTLfGIDNokIkB8MO9 tma5Fy1oj+nu6ZvDurNWZOzPFDkApH40F8QEUHHWMxK4EqeQJNNUr+FGinm/VmTlBzvh 1Pgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734493200; x=1735098000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2kx7Yo+7qnP6zfIGZjLQySFm7/eIdSqP5AxosAbTzEI=; b=L3c4a006G0MSRsguBVuzlf6+i8C2hUOdAMAqALDM7Y/OQpBo0xWyCAVLGXBWqYsQOS SleSEFZejBVxX5ZshACO+VYLngbsBo70p/JB8hJG4B12iDbgoEoVfJs+Kyc52GSUjhX8 jukbm79eN7o7gowtpzIQKXFwv2Q9jpYHPh6FiavOmGcX/A7QbUXq5pE6lhaxWsyyXnPh izGnTUFwoRspfMMnSrpsHhtTGqORyg33LxjzwZtPY17g7kHM/wqLuS6KPhtbH0cPJmoT OXlSRs0if4gF64iKnMjeAzAdHjNms3m3zZ1iHlzKkrzD7XIn/wRuXu+WVNBoUJSHJM+5 93CA== X-Gm-Message-State: AOJu0YyxFgX8kz5QLnfb56XnzfDgqkpx4q6tdZp9j4Sba39/I/wWb9+b jb3XBptKgQpwofiauM8sIflO8D33TqYfE7PB3lq8ErLWA1ebwWgKkJ+MAbyHOXU= X-Gm-Gg: ASbGncvPAxDSuJaullaGSKRXVntT2Qr8u2HfHnvtrqymlibUkBOii9SHI/QDCqtFUdT ugIXs2+AWG8VI0AUwDx+6QdSYR08f9hkJ4KBoWy4Jcw24jjFPi+ZfsOqcjjXBfoSG6cU5mujdyn q5iGEIzgII/kFEwkHSHoVjagf+f8XSip7onYNkv/HWubgXLyh54LbWUSZ8BchLeO7rd2ENHMFAn ZZP0NCg9WCk+RWMy2nv8UwmfEzhmHGMO7N7Ac8m9olv5VFGrIGXMtCYyNywhjj1cHFNNXrG/pCA XOBfLvJi0HtpslhJuPe5zbTszNitHT02eYAFt17Sztw= X-Google-Smtp-Source: AGHT+IGxf86QWksuWZYr5xG7V/WIeNdKu0q0dfVahhmabXKXtRQ3lKVaAw/mU9jIR7s6miD7dT6KCA== X-Received: by 2002:a17:903:90f:b0:216:3b31:56c2 with SMTP id d9443c01a7336-218d726cba9mr17644675ad.53.1734493200191; Tue, 17 Dec 2024 19:40:00 -0800 (PST) Received: from localhost.localdomain (133-32-227-190.east.xps.vectant.ne.jp. [133.32.227.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1dcccadsm66265725ad.103.2024.12.17.19.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 19:39:59 -0800 (PST) From: Joe Hattori To: sboyd@kernel.org, mchehab+huawei@kernel.org Cc: linux-kernel@vger.kernel.org, krzk@kernel.org, Joe Hattori Subject: [PATCH v2] spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup Date: Wed, 18 Dec 2024 12:39:54 +0900 Message-Id: <20241218033954.940888-1-joe@pf.is.s.u-tokyo.ac.jp> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" spmi_controller_probe() increments the refcount of an OF node, but does not release it. Instead, call of_node_get() in spmi_controller_alloc() and release it in spmi_ctrl_release() to avoid the reference leak. Also remove the lines in spmi_pmic_arb_bus_init() and spmi_controller_probe() where a pdev's of_node is stored after spmi_controller_alloc() is called. This bug was found by an experimental static analysis tool that I am developing. Fixes: e562cf3aea3e ("spmi: hisi-spmi-controller: move driver from staging") Signed-off-by: Joe Hattori --- Changes in v2: - Remove the store to of_node in spmi_pmic_arb_bus_init(). --- drivers/spmi/hisi-spmi-controller.c | 1 - drivers/spmi/spmi-pmic-arb.c | 1 - drivers/spmi/spmi.c | 3 ++- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-c= ontroller.c index 3cafdf22c909..dd21c5d1ca83 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -301,7 +301,6 @@ static int spmi_controller_probe(struct platform_device= *pdev) spin_lock_init(&spmi_controller->lock); =20 ctrl->dev.parent =3D pdev->dev.parent; - ctrl->dev.of_node =3D of_node_get(pdev->dev.of_node); =20 /* Callbacks */ ctrl->read_cmd =3D spmi_read_cmd; diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 5c058db21821..73f2f19737f8 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1746,7 +1746,6 @@ static int spmi_pmic_arb_bus_init(struct platform_dev= ice *pdev, irq_set_chained_handler_and_data(bus->irq, pmic_arb_chained_irq, bus); =20 - ctrl->dev.of_node =3D node; dev_set_name(&ctrl->dev, "spmi-%d", bus_index); =20 ret =3D devm_spmi_controller_add(dev, ctrl); diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index fb0101da1485..e662a7a78df2 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -36,6 +36,7 @@ static void spmi_ctrl_release(struct device *dev) struct spmi_controller *ctrl =3D to_spmi_controller(dev); =20 ida_free(&ctrl_ida, ctrl->nr); + of_node_put(dev->of_node); kfree(ctrl); } =20 @@ -458,7 +459,7 @@ struct spmi_controller *spmi_controller_alloc(struct de= vice *parent, ctrl->dev.type =3D &spmi_ctrl_type; ctrl->dev.bus =3D &spmi_bus_type; ctrl->dev.parent =3D parent; - ctrl->dev.of_node =3D parent->of_node; + ctrl->dev.of_node =3D of_node_get(parent->of_node); spmi_controller_set_drvdata(ctrl, &ctrl[1]); =20 id =3D ida_alloc(&ctrl_ida, GFP_KERNEL); --=20 2.34.1