From nobody Thu Dec 18 18:51:22 2025 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F20AF1FCF74 for ; Wed, 18 Dec 2024 21:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734557971; cv=none; b=Vfx1M3Y7eDYsZSkTERLnpkHyRm4q1mmevahy2+cU5uBojbzBuVvaA9LqckVf8WnVc8FjCyGs2zL9I0STb5olQSWtDTnA+BaxdlXpXNJ9T8+JGqadn/UzqW5SvwM+I9gZxne+wmOEd8lTsCDo2FoRwJpWI61A9xVsuG+Fof4VU9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734557971; c=relaxed/simple; bh=DhBuuSW9MUIQpcqfUsKuLLo1g4KmmcRnk8ucnEiFIdI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S5SIbJN5Qaw0f6HpBSwga2XCxvg9mxSfKp16cCo6YblfKkfvwlnpW+11dA7WMGIXp8M9IUplnSZ4NPF2xIykyxCZoHUYRoWT4V2FayzRcdbiPxu5cXclUuieY8jJ2bZq7kx9L49yp1MMvEXwyNbG5/T28i3odTAKKI4Zq8s2cxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZSnYYNwd; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZSnYYNwd" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-467a17055e6so583171cf.3 for ; Wed, 18 Dec 2024 13:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734557969; x=1735162769; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vcx11cNcczSAZshcCeyKTXI0xmNNHV+eiS3phSI5Ghw=; b=ZSnYYNwdPIr4Wmj3UL1BsGELGijOmIV5DfmbfAL2LpOdRlpVDw/f73fVXd5YzJzC6x kIBNzFdmLgMgzO0rVEho+O0vHrLbebcNiFlLl+gS/wLoBD1psCPZ8Ob26ZDxqn7BEvAu EGgNfp6hLWBUYm+PjU/bpSwSi8UQF6Pn6L5hw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734557969; x=1735162769; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vcx11cNcczSAZshcCeyKTXI0xmNNHV+eiS3phSI5Ghw=; b=pLvWIdpTe06PRzXx1tGhMg/92RJ3vXV2oo69rncXoWMFpbjwHTfTTbkOB9UgqaY/Sh mI/Yf4Ldb9B699OuqB4BkAMlbQv4jLnBDi9NdGzJce51MIu7WCGo5gy1bK0Y7yYuztyO r+KwtjuajQSCPL2/KswCU8HUuK+Og8pOUoqZLgwdj5z4ljmCU3HvyveU65xrp8WgDjYi NFAFelUUY/yUUFrpJiuVfrxnkh/y3bSrTExWE49YbmMl8CAR0hJfX9BfU2O4JROHUZBv i+261KH+OduKd141lar7rGQA1gKkEfoz8O82sDRi4zA/sUlQgos11/T+Y4UOjakrSTdH u6Pg== X-Forwarded-Encrypted: i=1; AJvYcCWBmHRtPnMYBLlCGN1FkWIIZdVbENTm0gNNzMjvgJ/lyf0M9bmFm4ixeImNypsmV+rmoWLEy15IvkuKn1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyzXFxdYjqqm5s2ytL1kZZZ+OuGYSMhUDlxCJAEKhdI3dU1AHZS s/3zqKhXHzNJOy/2vzkSr66+yNtqcw3uwuldTRN4wZtwCWbDm2xFbHGEcukPng== X-Gm-Gg: ASbGncuJlApucEgpwla2I2X8eUtINgqL6zAGhM0BPB4hnv+WehsR8hfT6gkjwl/Ltwl kb0bL0VUZisfEoUtH0JJ51fOJ+/sCkAhl4WSRcag02J2LQiOd8jH5IozvQ/MnYDIe/5oSP4piWs tE9q+a5c8C6hn5GVM59b6P3gTGC+30uPi+6ptERLpvp25iYfzhgUTbOJPWW+AQDucsXgIhUlX16 RwI124CVfllwr10d4DRbiwxX4+G+Xe3bPCicPR1Q/joCYFjjimvPRix+OCmv9WYF0/v3Kxr9tfJ xc9K17XCmC0SRUc9YpgwEEjcOVqQsn8= X-Google-Smtp-Source: AGHT+IHAFG2tbIFDyqlrvTJzXNQ7OmWJs8w6/+hb962JqnaH0dxvvp85RBnT6p4L5Azr1IBWby2OuQ== X-Received: by 2002:a05:622a:309:b0:467:54f4:737b with SMTP id d75a77b69052e-46908e1ed90mr61838381cf.25.1734557968851; Wed, 18 Dec 2024 13:39:28 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2c6e312sm55176651cf.8.2024.12.18.13.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 13:39:27 -0800 (PST) From: Ricardo Ribalda Date: Wed, 18 Dec 2024 21:39:09 +0000 Subject: [PATCH v2 2/4] media: uvcvideo: Invert default value for nodrop module param Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241218-uvc-deprecate-v2-2-ab814139e983@chromium.org> References: <20241218-uvc-deprecate-v2-0-ab814139e983@chromium.org> In-Reply-To: <20241218-uvc-deprecate-v2-0-ab814139e983@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The module param `nodrop` defines what to do with frames that contain an error: drop them or sending them to userspace. The default in the rest of the media subsystem is to return buffers with an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags. In UVC we drop buffers with errors by default. Change the default behaviour of uvcvideo to match the rest of the drivers and maybe get rid of the module parameter in the future. Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index b3c8411dc05c..091145743872 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -32,7 +32,7 @@ =20 unsigned int uvc_clock_param =3D CLOCK_MONOTONIC; unsigned int uvc_hw_timestamps_param; -unsigned int uvc_no_drop_param; +unsigned int uvc_no_drop_param =3D 1; static unsigned int uvc_quirks_param =3D -1; unsigned int uvc_dbg_param; unsigned int uvc_timeout_param =3D UVC_CTRL_STREAMING_TIMEOUT; --=20 2.47.1.613.gc27f4b7a9f-goog