From nobody Thu Dec 18 18:50:10 2025 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3900B1FD797 for ; Wed, 18 Dec 2024 21:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734557969; cv=none; b=lrncJ/x3Y3uasE9n83JiIo7jab8/IVUfI6RvsOozPESW/VcBgNTkY3xgANqW8M12yBQcU6jopcP6Cff4fDErImKdcqYzw/GLQESA/qEDKAKOdbr1HeSq+zD/GoL1TjtWf8AP6pikwlatsArLGue3dlIw/eu1J7AwE1nACueiD80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734557969; c=relaxed/simple; bh=qyRuVIeUYyOK0Q3PlRcwjQXuqSyYOCeaRPkUH3obUhU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OzdWH/y/A/kJE3kIFV/KvAPJmYvAQAagffPpxtaVZbUdedqDTiOJ8CESmoQRUq46Rlvw2xkuWn/RXWNMJrlxAQLZonEJR8Dv2pzzpnjaSLb3TDUYHWv31I0LITTfN6HNHTQFky21RuZUKty4TETqfbxVgsWCWI2vY9yCZZkOaHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=oS/MOZa5; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oS/MOZa5" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4679fc9b5f1so450411cf.1 for ; Wed, 18 Dec 2024 13:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734557967; x=1735162767; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Xf/EiHgc9x+QegkQdQE1ivkIRei7ICvkT+RDLhyzgnI=; b=oS/MOZa5afkdSu7++ElAHkZX5yAWwbJnFC7zQPogl97LjcmlMYLcdHsRR5Y39oJ3rr zzgRoFjaAYSlxEFx3zoYpe6AyCksEIC3pqtXqffoC943/cZGukA9K/3ifcQQyAgt09IV XLE5Ki+TF16YFp/YNXnC4sKTPCRdTfhnxzY4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734557967; x=1735162767; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xf/EiHgc9x+QegkQdQE1ivkIRei7ICvkT+RDLhyzgnI=; b=dIL+HI2fWcGL8EVmKPwusqI64TvCUpt9D9dTLBYG7MVo8gs5SOGeFmou+9CTlBVsha AVTHiCp5HebS7YhnFnRC1NdHHSJSjHFdLugXbeiCFrZdE0W8hzSchMORNH1M5qg0/Pq/ 3jG5HCH+XoOYpeY/2OqOkRQ9W2uzF+L1Apb0KdJbQcJrbEfIU/SXBqSs0e2d7+cDlhUd 6apVxGngFfW+UnTJGWnMrrZgPx1NAGpwvMdG7FPMeoRN4FGPTGEPjsxEFqb+1c6C4ck3 jFRCbFFVMLOt5QvEGKr8NfoTmowCTZhI7lkj0ix8dx/MuUv9THZqBn0INq0zafcoK99S X2og== X-Forwarded-Encrypted: i=1; AJvYcCVk1M/i9S1im2kon9O9xLW4I5oMWjKeITbl6on8lVPlBladhiT1WAIPX5MeXNcn2/msdDxEzGpjo6Ph7Fo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9aIpZQl7rTGCMep74dZzzDcNC4ZZwzVbI9MFk2+Xr2GXEWm9z MSUPpET+6AoRJeEqfDMUw/6Bn0ux/YvyRRfdYs/jEUSsVO/Va3j7z4S9UFCgEA== X-Gm-Gg: ASbGncv5AswH3jzteNfit+eoIQzi48LHTWCV7pKanqal34r7dYX8KvYg+f7NKBHROPv NJ21J664XkiBxR8LMLYZzDw7SygdV7aIM2Ad+qgpMMhPW4ezbuEp25j/CGWMxZZ1qq2LY7X4jyE L5vg2r4fd0HyhvZJMnTuwLmcQWP8mJRwDDp9FouRDtaX3KwqloWKa8L83cbz0ZnsByo7brmYmT2 KjVZKWNNAYKTPuHhsSLfc0Un/dKqEmr71ix2BUYFmW4vHeSiWD1g77k6vpt++7Fsh2pWVVZ+Y9L APuB/y1UngRxOFeoaLNQRO9v33HA6Wo= X-Google-Smtp-Source: AGHT+IGkLS9CMqZYLYYP5mdA8pjf23N/QyaWNYPecd0D7EIeWJo2+DJRQufGdZrMAa+2pzD2K1+kHg== X-Received: by 2002:ac8:5782:0:b0:467:5ea8:83df with SMTP id d75a77b69052e-46908e03aeamr61025111cf.30.1734557967098; Wed, 18 Dec 2024 13:39:27 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2c6e312sm55176651cf.8.2024.12.18.13.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 13:39:25 -0800 (PST) From: Ricardo Ribalda Date: Wed, 18 Dec 2024 21:39:08 +0000 Subject: [PATCH v2 1/4] media: uvcvideo: Propagate buf->error to userspace Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241218-uvc-deprecate-v2-1-ab814139e983@chromium.org> References: <20241218-uvc-deprecate-v2-0-ab814139e983@chromium.org> In-Reply-To: <20241218-uvc-deprecate-v2-0-ab814139e983@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Now we return VB2_BUF_STATE_DONE for valid and invalid frames. Propagate the correct value, so the user can know if the frame is valid or not via struct v4l2_buffer->flags. Reported-by: Hans de Goede Closes: https://lore.kernel.org/linux-media/84b0f212-cd88-46bb-8e6f-b94ec3e= ccba6@redhat.com Fixes: 6998b6fb4b1c ("[media] uvcvideo: Use videobuf2-vmalloc") Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_queue.c b/drivers/media/usb/uvc/uvc_= queue.c index 26ee85657fc8..f8464f0aae1b 100644 --- a/drivers/media/usb/uvc/uvc_queue.c +++ b/drivers/media/usb/uvc/uvc_queue.c @@ -479,7 +479,8 @@ static void uvc_queue_buffer_complete(struct kref *ref) =20 buf->state =3D buf->error ? UVC_BUF_STATE_ERROR : UVC_BUF_STATE_DONE; vb2_set_plane_payload(&buf->buf.vb2_buf, 0, buf->bytesused); - vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_DONE); + vb2_buffer_done(&buf->buf.vb2_buf, buf->error ? VB2_BUF_STATE_ERROR : + VB2_BUF_STATE_DONE); } =20 /* --=20 2.47.1.613.gc27f4b7a9f-goog