From nobody Thu Dec 18 07:51:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 447DF148850 for ; Tue, 17 Dec 2024 19:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734465009; cv=none; b=k1lfT3H4Q6pqcQARYtPkB1TrwhLFzuXhpHwRvf0bK/gW8F7B+Cz9ddH2cT7Nr2FLxyMmdSsotBuWjey5bqFS8ecSettd+UxFh4FCbJevVBzposnVzAS+MWt6VM3RE4cJJwTXD7vcZtC4TKFgPXnFHKw30qrqRSxcDr4PEll0gg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734465009; c=relaxed/simple; bh=xaoGY3xOfNRHW2SsMhyh6UaqjjDud38OX4F7jRmwu7E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NZdDdlk9M1HTK6eTePlNriP5wtcL54Oe+m3LneBndCyyv5Ijo0OWraApuxu+asM8BFIeybWFTmXTuBsRkHTEunply1V4IY47M/UWi/JDtzoFhgDO50UiQnM1R2yvFXZFgh1K7+KweraoiE8Eg+xUu4RpaLbjwQC9sElFRIT3qCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=djW1Dqug; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="djW1Dqug" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734465006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QiZlarG1yu2H+EY33I6/wxU1gz8WjSpLM11KEi/0F6c=; b=djW1Dqugz0JXVCC+MEu+6UNoDsxVUpBvOoxzQjbOoCI++URnuYHVT9dfhhktodZm0L0B8E bzhTBrOca+uZnch7CCklf9UsL+kp6HRYW19YuWDYvoG9RF9MJaojgs0yYa3BaonaOyzcPd vEbhGiKbRkIn8aU2wPQrDs4UJ8XI1AQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-hFXU9FYrOIm9-ozlkarAVA-1; Tue, 17 Dec 2024 14:50:04 -0500 X-MC-Unique: hFXU9FYrOIm9-ozlkarAVA-1 X-Mimecast-MFC-AGG-ID: hFXU9FYrOIm9-ozlkarAVA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43631d8d9c7so204275e9.1 for ; Tue, 17 Dec 2024 11:50:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734465003; x=1735069803; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QiZlarG1yu2H+EY33I6/wxU1gz8WjSpLM11KEi/0F6c=; b=Cwn3JIMaCQIQCTKSwnoSOfkgL73QLVYx6aKvTwuGKYizb8aDsgHQeMOgXehALz0L9I vlh3tY0SXlpAe/rxYfuMCJ5m9aJ6tMBCquMFbOBPclEVIfzS1ar/6SN8weQpkOUZiZau 9QNVWqs2s+wLBAzoOjcgfRhZRrU7ncN6zD/dFH/co5eHf0xMRSmS6AC1kFahRp6pVmEe Z7plB1H4Bxuth55srOiz85wVC2NpZdseXosPfbw+BifBkwuPMMn9LNbi2uYjlXZFD234 CieRKsotIIr4Hgb1GATbS5W/RpBQNTKYHXmzoFNJUsK2HL0s/PySYlIfc2LROSkWjs5I ma/A== X-Gm-Message-State: AOJu0Yz4okRlrp3Xi8ENzLjFwE6GJNDo7gEUXCH1gsIPi1xi2G9/uIyK KIX/tr1vvnCFbijNd8d9waaG40HkXyx1365dMsHHcg56lRT9LDi6dEGX2EK37sCPUVcK4lzWl9E gcg5cNTETTaxENQTOcQwnGgKlPgW6mOdgv5rVdMxxDWaVIyS9LiiJDuwZeYSBR/tqJ08KTvkJUi m2ulhutTQrm4+HCED/K0j4ZhUzU/zKls5iW5bFYiylxA== X-Gm-Gg: ASbGncsUp89G92goFgXjXvex9xxFvp19mHpRJJcTj5bo5I6x6OmQZZEwyovwqGlEjyb uapppoK79bxwq6DYyjBIH9p6LiwZtmio8uWHa8z5/1lTsBeUaJN+QpJW20GZXET5qlE9UGvZN2g lP1WI/BtVatRMw97tV/RWOiBIJMU8ofkt5+RddHI5CdTbrwYjtEISdG1C0v/l1D7GGdjRn8JI3I hn1tUZdC9eCJ6BLWqbnfIln6aSCqNxz2EBQTW74xOKGgwLiS5JKJh0ZYe3nOw3smcycp9BXkoH2 iuVVoUdxbHQ+4pydW2aFOdUK0hs5kWwKVrIF7q8dHA== X-Received: by 2002:a05:600c:4fc6:b0:431:15f1:421d with SMTP id 5b1f17b1804b1-4364820bd31mr43596295e9.16.1734465003314; Tue, 17 Dec 2024 11:50:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGu01heuMRPqdAutYPFEMpZEU82k3XDseEOR+rvfMk6ZreF6rabCJOfIKhZbv7US17WUW2jqQ== X-Received: by 2002:a05:600c:4fc6:b0:431:15f1:421d with SMTP id 5b1f17b1804b1-4364820bd31mr43596125e9.16.1734465002900; Tue, 17 Dec 2024 11:50:02 -0800 (PST) Received: from localhost (p200300cbc739b8006397a28153925533.dip0.t-ipconnect.de. [2003:cb:c739:b800:6397:a281:5392:5533]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-388c8060862sm11817576f8f.100.2024.12.17.11.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 11:50:02 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Oscar Salvador , stable@vger.kernel.org Subject: [PATCH v1] fs/proc/task_mmu: fix pagemap flags with PMD THP entries on 32bit Date: Tue, 17 Dec 2024 20:50:00 +0100 Message-ID: <20241217195000.1734039-1-david@redhat.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Entries (including flags) are u64, even on 32bit. So right now we are cutting of the flags on 32bit. This way, for example the cow selftest complains about: # ./cow ... Bail Out! read and ioctl return unmatched results for populated: 0 1 Fixes: 2c1f057e5be6 ("fs/proc/task_mmu: properly detect PM_MMAP_EXCLUSIVE p= er page of PMD-mapped THPs") Cc: Andrew Morton Cc: Oscar Salvador Cc: Signed-off-by: David Hildenbrand --- fs/proc/task_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 38a5a3e9cba20..f02cd362309a0 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1810,7 +1810,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned lo= ng addr, unsigned long end, } =20 for (; addr !=3D end; addr +=3D PAGE_SIZE, idx++) { - unsigned long cur_flags =3D flags; + u64 cur_flags =3D flags; pagemap_entry_t pme; =20 if (folio && (flags & PM_PRESENT) && --=20 2.47.1