From nobody Thu Dec 18 00:09:17 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FA83398A for ; Tue, 17 Dec 2024 14:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734445307; cv=none; b=PaAzaI3brEqJ6Yp363MWfUM7g6ZnGbOJpSIuiQyFoA/EV3hsnPI6XqYpfrHI7hJv6GZArzYmS2NbQEnv2egw5b+LEYsTyBl6ZWeu23pO9M9moDuSafQTguX41Hs+4XZoa04+OBm3foY5Xllcuy+hzk/g7+j4fyBtQ7pjQJ1M+i0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734445307; c=relaxed/simple; bh=sWv5g63h/lelG/c0svQYP3qdi2ru2vaye3Lu8aYT+2M=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-type; b=PVMf7JqOEF5YYsNCKuBKNaGJEmGcsCTFmOLztD3Wypf+MSqzeWdYBwGfVT6YVOiOhc0Jg1DOH5d9wRuu7n5+trKuplbdIM2E02ZDFWHzUkcrvbLH5FC/U6mW9anx4ZTMSp+ltiIbgnQWGQaNxJWLCPWCdgs8Bvn+imFHWV2F0MU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=azoNqTfx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="azoNqTfx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734445304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Dr2EHbX/y+fl2ClFkwVxyN+xWUTEC0vyjnXgy6CKlY=; b=azoNqTfxNsZgIoFsqYjLE3eImRWjjIak/iUl17WV78gtvdSBQNgISRclwrKO4W9TJ+BkpF gSrqmroF5xqIZxSVNzrLfGqb9tFsSmV13tozbmL5/54O9JxXPu89GxMfozWpnJrC/XLL6o GkArT3fk+EqxNJ5UnSWCehd7Ea+LLEA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-JNTNR6fqP6mM5FabTD3yKQ-1; Tue, 17 Dec 2024 09:21:43 -0500 X-MC-Unique: JNTNR6fqP6mM5FabTD3yKQ-1 X-Mimecast-MFC-AGG-ID: JNTNR6fqP6mM5FabTD3yKQ Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385df115288so2240489f8f.2 for ; Tue, 17 Dec 2024 06:21:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734445301; x=1735050101; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Dr2EHbX/y+fl2ClFkwVxyN+xWUTEC0vyjnXgy6CKlY=; b=pes4hfSWpFvzq6HvM2DRWkbP/bCrskCtjNC1bUF/yeYTeq872WIYJ6dKNS8EWNY4LJ zugyktOz6YXSPS7wx41ze0p4s3Fk7uzc0ruCHbbVN/840J7dHgYiw4XaNh32x53BkxZA qj3wHiRCl8Qp8NG6iZxDNbjgVsx66lBqcVGuy7PEFcaoismIez1U8EfICdSrmLwn150x HchOdChau3gTuE9NbXMS1+5WuImnc2XaUGMjPE8pNIVMHRqHaPOGh1Ztd8I7pe7rebDU alfgZzAQ9w962/zdtlyKsjDGWWIfkZuNtqQe58m+AYMJn8zNJ3wBVZkKtEPRvYPmgf2f BaZA== X-Forwarded-Encrypted: i=1; AJvYcCWbOXW3jlLX+qLmoE9b+xTFrTX5AKjWNXqC1kDFjlbz5Wn73gioRucnMT8i3uN1ef4FO2gSi7AMQQ6dLe0=@vger.kernel.org X-Gm-Message-State: AOJu0YwSUDcI9RKdTzC5YbIXCGsXGjNptWR2Yi610z8BNfOPfRViE4VV JF8Ccbsorj4M5LD6EAsYA4PqFfpjdfnqqdMQvPYQqg9aG8/oddYiD5O7Jq4/RcsihhTGuZkvQ+f 6g76B9B6oohxB7cLH+/HgWmEN0m0OZ4udJXtj+aWgKG3dWpLpndkv4J4hROvdLIM5ef006Ojc X-Gm-Gg: ASbGncsWN1Rcqnz80qKKmr5wyjHLvBbpJbYas407J6qmycALHNojzwZ0Wsm02yFPQcX w4Zq8S5H2/KWXg+zGOF1hppamHU0aUDAr/KakjJFfgWqUO+YOvxHYOq6zrl25ekt2DDKWTYpLzs 1NqPQ/WXutDnqP27NwTrxekLJVcGKOK1A0qSfYkzTtbpJDvE/K7Rl0zGrVPI6tCW975a1DiBytO 8s5O0zDA43UPElDf2EgSlbtHZT8nP4oWpHguICWpPAC/lMmAKL/jcVhXVcgtg== X-Received: by 2002:a05:6000:787:b0:385:f114:15bd with SMTP id ffacd0b85a97d-3888e0b8614mr13448728f8f.37.1734445300983; Tue, 17 Dec 2024 06:21:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuGTV7yX6OAyCGz+mhik59B+KccVwP+GQIMkxCeBkGgKnKosocOSTTeZKg4gnWSMhLmmy2fw== X-Received: by 2002:a05:6000:787:b0:385:f114:15bd with SMTP id ffacd0b85a97d-3888e0b8614mr13448709f8f.37.1734445300580; Tue, 17 Dec 2024 06:21:40 -0800 (PST) Received: from lab.hqhome163.com ([81.57.75.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4362557c57dsm173106295e9.12.2024.12.17.06.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 06:21:39 -0800 (PST) From: Alessandro Carminati To: Catalin Marinas , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Alessandro Carminati , Thomas Weissschuh , Juri Lelli , Gabriele Paoloni , Eric Chanudet , Alessandro Carminati Subject: [PATCH v2] mm/kmemleak: Fix sleeping function called from invalid context at print message Date: Tue, 17 Dec 2024 14:20:33 +0000 Message-Id: <20241217142032.55793-1-acarmina@redhat.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Address a bug in the kernel that triggers a "sleeping function called from invalid context" warning when /sys/kernel/debug/kmemleak is printed under specific conditions: - CONFIG_PREEMPT_RT=3Dy - Set SELinux as the LSM for the system - Set kptr_restrict to 1 - kmemleak buffer contains at least one item BUG: sleeping function called from invalid context at kernel/locking/spinlo= ck_rt.c:48 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 136, name: cat preempt_count: 1, expected: 0 RCU nest depth: 2, expected: 2 6 locks held by cat/136: #0: ffff32e64bcbf950 (&p->lock){+.+.}-{3:3}, at: seq_read_iter+0xb8/0xe30 #1: ffffafe6aaa9dea0 (scan_mutex){+.+.}-{3:3}, at: kmemleak_seq_start+0x34= /0x128 #3: ffff32e6546b1cd0 (&object->lock){....}-{2:2}, at: kmemleak_seq_show+0x= 3c/0x1e0 #4: ffffafe6aa8d8560 (rcu_read_lock){....}-{1:2}, at: has_ns_capability_no= audit+0x8/0x1b0 #5: ffffafe6aabbc0f8 (notif_lock){+.+.}-{2:2}, at: avc_compute_av+0xc4/0x3= d0 irq event stamp: 136660 hardirqs last enabled at (136659): [] _raw_spin_unlock_i= rqrestore+0xa8/0xd8 hardirqs last disabled at (136660): [] _raw_spin_lock_irq= save+0x8c/0xb0 softirqs last enabled at (0): [] copy_process+0x11d8/0x3= df8 softirqs last disabled at (0): [<0000000000000000>] 0x0 Preemption disabled at: [] kmemleak_seq_show+0x3c/0x1e0 CPU: 1 UID: 0 PID: 136 Comm: cat Tainted: G E 6.11.0-rt7+ #= 34 Tainted: [E]=3DUNSIGNED_MODULE Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace+0xa0/0x128 show_stack+0x1c/0x30 dump_stack_lvl+0xe8/0x198 dump_stack+0x18/0x20 rt_spin_lock+0x8c/0x1a8 avc_perm_nonode+0xa0/0x150 cred_has_capability.isra.0+0x118/0x218 selinux_capable+0x50/0x80 security_capable+0x7c/0xd0 has_ns_capability_noaudit+0x94/0x1b0 has_capability_noaudit+0x20/0x30 restricted_pointer+0x21c/0x4b0 pointer+0x298/0x760 vsnprintf+0x330/0xf70 seq_printf+0x178/0x218 print_unreferenced+0x1a4/0x2d0 kmemleak_seq_show+0xd0/0x1e0 seq_read_iter+0x354/0xe30 seq_read+0x250/0x378 full_proxy_read+0xd8/0x148 vfs_read+0x190/0x918 ksys_read+0xf0/0x1e0 __arm64_sys_read+0x70/0xa8 invoke_syscall.constprop.0+0xd4/0x1d8 el0_svc+0x50/0x158 el0t_64_sync+0x17c/0x180 %pS and %pK, in the same back trace line, are redundant, and %pS can void %pK service in certain contexts. %pS alone already provides the necessary information, and if it cannot resolve the symbol, it falls back to printing the raw address voiding the original intent behind the %pK. Additionally, %pK requires a privilege check CAP_SYSLOG enforced through the LSM, which can trigger a "sleeping function called from invalid context" warning under RT_PREEMPT kernels when the check occurs in an atomic context. This issue may also affect other LSMs. This change avoids the unnecessary privilege check and resolves the sleeping function warning without any loss of information. Signed-off-by: Alessandro Carminati Acked-by: Catalin Marinas Acked-by: Sebastian Andrzej Siewior --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 2a945c07ae99..737af23f4f4e 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -373,7 +373,7 @@ static void print_unreferenced(struct seq_file *seq, =20 for (i =3D 0; i < nr_entries; i++) { void *ptr =3D (void *)entries[i]; - warn_or_seq_printf(seq, " [<%pK>] %pS\n", ptr, ptr); + warn_or_seq_printf(seq, " %pS\n", ptr); } } =20 --=20 2.34.1