From nobody Sun Dec 14 19:12:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D2C1F869D for ; Tue, 17 Dec 2024 18:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459118; cv=none; b=WNknncI2eJaX2DXLlNG32jkyeAkpm+knrVHNQDTkDRaFE16E3OzxZAcdvi+fwqDXU4w01CM61V0XqRdOXdPWPPk6s0tg32Ex550LRHn0ekcm5bigFSizqyOR4JjlHfdiSLBYptnP6gtv14NSxqDjRo3JOIrGNrd6bdywIa1I0Hg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459118; c=relaxed/simple; bh=CEymn1dapn9L+g1VujOTt+GizasEFssPjK9PHGiZzV0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eftY2IWwqkKInrKBWzGowlX6lHBcxoQB3qfpare0hBNjCMBU1puKMFr9vKONCZwIruWKYgvxmNw3uNfwMASCzTPfci/Lnzs5CgKrMnrvgED0JjqFZ9bWHBRPMB4JtU4bRY9ayVmwlgwJs68wRWwz7mvW93vXuQPc3S5TBxypoUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rW5mzLpR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rW5mzLpR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88018C4CED3; Tue, 17 Dec 2024 18:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734459117; bh=CEymn1dapn9L+g1VujOTt+GizasEFssPjK9PHGiZzV0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rW5mzLpRUZmMPMfwrPOLSvNWDY0Y8MLCq63tgBR5e1U5vZ+ooFeHLat8qsB87q37v +vWDOTSiBkV1hvsM+Nq+Q768NomnFyiVhKpsruu0syZ2QdbqYeq7YhZq/10Mg6RPrJ 0N/YRxCrVtbGtSFOL1/bwVJAy5u/Mv5i05KViZCEeZC3UP9DJWFFhwdarFs7XLZoM1 kS6GDIyjknB1EEZMOW2pGQLGqCJ3EPIZ+bI+8o9pe7M+S80cfSbeHarlAERpWVgDvG A2m5s0LB9VjgUtBnn4jZzCM8pWD8dKJD2xTKXy1d05YA9wb2ly9PhEH2QU7r/AkmF5 K84vafo7doEBg== From: "Rob Herring (Arm)" Date: Tue, 17 Dec 2024 12:11:40 -0600 Subject: [PATCH v2 1/3] mfd: syscon: Fix race in device_node_get_regmap() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241217-syscon-fixes-v2-1-4f56d750541d@kernel.org> References: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> In-Reply-To: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> To: Lee Jones , Arnd Bergmann , Pankaj Dubey , Heiko Stuebner , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Cc: Peter Griffin , Will McVicker , John Madieu , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.15-dev It is possible for multiple, simultaneous callers calling device_node_get_regmap() with the same node to fail to find an entry in the syscon_list. There is a period of time while the first caller is calling of_syscon_register() that subsequent callers also fail to find an entry in the syscon_list and then call of_syscon_register() a second time. Fix this by keeping the lock held until after of_syscon_register() completes and adds the node to syscon_list. Convert the spinlock to a mutex as many of the functions called in of_syscon_register() such as kzalloc() and of_clk_get() may sleep. Fixes: bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform = devices") Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Signed-off-by: Rob Herring (Arm) Reviewed-by: Pankaj Dubey Tested-by: Pankaj Dubey Tested-by: Will McVicker --- drivers/mfd/syscon.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 3e1d699ba9340f8135dfdeae6feca474980cc48d..72f20de9652da2d7bad12e4bc2c= 43ac0c9a97f76 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -27,7 +28,7 @@ =20 static struct platform_driver syscon_driver; =20 -static DEFINE_SPINLOCK(syscon_list_slock); +static DEFINE_MUTEX(syscon_list_lock); static LIST_HEAD(syscon_list); =20 struct syscon { @@ -54,6 +55,8 @@ static struct syscon *of_syscon_register(struct device_no= de *np, bool check_res) struct resource res; struct reset_control *reset; =20 + WARN_ON(!mutex_is_locked(&syscon_list_lock)); + struct syscon *syscon __free(kfree) =3D kzalloc(sizeof(*syscon), GFP_KERN= EL); if (!syscon) return ERR_PTR(-ENOMEM); @@ -146,9 +149,7 @@ static struct syscon *of_syscon_register(struct device_= node *np, bool check_res) syscon->regmap =3D regmap; syscon->np =3D np; =20 - spin_lock(&syscon_list_slock); list_add_tail(&syscon->list, &syscon_list); - spin_unlock(&syscon_list_slock); =20 return_ptr(syscon); =20 @@ -169,7 +170,7 @@ static struct regmap *device_node_get_regmap(struct dev= ice_node *np, { struct syscon *entry, *syscon =3D NULL; =20 - spin_lock(&syscon_list_slock); + mutex_lock(&syscon_list_lock); =20 list_for_each_entry(entry, &syscon_list, list) if (entry->np =3D=3D np) { @@ -177,11 +178,11 @@ static struct regmap *device_node_get_regmap(struct d= evice_node *np, break; } =20 - spin_unlock(&syscon_list_slock); - if (!syscon) syscon =3D of_syscon_register(np, check_res); =20 + mutex_unlock(&syscon_list_lock); + if (IS_ERR(syscon)) return ERR_CAST(syscon); =20 @@ -212,7 +213,7 @@ int of_syscon_register_regmap(struct device_node *np, s= truct regmap *regmap) return -ENOMEM; =20 /* check if syscon entry already exists */ - spin_lock(&syscon_list_slock); + mutex_lock(&syscon_list_lock); =20 list_for_each_entry(entry, &syscon_list, list) if (entry->np =3D=3D np) { @@ -225,12 +226,12 @@ int of_syscon_register_regmap(struct device_node *np,= struct regmap *regmap) =20 /* register the regmap in syscon list */ list_add_tail(&syscon->list, &syscon_list); - spin_unlock(&syscon_list_slock); + mutex_unlock(&syscon_list_lock); =20 return 0; =20 err_unlock: - spin_unlock(&syscon_list_slock); + mutex_unlock(&syscon_list_lock); kfree(syscon); return ret; } --=20 2.45.2 From nobody Sun Dec 14 19:12:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3321F8930 for ; Tue, 17 Dec 2024 18:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459120; cv=none; b=cfXDD8EVl6jxUsbTxhp0WwX9QM0pUVSds8HpLWPAPv2eMmuZHtXbaQYfEfVMP1rWastk/5J7gTPRI88fCoi9MswjWM81x25LI93P7oxO8ig/+2Mojw9atOAwqB7ByCrphgzWrPv5Fxhlto+lw0d6qL1ajh0SEjj8y3dnezO3T6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459120; c=relaxed/simple; bh=kpOrvxsnyhKACVQ2qsRTR3Nb4KrhnGtNpRfRPuIsYjg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oT1W4d7qDIq+cVqqD4zyP37A4BxtkljoklfUGmcaEHJFtioSFiUQtTepVI7DEV5/T49agD6zHDjEv4+n7q8dvRygEYYUOYIkar4/9TBOHVQESFg+nBHgiycbLvYEFunNpeM9e9rSrr98ywYBLJamt9g1MsKhCCN/O4fNYpQIsYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E0ltokNF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E0ltokNF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CC21C4CED7; Tue, 17 Dec 2024 18:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734459119; bh=kpOrvxsnyhKACVQ2qsRTR3Nb4KrhnGtNpRfRPuIsYjg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=E0ltokNFg7sPjq2BCTSCoR6FLN9OUNYcz44OAduYWcIEGL2xsONP3goHw5eFh05fP hVjFTZQdqoyCS1kvwnMjMU9VxHCUlFDiNcD/TDRfEvEVTT07ZsDm4+vFkiQo4Ggn9z mHm2FQI8Lci6zYulzLJiuhngBn0U7+wD7aTLn/nXabFeTTJ0Zzi5Voe8/0rhbVbMS+ GoaiDEOPrHAy6frh+DJc5H2E9Bx3aO2c/G8xXRb26T+WRRohVkbq8xO1sPjQPqJgmC A62rpgjIBPDtG5H4HmnE/b/yftZdliDvdyRc3e2NjbgBo9s8VVWaxgWFqApIWRva+M OByw7KNGq9Yfw== From: "Rob Herring (Arm)" Date: Tue, 17 Dec 2024 12:11:41 -0600 Subject: [PATCH v2 2/3] mfd: syscon: Remove the platform driver support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241217-syscon-fixes-v2-2-4f56d750541d@kernel.org> References: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> In-Reply-To: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> To: Lee Jones , Arnd Bergmann , Pankaj Dubey , Heiko Stuebner , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Cc: Peter Griffin , Will McVicker , John Madieu , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.15-dev The platform driver is dead code. It is not used by DT platforms since commit bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform devices") which said: For non-DT based platforms, this patch keeps syscon platform driver structure so that syscon can be probed and such non-DT based drivers can use syscon_regmap_lookup_by_pdev API and access regmap handles. Once all users of "syscon_regmap_lookup_by_pdev" migrated to DT based, we can completely remove platform driver of syscon, and keep only helper functions to get regmap handles. The last user of syscon_regmap_lookup_by_pdevname() was removed in 2018. syscon_regmap_lookup_by_pdevname() was then removed in 2019, but that commit failed to remove the rest of the platform driver. Tested-by: Krzysztof Kozlowski Signed-off-by: Rob Herring (Arm) Acked-by: Liviu Dudau Reviewed-by: Krzysztof Kozlowski Reviewed-by: Pankaj Dubey Tested-by: Pankaj Dubey Tested-by: Will McVicker --- drivers/mfd/syscon.c | 66 --------------------------------= ---- drivers/mfd/vexpress-sysreg.c | 1 - include/linux/platform_data/syscon.h | 9 ----- 3 files changed, 76 deletions(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 72f20de9652da2d7bad12e4bc2c43ac0c9a97f76..bfb1f69fcff1d3cd35cf04ccd4c= 449e7d0395c79 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -12,22 +12,15 @@ #include #include #include -#include -#include #include #include #include #include -#include -#include -#include #include #include #include #include =20 -static struct platform_driver syscon_driver; - static DEFINE_MUTEX(syscon_list_lock); static LIST_HEAD(syscon_list); =20 @@ -337,62 +330,3 @@ struct regmap *syscon_regmap_lookup_by_phandle_optiona= l(struct device_node *np, return regmap; } EXPORT_SYMBOL_GPL(syscon_regmap_lookup_by_phandle_optional); - -static int syscon_probe(struct platform_device *pdev) -{ - struct device *dev =3D &pdev->dev; - struct syscon_platform_data *pdata =3D dev_get_platdata(dev); - struct syscon *syscon; - struct regmap_config syscon_config =3D syscon_regmap_config; - struct resource *res; - void __iomem *base; - - syscon =3D devm_kzalloc(dev, sizeof(*syscon), GFP_KERNEL); - if (!syscon) - return -ENOMEM; - - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENOENT; - - base =3D devm_ioremap(dev, res->start, resource_size(res)); - if (!base) - return -ENOMEM; - - syscon_config.max_register =3D resource_size(res) - 4; - if (!syscon_config.max_register) - syscon_config.max_register_is_0 =3D true; - - if (pdata) - syscon_config.name =3D pdata->label; - syscon->regmap =3D devm_regmap_init_mmio(dev, base, &syscon_config); - if (IS_ERR(syscon->regmap)) { - dev_err(dev, "regmap init failed\n"); - return PTR_ERR(syscon->regmap); - } - - platform_set_drvdata(pdev, syscon); - - dev_dbg(dev, "regmap %pR registered\n", res); - - return 0; -} - -static const struct platform_device_id syscon_ids[] =3D { - { "syscon", }, - { } -}; - -static struct platform_driver syscon_driver =3D { - .driver =3D { - .name =3D "syscon", - }, - .probe =3D syscon_probe, - .id_table =3D syscon_ids, -}; - -static int __init syscon_init(void) -{ - return platform_driver_register(&syscon_driver); -} -postcore_initcall(syscon_init); diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index d34d58ce46db2ad0d53b3daeabc9d3763883b39a..ef03d6cec9ff6927668d051ca45= 9eb1d8ff7269e 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/include/linux/platform_data/syscon.h b/include/linux/platform_= data/syscon.h deleted file mode 100644 index 2c089dd3e2bda3baf5cef201ef43bca709e12c0b..000000000000000000000000000= 0000000000000 --- a/include/linux/platform_data/syscon.h +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef PLATFORM_DATA_SYSCON_H -#define PLATFORM_DATA_SYSCON_H - -struct syscon_platform_data { - const char *label; -}; - -#endif --=20 2.45.2 From nobody Sun Dec 14 19:12:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2920D1F8AD9 for ; Tue, 17 Dec 2024 18:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459122; cv=none; b=EPiniv2aZweT8rD0Tq44sWGOqThPR/0aTSgWyODmwaDDpXdOlj1I41F2/OolhxA1NgW4hLiSq7yqM0WLsONgAlKGYdUUASTIsp0m7U8X/DFOGEkbb34M04GkjBeNkFxuIkYl6K7oTaczEG5q50/uLeofu/77/TKi65Ay6OBEjAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734459122; c=relaxed/simple; bh=d9mGnZDHaJzDeXuKCaPy+9xk0XBg5gLpu9ArK0AHMKM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rZBIKihVfYERF6LPFVkzLbjZiX1oYRgpomejZ2Bt1C89ILwKBEkMzmiNd1gekPHh9JExIE85BPwEdb8klXcqog17UaMun1RKN9dtIuRHOmEg/zM3Q4IRHXNdCDS1Xo5QMLMRR9oK+XqUwf+u6cRYCIBSNKvz1UIJytLIq+0NRhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oeGJV7Tz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oeGJV7Tz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 357FFC4CEDD; Tue, 17 Dec 2024 18:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734459121; bh=d9mGnZDHaJzDeXuKCaPy+9xk0XBg5gLpu9ArK0AHMKM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oeGJV7TzMO2K/f4KYDTiE7oK8pvu0X6kilCxjF5oFugyKqzLn+6n34touk83bBI+F skpEqsPKCkHdiNdFIBGSRhJndcH41NadHgdnnn5LSoCdZbpBoE8+VzsUH/3UA4VE5D /zyFHELz5BOhGK0S0aS5NwjPHbFEMTOE8v7gKxCgg7Kl2Hf/nrFywk2LbP40jJ1e1P G7yGDFVr1i9vvN69t0G1BcnUbV/qjvlPQi6C9CHQfZvaivfRTBfRJL/VMASFIM4xpa syn1KdPb9tFSzE25V9vueRU9bBIJ6fFv6Zu4RAF5vbZl7O/L6ErrPliOQVDL8iAjp2 /BpPqY4vXonMg== From: "Rob Herring (Arm)" Date: Tue, 17 Dec 2024 12:11:42 -0600 Subject: [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org> References: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> In-Reply-To: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> To: Lee Jones , Arnd Bergmann , Pankaj Dubey , Heiko Stuebner , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Cc: Peter Griffin , Will McVicker , John Madieu , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.15-dev of_syscon_register_regmap() was added for nodes which need a custom regmap setup. It's not really correct for those nodes to claim they are compatible with "syscon" as the default handling likely doesn't work in those cases. If device_node_get_regmap() happens to be called first, then of_syscon_register() will be called and an incorrect regmap will be created (barring some other error). That may lead to unknown results in the worst case. In the best case, of_syscon_register_regmap() will fail with -EEXIST. This problem remains unless these cases drop "syscon" (an ABI issue) or we exclude them using their specific compatible. ATM, there is only one user: "google,gs101-pmu" There are also cases of adding "syscon" compatible to existing nodes after the fact in order to register the syscon. That presents a potential DT ABI problem. Instead, if there's a kernel change needing a syscon for a node, then it should be possible to allow the kernel to register a syscon without a DT change. That's only possible by using of_syscon_register_regmap() currently, but in the future we may want to support a match list for cases which don't need a custom regmap. With this change, the lookup functions will succeed for any node registered by of_syscon_register_regmap() regardless of whether the node compatible contains "syscon". Signed-off-by: Rob Herring (Arm) Reviewed-by: Krzysztof Kozlowski Reviewed-by: Pankaj Dubey Tested-by: Will McVicker --- v2: - Fix logic when a syscon is found in list to not return an error --- drivers/mfd/syscon.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index bfb1f69fcff1d3cd35cf04ccd4c449e7d0395c79..226915ca3c93dcaf47bdd46b58e= 00e10e155f952 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -171,9 +171,12 @@ static struct regmap *device_node_get_regmap(struct de= vice_node *np, break; } =20 - if (!syscon) - syscon =3D of_syscon_register(np, check_res); - + if (!syscon) { + if (of_device_is_compatible(np, "syscon")) + syscon =3D of_syscon_register(np, check_res); + else + syscon =3D ERR_PTR(-EINVAL); + } mutex_unlock(&syscon_list_lock); =20 if (IS_ERR(syscon)) @@ -238,9 +241,6 @@ EXPORT_SYMBOL_GPL(device_node_to_regmap); =20 struct regmap *syscon_node_to_regmap(struct device_node *np) { - if (!of_device_is_compatible(np, "syscon")) - return ERR_PTR(-EINVAL); - return device_node_get_regmap(np, true); } EXPORT_SYMBOL_GPL(syscon_node_to_regmap); --=20 2.45.2